react-native-wgpu 0.5.9 → 0.5.11

package/android/cpp/AndroidPlatformContext.h

@@ -93,10 +93,10 @@ public:
     return createImageBitmapFromData(data);
   }
 
-  void createImageBitmapAsync(
-      std::string blobId, double offset, double size,
-      std::function<void(ImageData)> onSuccess,
-      std::function<void(std::string)> onError) override {
+  void
+  createImageBitmapAsync(std::string blobId, double offset, double size,
+                         std::function<void(ImageData)> onSuccess,
+                         std::function<void(std::string)> onError) override {
     std::thread([this, blobId = std::move(blobId), offset, size,
                  onSuccess = std::move(onSuccess),
                  onError = std::move(onError)]() {
@@ -189,7 +189,8 @@ public:
   void createImageBitmapFromDataAsync(
       std::span<const uint8_t> data, std::function<void(ImageData)> onSuccess,
       std::function<void(std::string)> onError) override {
-    std::thread([this, ownedData = std::vector<uint8_t>(data.begin(), data.end()),
+    std::thread([this,
+                 ownedData = std::vector<uint8_t>(data.begin(), data.end()),
                  onSuccess = std::move(onSuccess),
                  onError = std::move(onError)]() mutable {
       jni::Environment::ensureCurrentThreadIsAttached();

package/apple/ApplePlatformContext.h

@@ -16,10 +16,10 @@ public:
   ImageData createImageBitmap(std::string blobId, double offset,
                               double size) override;
 
-  void createImageBitmapAsync(
-      std::string blobId, double offset, double size,
-      std::function<void(ImageData)> onSuccess,
-      std::function<void(std::string)> onError) override;
+  void
+  createImageBitmapAsync(std::string blobId, double offset, double size,
+                         std::function<void(ImageData)> onSuccess,
+                         std::function<void(std::string)> onError) override;
 
   ImageData createImageBitmapFromData(std::span<const uint8_t> data) override;
 

package/apple/ApplePlatformContext.mm

@@ -82,17 +82,18 @@ void ApplePlatformContext::createImageBitmapAsync(
                                  std::move(onError));
 }
 
-ImageData ApplePlatformContext::createImageBitmapFromData(
-    std::span<const uint8_t> data) {
+ImageData
+ApplePlatformContext::createImageBitmapFromData(std::span<const uint8_t> data) {
   // This avoids a copy by assuming the UIImage/NSImage constructors
   // decode `nsData` eagerly before the memory for the wrapped `data`
   // is freed.
   //
   // Since we get the `CGImageRef` from `image` and then throw
   // it away, that's a fairly safe assumption.
-  NSData *nsData = [NSData dataWithBytesNoCopy:const_cast<uint8_t *>(data.data())
-                                        length:data.size()
-                                  freeWhenDone:NO];
+  NSData *nsData =
+      [NSData dataWithBytesNoCopy:const_cast<uint8_t *>(data.data())
+                           length:data.size()
+                     freeWhenDone:NO];
 
 #if !TARGET_OS_OSX
   UIImage *image = [UIImage imageWithData:nsData];
@@ -141,17 +142,16 @@ void ApplePlatformContext::createImageBitmapFromDataAsync(
   auto ownedData =
       std::make_shared<std::vector<uint8_t>>(data.begin(), data.end());
 
-  dispatch_async(
-      dispatch_get_global_queue(QOS_CLASS_USER_INITIATED, 0), ^{
-        @autoreleasepool {
-          try {
-            auto result = createImageBitmapFromData(*ownedData);
-            onSuccess(std::move(result));
-          } catch (const std::exception &e) {
-            onError(e.what());
-          }
-        }
-      });
+  dispatch_async(dispatch_get_global_queue(QOS_CLASS_USER_INITIATED, 0), ^{
+    @autoreleasepool {
+      try {
+        auto result = createImageBitmapFromData(*ownedData);
+        onSuccess(std::move(result));
+      } catch (const std::exception &e) {
+        onError(e.what());
+      }
+    }
+  });
 }
 
 } // namespace rnwgpu

package/apple/WebGPUModule.h

@@ -5,7 +5,8 @@
 #import <React/RCTCallInvokerModule.h>
 #import <React/RCTEventEmitter.h>
 
-@interface WebGPUModule : RCTEventEmitter <NativeWebGPUModuleSpec, RCTCallInvokerModule>
+@interface WebGPUModule
+    : RCTEventEmitter <NativeWebGPUModuleSpec, RCTCallInvokerModule>
 
 + (std::shared_ptr<rnwgpu::RNWebGPUManager>)getManager;
 

package/apple/WebGPUModule.mm

@@ -55,11 +55,13 @@ RCT_EXPORT_BLOCKING_SYNCHRONOUS_METHOD(install) {
     return @true;
   }
 
-  // self.bridge works in both Legacy (RCTBridge) and Bridgeless (RCTBridgeProxy).
+  // self.bridge works in both Legacy (RCTBridge) and Bridgeless
+  // (RCTBridgeProxy).
   jsi::Runtime *runtime = (jsi::Runtime *)self.bridge.runtime;
   if (!runtime) {
     NSLog(@"Failed to install react-native-wgpu: jsi::Runtime* was null! "
-          @"(self.bridge=%@)", self.bridge);
+          @"(self.bridge=%@)",
+          self.bridge);
     return [NSNumber numberWithBool:NO];
   }
 

package/cpp/rnwgpu/PlatformContext.h

@@ -28,17 +28,19 @@ public:
                                       double size) = 0;
 
   // Async version that performs image decoding on a background thread
-  virtual void createImageBitmapAsync(
-      std::string blobId, double offset, double size,
-      std::function<void(ImageData)> onSuccess,
-      std::function<void(std::string)> onError) = 0;
+  virtual void
+  createImageBitmapAsync(std::string blobId, double offset, double size,
+                         std::function<void(ImageData)> onSuccess,
+                         std::function<void(std::string)> onError) = 0;
 
   // Create ImageBitmap from raw encoded image bytes (PNG/JPEG/etc.)
-  virtual ImageData createImageBitmapFromData(std::span<const uint8_t> data) = 0;
+  virtual ImageData
+  createImageBitmapFromData(std::span<const uint8_t> data) = 0;
 
-  virtual void createImageBitmapFromDataAsync(
-      std::span<const uint8_t> data, std::function<void(ImageData)> onSuccess,
-      std::function<void(std::string)> onError) = 0;
+  virtual void
+  createImageBitmapFromDataAsync(std::span<const uint8_t> data,
+                                 std::function<void(ImageData)> onSuccess,
+                                 std::function<void(std::string)> onError) = 0;
 };
 
 } // namespace rnwgpu

package/cpp/rnwgpu/api/GPUCanvasContext.cpp

@@ -48,7 +48,9 @@ std::shared_ptr<GPUTexture> GPUCanvasContext::getCurrentTexture() {
     _surfaceInfo->reconfigure(width, height);
   }
   auto texture = _surfaceInfo->getCurrentTexture();
-  return std::make_shared<GPUTexture>(texture, "");
+  // Pass reportsMemoryPressure=false to avoid triggering spurious Hermes GC
+  // cycles every frame since the canvas texture doesn't own the buffer.
+  return std::make_shared<GPUTexture>(texture, "", false);
 }
 
 void GPUCanvasContext::present() {

package/cpp/rnwgpu/api/GPUFeatures.h

@@ -2,9 +2,9 @@
 
 #include <string>
 
-#include "webgpu/webgpu_cpp.h"
+#include <cstdio>
 
-#include "WGPULogger.h"
+#include "webgpu/webgpu_cpp.h"
 
 namespace rnwgpu {
 
@@ -89,9 +89,6 @@ static void convertEnumToJSUnion(wgpu::FeatureName inEnum,
   case wgpu::FeatureName::Unorm16TextureFormats:
     *outUnion = "unorm16-texture-formats";
     break;
-  case wgpu::FeatureName::Snorm16TextureFormats:
-    *outUnion = "snorm16-texture-formats";
-    break;
   case wgpu::FeatureName::MultiPlanarFormatExtendedUsages:
     *outUnion = "multi-planar-format-extended-usages";
     break;
@@ -122,18 +119,12 @@ static void convertEnumToJSUnion(wgpu::FeatureName inEnum,
   case wgpu::FeatureName::AdapterPropertiesVk:
     *outUnion = "adapter-properties-vk";
     break;
-  case wgpu::FeatureName::R8UnormStorage:
-    *outUnion = "r8unorm-storage";
-    break;
   case wgpu::FeatureName::DawnFormatCapabilities:
     *outUnion = "format-capabilities";
     break;
   case wgpu::FeatureName::DawnDrmFormatCapabilities:
     *outUnion = "drm-format-capabilities";
     break;
-  case wgpu::FeatureName::Norm16TextureFormats:
-    *outUnion = "norm16-texture-formats";
-    break;
   case wgpu::FeatureName::MultiPlanarFormatNv16:
     *outUnion = "multi-planar-format-nv16";
     break;
@@ -204,7 +195,7 @@ static void convertEnumToJSUnion(wgpu::FeatureName inEnum,
     *outUnion = "dawn-load-resolve-texture";
     break;
   default:
-    Logger::logToConsole("Unknown feature name %d", inEnum);
+    fprintf(stderr, "Unknown feature name %d\n", static_cast<int>(inEnum));
     *outUnion = "";
   }
 }

package/cpp/rnwgpu/api/GPUTexture.h

@@ -21,8 +21,10 @@ class GPUTexture : public NativeObject<GPUTexture> {
 public:
   static constexpr const char *CLASS_NAME = "GPUTexture";
 
-  explicit GPUTexture(wgpu::Texture instance, std::string label)
-      : NativeObject(CLASS_NAME), _instance(instance), _label(label) {}
+  explicit GPUTexture(wgpu::Texture instance, std::string label,
+                      bool reportsMemoryPressure = true)
+      : NativeObject(CLASS_NAME), _instance(instance), _label(label),
+        _reportsMemoryPressure(reportsMemoryPressure) {}
 
 public:
   std::string getBrand() { return CLASS_NAME; }
@@ -68,6 +70,9 @@ public:
   inline const wgpu::Texture get() { return _instance; }
 
   size_t getMemoryPressure() override {
+    if (!_reportsMemoryPressure) {
+      return sizeof(GPUTexture);
+    }
     // Calculate approximate memory usage based on texture properties
     uint32_t width = getWidth();
     uint32_t height = getHeight();
@@ -85,6 +90,7 @@ public:
     case wgpu::TextureFormat::R8Snorm:
     case wgpu::TextureFormat::R8Uint:
     case wgpu::TextureFormat::R8Sint:
+    case wgpu::TextureFormat::Stencil8:
       bytesPerPixel = 1;
       break;
     case wgpu::TextureFormat::R16Uint:
@@ -94,6 +100,7 @@ public:
     case wgpu::TextureFormat::RG8Snorm:
     case wgpu::TextureFormat::RG8Uint:
     case wgpu::TextureFormat::RG8Sint:
+    case wgpu::TextureFormat::Depth16Unorm:
       bytesPerPixel = 2;
       break;
     case wgpu::TextureFormat::RGBA8Unorm:
@@ -110,6 +117,9 @@ public:
     case wgpu::TextureFormat::RG16Uint:
     case wgpu::TextureFormat::RG16Sint:
     case wgpu::TextureFormat::RG16Float:
+    case wgpu::TextureFormat::Depth24Plus:
+    case wgpu::TextureFormat::Depth24PlusStencil8:
+    case wgpu::TextureFormat::Depth32Float:
       bytesPerPixel = 4;
       break;
     case wgpu::TextureFormat::RG32Float:
@@ -118,6 +128,7 @@ public:
     case wgpu::TextureFormat::RGBA16Uint:
     case wgpu::TextureFormat::RGBA16Sint:
     case wgpu::TextureFormat::RGBA16Float:
+    case wgpu::TextureFormat::Depth32FloatStencil8:
       bytesPerPixel = 8;
       break;
     case wgpu::TextureFormat::RGBA32Float:
@@ -145,6 +156,7 @@ public:
 private:
   wgpu::Texture _instance;
   std::string _label;
+  bool _reportsMemoryPressure = true;
 };
 
 } // namespace rnwgpu

package/cpp/rnwgpu/api/RNWebGPU.h

@@ -103,8 +103,7 @@ public:
         auto bufferVal = obj.getProperty(runtime, "buffer");
         if (bufferVal.isObject() &&
             bufferVal.getObject(runtime).isArrayBuffer(runtime)) {
-          const auto &ab =
-              bufferVal.getObject(runtime).getArrayBuffer(runtime);
+          const auto &ab = bufferVal.getObject(runtime).getArrayBuffer(runtime);
           auto byteOffset = static_cast<size_t>(
               obj.getProperty(runtime, "byteOffset").asNumber());
           auto byteLength = static_cast<size_t>(
@@ -120,15 +119,13 @@ public:
 
         return Promise::createPromise(
             runtime,
-            [platformContext, callInvoker,
-             dataCopy = std::move(dataCopy)](
+            [platformContext, callInvoker, dataCopy = std::move(dataCopy)](
                 jsi::Runtime & /*runtime*/,
                 std::shared_ptr<Promise> promise) mutable {
               platformContext->createImageBitmapFromDataAsync(
                   dataCopy,
                   [callInvoker, promise](ImageData imageData) {
-                    auto imageBitmap =
-                        std::make_shared<ImageBitmap>(imageData);
+                    auto imageBitmap = std::make_shared<ImageBitmap>(imageData);
                     callInvoker->invokeAsync([promise, imageBitmap]() {
                       promise->resolve(
                           JSIConverter<std::shared_ptr<ImageBitmap>>::toJSI(
@@ -158,12 +155,11 @@ public:
               blobId, offset, size,
               [callInvoker, promise](ImageData imageData) {
                 auto imageBitmap = std::make_shared<ImageBitmap>(imageData);
-                callInvoker->invokeAsync(
-                    [promise, imageBitmap]() {
-                      promise->resolve(
-                          JSIConverter<std::shared_ptr<ImageBitmap>>::toJSI(
-                              promise->runtime, imageBitmap));
-                    });
+                callInvoker->invokeAsync([promise, imageBitmap]() {
+                  promise->resolve(
+                      JSIConverter<std::shared_ptr<ImageBitmap>>::toJSI(
+                          promise->runtime, imageBitmap));
+                });
               },
               [callInvoker, promise](std::string error) {
                 callInvoker->invokeAsync(

package/cpp/rnwgpu/api/descriptors/Unions.h

@@ -463,8 +463,6 @@ inline void convertJSUnionToEnum(const std::string &inUnion,
     *outEnum = wgpu::FeatureName::PixelLocalStorageNonCoherent;
   } else if (inUnion == "unorm16-texture-formats") {
     *outEnum = wgpu::FeatureName::Unorm16TextureFormats;
-  } else if (inUnion == "snorm16-texture-formats") {
-    *outEnum = wgpu::FeatureName::Snorm16TextureFormats;
   } else if (inUnion == "multi-planar-format-extended-usages") {
     *outEnum = wgpu::FeatureName::MultiPlanarFormatExtendedUsages;
   } else if (inUnion == "multi-planar-format-p010") {
@@ -485,12 +483,8 @@ inline void convertJSUnionToEnum(const std::string &inUnion,
     *outEnum = wgpu::FeatureName::AdapterPropertiesD3D;
   } else if (inUnion == "adapter-properties-vk") {
     *outEnum = wgpu::FeatureName::AdapterPropertiesVk;
-  } else if (inUnion == "r8unorm-storage") {
-    *outEnum = wgpu::FeatureName::R8UnormStorage;
   } else if (inUnion == "format-capabilities") {
     *outEnum = wgpu::FeatureName::DawnFormatCapabilities;
-  } else if (inUnion == "norm16-texture-formats") {
-    *outEnum = wgpu::FeatureName::Norm16TextureFormats;
   } else if (inUnion == "multi-planar-format-nv16") {
     *outEnum = wgpu::FeatureName::MultiPlanarFormatNv16;
   } else if (inUnion == "multi-planar-format-nv24") {
@@ -629,9 +623,6 @@ inline void convertEnumToJSUnion(wgpu::FeatureName inEnum,
   case wgpu::FeatureName::Unorm16TextureFormats:
     *outUnion = "unorm16-texture-formats";
     break;
-  case wgpu::FeatureName::Snorm16TextureFormats:
-    *outUnion = "snorm16-texture-formats";
-    break;
   case wgpu::FeatureName::MultiPlanarFormatExtendedUsages:
     *outUnion = "multi-planar-format-extended-usages";
     break;
@@ -662,12 +653,6 @@ inline void convertEnumToJSUnion(wgpu::FeatureName inEnum,
   case wgpu::FeatureName::AdapterPropertiesVk:
     *outUnion = "adapter-properties-vk";
     break;
-  case wgpu::FeatureName::R8UnormStorage:
-    *outUnion = "r8unorm-storage";
-    break;
-  case wgpu::FeatureName::Norm16TextureFormats:
-    *outUnion = "norm16-texture-formats";
-    break;
   case wgpu::FeatureName::MultiPlanarFormatNv16:
     *outUnion = "multi-planar-format-nv16";
     break;