react-native-vroom-chart 0.9.0 → 0.10.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
package/README.md CHANGED
@@ -16,8 +16,11 @@ import { VroomChart } from 'react-native-vroom-chart';
16
16
  ## Peer dependencies
17
17
 
18
18
  - `react-native` ≥ 0.76
19
- - `@shopify/react-native-skia` ≥ 1.5 — provides the Skia runtime we draw into
19
+ - `@shopify/react-native-skia` ≥ 2.11.0 — provides the Skia runtime we draw into. vroom links RN-Skia's native internals (`cpp/api`) and tracks that package closely; those headers have no semver guarantee.
20
+
20
21
  - `react-native-gesture-handler` ≥ 2.16 — long-press / pan / pinch recognition
22
+ - `react-native-reanimated` ≥ 4.0 — gesture worklets
23
+ - `react-native-worklets` ≥ 0.7.0 — required by Skia 2.11's Reanimated integration on native
21
24
 
22
25
  ## Status
23
26
 
@@ -4,20 +4,21 @@
4
4
  # core the iOS podspec compiles (see ../react-native-vroom-chart.podspec),
5
5
  # plus this directory's small JNI entry point (src/main/cpp/VroomChartJni.cpp).
6
6
  #
7
- # RN-Skia's headers (JsiSkHostObjects.h, RNSkPlatformContext.h needed by
8
- # ../cpp/VroomSkiaContext.cpp) aren't consumed via CMake's prefab mechanism;
9
- # instead we point directly at @shopify/react-native-skia's `cpp/` sources,
10
- # mirroring the podspec's `require.resolve('@shopify/react-native-skia/package.json')`
11
- # trick (VROOM_SKIA_CPP_DIR is computed the same way in build.gradle).
7
+ # RN-Skia's headers (JsiSkNativeObjects.h, JsiSkPicture.h, and the
8
+ # RNSkPlatformContext.h they pull in) aren't consumed via CMake's prefab
9
+ # mechanism; instead we point directly at @shopify/react-native-skia's `cpp/`
10
+ # sources, mirroring the podspec's
11
+ # `require.resolve('@shopify/react-native-skia/package.json')` trick
12
+ # (VROOM_SKIA_CPP_DIR is computed the same way in build.gradle).
12
13
  #
13
- # IMPORTANT SK_GRAPHITE ABI note: RNSkPlatformContext's vtable layout
14
- # differs depending on whether SK_GRAPHITE was defined when RN-Skia's own
15
- # Android build compiled RNSkAndroidPlatformContext (the concrete class whose
16
- # vtable we call into via VroomSkiaContext.cpp's `ctx->createFontMgr()`).
17
- # We must define SK_GRAPHITE identically to however RN-Skia's own CMakeLists
18
- # (android/CMakeLists.txt) decided it, or virtual calls resolve to the wrong
19
- # vtable slot. We replicate their libskia.a symbol probe below rather than
20
- # hard-coding an assumption.
14
+ # Prebuilt libskia.a lives in the sibling npm package react-native-skia-android
15
+ # (or react-native-skia-graphite-android). build.gradle resolves that package
16
+ # and passes VROOM_SKIA_ANDROID_LIBS_DIR = <pkg>/libs; we append ${ANDROID_ABI}.
17
+ #
18
+ # SK_GRAPHITE vs SK_GL/SK_GANESH must match RN-Skia's own build so our direct
19
+ # Skia calls see the same ABI. Graphite is detected from the
20
+ # <skia-pkg>/libs/.graphite marker (same file RN-Skia uses) and passed in as
21
+ # VROOM_SKIA_GRAPHITE.
21
22
  cmake_minimum_required(VERSION 3.22)
22
23
  project(vroomchart)
23
24
 
@@ -35,44 +36,30 @@ find_package(shopify_react-native-skia REQUIRED CONFIG)
35
36
  if(NOT DEFINED VROOM_SKIA_CPP_DIR)
36
37
  message(FATAL_ERROR "VROOM_SKIA_CPP_DIR not set — passed from android/build.gradle.")
37
38
  endif()
39
+ if(NOT DEFINED VROOM_SKIA_ANDROID_LIBS_DIR)
40
+ message(FATAL_ERROR "VROOM_SKIA_ANDROID_LIBS_DIR not set — passed from android/build.gradle.")
41
+ endif()
38
42
 
39
- # RN-Skia's own package root is one level up from its cpp/ dir; its prebuilt
40
- # Skia static libs live at <root>/libs/android/<abi>/libskia.a.
41
- get_filename_component(VROOM_SKIA_PKG_DIR "${VROOM_SKIA_CPP_DIR}" DIRECTORY)
42
- set(VROOM_SKIA_LIBS_DIR "${VROOM_SKIA_PKG_DIR}/libs/android/${ANDROID_ABI}")
43
+ set(VROOM_SKIA_LIBS_DIR "${VROOM_SKIA_ANDROID_LIBS_DIR}/${ANDROID_ABI}")
43
44
 
44
45
  # Our chart core calls Skia types (SkCanvas, SkPaint, SkFont, ...) and
45
- # RN-Skia's own JSI plumbing (RNJsi::JsiHostObject, JsiSkPicture, ...)
46
+ # RN-Skia's own JSI plumbing (JsiSkPicture / NativeObject, ...)
46
47
  # directly — none of that is header-only, and we need *both* libraries:
47
48
  # - librnskia.so (RN-Skia's prefab-published `rnskia` module, consumed above
48
- # via `implementation project(":shopify_react-native-skia")`) for RNJsi's
49
- # own symbols (JsiHostObject, JsiSkPicture, ...), which only exist there.
50
- # - libskia.a (RN-Skia's bundled prebuilt Skia static lib) for direct Skia
51
- # calls (SkCanvas::drawRect, SkFont, ...): librnskia.so links libskia.a
52
- # internally but doesn't re-export its symbols, so linking librnskia.so
53
- # alone leaves every direct Skia call undefined.
49
+ # via `implementation project(":shopify_react-native-skia")`) for RN-Skia's
50
+ # own symbols (JsiSkPicture, NativeObject, ...), which only exist there.
51
+ # - libskia.a (the prebuilt Skia static lib from react-native-skia-android)
52
+ # for direct Skia calls (SkCanvas::drawRect, SkFont, ...): librnskia.so
53
+ # links libskia.a internally but doesn't re-export its symbols, so linking
54
+ # librnskia.so alone leaves every direct Skia call undefined.
54
55
  # Recompiling RN-Skia's cpp/jsi/*.cpp ourselves instead of linking librnskia.so
55
- # was considered and rejected — it would duplicate RNJsi's symbols (and their
56
+ # was considered and rejected — it would duplicate RN-Skia's symbols (and their
56
57
  # static/global state) across two separately-loaded .so's, which is fine on
57
58
  # iOS's single static binary but not here.
58
59
  add_library(vroom_skia_prebuilt STATIC IMPORTED)
59
60
  set_property(TARGET vroom_skia_prebuilt PROPERTY
60
61
  IMPORTED_LOCATION "${VROOM_SKIA_LIBS_DIR}/libskia.a")
61
62
 
62
- set(SK_GRAPHITE_AVAILABLE OFF)
63
- if(EXISTS "${VROOM_SKIA_LIBS_DIR}/libskia.a")
64
- execute_process(
65
- COMMAND nm "${VROOM_SKIA_LIBS_DIR}/libskia.a"
66
- COMMAND grep "dawn::\\|wgpu\\|_ZN4dawn\\|DawnDevice\\|dawn_native"
67
- OUTPUT_VARIABLE VROOM_NM_OUTPUT
68
- ERROR_QUIET
69
- RESULT_VARIABLE VROOM_NM_RESULT
70
- )
71
- if(VROOM_NM_RESULT EQUAL 0 AND NOT "${VROOM_NM_OUTPUT}" STREQUAL "")
72
- set(SK_GRAPHITE_AVAILABLE ON)
73
- endif()
74
- endif()
75
-
76
63
  # The chart core (shared across iOS/Android/WASM — see ../../core/CMakeLists.txt).
77
64
  set(VROOM_CORE_INCLUDE_DIR "${CMAKE_CURRENT_SOURCE_DIR}/../cpp/_core_include")
78
65
  set(VROOM_CORE_SRC_DIR "${CMAKE_CURRENT_SOURCE_DIR}/../cpp/_core_src")
@@ -81,7 +68,7 @@ file(GLOB VROOM_CORE_SOURCES CONFIGURE_DEPENDS "${VROOM_CORE_SRC_DIR}/*.cpp")
81
68
  add_library(vroomchart SHARED
82
69
  "${CMAKE_CURRENT_SOURCE_DIR}/../cpp/VroomJsiInstaller.cpp"
83
70
  "${CMAKE_CURRENT_SOURCE_DIR}/../cpp/VroomChartHostObject.cpp"
84
- "${CMAKE_CURRENT_SOURCE_DIR}/../cpp/VroomSkiaContext.cpp"
71
+ "${CMAKE_CURRENT_SOURCE_DIR}/../cpp/VroomFontMgr.cpp"
85
72
  ${VROOM_CORE_SOURCES}
86
73
  "${CMAKE_CURRENT_SOURCE_DIR}/src/main/cpp/VroomChartJni.cpp"
87
74
  )
@@ -101,7 +88,9 @@ target_include_directories(vroomchart PRIVATE
101
88
  "${VROOM_SKIA_CPP_DIR}/dawn/include"
102
89
  # RNSkPlatformContext.h pulls in ReactCommon/CallInvoker.h directly, which
103
90
  # isn't part of the prefab-published jsi headers — same dirs RN-Skia's own
104
- # android/CMakeLists.txt adds for the same reason.
91
+ # android/CMakeLists.txt adds for the same reason. Still required: we include
92
+ # JsiSkPicture.h, which includes JsiSkNativeObjects.h, which includes
93
+ # RNSkPlatformContext.h.
105
94
  "${REACT_NATIVE_DIR}/ReactCommon"
106
95
  "${REACT_NATIVE_DIR}/ReactCommon/callinvoker"
107
96
  "${REACT_NATIVE_DIR}/ReactCommon/runtimeexecutor"
@@ -114,7 +103,7 @@ target_compile_definitions(vroomchart PRIVATE
114
103
  ONANDROID
115
104
  ON_ANDROID
116
105
  )
117
- if(SK_GRAPHITE_AVAILABLE)
106
+ if(VROOM_SKIA_GRAPHITE)
118
107
  target_compile_definitions(vroomchart PRIVATE SK_GRAPHITE)
119
108
  else()
120
109
  target_compile_definitions(vroomchart PRIVATE SK_GL SK_GANESH)
package/android/README.md CHANGED
@@ -8,31 +8,33 @@ Android equivalent of `../ios/`: a small TurboModule
8
8
  [`../cpp/VroomJsiInstaller.cpp`](../cpp/VroomJsiInstaller.cpp) the iOS bridge
9
9
  uses.
10
10
 
11
- The chart core itself (`../cpp/_core_src`) and the RN-Skia font/context glue
12
- (`../cpp/VroomSkiaContext.*`) are unmodified and shared across iOS and
13
- Android — only the platform glue (this directory + `../ios/`) differs.
11
+ The chart core (`../cpp/_core_src`) and the platform font-manager helper
12
+ (`../cpp/VroomFontMgr.*`) are unmodified and shared across iOS and Android —
13
+ only the platform glue (this directory + `../ios/`) differs.
14
14
  `../cpp/VroomChartHostObject.cpp` has one small `#if defined(__ANDROID__)`
15
15
  branch (see "Cross-`.so` Skia objects" below).
16
16
 
17
17
  `build.gradle` resolves `@shopify/react-native-skia`'s `cpp/` sources via
18
18
  Node module resolution (mirroring `../react-native-vroom-chart.podspec`'s
19
- `require.resolve` trick) so `VroomSkiaContext.cpp` can include RN-Skia's
20
- `JsiSkHostObjects.h` / `RNSkPlatformContext.h`. `CMakeLists.txt` also
21
- replicates RN-Skia's own Graphite-vs-Ganesh detection (probing its bundled
22
- `libskia.a`) so `SK_GRAPHITE` is defined identically to however RN-Skia's own
23
- Android build was compiled `RNSkPlatformContext`'s vtable layout depends on
24
- that macro, and a mismatch would corrupt the virtual call in
25
- `VroomJsiInstaller.cpp`'s `ensureAxisTypeface`.
19
+ `require.resolve` trick) so we can include RN-Skia's `JsiSkPicture.h` /
20
+ `JsiSkNativeObjects.h`. Android prebuilt `libskia.a` lives in the sibling
21
+ `react-native-skia-android` package (or `react-native-skia-graphite-android`
22
+ when `<skia-pkg>/libs/.graphite` exists); Gradle resolves that package and
23
+ passes its `libs/` dir to CMake. Graphite vs Ganesh is the same marker file
24
+ RN-Skia uses, so `SK_GRAPHITE` / `SK_GL`+`SK_GANESH` match RN-Skia's own
25
+ build — needed for vroom's direct Skia calls, not for a virtual call into
26
+ RN-Skia (we construct the font manager ourselves).
26
27
 
27
28
  We link two RN-Skia-adjacent libraries into `libvroomchart.so`, for two
28
29
  different reasons:
29
30
  - `shopify_react-native-skia::rnskia` (RN-Skia's own prefab-published
30
- shared library, `librnskia.so`) — for `RNJsi::JsiHostObject` and friends,
31
- whose out-of-line methods are compiled only there.
32
- - RN-Skia's bundled `libskia.a` (imported directly by path, since it isn't
33
- prefab-published) — for direct Skia calls (`SkCanvas::drawRect`, `SkFont`,
34
- ...), since `librnskia.so` links `libskia.a` internally but doesn't
35
- re-export its symbols.
31
+ shared library, `librnskia.so`) — for `JsiSkPicture` / `NativeObject`
32
+ and friends, whose out-of-line methods are compiled only there.
33
+ - `libskia.a` from `react-native-skia-android` (imported directly by path,
34
+ since it isn't prefab-published) — for direct Skia calls
35
+ (`SkCanvas::drawRect`, `SkFont`, `SkFontMgr_New_Android`, ...), since
36
+ `librnskia.so` links `libskia.a` internally but doesn't re-export its
37
+ symbols.
36
38
 
37
39
  ### Cross-`.so` Skia objects
38
40
 
@@ -43,11 +45,11 @@ of the JSI bridge, but **`RNSkia::JsiSkPicture` — the object `render()` /
43
45
  `libvroomchart.so` on Android.** RN-Skia's own C++ (e.g.
44
46
  `cpp/api/recorder/Convertor.h`'s `getPropertyValue<sk_sp<SkPicture>>`, which
45
47
  runs whenever `<Picture>` reads the value) does
46
- `value.asObject(rt).asHostObject<JsiSkPicture>(rt)`, a `dynamic_pointer_cast`
47
- under the hood. A `JsiSkPicture` we construct ourselves has a vtable/typeinfo
48
- compiled into *our* `.so`; that cast — running inside `librnskia.so` — sees a
49
- different, unmerged RTTI record for "the same" class and fails with `Object
50
- is not a HostObject of desired type`.
48
+ `getJsiObject<JsiSkPicture>(rt, value)`, a `dynamic_pointer_cast` under the
49
+ hood. A `JsiSkPicture` we construct ourselves has a vtable/typeinfo compiled
50
+ into *our* `.so`; that cast — running inside `librnskia.so` — sees a
51
+ different, unmerged RTTI record for "the same" class and fails with
52
+ `Expected a Skia object of a different type`.
51
53
 
52
54
  `VroomChartHostObject.cpp`'s `wrapPicture()` works around this only on
53
55
  Android: instead of constructing `RNSkia::JsiSkPicture` directly (as iOS
@@ -28,7 +28,23 @@ def resolvePackageDir(packageJsonSpecifier) {
28
28
  }
29
29
 
30
30
  def reactNativeDir = resolvePackageDir("react-native/package.json")
31
- def skiaCppDir = new File(resolvePackageDir("@shopify/react-native-skia/package.json"), "cpp")
31
+ def skiaPkgDir = resolvePackageDir("@shopify/react-native-skia/package.json")
32
+ def skiaCppDir = new File(skiaPkgDir, "cpp")
33
+
34
+ // Skia 2.10+ ships Android prebuilts in react-native-skia-android (Ganesh)
35
+ // or react-native-skia-graphite-android (Graphite). Graphite is selected by
36
+ // the same libs/.graphite marker RN-Skia uses. Resolve from the skia package
37
+ // so pnpm's nested .pnpm layout still finds the sibling binary package.
38
+ def useGraphite = new File(skiaPkgDir, "libs/.graphite").exists()
39
+ def skiaAndroidPkgName = useGraphite
40
+ ? "react-native-skia-graphite-android"
41
+ : "react-native-skia-android"
42
+ def skiaAndroidPkgJson = providers.exec {
43
+ workingDir(rootDir)
44
+ commandLine("node", "--print",
45
+ "require.resolve('${skiaAndroidPkgName}/package.json', { paths: ['${skiaPkgDir}'] })")
46
+ }.standardOutput.asText.get().trim()
47
+ def skiaAndroidLibsDir = new File(file(skiaAndroidPkgJson).parentFile, "libs")
32
48
 
33
49
  // Mirror ../cpp/_core_{src,include} from ../../core/{src,include} whenever
34
50
  // the monorepo core is present, so edits to packages/core/ propagate on the
@@ -72,7 +88,9 @@ android {
72
88
  abiFilters(*reactNativeArchitectures())
73
89
  arguments "-DANDROID_STL=c++_shared",
74
90
  "-DREACT_NATIVE_DIR=${reactNativeDir}",
75
- "-DVROOM_SKIA_CPP_DIR=${skiaCppDir}"
91
+ "-DVROOM_SKIA_CPP_DIR=${skiaCppDir}",
92
+ "-DVROOM_SKIA_ANDROID_LIBS_DIR=${skiaAndroidLibsDir}",
93
+ "-DVROOM_SKIA_GRAPHITE=${useGraphite ? 'ON' : 'OFF'}"
76
94
  }
77
95
  }
78
96
  }
@@ -105,11 +123,11 @@ repositories {
105
123
 
106
124
  dependencies {
107
125
  implementation "com.facebook.react:react-android"
108
- // ../cpp/VroomChartHostObject.cpp constructs RN-Skia JSI host objects
109
- // (JsiSkPicture, etc.) whose base class (RNJsi::JsiHostObject) has
110
- // out-of-line methods compiled into RN-Skia's own native library — we link
111
- // against its prefab-published `rnskia` package (below, in CMakeLists.txt)
112
- // rather than recompiling those .cpp files ourselves, to avoid duplicate
113
- // definitions of RNSkia's internals across two separately-loaded .so's.
126
+ // ../cpp/VroomChartHostObject.cpp constructs RN-Skia JSI objects
127
+ // (JsiSkPicture, etc.) whose NativeObject base has out-of-line methods
128
+ // compiled into RN-Skia's own native library — we link against its
129
+ // prefab-published `rnskia` package (below, in CMakeLists.txt) rather than
130
+ // recompiling those .cpp files ourselves, to avoid duplicate definitions of
131
+ // RN-Skia's internals across two separately-loaded .so's.
114
132
  implementation project(":shopify_react-native-skia")
115
133
  }
@@ -8,7 +8,7 @@
8
8
  #include "vroom/vroom_chart.h"
9
9
 
10
10
  // RN-Skia headers.
11
- #include "JsiSkHostObjects.h"
11
+ #include "JsiSkNativeObjects.h"
12
12
  #include "JsiSkPicture.h"
13
13
 
14
14
  namespace vroom {
@@ -78,9 +78,9 @@ std::vector<jsi::PropNameID> ChartHostObject::getPropertyNames(
78
78
  // does, below) gives it a vtable/typeinfo from *our* .so; when RN-Skia's own
79
79
  // compiled code later consumes it (e.g. Convertor.h's
80
80
  // `getPropertyValue<sk_sp<SkPicture>>`, which does
81
- // `value.asObject(rt).asHostObject<JsiSkPicture>(rt)` — a dynamic_pointer_cast
82
- // under the hood), the cast fails cross-.so with "Object is not a HostObject
83
- // of desired type", because the object's *runtime* type was never actually
81
+ // `getJsiObject<JsiSkPicture>(rt, value)` — a dynamic_pointer_cast
82
+ // under the hood), the cast fails cross-.so with "Expected a Skia object of
83
+ // a different type", because the object's *runtime* type was never actually
84
84
  // compiled inside librnskia.so. iOS statically links everything into one
85
85
  // binary, so no such mismatch exists there.
86
86
  //
@@ -122,26 +122,30 @@ static facebook::jsi::Value wrapPicture(facebook::jsi::Runtime& rt,
122
122
  if (!skiaApi.isObject()) return facebook::jsi::Value::null();
123
123
  auto pictureFactory = skiaApi.asObject(rt).getProperty(rt, "Picture");
124
124
  if (!pictureFactory.isObject()) return facebook::jsi::Value::null();
125
+ auto pictureFactoryObj = pictureFactory.asObject(rt);
125
126
  auto makePicture =
126
- pictureFactory.asObject(rt).getPropertyAsFunction(rt, "MakePicture");
127
+ pictureFactoryObj.getPropertyAsFunction(rt, "MakePicture");
127
128
 
128
129
  // Mirrors JsiSkPictureFactory::MakePicture's expected argument shape: an
129
130
  // object with a `.buffer` property holding the ArrayBuffer (matching a
130
131
  // Uint8Array-like value; the factory ignores everything else about it).
132
+ //
133
+ // Skia 2.11's NativeState host methods recover the factory via `this`
134
+ // (`fromThis` → "Expected PictureFactory but got non-object" if unbound).
131
135
  jsi::Object arg(rt);
132
136
  arg.setProperty(rt, "buffer", arrayBuffer);
133
- return makePicture.call(rt, arg);
137
+ return makePicture.callWithThis(rt, pictureFactoryObj, arg);
134
138
  }
135
139
  #else
136
- // Shared helper: wraps a fresh picture for return to JS, with memory pressure
137
- // reported to Hermes so GC keeps up under gesture-rate churn.
140
+ // Shared helper: wraps a fresh picture for return to JS. Memory pressure is
141
+ // applied inside JsiSkPicture::create (NativeObject::create reads
142
+ // getMemoryPressure() → picture->approximateBytesUsed()).
138
143
  static facebook::jsi::Value wrapPicture(facebook::jsi::Runtime& rt,
139
144
  const sk_sp<SkPicture>& pic) {
140
145
  if (!pic) return facebook::jsi::Value::null();
141
146
  auto host =
142
147
  std::make_shared<RNSkia::JsiSkPicture>(/*context=*/nullptr, pic);
143
- return JSI_CREATE_HOST_OBJECT_WITH_MEMORY_PRESSURE(rt, host,
144
- /*context=*/nullptr);
148
+ return RNSkia::makeJsiObject(rt, host);
145
149
  }
146
150
  #endif
147
151
 
@@ -0,0 +1,25 @@
1
+ #include "VroomFontMgr.h"
2
+
3
+ #pragma clang diagnostic push
4
+ #pragma clang diagnostic ignored "-Wdocumentation"
5
+ #if defined(__APPLE__)
6
+ #include "include/ports/SkFontMgr_mac_ct.h"
7
+ #elif defined(__ANDROID__)
8
+ #include "include/ports/SkFontMgr_android.h"
9
+ #include "include/ports/SkFontScanner_FreeType.h"
10
+ #endif
11
+ #pragma clang diagnostic pop
12
+
13
+ namespace vroom {
14
+
15
+ sk_sp<SkFontMgr> makePlatformFontMgr() {
16
+ #if defined(__APPLE__)
17
+ return SkFontMgr_New_CoreText(nullptr);
18
+ #elif defined(__ANDROID__)
19
+ return SkFontMgr_New_Android(nullptr, SkFontScanner_Make_FreeType());
20
+ #else
21
+ return nullptr;
22
+ #endif
23
+ }
24
+
25
+ } // namespace vroom
@@ -0,0 +1,14 @@
1
+ #pragma once
2
+
3
+ #pragma clang diagnostic push
4
+ #pragma clang diagnostic ignored "-Wdocumentation"
5
+ #include "include/core/SkFontMgr.h"
6
+ #include "include/core/SkRefCnt.h"
7
+ #pragma clang diagnostic pop
8
+
9
+ namespace vroom {
10
+
11
+ // Returns the platform system font manager, or nullptr if unavailable.
12
+ sk_sp<SkFontMgr> makePlatformFontMgr();
13
+
14
+ } // namespace vroom
@@ -15,7 +15,7 @@
15
15
  #include <memory>
16
16
 
17
17
  #include "VroomChartHostObject.h"
18
- #include "VroomSkiaContext.h"
18
+ #include "VroomFontMgr.h"
19
19
 
20
20
  #include "chart_internal.h"
21
21
 
@@ -26,20 +26,36 @@
26
26
  #include "include/core/SkTypeface.h"
27
27
  #pragma clang diagnostic pop
28
28
 
29
+ #if defined(__ANDROID__)
30
+ #include <android/log.h>
31
+ #define VROOM_WARN(...) \
32
+ __android_log_print(ANDROID_LOG_WARN, "VroomChart", __VA_ARGS__)
33
+ #elif defined(__APPLE__)
34
+ #include <os/log.h>
35
+ #define VROOM_WARN(fmt, ...) \
36
+ os_log_error(OS_LOG_DEFAULT, "VroomChart: " fmt, ##__VA_ARGS__)
37
+ #else
38
+ #define VROOM_WARN(...)
39
+ #endif
40
+
29
41
  namespace vroom {
30
42
 
31
43
  namespace jsi = facebook::jsi;
32
44
 
33
- // Loads the system typeface once via RN-Skia's platform context and hands
34
- // it to the chart core. Retries on each create() until it succeeds (in case
35
- // SkiaApi isn't installed yet when our first chart instance is created).
36
- static void ensureAxisTypeface(jsi::Runtime& runtime) {
45
+ // Loads the system typeface once via the platform SkFontMgr and hands it to
46
+ // the chart core. Built only once constructing a font manager enumerates
47
+ // the system font set and is not cheap. Failure is logged once; we do not
48
+ // retry, because this no longer depends on RN-Skia's JSI bindings appearing.
49
+ static void ensureAxisTypeface() {
37
50
  static bool done = false;
38
51
  if (done) return;
39
- auto ctx = vroom::getRNSkContext(runtime);
40
- if (!ctx) return;
41
- auto mgr = ctx->createFontMgr();
42
- if (!mgr) return;
52
+ done = true;
53
+
54
+ auto mgr = vroom::makePlatformFontMgr();
55
+ if (!mgr) {
56
+ VROOM_WARN("axis typeface: platform font manager unavailable");
57
+ return;
58
+ }
43
59
 
44
60
  // A null family name is meant to request "the platform default" — CoreText
45
61
  // (iOS) honors that, but Android's SkFontMgr_New_Android does not: it
@@ -51,12 +67,16 @@ static void ensureAxisTypeface(jsi::Runtime& runtime) {
51
67
  if (!tf) {
52
68
  tf = mgr->matchFamilyStyle("sans-serif", SkFontStyle());
53
69
  }
54
- if (!tf) return;
70
+ if (!tf) {
71
+ VROOM_WARN("axis typeface: no default or sans-serif typeface");
72
+ return;
73
+ }
55
74
  vroom::set_axis_typeface(tf);
56
- done = true;
57
75
  }
58
76
 
59
77
  void installJsi(jsi::Runtime& runtime) {
78
+ ensureAxisTypeface();
79
+
60
80
  auto create = jsi::Function::createFromHostFunction(
61
81
  runtime,
62
82
  jsi::PropNameID::forAscii(runtime, "create"),
@@ -65,7 +85,6 @@ void installJsi(jsi::Runtime& runtime) {
65
85
  const jsi::Value& /*thisVal*/,
66
86
  const jsi::Value* /*args*/,
67
87
  size_t /*count*/) -> jsi::Value {
68
- ensureAxisTypeface(rt);
69
88
  auto host = std::make_shared<ChartHostObject>();
70
89
  return jsi::Object::createFromHostObject(rt, host);
71
90
  });
@@ -345,7 +345,8 @@ void vroom_chart_set_visible_range(VroomChart* chart, int64_t start_ms, int64_t
345
345
  // Target candle *body* width in px for the default/reset framing. Larger = more
346
346
  // zoomed in (fewer candles), smaller = more zoomed out. 0 restores the legacy
347
347
  // "most recent ~80 candles" default. Affects initial framing only; an explicit
348
- // set_visible_range still overrides it.
348
+ // set_visible_range still overrides it. A series shorter than the implied window
349
+ // is left-padded with empty slots so bars stay this wide instead of stretching.
349
350
  void vroom_chart_set_default_candle_width(VroomChart* chart, float px);
350
351
 
351
352
  // Chart render mode: 0 = candlesticks (default), 1 = line chart (a polyline
@@ -50,6 +50,21 @@ int64_t max_future_gap(int64_t window_ms, int64_t cur_future) {
50
50
  return std::max<int64_t>((window_ms * 3) / 4, cur_future);
51
51
  }
52
52
 
53
+ // Pan/translate future allowance. A window longer than the data has nowhere
54
+ // useful to scroll, so don't grow the future gap — growing it used to combine
55
+ // with a first-candle start pin and latch the view. Dense series keep the
56
+ // usual 3/4-window rubber-band.
57
+ int64_t pan_max_future(int64_t window_ms, int64_t cur_future,
58
+ int64_t first_time, int64_t last_time,
59
+ int64_t candle_duration_ms) {
60
+ const int64_t dur = candle_duration_ms > 0 ? candle_duration_ms : 0;
61
+ const int64_t data_extent = last_time + dur - first_time;
62
+ if (data_extent >= 0 && window_ms > data_extent) {
63
+ return std::max<int64_t>(0, cur_future);
64
+ }
65
+ return max_future_gap(window_ms, cur_future);
66
+ }
67
+
53
68
  // Rubber-band a forward (into-future) pan delta: once the current future gap is
54
69
  // past the soft cap (window/2), damp the delta quadratically toward zero as it
55
70
  // nears the hard cap (3*window/4). Backward (into-past) deltas are unaffected.
@@ -109,13 +124,20 @@ void apply_default_framing(VroomChart* chart) {
109
124
  const double body = std::clamp(static_cast<double>(chart->default_candle_px),
110
125
  kMinCandleBodyPx, kMaxCandleBodyPx);
111
126
  if (usable > 0.0 && ratio > 0.0 && dur > 0.0 && body > 0.0) {
112
- int64_t window_ms = static_cast<int64_t>((usable * dur * ratio) / body);
113
- const int64_t span =
114
- chart->candles.back().time_ms - chart->candles.front().time_ms;
115
- window_ms = std::clamp<int64_t>(window_ms, chart->candle_duration_ms,
116
- span > 0 ? span : window_ms);
117
- frame(window_ms);
118
- return;
127
+ int64_t window_ms = vroom::window_for_body_width(
128
+ lay, chart->candle_duration_ms, body);
129
+ // Floor at one slot so the window is valid. Do NOT clamp to the
130
+ // data span: a short series would then stretch each bar to fill
131
+ // the plot, the opposite of a target body width. Empty space on
132
+ // the left is intentional — same rule as timeframeWindow (width
133
+ // wins).
134
+ if (window_ms > 0) {
135
+ if (window_ms < chart->candle_duration_ms) {
136
+ window_ms = chart->candle_duration_ms;
137
+ }
138
+ frame(window_ms);
139
+ return;
140
+ }
119
141
  }
120
142
  }
121
143
 
@@ -404,30 +426,23 @@ extern "C" void vroom_chart_pan(VroomChart* chart, float dx_px, float /*dy_px*/)
404
426
  (-dx_px / usable_px) * static_cast<float>(window_ms));
405
427
  if (delta_ms == 0) return;
406
428
 
407
- // The right edge can overshoot the last candle into empty "future" space.
408
- // Free scrolling up to half a window (candles fill >= 50%); from there to
409
- // 3/4 of a window (candles fill >= 25%) panning forward is rubber-banded so
410
- // it slows and hard-stops at the cap. The x-axis drag zoom can leave a gap
411
- // larger than the cap (it zooms in until ~one candle remains), so the cap
412
- // never forces it back — it just shrinks naturally as the user scrolls.
413
- // Left edge still hard-clamps at the first candle.
429
+ // Forward pans rubber-band between half and 3/4 of a window of empty
430
+ // future (see damp_future_delta / max_future_gap). Past clamping lives in
431
+ // clamp_shifted_time_window: dense series pin start at the first candle;
432
+ // a window longer than the data keeps empty past instead of latching.
414
433
  const int64_t first_time = chart->candles.front().time_ms;
415
434
  const int64_t last_time = chart->candles.back().time_ms;
416
435
  const int64_t cur_future = chart->visible_end_ms - last_time;
417
436
  const int64_t eff_delta = damp_future_delta(delta_ms, cur_future, window_ms);
418
437
 
419
- int64_t new_start = chart->visible_start_ms + eff_delta;
420
- int64_t new_end = chart->visible_end_ms + eff_delta;
421
-
422
- const int64_t max_future = max_future_gap(window_ms, cur_future);
423
- if (new_end > last_time + max_future) {
424
- new_end = last_time + max_future;
425
- new_start = new_end - window_ms;
426
- }
427
- if (new_start < first_time) {
428
- new_start = first_time;
429
- new_end = new_start + window_ms;
430
- }
438
+ const auto clamped = vroom::clamp_shifted_time_window(
439
+ chart->visible_start_ms + eff_delta,
440
+ chart->visible_end_ms + eff_delta,
441
+ first_time, last_time, chart->candle_duration_ms,
442
+ pan_max_future(window_ms, cur_future, first_time, last_time,
443
+ chart->candle_duration_ms));
444
+ const int64_t new_start = clamped.start_ms;
445
+ const int64_t new_end = clamped.end_ms;
431
446
 
432
447
  if (new_start == chart->visible_start_ms &&
433
448
  new_end == chart->visible_end_ms) {
@@ -467,22 +482,16 @@ extern "C" void vroom_chart_translate(VroomChart* chart, float dx_px, float dy_p
467
482
  const int64_t cur_future = chart->visible_end_ms - last_time;
468
483
  const int64_t eff_delta =
469
484
  damp_future_delta(delta_ms, cur_future, window_ms);
470
- int64_t new_start = chart->visible_start_ms + eff_delta;
471
- int64_t new_end = chart->visible_end_ms + eff_delta;
472
- const int64_t max_future =
473
- max_future_gap(window_ms, cur_future);
474
- if (new_end > last_time + max_future) {
475
- new_end = last_time + max_future;
476
- new_start = new_end - window_ms;
477
- }
478
- if (new_start < first_time) {
479
- new_start = first_time;
480
- new_end = new_start + window_ms;
481
- }
482
- if (new_start != chart->visible_start_ms ||
483
- new_end != chart->visible_end_ms) {
484
- chart->visible_start_ms = new_start;
485
- chart->visible_end_ms = new_end;
485
+ const auto clamped = vroom::clamp_shifted_time_window(
486
+ chart->visible_start_ms + eff_delta,
487
+ chart->visible_end_ms + eff_delta,
488
+ first_time, last_time, chart->candle_duration_ms,
489
+ pan_max_future(window_ms, cur_future, first_time, last_time,
490
+ chart->candle_duration_ms));
491
+ if (clamped.start_ms != chart->visible_start_ms ||
492
+ clamped.end_ms != chart->visible_end_ms) {
493
+ chart->visible_start_ms = clamped.start_ms;
494
+ chart->visible_end_ms = clamped.end_ms;
486
495
  changed = true;
487
496
  }
488
497
  }
@@ -597,9 +606,9 @@ extern "C" void vroom_chart_scale_time_axis(VroomChart* chart, float dx_px) {
597
606
  if (new_window_ms > max_window) new_window_ms = max_window;
598
607
 
599
608
  // Pivot around the right edge — most-recent visible candle stays put.
609
+ // A window longer than the data may start before the first candle; that
610
+ // empty past is how defaultCandleWidth wins, so don't pin start to first.
600
611
  int64_t new_start = chart->visible_end_ms - new_window_ms;
601
- const int64_t first_time = chart->candles.front().time_ms;
602
- if (new_start < first_time) new_start = first_time;
603
612
 
604
613
  if (new_start == chart->visible_start_ms) return;
605
614
  chart->visible_start_ms = new_start;
@@ -779,17 +788,14 @@ extern "C" void vroom_chart_zoom(VroomChart* chart, float scale_x, float scale_y
779
788
  const int64_t last_time = chart->candles.back().time_ms;
780
789
  // Cap the future gap at 3/4 of the (new) window so >= 25% of the
781
790
  // chart still shows candles, without snapping back an existing
782
- // larger gap (e.g. from the x-axis drag zoom).
783
- const int64_t max_future = max_future_gap(
784
- new_window, chart->visible_end_ms - last_time);
785
- if (new_end > last_time + max_future) {
786
- new_end = last_time + max_future;
787
- new_start = new_end - new_window;
788
- }
789
- if (new_start < first_time) {
790
- new_start = first_time;
791
- new_end = new_start + new_window;
792
- }
791
+ // larger gap (e.g. from the x-axis drag zoom). Past clamping
792
+ // matches pan: a window longer than the data keeps empty left.
793
+ const auto clamped = vroom::clamp_shifted_time_window(
794
+ new_start, new_end, first_time, last_time,
795
+ chart->candle_duration_ms,
796
+ max_future_gap(new_window, chart->visible_end_ms - last_time));
797
+ new_start = clamped.start_ms;
798
+ new_end = clamped.end_ms;
793
799
  if (new_start != chart->visible_start_ms ||
794
800
  new_end != chart->visible_end_ms) {
795
801
  chart->visible_start_ms = new_start;
@@ -23,8 +23,8 @@ sk_sp<SkPicture> render_chart_picture(VroomChart* chart);
23
23
  bool is_animating(VroomChart* chart);
24
24
 
25
25
  // Sets the typeface used for axis labels. Bridge layer calls this once at
26
- // startup with a system typeface loaded via RN-Skia's font manager. Labels
27
- // are skipped if no typeface is set.
26
+ // startup with a system typeface from the platform SkFontMgr. Labels are
27
+ // skipped if no typeface is set.
28
28
  void set_axis_typeface(sk_sp<SkTypeface> typeface);
29
29
 
30
30
  } // namespace vroom
@@ -21,6 +21,7 @@
21
21
  #include "chart.h"
22
22
  #include "fonts.h"
23
23
  #include "theme.h"
24
+ #include "ticks.h"
24
25
 
25
26
  namespace vroom::crosshair {
26
27
 
@@ -146,7 +147,10 @@ void draw(SkCanvas* canvas,
146
147
  if (lay.y_axis_width_px > 0.f) {
147
148
  const double price = vroom::y_to_price(lay, bounds, cy);
148
149
  char buf[32];
149
- std::snprintf(buf, sizeof(buf), "%.2f", price);
150
+ const int decimals = vroom::price_decimals(
151
+ vroom::pick_price_interval(bounds.max - bounds.min,
152
+ vroom::price_pane_bottom(lay)));
153
+ vroom::format_price(buf, sizeof(buf), price, decimals);
150
154
  const float axis_center_x = lay.width_px - lay.y_axis_width_px * 0.5f;
151
155
  draw_badge(canvas, font, buf, axis_center_x, cy, badge_fill,
152
156
  SK_ColorWHITE);
@@ -1,8 +1,8 @@
1
1
  // Global typeface for axis/label text rendering.
2
2
  //
3
- // Loaded once at startup by the bridge layer (which uses RN-Skia's platform-
4
- // context font manager to grab the system default). Held as a process-global
5
- // so all charts share it; per-chart font configuration is not modeled yet.
3
+ // Loaded once at startup by the bridge layer (which constructs a platform
4
+ // SkFontMgr and grabs the system default). Held as a process-global so all
5
+ // charts share it; per-chart font configuration is not modeled yet.
6
6
 
7
7
  #pragma once
8
8
 
@@ -153,13 +153,15 @@ void draw_y_labels(SkCanvas* canvas,
153
153
  // Horizontal center of the y-axis container ([width - y_axis_width, width]).
154
154
  // Labels (and the price box) center on this so their text shares a column.
155
155
  const float axis_center_x = lay.width_px - lay.y_axis_width_px * 0.5f;
156
+ const int decimals = vroom::price_decimals(
157
+ vroom::pick_price_interval(bounds.max - bounds.min, candle_area_h));
156
158
 
157
159
  for (const auto& f : chart.y_fades) {
158
160
  if (f.opacity <= 1e-3f) continue;
159
161
  const float y = vroom::price_to_y(lay, bounds, f.price);
160
162
 
161
163
  char buf[32];
162
- std::snprintf(buf, sizeof(buf), "%.2f", f.price);
164
+ vroom::format_price(buf, sizeof(buf), f.price, decimals);
163
165
  const size_t len = std::strlen(buf);
164
166
  const float text_w = font.measureText(
165
167
  buf, len, SkTextEncoding::kUTF8);
@@ -367,9 +369,12 @@ void recompute_axis_width(VroomChart& chart) {
367
369
  }
368
370
 
369
371
  SkFont font(tf, chart.theme.floats[VROOM_FLOAT_AXIS_FONT_SIZE_PX]);
372
+ const auto lay = chart.layout();
373
+ const int decimals = vroom::price_decimals(
374
+ vroom::pick_price_interval(hi - lo, vroom::price_pane_bottom(lay)));
370
375
  char buf_hi[32], buf_lo[32];
371
- std::snprintf(buf_hi, sizeof(buf_hi), "%.2f", hi);
372
- std::snprintf(buf_lo, sizeof(buf_lo), "%.2f", lo);
376
+ vroom::format_price(buf_hi, sizeof(buf_hi), hi, decimals);
377
+ vroom::format_price(buf_lo, sizeof(buf_lo), lo, decimals);
373
378
  const float w_hi = font.measureText(
374
379
  buf_hi, std::strlen(buf_hi), SkTextEncoding::kUTF8);
375
380
  const float w_lo = font.measureText(
@@ -19,6 +19,7 @@
19
19
  #include "chart.h"
20
20
  #include "fonts.h"
21
21
  #include "theme.h"
22
+ #include "ticks.h"
22
23
  #include "viewport.h"
23
24
 
24
25
  namespace vroom::price_indicator {
@@ -66,7 +67,9 @@ void draw(SkCanvas* canvas,
66
67
  font.setEdging(SkFont::Edging::kSubpixelAntiAlias);
67
68
 
68
69
  char buf[32];
69
- std::snprintf(buf, sizeof(buf), "%.2f", last.close);
70
+ const int decimals = vroom::price_decimals(
71
+ vroom::pick_price_interval(bounds.max - bounds.min, candle_area_h));
72
+ vroom::format_price(buf, sizeof(buf), last.close, decimals);
70
73
  const size_t len = std::strlen(buf);
71
74
 
72
75
  // Measure the tight glyph bounds (origin at the baseline) so we can center
@@ -23,6 +23,7 @@
23
23
  #include "fonts.h"
24
24
  #include "price_line_layout.h"
25
25
  #include "theme.h"
26
+ #include "ticks.h"
26
27
  #include "viewport.h"
27
28
 
28
29
  namespace vroom::price_lines {
@@ -212,11 +213,12 @@ void draw_axis_badge(SkCanvas* canvas,
212
213
  const Layout& lay,
213
214
  double price,
214
215
  float y,
215
- SkColor fill) {
216
+ SkColor fill,
217
+ int decimals) {
216
218
  if (lay.y_axis_width_px <= 0.f) return;
217
219
 
218
220
  char buf[32];
219
- std::snprintf(buf, sizeof(buf), "%.2f", price);
221
+ vroom::format_price(buf, sizeof(buf), price, decimals);
220
222
  const size_t len = std::strlen(buf);
221
223
 
222
224
  SkRect tb;
@@ -253,6 +255,8 @@ void draw(SkCanvas* canvas,
253
255
  const VroomPriceLineStyle& style = chart.price_line_style;
254
256
  SkFont font;
255
257
  const bool has_font = label_font(chart, &font);
258
+ const int decimals = vroom::price_decimals(
259
+ vroom::pick_price_interval(bounds.max - bounds.min, candle_area_h));
256
260
 
257
261
  for (size_t i = 0; i < chart.price_lines.size(); ++i) {
258
262
  const VroomChart::StoredPriceLine& pl = chart.price_lines[i];
@@ -351,7 +355,7 @@ void draw(SkCanvas* canvas,
351
355
 
352
356
  if (has_font && (pl.flags & VROOM_PRICE_LINE_AXIS_LABEL) != 0) {
353
357
  draw_axis_badge(canvas, font, lay, render_price(chart, i), y,
354
- line_color);
358
+ line_color, decimals);
355
359
  }
356
360
  }
357
361
  }
@@ -2,6 +2,7 @@
2
2
 
3
3
  #include <algorithm>
4
4
  #include <cmath>
5
+ #include <cstdio>
5
6
  #include <ctime>
6
7
 
7
8
  namespace vroom {
@@ -145,4 +146,17 @@ double pick_price_interval(double range, float candle_area_h) {
145
146
  return nice * magnitude;
146
147
  }
147
148
 
149
+ int price_decimals(double interval) {
150
+ if (!(interval > 0.0) || !std::isfinite(interval)) return 2;
151
+ const double d = std::ceil(-std::log10(interval) - 1e-12);
152
+ if (d < 0.0) return 0;
153
+ if (d > 12.0) return 12;
154
+ return static_cast<int>(d);
155
+ }
156
+
157
+ void format_price(char* buf, size_t buf_size, double price, int decimals) {
158
+ if (!buf || buf_size == 0) return;
159
+ std::snprintf(buf, buf_size, "%.*f", decimals, price);
160
+ }
161
+
148
162
  } // namespace vroom
@@ -6,6 +6,7 @@
6
6
 
7
7
  #pragma once
8
8
 
9
+ #include <cstddef>
9
10
  #include <cstdint>
10
11
 
11
12
  namespace vroom {
@@ -50,4 +51,11 @@ int64_t next_tick(int64_t t, const TimeTick& tick);
50
51
  // in the same units as the data (e.g. dollars).
51
52
  double pick_price_interval(double range, float candle_area_h);
52
53
 
54
+ // Decimal places needed so adjacent ticks `interval` apart don't collapse to
55
+ // the same string. 0.01 → 2, 0.005 → 3, 1e-8 → 8. Clamped to [0, 12].
56
+ int price_decimals(double interval);
57
+
58
+ // Writes `price` into `buf` using `decimals` (from price_decimals).
59
+ void format_price(char* buf, size_t buf_size, double price, int decimals);
60
+
53
61
  } // namespace vroom
@@ -17,6 +17,16 @@ float candle_body_width(const Layout& layout,
17
17
  return static_cast<float>(slot * layout.candle_width_ratio);
18
18
  }
19
19
 
20
+ int64_t window_for_body_width(const Layout& layout,
21
+ int64_t candle_duration_ms,
22
+ double body_px) {
23
+ const double usable = candle_area_width(layout);
24
+ const double ratio = static_cast<double>(layout.candle_width_ratio);
25
+ const double dur = static_cast<double>(candle_duration_ms);
26
+ if (usable <= 0.0 || ratio <= 0.0 || dur <= 0.0 || body_px <= 0.0) return 0;
27
+ return static_cast<int64_t>((usable * dur * ratio) / body_px);
28
+ }
29
+
20
30
  float candle_center_x(const Layout& layout,
21
31
  int64_t time_ms,
22
32
  int64_t candle_duration_ms,
@@ -265,4 +275,39 @@ double y_to_price(const Layout& layout,
265
275
  return bounds.min + t * range;
266
276
  }
267
277
 
278
+ TimeWindow clamp_shifted_time_window(int64_t start_ms, int64_t end_ms,
279
+ int64_t first_time, int64_t last_time,
280
+ int64_t candle_duration_ms,
281
+ int64_t max_future) {
282
+ const int64_t window = end_ms - start_ms;
283
+ if (window <= 0) return {start_ms, end_ms};
284
+
285
+ const int64_t dur = candle_duration_ms > 0 ? candle_duration_ms : 0;
286
+ const int64_t last_slot_end = last_time + dur;
287
+ const int64_t data_extent = last_slot_end - first_time;
288
+
289
+ if (max_future >= 0 && end_ms > last_time + max_future) {
290
+ end_ms = last_time + max_future;
291
+ start_ms = end_ms - window;
292
+ }
293
+
294
+ // Window longer than the series: empty past is how width wins. Floor the
295
+ // right edge at last_time so a pan into the past is a no-op when the
296
+ // candles are already right-aligned. Do not pin start to first_time — that
297
+ // throws the extra length into the future and the two caps latch.
298
+ if (data_extent >= 0 && window > data_extent) {
299
+ if (end_ms < last_time) {
300
+ end_ms = last_time;
301
+ start_ms = end_ms - window;
302
+ }
303
+ return {start_ms, end_ms};
304
+ }
305
+
306
+ if (start_ms < first_time) {
307
+ start_ms = first_time;
308
+ end_ms = start_ms + window;
309
+ }
310
+ return {start_ms, end_ms};
311
+ }
312
+
268
313
  } // namespace vroom
@@ -86,6 +86,36 @@ float candle_body_width(const Layout& layout,
86
86
  int64_t window_ms,
87
87
  int64_t candle_duration_ms);
88
88
 
89
+ // Inverse of candle_body_width: the time window that makes each candle body
90
+ // `body_px` wide. Returns 0 if any input is degenerate. Does not consult the
91
+ // data span — a short series leaves empty space on the left (width wins).
92
+ int64_t window_for_body_width(const Layout& layout,
93
+ int64_t candle_duration_ms,
94
+ double body_px);
95
+
96
+ // A [start, end] time window of fixed length, used by pan/zoom clamping.
97
+ struct TimeWindow {
98
+ int64_t start_ms;
99
+ int64_t end_ms;
100
+ };
101
+
102
+ // Clamp a same-length time window after a pan or pinch-zoom shift.
103
+ //
104
+ // The future cap (`max_future`, typically 3/4 of the window) is unchanged: the
105
+ // right edge cannot run past last_time + max_future.
106
+ //
107
+ // The past cap depends on whether the window fits in the data:
108
+ // - Window ≤ data extent: start cannot precede first_time (no empty past).
109
+ // - Window > data extent: empty past is intentional (width wins). start MAY
110
+ // precede first_time. Instead, the last candle cannot leave the right edge
111
+ // (end >= last_time). Pinning start to first_time in this case would shove
112
+ // the extra length into the future and latch, because the future cap then
113
+ // fights the past cap on every subsequent pan.
114
+ TimeWindow clamp_shifted_time_window(int64_t start_ms, int64_t end_ms,
115
+ int64_t first_time, int64_t last_time,
116
+ int64_t candle_duration_ms,
117
+ int64_t max_future);
118
+
89
119
  // Center-x of a candle whose period starts at time_ms and lasts
90
120
  // candle_duration_ms, given the current visible time window.
91
121
  float candle_center_x(const Layout& layout,
package/lib/index.d.mts CHANGED
@@ -627,7 +627,8 @@ type VroomChartCoreProps = {
627
627
  * more zoomed in (fewer candles); smaller → more zoomed out. Only affects
628
628
  * first load / reset; an explicit `visibleRange` takes precedence. Omit for
629
629
  * the default (~80 candles). Useful to keep candles a consistent size across
630
- * devices of different widths.
630
+ * devices of different widths. A series shorter than the window is left-padded
631
+ * with empty slots — bars stay this wide rather than stretching to fill.
631
632
  */
632
633
  defaultCandleWidth?: number;
633
634
  /**
package/lib/index.d.ts CHANGED
@@ -627,7 +627,8 @@ type VroomChartCoreProps = {
627
627
  * more zoomed in (fewer candles); smaller → more zoomed out. Only affects
628
628
  * first load / reset; an explicit `visibleRange` takes precedence. Omit for
629
629
  * the default (~80 candles). Useful to keep candles a consistent size across
630
- * devices of different widths.
630
+ * devices of different widths. A series shorter than the window is left-padded
631
+ * with empty slots — bars stay this wide rather than stretching to fill.
631
632
  */
632
633
  defaultCandleWidth?: number;
633
634
  /**
package/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "react-native-vroom-chart",
3
- "version": "0.9.0",
3
+ "version": "0.10.0",
4
4
  "description": "Mobile-first Skia candlestick chart for React Native",
5
5
  "license": "MIT",
6
6
  "author": "Darion Welch",
@@ -59,20 +59,21 @@
59
59
  "access": "public"
60
60
  },
61
61
  "peerDependencies": {
62
- "@shopify/react-native-skia": ">=2.0.0",
62
+ "@shopify/react-native-skia": ">=2.11.0",
63
63
  "react": "*",
64
64
  "react-native": "*",
65
65
  "react-native-gesture-handler": ">=2.16.0",
66
- "react-native-reanimated": ">=4.0.0"
66
+ "react-native-reanimated": ">=4.0.0",
67
+ "react-native-worklets": ">=0.7.0"
67
68
  },
68
69
  "devDependencies": {
69
- "@shopify/react-native-skia": "2.2.12",
70
+ "@shopify/react-native-skia": "2.11.0",
70
71
  "@types/react": "~19.1.0",
71
72
  "react": "19.1.0",
72
73
  "react-native": "0.81.5",
73
74
  "react-native-gesture-handler": "~2.28.0",
74
75
  "react-native-reanimated": "~4.1.7",
75
- "react-native-worklets": "0.5.1",
76
+ "react-native-worklets": "0.7.4",
76
77
  "tsup": "^8.5.1",
77
78
  "typescript": "~5.9.2",
78
79
  "vitest": "^3.2.6",
@@ -10,6 +10,11 @@ skia_pkg_json = `node --print "require.resolve('@shopify/react-native-skia/packa
10
10
  skia_src_dir = File.dirname(skia_pkg_json)
11
11
  skia_cpp_dir = File.join(skia_src_dir, "cpp")
12
12
  skia_skia_dir = File.join(skia_src_dir, "cpp", "skia")
13
+ skia_api_dir = File.join(skia_src_dir, "cpp", "api")
14
+ use_graphite = File.exist?(File.join(skia_src_dir, "libs", ".graphite"))
15
+ skia_preprocessor_defs = use_graphite ?
16
+ "$(inherited) SK_GRAPHITE=1 SK_IMAGE_READ_PIXELS_DISABLE_LEGACY_API=1 SK_DISABLE_LEGACY_SHAPER_FACTORY=1" :
17
+ "$(inherited) SK_METAL=1 SK_GANESH=1 SK_IMAGE_READ_PIXELS_DISABLE_LEGACY_API=1 SK_DISABLE_LEGACY_SHAPER_FACTORY=1"
13
18
 
14
19
  Pod::Spec.new do |s|
15
20
  s.name = "react-native-vroom-chart"
@@ -60,12 +65,13 @@ Pod::Spec.new do |s|
60
65
  '"$(PODS_TARGET_SRCROOT)/cpp"',
61
66
  "\"#{skia_cpp_dir}\"",
62
67
  "\"#{skia_skia_dir}\"",
68
+ "\"#{skia_api_dir}\"",
63
69
  ].join(" "),
64
- "CLANG_CXX_LANGUAGE_STANDARD" => "c++17",
65
- # Match RN-Skia's Skia build flags so our SkCanvas/SkPicture code sees the
66
- # same SK_METAL / SK_GANESH defines and doesn't mis-link.
67
- "GCC_PREPROCESSOR_DEFINITIONS" =>
68
- "$(inherited) SK_METAL=1 SK_GANESH=1 SK_DISABLE_LEGACY_SHAPER_FACTORY=1",
70
+ "CLANG_CXX_LANGUAGE_STANDARD" => "c++20",
71
+ # Match RN-Skia's Skia build flags (Ganesh vs Graphite, plus the
72
+ # SK_IMAGE_READ_PIXELS_DISABLE_LEGACY_API define both branches set) so our
73
+ # SkCanvas/SkPicture code sees the same ABI and doesn't mis-link.
74
+ "GCC_PREPROCESSOR_DEFINITIONS" => skia_preprocessor_defs,
69
75
  }
70
76
 
71
77
  s.dependency "React-Core"
@@ -1,33 +0,0 @@
1
- #include "VroomSkiaContext.h"
2
-
3
- namespace vroom {
4
-
5
- namespace jsi = facebook::jsi;
6
-
7
- std::shared_ptr<RNSkia::RNSkPlatformContext> getRNSkContext(
8
- jsi::Runtime& runtime) {
9
- auto val = runtime.global().getProperty(runtime, "SkiaApi");
10
- if (!val.isObject()) return nullptr;
11
- auto obj = val.asObject(runtime);
12
- if (!obj.isHostObject(runtime)) return nullptr;
13
- auto host = obj.asHostObject(runtime);
14
-
15
- // `global.SkiaApi` is always installed by RN-Skia's own
16
- // RNSkManager::installBindings() as exactly a `JsiSkApi` host object — never
17
- // any other JsiSkHostObject subclass — so this cast is safe as a plain
18
- // static_cast, without any RTTI check. We deliberately avoid
19
- // dynamic_pointer_cast here: on Android, RN-Skia is compiled into its own
20
- // librnskia.so, separate from libvroomchart.so, so a `JsiSkApi` constructed
21
- // by librnskia.so's code carries typeinfo from that .so; a dynamic_cast
22
- // performed here (in libvroomchart.so) sees an unmerged RTTI record for
23
- // "the same" class and always fails, even though the object is perfectly
24
- // valid to use. (Same underlying issue as the JsiSkPicture cross-.so cast
25
- // documented in VroomChartHostObject.cpp — but there RN-Skia's own compiled
26
- // code does the cast on an object *we* construct, so we can't avoid it;
27
- // here *we* do the cast on an object *they* construct, so we can just skip
28
- // the runtime check we don't need.)
29
- auto* accessor = static_cast<HostObjectAccessor*>(host.get());
30
- return accessor->getContext();
31
- }
32
-
33
- } // namespace vroom
@@ -1,30 +0,0 @@
1
- // Helpers for reaching into RN-Skia's installed JSI bindings to grab its
2
- // RNSkPlatformContext — which we need so we can use JsiSkFontMgrFactory to
3
- // get the system font manager cross-platform.
4
- //
5
- // JsiSkHostObject::getContext() is protected, so we use a "friend helper"
6
- // subclass that exposes it via `using`. We never construct an instance —
7
- // we just static_cast existing host objects to the accessor type.
8
-
9
- #pragma once
10
-
11
- #include <memory>
12
-
13
- #include <jsi/jsi.h>
14
-
15
- #include "JsiSkHostObjects.h" // RNSkia::JsiSkHostObject
16
- #include "RNSkPlatformContext.h" // RNSkia::RNSkPlatformContext
17
-
18
- namespace vroom {
19
-
20
- class HostObjectAccessor : public RNSkia::JsiSkHostObject {
21
- public:
22
- using RNSkia::JsiSkHostObject::getContext;
23
- };
24
-
25
- // Returns the RN-Skia platform context by reading global.SkiaApi.
26
- // Returns nullptr if SkiaApi isn't on the global yet (RN-Skia not installed).
27
- std::shared_ptr<RNSkia::RNSkPlatformContext> getRNSkContext(
28
- facebook::jsi::Runtime& runtime);
29
-
30
- } // namespace vroom