react-native-vroom-chart 0.17.0 → 0.18.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "react-native-vroom-chart",
-  "version": "0.17.0",
+  "version": "0.18.0",
   "description": "Mobile-first Skia candlestick chart for React Native",
   "license": "MIT",
   "author": "Darion Welch",
@@ -61,19 +61,19 @@
   "peerDependencies": {
     "@shopify/react-native-skia": ">=2.11.0",
     "react": "*",
-    "react-native": "*",
+    "react-native": ">=0.78",
     "react-native-gesture-handler": ">=2.16.0",
     "react-native-reanimated": ">=4.0.0",
     "react-native-worklets": ">=0.7.0"
   },
   "devDependencies": {
-    "@shopify/react-native-skia": "2.11.0",
-    "@types/react": "~19.1.0",
-    "react": "19.1.0",
-    "react-native": "0.81.5",
-    "react-native-gesture-handler": "~2.28.0",
-    "react-native-reanimated": "~4.1.7",
-    "react-native-worklets": "0.7.4",
+    "@shopify/react-native-skia": "2.12.0",
+    "@types/react": "~19.2.0",
+    "react": "19.2.3",
+    "react-native": "0.86.3",
+    "react-native-gesture-handler": "~2.32.0",
+    "react-native-reanimated": "~4.5.1",
+    "react-native-worklets": "0.10.1",
     "tsup": "^8.5.1",
     "typescript": "~5.9.2",
     "vitest": "^3.2.6",

package/react-native-vroom-chart.podspec

@@ -37,7 +37,7 @@ Pod::Spec.new do |s|
   s.homepage     = "https://github.com/keepitreal/vroom"
   s.license      = { :type => "MIT" }
   s.authors      = { "vroom" => "noreply@example.com" }
-  s.platforms    = { :ios => "14.0" }
+  s.platforms    = { :ios => "15.1" }
   s.source       = { :git => "" }
 
   s.requires_arc = true

package/src/NativeVroomChart.ts

@@ -1,10 +1,13 @@
 import type { TurboModule } from 'react-native';
 import { TurboModuleRegistry } from 'react-native';
 
-// TurboModule spec consumed by codegen. The only method is `install`, which
-// the native side uses to install the `global.VroomChartJSI` host object the
-// first time it's called from JS. All real chart operations go through that
-// host object, not through the TurboModule itself.
+// TurboModule spec consumed by codegen. The native side installs the
+// `global.VroomChartJSI` host object when React Native instantiates this
+// module, not when `install` is called — see the JSI-bindings hooks in
+// ../ios/VroomChartModule.mm and ../android/src/main/cpp/VroomChartJsiBindings.cpp.
+// `install` remains so the spec has a method to generate and so JS has a way
+// to force instantiation; all real chart operations go through the host
+// object, not through the TurboModule itself.
 export interface Spec extends TurboModule {
   install(): boolean;
 }

package/src/useChartCore.ts

@@ -354,10 +354,17 @@ const EMPTY_FOOTPRINTS = footprintsToSpec({ prints: [] });
 let installed = false;
 function ensureInstalled(): void {
   if (installed) return;
-  const ok = NativeVroomChart.install();
-  if (!ok) throw new Error('VroomChartModule.install() returned false');
+  // The bindings are installed by the TurboModule itself, when the runtime
+  // hands it over (installJSIBindingsWithRuntime:callInvoker: on iOS,
+  // getBindingsInstaller() on Android). Touching the module is what forces
+  // that to have happened; the global is the thing worth checking.
+  NativeVroomChart.install();
   if (typeof globalThis.VroomChartJSI === 'undefined') {
-    throw new Error('global.VroomChartJSI undefined after install()');
+    throw new Error(
+      'global.VroomChartJSI is undefined — VroomChartModule did not install ' +
+        'its JSI bindings. This requires react-native >= 0.78 with the New ' +
+        'Architecture enabled.',
+    );
   }
   installed = true;
 }

package/android/src/main/cpp/VroomChartJni.cpp

@@ -1,24 +0,0 @@
-// JNI entry point for VroomChartModule.install() (see
-// ../java/com/vroom/chart/VroomChartModule.kt). This is the Android
-// equivalent of ../../ios/VroomChartModule.mm's `-install` method: it
-// reinterprets the JSI runtime pointer handed over from Java and calls the
-// same platform-agnostic vroom::installJsi() the iOS bridge uses.
-
-#include <jni.h>
-
-#include <jsi/jsi.h>
-
-#include "VroomJsiInstaller.h"
-
-extern "C" JNIEXPORT jboolean JNICALL
-Java_com_vroom_chart_VroomChartModule_nativeInstall(JNIEnv* /*env*/,
-                                                      jobject /*thiz*/,
-                                                      jlong runtimePointer) {
-  auto* runtime =
-      reinterpret_cast<facebook::jsi::Runtime*>(runtimePointer);
-  if (runtime == nullptr) {
-    return JNI_FALSE;
-  }
-  vroom::installJsi(*runtime);
-  return JNI_TRUE;
-}