react-native-vroom-chart 0.10.0 → 0.11.0

package/cpp/_core_src/chart.cpp

@@ -36,6 +36,7 @@
 #include "rsi.h"
 #include "rsi_pane.h"
 #include "style_inherit.h"
+#include "tip_anchor.h"
 #include "tip_pulse.h"
 #include "volume.h"
 #include "vwap.h"
@@ -311,16 +312,23 @@ void VroomChart::draw_chart(SkCanvas* canvas) {
     // 5.8. Line-mode tip marker — the dot (and optional pulse) at the newest
     //      close. Above the overlays so it stays the eye's anchor, but before the
     //      axis masks, which trim the ring at the price scale.
+    //
+    //      Unlike every layer above, this one anchors to the newest candle in
+    //      the series rather than the newest on screen, so panning into history
+    //      carries the dot off the right edge with its candle (tip_anchor.h).
     if (fade > 0.f && theme.floats[VROOM_FLOAT_LINE_TIP_DOT] > 0.5f) {
+        const auto anchor = vroom::tip_anchor::at(range.start, range.end,
+                                                  candles.size(), morphing);
         vroom::ma_overlay::draw_close_tip(
-            canvas, lay, bounds, visible, n, window_ms, visible_start_ms,
-            candle_duration_ms, candle_right, candle_area_h,
+            canvas, lay, bounds, visible, anchor.slot_count, window_ms,
+            visible_start_ms, candle_duration_ms, candle_right, candle_area_h,
             theme.colors[VROOM_COLOR_LINE],
             theme.colors[VROOM_COLOR_BACKGROUND],
             theme.floats[VROOM_FLOAT_LINE_WIDTH_PX], fade,
             theme.floats[VROOM_FLOAT_LINE_TIP_PULSE] > 0.5f,
             tip_pulse_elapsed_s / vroom::tip_pulse::kPeriodSeconds,
-            morph_src, morph_n, morph_t);
+            anchor.use_morph ? morph_src : nullptr,
+            anchor.use_morph ? morph_n : 0, morph_t);
     }
 
     // 6. Axis backgrounds (mask any candle overflow). The x-axis separator

package/cpp/_core_src/chart.h

@@ -23,6 +23,7 @@
 #pragma clang diagnostic pop
 
 #include "labels.h"
+#include "price_format.h"
 #include "theme.h"
 #include "viewport.h"
 
@@ -89,6 +90,12 @@ struct VroomChart {
     // label. 0 = uncomputed; layout() falls back to a width ratio.
     float axis_width_px = 0.f;
 
+    // How prices render, derived from the asset's own scale. Cached beside the
+    // width because the two are measured together — every label site reads this
+    // so none of them can disagree with the strip they're drawn in. Both are
+    // refreshed by labels::recompute_axis_width.
+    vroom::PriceFormat price_fmt{};
+
     // --- price bounds (y-axis state) ---------------------------------------
     // Two modes. Auto (price_bounds_manual == false, the default): the y-range
     // continuously follows the visible candles each frame and `price_bounds`

package/cpp/_core_src/crosshair.cpp

@@ -20,6 +20,7 @@
 
 #include "chart.h"
 #include "fonts.h"
+#include "price_format.h"
 #include "theme.h"
 #include "ticks.h"
 
@@ -146,11 +147,12 @@ void draw(SkCanvas* canvas,
     // sharing the y-axis labels' column.
     if (lay.y_axis_width_px > 0.f) {
         const double price = vroom::y_to_price(lay, bounds, cy);
-        char buf[32];
-        const int decimals = vroom::price_decimals(
+        char buf[48];
+        const vroom::PriceFormat fmt = vroom::with_tick_guard(
+            chart.price_fmt,
             vroom::pick_price_interval(bounds.max - bounds.min,
                                        vroom::price_pane_bottom(lay)));
-        vroom::format_price(buf, sizeof(buf), price, decimals);
+        vroom::format_price(buf, sizeof(buf), price, fmt);
         const float axis_center_x = lay.width_px - lay.y_axis_width_px * 0.5f;
         draw_badge(canvas, font, buf, axis_center_x, cy, badge_fill,
                    SK_ColorWHITE);

package/cpp/_core_src/labels.cpp

@@ -19,6 +19,7 @@
 
 #include "chart.h"
 #include "fonts.h"
+#include "price_format.h"
 #include "ticks.h"
 #include "viewport.h"
 
@@ -47,6 +48,19 @@ void advance(Fade& f, float step, float dt) {
     }
 }
 
+// What the asset is worth, which is what its price precision keys off. The
+// newest close rather than the visible range, so panning and zooming don't
+// shift the decimals around under the user.
+//
+// An asset that has crossed orders of magnitude within one series (a token at
+// 0.00001 that later trades at 100) reads its recent scale here, so deep
+// history would round flat — the tick guard at each label site is what rescues
+// it, since the bounds down there are tiny enough to demand more decimals.
+double reference_price(const VroomChart& chart) {
+    if (!chart.candles.empty()) return chart.candles.back().close;
+    return (chart.price_bounds.max + chart.price_bounds.min) * 0.5;
+}
+
 // Drives a whole axis off the morph envelope instead of the per-label fades:
 // everything in the phase's tick set shares one opacity, and anything outside it
 // is dropped outright. At the midpoint the axis is transparent, so swapping the
@@ -153,15 +167,16 @@ void draw_y_labels(SkCanvas* canvas,
     // Horizontal center of the y-axis container ([width - y_axis_width, width]).
     // Labels (and the price box) center on this so their text shares a column.
     const float axis_center_x = lay.width_px - lay.y_axis_width_px * 0.5f;
-    const int decimals = vroom::price_decimals(
+    const vroom::PriceFormat fmt = vroom::with_tick_guard(
+        chart.price_fmt,
         vroom::pick_price_interval(bounds.max - bounds.min, candle_area_h));
 
     for (const auto& f : chart.y_fades) {
         if (f.opacity <= 1e-3f) continue;
         const float y = vroom::price_to_y(lay, bounds, f.price);
 
-        char buf[32];
-        vroom::format_price(buf, sizeof(buf), f.price, decimals);
+        char buf[48];
+        vroom::format_price(buf, sizeof(buf), f.price, fmt);
         const size_t len = std::strlen(buf);
         const float text_w = font.measureText(
             buf, len, SkTextEncoding::kUTF8);
@@ -347,6 +362,10 @@ void gc_x_fades(VroomChart& chart) {
 // ----- Axis-width sizing ----------------------------------------------------
 
 void recompute_axis_width(VroomChart& chart) {
+    // Precision first, and unconditionally: the label sites read it whether or
+    // not a typeface has loaded, and it's what the measurement below sizes for.
+    chart.price_fmt = vroom::price_format_for(reference_price(chart));
+
     auto tf = vroom::axis_typeface();
     if (!tf) {
         chart.axis_width_px = 0.f;
@@ -370,11 +389,16 @@ void recompute_axis_width(VroomChart& chart) {
 
     SkFont font(tf, chart.theme.floats[VROOM_FLOAT_AXIS_FONT_SIZE_PX]);
     const auto lay = chart.layout();
-    const int decimals = vroom::price_decimals(
+    // Same guard the label sites apply, against the bounds this is sizing for,
+    // so a zoom deep enough to add decimals widens the strip to hold them.
+    const vroom::PriceFormat fmt = vroom::with_tick_guard(
+        chart.price_fmt,
         vroom::pick_price_interval(hi - lo, vroom::price_pane_bottom(lay)));
-    char buf_hi[32], buf_lo[32];
-    vroom::format_price(buf_hi, sizeof(buf_hi), hi, decimals);
-    vroom::format_price(buf_lo, sizeof(buf_lo), lo, decimals);
+    // At the same decimals the longest label is whichever bound has the most
+    // integer digits, separators included.
+    char buf_hi[48], buf_lo[48];
+    vroom::format_price(buf_hi, sizeof(buf_hi), hi, fmt);
+    vroom::format_price(buf_lo, sizeof(buf_lo), lo, fmt);
     const float w_hi = font.measureText(
         buf_hi, std::strlen(buf_hi), SkTextEncoding::kUTF8);
     const float w_lo = font.measureText(

package/cpp/_core_src/ma_overlay.h

@@ -108,6 +108,11 @@ void draw_close_gradient(SkCanvas* canvas,
 // switch. `opacity` scales everything, fading the marker in with the line during
 // the candle→line morph.
 //
+// `n` counts the slots to the candle being marked, which is the series' newest
+// rather than the visible slice's — see tip_anchor.h, which derives it. That
+// candle can sit off the pane when panned into history, and the marker then
+// draws nothing.
+//
 // `pulse_phase` is in cycles and wraps, so the caller can hand over elapsed time
 // divided by tip_pulse::kPeriodSeconds. Ignored unless `pulse`.
 void draw_close_tip(SkCanvas* canvas,

package/cpp/_core_src/price_format.cpp

@@ -0,0 +1,87 @@
+#include "price_format.h"
+
+#include <algorithm>
+#include <cmath>
+#include <cstdio>
+
+namespace vroom {
+
+namespace {
+
+// Room for %.*f of any finite double at kPriceMaxDecimals: sign, the 309
+// integer digits DBL_MAX can reach, the point, and the decimals.
+constexpr size_t kPlainCap = 340;
+
+constexpr char kGroupSeparator = ',';
+constexpr int kGroupSize = 3;
+
+}  // namespace
+
+int significant_decimals(double reference) {
+    const double r = std::fabs(reference);
+    if (!(r > 0.0) || !std::isfinite(r)) return kPriceMinDecimals;
+    // floor(log10) is the exponent of the leading digit, so subtracting it from
+    // the digit budget lands the last significant digit on the final decimal.
+    const int exponent = static_cast<int>(std::floor(std::log10(r)));
+    return std::clamp(kPriceSigDigits - 1 - exponent, kPriceMinDecimals,
+                      kPriceMaxDecimals);
+}
+
+PriceFormat price_format_for(double reference) {
+    return PriceFormat{significant_decimals(reference), true};
+}
+
+int price_decimals(double interval) {
+    if (!(interval > 0.0) || !std::isfinite(interval)) return kPriceMinDecimals;
+    const double d = std::ceil(-std::log10(interval) - 1e-12);
+    if (d < 0.0) return 0;
+    if (d > static_cast<double>(kPriceMaxDecimals)) return kPriceMaxDecimals;
+    return static_cast<int>(d);
+}
+
+PriceFormat with_tick_guard(const PriceFormat& fmt, double interval) {
+    return PriceFormat{std::max(fmt.decimals, price_decimals(interval)),
+                       fmt.group};
+}
+
+void format_price(char* buf, size_t buf_size, double price,
+                  const PriceFormat& fmt) {
+    if (!buf || buf_size == 0) return;
+    const int decimals = std::clamp(fmt.decimals, 0, kPriceMaxDecimals);
+
+    char plain[kPlainCap];
+    if (std::snprintf(plain, sizeof(plain), "%.*f", decimals, price) < 0) {
+        buf[0] = '\0';
+        return;
+    }
+    if (!fmt.group) {
+        std::snprintf(buf, buf_size, "%s", plain);
+        return;
+    }
+
+    const char* src = plain;
+    size_t out = 0;
+    // Leaves room for the terminator on every write, so the result truncates
+    // the way snprintf would rather than running off the end.
+    const auto put = [&](char c) {
+        if (out + 1 < buf_size) buf[out++] = c;
+    };
+
+    if (*src == '-' || *src == '+') put(*src++);
+
+    // Digits up to the point, or the whole run when decimals == 0. A non-finite
+    // price has none, and falls through to the tail copy as "inf" / "nan".
+    const char* int_end = src;
+    while (*int_end >= '0' && *int_end <= '9') ++int_end;
+
+    const ptrdiff_t digits = int_end - src;
+    for (ptrdiff_t i = 0; i < digits; ++i) {
+        if (i > 0 && (digits - i) % kGroupSize == 0) put(kGroupSeparator);
+        put(src[i]);
+    }
+    for (const char* p = int_end; *p != '\0'; ++p) put(*p);
+
+    buf[out] = '\0';
+}
+
+}  // namespace vroom

package/cpp/_core_src/price_format.h

@@ -0,0 +1,69 @@
+// How a price is turned into the string on the y-axis.
+//
+// Precision follows the asset's own scale rather than the tick interval: a
+// sub-cent token needs nine decimals to say anything at all, while a
+// five-figure one is unreadable past two. Deriving it from the interval — as
+// the axis used to — gets both wrong, printing "84000" for the one and
+// "0.000060" for the other.
+//
+// The rule is a fixed count of significant digits with a floor, which is what
+// reproduces a conventional price scale across the whole range:
+//
+//   4.4094e-5 -> 9 decimals   0.000044094
+//   0.023397  -> 6 decimals   0.023397
+//   80285.20  -> 2 decimals   80,285.20   (floor)
+//   2513.92   -> 2 decimals   2,513.92    (floor)
+//
+// The reference is the asset's own price, not the visible range, so the
+// precision holds steady while the user pans and zooms. A range-derived count
+// would change under the user's finger and drag the axis width along with it.
+//
+// Skia-free and separately compiled so the unit tests can cover it; see
+// tests/test_price_format.cpp.
+
+#pragma once
+
+#include <cstddef>
+
+namespace vroom {
+
+// Significant digits a price is quoted to. Five is what conventional price
+// scales show: it keeps 0.023397 intact and still fits 0.000044094.
+inline constexpr int kPriceSigDigits = 5;
+
+// Prices at or above ~1 unit read as currency, where fewer than two decimals
+// looks broken (a "$84,000" axis next to a "$80,285.20" last price).
+inline constexpr int kPriceMinDecimals = 2;
+
+// Past this the digits are noise, and %.*f starts printing the binary
+// representation's tail rather than anything the feed meant.
+inline constexpr int kPriceMaxDecimals = 12;
+
+// How to render a price. `group` inserts thousands separators, which only ever
+// affects the integer part.
+struct PriceFormat {
+    int  decimals = kPriceMinDecimals;
+    bool group = true;
+};
+
+// Decimals giving kPriceSigDigits significant digits for an asset priced around
+// |reference|, clamped to [kPriceMinDecimals, kPriceMaxDecimals]. A zero or
+// non-finite reference falls back to the floor.
+int significant_decimals(double reference);
+
+// The format for an asset priced around `reference`.
+PriceFormat price_format_for(double reference);
+
+// Decimal places needed so adjacent ticks `interval` apart don't collapse to
+// the same string. 0.01 → 2, 0.005 → 3, 1e-8 → 8. Clamped to [0, 12].
+int price_decimals(double interval);
+
+// `fmt` raised, if need be, so ticks `interval` apart stay distinct. The asset's
+// precision is the floor; only a zoom deeper than that precision adds to it.
+PriceFormat with_tick_guard(const PriceFormat& fmt, double interval);
+
+// Writes `price` into `buf` per `fmt`, truncating rather than overrunning.
+void format_price(char* buf, size_t buf_size, double price,
+                  const PriceFormat& fmt);
+
+}  // namespace vroom

package/cpp/_core_src/price_indicator.cpp

@@ -18,6 +18,7 @@
 
 #include "chart.h"
 #include "fonts.h"
+#include "price_format.h"
 #include "theme.h"
 #include "ticks.h"
 #include "viewport.h"
@@ -66,10 +67,11 @@ void draw(SkCanvas* canvas,
     font.setSubpixel(true);
     font.setEdging(SkFont::Edging::kSubpixelAntiAlias);
 
-    char buf[32];
-    const int decimals = vroom::price_decimals(
+    char buf[48];
+    const vroom::PriceFormat fmt = vroom::with_tick_guard(
+        chart.price_fmt,
         vroom::pick_price_interval(bounds.max - bounds.min, candle_area_h));
-    vroom::format_price(buf, sizeof(buf), last.close, decimals);
+    vroom::format_price(buf, sizeof(buf), last.close, fmt);
     const size_t len = std::strlen(buf);
 
     // Measure the tight glyph bounds (origin at the baseline) so we can center

package/cpp/_core_src/price_lines.cpp

@@ -21,6 +21,7 @@
 
 #include "chart.h"
 #include "fonts.h"
+#include "price_format.h"
 #include "price_line_layout.h"
 #include "theme.h"
 #include "ticks.h"
@@ -214,11 +215,11 @@ void draw_axis_badge(SkCanvas* canvas,
                      double price,
                      float y,
                      SkColor fill,
-                     int decimals) {
+                     const PriceFormat& fmt) {
     if (lay.y_axis_width_px <= 0.f) return;
 
-    char buf[32];
-    vroom::format_price(buf, sizeof(buf), price, decimals);
+    char buf[48];
+    vroom::format_price(buf, sizeof(buf), price, fmt);
     const size_t len = std::strlen(buf);
 
     SkRect tb;
@@ -255,7 +256,8 @@ void draw(SkCanvas* canvas,
     const VroomPriceLineStyle& style = chart.price_line_style;
     SkFont font;
     const bool has_font = label_font(chart, &font);
-    const int decimals = vroom::price_decimals(
+    const vroom::PriceFormat fmt = vroom::with_tick_guard(
+        chart.price_fmt,
         vroom::pick_price_interval(bounds.max - bounds.min, candle_area_h));
 
     for (size_t i = 0; i < chart.price_lines.size(); ++i) {
@@ -355,7 +357,7 @@ void draw(SkCanvas* canvas,
 
         if (has_font && (pl.flags & VROOM_PRICE_LINE_AXIS_LABEL) != 0) {
             draw_axis_badge(canvas, font, lay, render_price(chart, i), y,
-                            line_color, decimals);
+                            line_color, fmt);
         }
     }
 }

package/cpp/_core_src/ticks.cpp

@@ -2,7 +2,6 @@
 
 #include <algorithm>
 #include <cmath>
-#include <cstdio>
 #include <ctime>
 
 namespace vroom {
@@ -146,17 +145,4 @@ double pick_price_interval(double range, float candle_area_h) {
     return nice * magnitude;
 }
 
-int price_decimals(double interval) {
-    if (!(interval > 0.0) || !std::isfinite(interval)) return 2;
-    const double d = std::ceil(-std::log10(interval) - 1e-12);
-    if (d < 0.0) return 0;
-    if (d > 12.0) return 12;
-    return static_cast<int>(d);
-}
-
-void format_price(char* buf, size_t buf_size, double price, int decimals) {
-    if (!buf || buf_size == 0) return;
-    std::snprintf(buf, buf_size, "%.*f", decimals, price);
-}
-
 }  // namespace vroom

package/cpp/_core_src/ticks.h

@@ -6,7 +6,6 @@
 
 #pragma once
 
-#include <cstddef>
 #include <cstdint>
 
 namespace vroom {
@@ -49,13 +48,8 @@ int64_t next_tick(int64_t t, const TimeTick& tick);
 // "Nice number" tick selection for the y-axis: snaps to 1, 2, or 5 × 10ⁿ
 // based on the price range and target spacing. Returns the price interval
 // in the same units as the data (e.g. dollars).
+//
+// Turning that interval into a label string is price_format.h's job.
 double pick_price_interval(double range, float candle_area_h);
 
-// Decimal places needed so adjacent ticks `interval` apart don't collapse to
-// the same string. 0.01 → 2, 0.005 → 3, 1e-8 → 8. Clamped to [0, 12].
-int price_decimals(double interval);
-
-// Writes `price` into `buf` using `decimals` (from price_decimals).
-void format_price(char* buf, size_t buf_size, double price, int decimals);
-
 }  // namespace vroom

package/cpp/_core_src/tip_anchor.h

@@ -0,0 +1,49 @@
+// Which slot the line chart's tip marker anchors to (see draw_close_tip in
+// ma_overlay.cpp).
+//
+// The tip marks the newest close in the *series*, not the newest close on
+// screen — the same rule the price indicator follows (price_indicator.cpp).
+// Panning into history therefore carries the dot off the right edge with the
+// candle it belongs to, where draw_close_tip's on-pane guard drops it.
+//
+// Every other line-chart layer draws the visible slice, so the tip is the one
+// caller that has to reach past range.end. The slice is a view into the same
+// contiguous candle buffer, so widening the slot count is enough to reach the
+// newest candle — no second pointer.
+//
+// Skia-free and header-only so the unit tests can cover it; see
+// tests/test_tip_anchor.cpp.
+
+#pragma once
+
+#include <cstddef>
+
+namespace vroom::tip_anchor {
+
+// How draw_close_tip should be called for one frame.
+struct Anchor {
+    // Slot count to pass in place of the visible count, so slot 0 resolves to
+    // the newest candle in the series. Never 0 for a non-empty visible slice.
+    std::size_t slot_count;
+    // Whether the interval-morph capture still lines up with slot 0.
+    bool use_morph;
+};
+
+// `range_start`/`range_end` are the visible slice's half-open bounds into a
+// series of `total` candles; `morphing` is whether an interval morph is running.
+//
+// The capture taken at a timeframe switch is indexed from the newest *visible*
+// candle, so it only pairs with slot 0 while the newest candle is the one at the
+// right edge. Scrolled back, pairing them would interpolate the tip between two
+// unrelated candles and strand the dot mid-pane for the length of the switch.
+inline Anchor at(std::size_t range_start,
+                 std::size_t range_end,
+                 std::size_t total,
+                 bool morphing) {
+    // A caller with an empty or out-of-bounds slice has nothing to anchor to;
+    // reporting 0 slots lets draw_close_tip take its existing early-out.
+    if (range_start >= total) return Anchor{0, false};
+    return Anchor{total - range_start, morphing && range_end >= total};
+}
+
+}  // namespace vroom::tip_anchor

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "react-native-vroom-chart",
-  "version": "0.10.0",
+  "version": "0.11.0",
   "description": "Mobile-first Skia candlestick chart for React Native",
   "license": "MIT",
   "author": "Darion Welch",
@@ -83,6 +83,7 @@
     "typecheck": "tsc --noEmit",
     "test": "vitest run",
     "build": "tsup",
+    "check:podspec": "ruby scripts/check-podspec-portable.rb",
     "vendor:core": "node scripts/vendor-core.mjs"
   }
 }

package/react-native-vroom-chart.podspec

@@ -1,16 +1,30 @@
 require "json"
+require "pathname"
 
 package = JSON.parse(File.read(File.join(__dir__, "package.json")))
 
-# Resolve the absolute path to the @shopify/react-native-skia source.
-# We need it because RN-Skia ships its Skia headers via `#include "include/core/SkPicture.h"`,
-# which only resolves when the include path points at the source `cpp/` and `cpp/skia/`
-# directories — CocoaPods' flat Headers/Public/ layout loses the `include/...` prefix.
+# Locate the @shopify/react-native-skia source. We need it because RN-Skia ships
+# its Skia headers via `#include "include/core/SkPicture.h"`, which only resolves
+# when the include path points at the source `cpp/` and `cpp/skia/` directories —
+# CocoaPods' flat Headers/Public/ layout loses the `include/...` prefix.
+#
+# The paths must be emitted relative to $(PODS_TARGET_SRCROOT), never absolute.
+# CocoaPods serializes this spec to `Pods/Local Podspecs/*.podspec.json` and hashes
+# that file into Podfile.lock's SPEC CHECKSUMS, so an absolute path bakes the
+# checkout root of whoever ran `pod install` into the lockfile and every other
+# machine fails `pod install --deployment`. Resolving at spec-eval time (rather
+# than hardcoding `../@shopify/react-native-skia`) keeps this correct under
+# non-hoisted layouts such as pnpm's.
 skia_pkg_json = `node --print "require.resolve('@shopify/react-native-skia/package.json')"`.strip
+raise "react-native-vroom-chart: could not resolve @shopify/react-native-skia" if skia_pkg_json.empty?
 skia_src_dir = File.dirname(skia_pkg_json)
-skia_cpp_dir = File.join(skia_src_dir, "cpp")
-skia_skia_dir = File.join(skia_src_dir, "cpp", "skia")
-skia_api_dir = File.join(skia_src_dir, "cpp", "api")
+skia_rel_dir = File.join("$(PODS_TARGET_SRCROOT)",
+  Pathname.new(skia_src_dir).relative_path_from(Pathname.new(__dir__)).to_s)
+skia_cpp_dir = File.join(skia_rel_dir, "cpp")
+skia_skia_dir = File.join(skia_rel_dir, "cpp", "skia")
+skia_api_dir = File.join(skia_rel_dir, "cpp", "api")
+# Absolute is fine here: the result only selects a preprocessor-define string,
+# so it never reaches the emitted spec.
 use_graphite = File.exist?(File.join(skia_src_dir, "libs", ".graphite"))
 skia_preprocessor_defs = use_graphite ?
   "$(inherited) SK_GRAPHITE=1 SK_IMAGE_READ_PIXELS_DISABLE_LEGACY_API=1 SK_DISABLE_LEGACY_SHAPER_FACTORY=1" :