react-native-video-trim 8.1.2 → 8.1.4

package/android/src/main/java/com/videotrim/BaseVideoTrimModule.kt

@@ -690,7 +690,9 @@ open class BaseVideoTrimModule internal constructor(
 
     if (!needsReEncode) {
       // Stream copy: no encoder is opened so the fallback chain doesn't apply.
+      // -y overwrites any pre-existing output file without prompting.
       val cmds = mutableListOf(
+        "-y",
         "-ss", "${startTime}ms",
         "-to", "${endTime}ms",
         "-i", url,
@@ -721,7 +723,11 @@ open class BaseVideoTrimModule internal constructor(
     } catch (_: Exception) {}
 
     val buildCommand: (List<String>) -> Array<String> = { encoderArgs ->
+      // -y overwrites the output file without prompting, so the encoder fallback
+      // chain's software retry can reuse the same output path left behind by the
+      // failed hardware attempt instead of aborting on FFmpeg's overwrite prompt.
       val cmds = mutableListOf(
+        "-y",
         "-ss", "${startTime}ms",
         "-to", "${endTime}ms",
         "-i", url,

package/android/src/main/java/com/videotrim/utils/VideoTrimmerUtil.kt

@@ -297,7 +297,8 @@ object VideoTrimmerUtil {
     if (!needsReEncode) {
       // Stream copy: no re-encoding, extremely fast but only cuts at keyframes.
       // No encoder is opened so the fallback chain doesn't apply — single attempt.
-      val cmds = mutableListOf("-ss", "${startMs}ms", "-to", "${endMs}ms", "-i", inputFile)
+      // -y overwrites any pre-existing output file without prompting.
+      val cmds = mutableListOf("-y", "-ss", "${startMs}ms", "-to", "${endMs}ms", "-i", inputFile)
       if (removeAudio) {
         cmds.addAll(listOf("-c:v", "copy", "-an"))
       } else {
@@ -354,7 +355,11 @@ object VideoTrimmerUtil {
     // Note: Android FFmpegKit auto-rotates by default, so no -noautorotate is needed.
     // The transpose filters above only handle user-initiated rotation, not source metadata.
     val buildCommand: (List<String>) -> Array<String> = { encoderArgs ->
-      val cmds = mutableListOf("-ss", "${startMs}ms", "-to", "${endMs}ms", "-i", inputFile)
+      // -y overwrites the output file without prompting. This is critical for the
+      // encoder fallback chain: the first (hardware) attempt opens/creates the output
+      // file before MediaCodec fails, so the software retry reuses the same path and
+      // would otherwise hit FFmpeg's interactive "Overwrite? [y/N]" prompt and abort.
+      val cmds = mutableListOf("-y", "-ss", "${startMs}ms", "-to", "${endMs}ms", "-i", inputFile)
       // When enablePreciseTrimming is the only reason for re-encode (no transforms),
       // videoFilters is empty — skip -vf entirely to avoid FFmpeg error on empty filter.
       if (filterString.isNotEmpty()) {

package/ios/VideoTrim.swift

@@ -359,7 +359,11 @@ public class VideoTrim: RCTEventEmitter, AssetLoaderDelegate, UIDocumentPickerDe
       root.present(progressAlert, animated: true, completion: nil)
     }
     
+    // -y overwrites any pre-existing output file without prompting, so FFmpeg never
+    // blocks on an interactive "Overwrite? [y/N]" prompt (hardening; also keeps the
+    // command symmetric with Android, where -y is required by the encoder fallback chain).
     var cmds = [
+      "-y",
       "-ss",
       "\(startTime * 1000)ms",
       "-to",
@@ -378,22 +382,13 @@ public class VideoTrim: RCTEventEmitter, AssetLoaderDelegate, UIDocumentPickerDe
     let needsReEncode = hasUserTransform || cropNorm != nil || enablePreciseTrimming || needsSpeed
     
     if needsReEncode, let vc = vc {
-      // -noautorotate disables FFmpeg's automatic rotation, so we must manually
-      // compensate for the source video's rotation metadata via transpose filters.
-      if let asset = vc.asset,
-         let videoTrack = asset.tracks(withMediaType: .video).first {
-        let t = videoTrack.preferredTransform
-        let sourceAngle = atan2(t.b, t.a)
-        if abs(sourceAngle - .pi / 2) < 0.1 {
-          videoFilters.append("transpose=1")
-        } else if abs(sourceAngle + .pi / 2) < 0.1 {
-          videoFilters.append("transpose=2")
-        } else if abs(abs(sourceAngle) - .pi) < 0.1 {
-          videoFilters.append("transpose=1")
-          videoFilters.append("transpose=1")
-        }
-      }
-      
+      // Let FFmpeg autorotate the source (note: NO -noautorotate below). Autorotate bakes
+      // the source rotation matrix into upright, display-orientation pixels AND strips the
+      // matrix from the output. The previous approach (-noautorotate + a manual source-
+      // compensation transpose) baked the pixels but left the source rotation matrix on the
+      // output, so on ffmpeg-kit 6 every rotation-tagged portrait clip came out
+      // double-rotated (sideways). User rotate/flip and crop below operate on the already-
+      // upright autorotated frame, so their math is unchanged.
       switch vc.rotationCount {
       case 1: videoFilters.append("transpose=2")
       case 2:
@@ -460,9 +455,9 @@ public class VideoTrim: RCTEventEmitter, AssetLoaderDelegate, UIDocumentPickerDe
         }
       }
       
-      // -noautorotate: we handle rotation via explicit transpose filters above,
-      // so FFmpeg must not auto-rotate or the output will be double-rotated.
-      cmds.append("-noautorotate")
+      // NOTE: intentionally NO -noautorotate. FFmpeg autorotates the input so the source
+      // rotation is baked into the pixels and the output carries no stale rotation matrix
+      // (otherwise rotation-tagged portrait clips are double-rotated -> sideways on ffmpeg-kit 6).
       cmds.append(contentsOf: ["-i", inputFile.path])
       // When enablePreciseTrimming is the only reason for re-encode (no transforms),
       // videoFilters is empty — skip -vf entirely to avoid FFmpeg error on empty filter.
@@ -648,7 +643,9 @@ public class VideoTrim: RCTEventEmitter, AssetLoaderDelegate, UIDocumentPickerDe
     
     let startTime = config["startTime"] as? Double ?? 0
     let endTime = config["endTime"] as? Double ?? 0
+    // -y overwrites any pre-existing output file without prompting (hardening).
     var cmds = [
+      "-y",
       "-ss",
       "\(startTime)ms",
       "-to",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "react-native-video-trim",
-  "version": "8.1.2",
+  "version": "8.1.4",
   "description": "Video trimmer for your React Native app",
   "main": "./lib/module/index.js",
   "types": "./lib/typescript/src/index.d.ts",