react-native-video-trim 4.0.0 → 4.1.0

package/README.md

@@ -1,3 +1,4 @@
+# Table of contents
 - [Installation](#installation)
    * [For iOS (React Native CLI project)](#for-ios-react-native-cli-project)
    * [For Expo project](#for-expo-project)
@@ -19,8 +20,6 @@
 - [Android: update SDK version](#android-update-sdk-version)
 - [Thanks](#thanks)
 
-<!-- TOC end -->
-
 # React Native Video Trim
 <div align="center">
 <h2>Video trimmer for your React Native app</h2>
@@ -31,7 +30,7 @@
 
 ## Features
 - ✅ Support video and audio
-- ✅ Support local files
+- ✅ Support local files and remote files (remote files need `https` version, see below)
 - ✅ Save to Photos, Documents and Share to other apps
 - ✅ Check if file is valid video/audio
 - ✅ File operations: list, clean up, delete specific file
@@ -71,9 +70,10 @@ npx pod-install ios
 You need to run `prebuild` in order for native code takes effect:
 ```
 npx expo prebuild
-
-npx pod-install ios
 ```
+Then you need to restart to make the changes take effect
+
+> Note that on iOS you'll need to run on real device, Expo Go may not work because of library linking
 
 ## Usage
 
@@ -211,6 +211,8 @@ Main method to show Video Editor UI.
   - `alertOnFailTitle` (`default = "Error"`)
   - `alertOnFailMessage` (`default = "Fail to load media. Possibly invalid file or no network connection"`)
   - `alertOnFailCloseText` (`default = "Close"`)
+  - `enableRotation` (`default = false`)
+  - `rotationAngle` (`default = 0`)
 
 If `saveToPhoto = true`, you must ensure that you have request permission to write to photo/gallery
 - For Android: you need to have `<uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE" />` in AndroidManifest.xml
@@ -241,6 +243,10 @@ If you face issue when building Android app related to `file_paths`, then you ma
 </paths>
 ```
 
+# trim(url: string, options: TrimOptions): Promise<string>
+
+Directly trim a file without showing editor
+
 ## isValidFile(videoPath: string)
 
 This method is to check if a path is a valid video/audio
@@ -363,14 +369,36 @@ If there's error while loading media, there'll be a prompt
 
 Related props: `alertOnFailToLoad, alertOnFailTitle, alertOnFailMessage, alertOnFailCloseText`
 
+# Use FFMPEG HTTPS version
+
+If you want to trim a remote file, you need to use `https` version (default is `min` which does not support remote file).
+
+Do the following:
+
+```
+// android/build.gradle
+buildscript {
+    ext {
+        VideoTrim_ffmpeg_package=https
+
+        // optional: VideoTrim_ffmpeg_version=6.0.1
+    }
+}
+
+// ios
+FFMPEGKIT_PACKAGE=https FFMPEG_KIT_PACKAGE_VERSION=6.0 pod install
+```
+
 # Android: update SDK version
 You can override sdk version to use any version in your `android/build.gradle` > `buildscript` > `ext`
 ```gradle
 buildscript {
     ext {
-        VideoTrim_compileSdkVersion = 34
-        VideoTrim_minSdkVersion = 26
-        VideoTrim_targetSdkVersion = 34
+        VideoTrim_kotlinVersion=2.0.21
+        VideoTrim_minSdkVersion=24
+        VideoTrim_targetSdkVersion=34
+        VideoTrim_compileSdkVersion=35
+        VideoTrim_ndkVersion=27.1.12297006
     }
 }
 ```

package/VideoTrim.podspec

@@ -15,7 +15,7 @@ Pod::Spec.new do |s|
 
   s.source_files = "ios/**/*.{h,m,mm,swift}"
 
-  s.dependency 'ffmpeg-mobile-min', '~> 6.0'
+  s.dependency "ffmpeg-mobile-#{ENV['FFMPEGKIT_PACKAGE'] || 'min'}", ENV['FFMPEGKIT_PACKAGE_VERSION'] || '~> 6.0'
 
   load 'nitrogen/generated/ios/VideoTrim+autolinking.rb'
   add_nitrogen_files(s)

package/android/build.gradle

@@ -30,6 +30,14 @@ def getExtOrIntegerDefault(name) {
   return rootProject.ext.has(name) ? rootProject.ext.get(name) : (project.properties["VideoTrim_" + name]).toInteger()
 }
 
+def getPackageNameOrDefault() {
+  return rootProject.ext.has("VideoTrim_ffmpeg_package") ? rootProject.ext.get("VideoTrim_ffmpeg_package") : project.properties["VideoTrim_ffmpeg_package"]
+}
+
+def getPackageVersionOrDefault() {
+  return rootProject.ext.has("VideoTrim_ffmpeg_version") ? rootProject.ext.get("VideoTrim_ffmpeg_version") : project.properties["VideoTrim_ffmpeg_version"]
+}
+
 android {
   namespace "com.margelo.nitro.videotrim"
 
@@ -126,6 +134,6 @@ dependencies {
   implementation "org.jetbrains.kotlin:kotlin-stdlib:$kotlin_version"
   implementation project(":react-native-nitro-modules")
 
-  implementation 'io.github.maitrungduc1410:ffmpeg-kit-min:6.0.0'
+  implementation 'io.github.maitrungduc1410:ffmpeg-kit-' + getPackageNameOrDefault() +':' + getPackageVersionOrDefault()
 }
 

package/android/gradle.properties

@@ -3,3 +3,5 @@ VideoTrim_minSdkVersion=24
 VideoTrim_targetSdkVersion=34
 VideoTrim_compileSdkVersion=35
 VideoTrim_ndkVersion=27.1.12297006
+VideoTrim_ffmpeg_package=min
+VideoTrim_ffmpeg_version=6.0.1

package/android/src/main/java/com/margelo/nitro/videotrim/VideoTrim.kt

@@ -4,6 +4,7 @@ import android.R.attr.progressBarStyleHorizontal
 import android.R.attr.selectableItemBackground
 import android.R.color.holo_red_light
 import android.R.style.Theme_Black_NoTitleBar_Fullscreen
+import android.annotation.SuppressLint
 import android.app.Activity
 import android.content.Context
 import android.content.DialogInterface
@@ -24,6 +25,8 @@ import androidx.core.content.ContextCompat
 import androidx.core.content.FileProvider
 import androidx.core.graphics.toColorInt
 import androidx.core.net.toUri
+import com.arthenica.ffmpegkit.FFmpegKit
+import com.arthenica.ffmpegkit.ReturnCode;
 import com.facebook.proguard.annotations.DoNotStrip
 import com.facebook.react.bridge.BaseActivityEventListener
 import com.facebook.react.bridge.LifecycleEventListener
@@ -39,7 +42,11 @@ import iknow.android.utils.BaseUtils
 import java.io.File
 import java.io.FileInputStream
 import java.io.IOException
+import java.text.SimpleDateFormat
+import java.util.Date
+import java.util.TimeZone
 import kotlin.coroutines.resume
+import kotlin.coroutines.resumeWithException
 import kotlin.coroutines.suspendCoroutine
 
 @DoNotStrip
@@ -50,41 +57,10 @@ class VideoTrim : HybridVideoTrimSpec(), VideoTrimListener, LifecycleEventListen
   private var mProgressDialog: AlertDialog? = null
   private var cancelTrimmingConfirmDialog: AlertDialog? = null
   private var mProgressBar: ProgressBar? = null
-
-  //  private var enableCancelTrimming = true
-//
-//  private var cancelTrimmingButtonText: String? = "Cancel"
-//  private var enableCancelTrimmingDialog = true
-//  private var cancelTrimmingDialogTitle: String? = "Warning!"
-//  private var cancelTrimmingDialogMessage: String? = "Are you sure want to cancel trimming?"
-//  private var cancelTrimmingDialogCancelText: String? = "Close"
-//  private var cancelTrimmingDialogConfirmText: String? = "Proceed"
-//  private var enableCancelDialog = true
-//  private var cancelDialogTitle: String? = "Warning!"
-//  private var cancelDialogMessage: String? = "Are you sure want to cancel?"
-//  private var cancelDialogCancelText: String? = "Close"
-//  private var cancelDialogConfirmText: String? = "Proceed"
-//  private var enableSaveDialog = true
-//  private var saveDialogTitle: String? = "Confirmation!"
-//  private var saveDialogMessage: String? = "Are you sure want to save?"
-//  private var saveDialogCancelText: String? = "Close"
-//  private var saveDialogConfirmText: String? = "Proceed"
-//  private var trimmingText: String? = "Trimming video..."
   private var outputFile: String? = null
-//  private var saveToPhoto = false
-//  private var removeAfterSavedToPhoto = false
-//  private var removeAfterFailedToSavePhoto = false
-//  private var removeAfterSavedToDocuments = false
-//  private var removeAfterFailedToSaveDocuments = false
-
-  //  private boolean removeAfterShared = false; // TODO: on Android there's no way to know if user shared the file or share sheet closed
-  //  private boolean removeAfterFailedToShare = false; // TODO: implement this
-//  private var openDocumentsOnFinish = false
-//  private var openShareSheetOnFinish = false
   private var isVideoType = true
-//  private var closeWhenFinish = true
-
-  private lateinit var editorConfig: EditorConfig
+  private var editorConfig: EditorConfig? = null
+  private var trimOptions: TrimOptions? = null
   private var onEvent: ((eventName: String, payload: Map<String, String>) -> Unit)? = null
   private var onComplete: (() -> Unit)? = null
 
@@ -112,7 +88,7 @@ class VideoTrim : HybridVideoTrimSpec(), VideoTrimListener, LifecycleEventListen
               } ?: return
             // File saved successfully
             Log.d(TAG, "File saved successfully to $uri")
-            if (editorConfig.removeAfterSavedToDocuments) {
+            if (editorConfig?.removeAfterSavedToDocuments == true || trimOptions?.removeAfterFailedToSaveDocuments == true) {
               StorageUtil.deleteFile(outputFile)
             }
           } catch (e: Exception) {
@@ -122,7 +98,7 @@ class VideoTrim : HybridVideoTrimSpec(), VideoTrimListener, LifecycleEventListen
               "Failed to save edited video to Documents: ${e.localizedMessage}",
               ErrorCode.FAIL_TO_SAVE_TO_DOCUMENTS
             )
-            if (editorConfig.removeAfterFailedToSaveDocuments) {
+            if (editorConfig?.removeAfterFailedToSaveDocuments == true || trimOptions?.removeAfterFailedToSaveDocuments == true) {
               StorageUtil.deleteFile(outputFile)
             }
           } finally {
@@ -145,68 +121,9 @@ class VideoTrim : HybridVideoTrimSpec(), VideoTrimListener, LifecycleEventListen
 
     this.editorConfig = config
     this.onEvent = onEvent
-//    enableCancelTrimming =
-//      !config.hasKey("enableCancelTrimming") || config.getBoolean("enableCancelTrimming")
-//
-//    cancelTrimmingButtonText =
-//      if (config.hasKey("cancelTrimmingButtonText")) config.getString("cancelTrimmingButtonText") else "Cancel"
-//    enableCancelTrimmingDialog =
-//      !config.hasKey("enableCancelTrimmingDialog") || config.getBoolean("enableCancelTrimmingDialog")
-//    cancelTrimmingDialogTitle =
-//      if (config.hasKey("cancelTrimmingDialogTitle")) config.getString("cancelTrimmingDialogTitle") else "Warning!"
-//    cancelTrimmingDialogMessage =
-//      if (config.hasKey("cancelTrimmingDialogMessage")) config.getString("cancelTrimmingDialogMessage") else "Are you sure want to cancel trimming?"
-//    cancelTrimmingDialogCancelText =
-//      if (config.hasKey("cancelTrimmingDialogCancelText")) config.getString("cancelTrimmingDialogCancelText") else "Close"
-//    cancelTrimmingDialogConfirmText =
-//      if (config.hasKey("cancelTrimmingDialogConfirmText")) config.getString("cancelTrimmingDialogConfirmText") else "Proceed"
-//
-//    enableCancelDialog =
-//      !config.hasKey("enableCancelDialog") || config.getBoolean("enableCancelDialog")
-//    cancelDialogTitle =
-//      if (config.hasKey("cancelDialogTitle")) config.getString("cancelDialogTitle") else "Warning!"
-//    cancelDialogMessage =
-//      if (config.hasKey("cancelDialogMessage")) config.getString("cancelDialogMessage") else "Are you sure want to cancel?"
-//    cancelDialogCancelText =
-//      if (config.hasKey("cancelDialogCancelText")) config.getString("cancelDialogCancelText") else "Close"
-//    cancelDialogConfirmText =
-//      if (config.hasKey("cancelDialogConfirmText")) config.getString("cancelDialogConfirmText") else "Proceed"
-//
-//    enableSaveDialog = !config.hasKey("enableSaveDialog") || config.getBoolean("enableSaveDialog")
-//    saveDialogTitle =
-//      if (config.hasKey("saveDialogTitle")) config.getString("saveDialogTitle") else "Confirmation!"
-//    saveDialogMessage =
-//      if (config.hasKey("saveDialogMessage")) config.getString("saveDialogMessage") else "Are you sure want to save?"
-//    saveDialogCancelText =
-//      if (config.hasKey("saveDialogCancelText")) config.getString("saveDialogCancelText") else "Close"
-//    saveDialogConfirmText =
-//      if (config.hasKey("saveDialogConfirmText")) config.getString("saveDialogConfirmText") else "Proceed"
-//    trimmingText =
-//      if (config.hasKey("trimmingText")) config.getString("trimmingText") else "Trimming video..."
-//
-//    saveToPhoto = config.hasKey("saveToPhoto") && config.getBoolean("saveToPhoto")
-//    removeAfterSavedToPhoto =
-//      config.hasKey("removeAfterSavedToPhoto") && config.getBoolean("removeAfterSavedToPhoto")
-//    removeAfterFailedToSavePhoto =
-//      config.hasKey("removeAfterFailedToSavePhoto") && config.getBoolean("removeAfterFailedToSavePhoto")
-//    removeAfterSavedToDocuments =
-//      config.hasKey("removeAfterSavedToDocuments") && config.getBoolean("removeAfterSavedToDocuments")
-//    removeAfterFailedToSaveDocuments =
-//      config.hasKey("removeAfterFailedToSaveDocuments") && config.getBoolean("removeAfterFailedToSaveDocuments")
-//    //    removeAfterShared = config.hasKey("removeAfterShared") && config.getBoolean("removeAfterShared");
-////    removeAfterFailedToShare = config.hasKey("removeAfterFailedToShare") && config.getBoolean("removeAfterFailedToShare");
-//    openDocumentsOnFinish =
-//      config.hasKey("openDocumentsOnFinish") && config.getBoolean("openDocumentsOnFinish")
-//
-//    openShareSheetOnFinish =
-//      config.hasKey("openShareSheetOnFinish") && config.getBoolean("openShareSheetOnFinish")
-
-    isVideoType = config.type == "video"
-
-//    closeWhenFinish = !config.hasKey("closeWhenFinish") || config.getBoolean("closeWhenFinish")
+    this.isVideoType = config.type == "video"
 
     val activity = NitroModules.applicationContext?.currentActivity
-
     if (!isInit) {
       init()
       isInit = true
@@ -288,11 +205,11 @@ class VideoTrim : HybridVideoTrimSpec(), VideoTrimListener, LifecycleEventListen
       )
     )
 
-    if (editorConfig.saveToPhoto && isVideoType) {
+    if (editorConfig!!.saveToPhoto && isVideoType) {
       try {
         StorageUtil.saveVideoToGallery(NitroModules.applicationContext, outputFile)
         Log.d(TAG, "Edited video saved to Photo Library successfully.")
-        if (editorConfig.removeAfterSavedToPhoto) {
+        if (editorConfig!!.removeAfterSavedToPhoto) {
           StorageUtil.deleteFile(outputFile)
         }
       } catch (e: IOException) {
@@ -301,19 +218,19 @@ class VideoTrim : HybridVideoTrimSpec(), VideoTrimListener, LifecycleEventListen
           "Failed to save edited video to Photo Library: " + e.localizedMessage,
           ErrorCode.FAIL_TO_SAVE_TO_PHOTO
         )
-        if (editorConfig.removeAfterFailedToSavePhoto) {
+        if (editorConfig!!.removeAfterFailedToSavePhoto) {
           StorageUtil.deleteFile(outputFile)
         }
       } finally {
-        hideDialog(editorConfig.closeWhenFinish)
+        hideDialog(editorConfig!!.closeWhenFinish)
       }
-    } else if (editorConfig.openDocumentsOnFinish) {
+    } else if (editorConfig!!.openDocumentsOnFinish) {
       saveFileToExternalStorage(File(outputFile!!))
-    } else if (editorConfig.openShareSheetOnFinish) {
-      hideDialog(editorConfig.closeWhenFinish)
+    } else if (editorConfig!!.openShareSheetOnFinish) {
+      hideDialog(editorConfig!!.closeWhenFinish)
       shareFile(NitroModules.applicationContext!!, File(outputFile!!))
     } else {
-      hideDialog(editorConfig.closeWhenFinish)
+      hideDialog(editorConfig!!.closeWhenFinish)
     }
   }
 
@@ -331,7 +248,7 @@ class VideoTrim : HybridVideoTrimSpec(), VideoTrimListener, LifecycleEventListen
   }
 
   override fun onCancel() {
-    if (!editorConfig.enableCancelDialog) {
+    if (!editorConfig!!.enableCancelDialog) {
       sendEvent("onCancel", mapOf())
       hideDialog(true)
       return
@@ -340,16 +257,16 @@ class VideoTrim : HybridVideoTrimSpec(), VideoTrimListener, LifecycleEventListen
     val builder = AlertDialog.Builder(
       NitroModules.applicationContext?.currentActivity!!
     )
-    builder.setMessage(editorConfig.cancelDialogMessage)
-    builder.setTitle(editorConfig.cancelDialogTitle)
+    builder.setMessage(editorConfig!!.cancelDialogMessage)
+    builder.setTitle(editorConfig!!.cancelDialogTitle)
     builder.setCancelable(false)
-    builder.setPositiveButton(editorConfig.cancelDialogConfirmText) { dialog: DialogInterface, which: Int ->
+    builder.setPositiveButton(editorConfig!!.cancelDialogConfirmText) { dialog: DialogInterface, which: Int ->
       dialog.cancel()
       sendEvent("onCancel", mapOf())
       hideDialog(true)
     }
     builder.setNegativeButton(
-      editorConfig.cancelDialogCancelText
+      editorConfig!!.cancelDialogCancelText
     ) { dialog: DialogInterface, which: Int ->
       dialog.cancel()
     }
@@ -358,7 +275,7 @@ class VideoTrim : HybridVideoTrimSpec(), VideoTrimListener, LifecycleEventListen
   }
 
   override fun onSave() {
-    if (!editorConfig.enableSaveDialog) {
+    if (!editorConfig!!.enableSaveDialog) {
       startTrim()
       return
     }
@@ -366,15 +283,15 @@ class VideoTrim : HybridVideoTrimSpec(), VideoTrimListener, LifecycleEventListen
     val builder = AlertDialog.Builder(
       NitroModules.applicationContext?.currentActivity!!
     )
-    builder.setMessage(editorConfig.saveDialogMessage)
-    builder.setTitle(editorConfig.saveDialogTitle)
+    builder.setMessage(editorConfig!!.saveDialogMessage)
+    builder.setTitle(editorConfig!!.saveDialogTitle)
     builder.setCancelable(false)
-    builder.setPositiveButton(editorConfig.saveDialogConfirmText) { dialog: DialogInterface, which: Int ->
+    builder.setPositiveButton(editorConfig!!.saveDialogConfirmText) { dialog: DialogInterface, which: Int ->
       dialog.cancel()
       startTrim()
     }
     builder.setNegativeButton(
-      editorConfig.saveDialogCancelText
+      editorConfig!!.saveDialogCancelText
     ) { dialog: DialogInterface, _: Int ->
       dialog.cancel()
     }
@@ -408,7 +325,7 @@ class VideoTrim : HybridVideoTrimSpec(), VideoTrimListener, LifecycleEventListen
       ViewGroup.LayoutParams.WRAP_CONTENT,
       ViewGroup.LayoutParams.WRAP_CONTENT
     )
-    textView.text = editorConfig.trimmingText
+    textView.text = editorConfig!!.trimmingText
     textView.gravity = Gravity.CENTER
     textView.textSize = 18f
     layout.addView(textView)
@@ -423,14 +340,14 @@ class VideoTrim : HybridVideoTrimSpec(), VideoTrimListener, LifecycleEventListen
     layout.addView(mProgressBar)
 
     // Create button
-    if (editorConfig.enableCancelTrimming) {
+    if (editorConfig!!.enableCancelTrimming) {
       val button = Button(activity)
       button.layoutParams = ViewGroup.LayoutParams(
         ViewGroup.LayoutParams.WRAP_CONTENT,
         ViewGroup.LayoutParams.WRAP_CONTENT
       )
       // Set the text and style it like a text button
-      button.text = editorConfig.cancelTrimmingButtonText
+      button.text = editorConfig!!.cancelTrimmingButtonText
       button.setTextColor(
         ContextCompat.getColor(
           activity!!,
@@ -443,14 +360,14 @@ class VideoTrim : HybridVideoTrimSpec(), VideoTrimListener, LifecycleEventListen
       activity.theme.resolveAttribute(selectableItemBackground, outValue, true)
       button.setBackgroundResource(outValue.resourceId)
       button.setOnClickListener { v: View? ->
-        if (editorConfig.enableCancelTrimmingDialog) {
+        if (editorConfig!!.enableCancelTrimmingDialog) {
           val builder = AlertDialog.Builder(
             activity
           )
-          builder.setMessage(editorConfig.cancelTrimmingDialogMessage)
-          builder.setTitle(editorConfig.cancelTrimmingDialogTitle)
+          builder.setMessage(editorConfig!!.cancelTrimmingDialogMessage)
+          builder.setTitle(editorConfig!!.cancelTrimmingDialogTitle)
           builder.setCancelable(false)
-          builder.setPositiveButton(editorConfig.cancelTrimmingDialogConfirmText) { dialog: DialogInterface?, which: Int ->
+          builder.setPositiveButton(editorConfig!!.cancelTrimmingDialogConfirmText) { dialog: DialogInterface?, which: Int ->
             if (trimmerView != null) {
               trimmerView!!.onCancelTrimClicked()
             }
@@ -459,7 +376,7 @@ class VideoTrim : HybridVideoTrimSpec(), VideoTrimListener, LifecycleEventListen
             }
           }
           builder.setNegativeButton(
-            editorConfig.cancelTrimmingDialogCancelText
+            editorConfig!!.cancelTrimmingDialogCancelText
           ) { dialog: DialogInterface, which: Int ->
             dialog.cancel()
           }
@@ -591,6 +508,106 @@ class VideoTrim : HybridVideoTrimSpec(), VideoTrimListener, LifecycleEventListen
     }
   }
 
+  override fun trim(url: String, options: TrimOptions): Promise<String> {
+    return Promise.async {
+      trimOptions = options
+
+      @SuppressLint("SimpleDateFormat")
+      suspend fun getTrimresult(): String = suspendCoroutine { continuation ->
+        val currentDate = Date()
+        val dateFormat = SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ss.SSSZ")
+
+        dateFormat.timeZone = TimeZone.getTimeZone("UTC")
+        val formattedDateTime = dateFormat.format(currentDate)
+
+        var cmds = arrayOf(
+          "-ss",
+          "${options.startTime}ms",
+          "-to",
+          "${options.endTime}ms",
+        )
+
+        if (options.enableRotation) {
+          cmds += arrayOf("-display_rotation", "${options.rotationAngle}")
+        }
+
+        outputFile = StorageUtil.getOutputPath(NitroModules.applicationContext, options.outputExt)
+
+        cmds += arrayOf(
+          "-i",
+          url,
+          "-c",
+          "copy",
+          "-metadata",
+          "creation_time=$formattedDateTime",
+          outputFile!!
+        )
+
+        Log.d(TAG, "Command: ${cmds.joinToString(",")}")
+
+        FFmpegKit.executeWithArgumentsAsync(cmds, { session ->
+          val state = session.state
+          val returnCode = session.returnCode
+          when {
+            ReturnCode.isSuccess(returnCode) -> {
+              // SUCCESS
+              if (options.saveToPhoto && options.type == "video") {
+                try {
+                  StorageUtil.saveVideoToGallery(NitroModules.applicationContext, outputFile)
+                  Log.d(TAG, "Edited video saved to Photo Library successfully.")
+                  if (options.removeAfterSavedToPhoto) {
+                    StorageUtil.deleteFile(outputFile)
+                  }
+
+                  continuation.resume(outputFile!!)
+                } catch (e: IOException) {
+                  e.printStackTrace()
+
+                  if (options.removeAfterFailedToSavePhoto) {
+                    StorageUtil.deleteFile(outputFile)
+                  }
+
+                  continuation.resumeWithException(
+                    Exception("Failed to save edited video to Photo Library: " + e.localizedMessage)
+                  )
+                }
+              } else {
+                  if (options.openDocumentsOnFinish) {
+                    saveFileToExternalStorage(File(outputFile!!))
+                  } else if (options.openShareSheetOnFinish) {
+                    shareFile(NitroModules.applicationContext!!, File(outputFile!!))
+                  }
+
+                  continuation.resume(outputFile!!)
+                }
+              }
+            ReturnCode.isCancel(returnCode) -> {
+              // CANCEL
+              println("FFmpeg command was cancelled")
+              continuation.resumeWithException(
+                Exception("FFmpeg command was cancelled")
+              )
+            }
+            else -> {
+              // FAILURE
+              val errorMessage = String.format("Command failed with state %s and rc %s.%s", state, returnCode, session.getFailStackTrace());
+              println(errorMessage)
+              continuation.resumeWithException(
+                Exception(errorMessage)
+              )
+            }
+          }
+        }, { log ->
+          Log.d(TAG, "FFmpeg process started with log ${log.message}")
+        }, { statistics ->
+          // Handle statistics if needed
+        })
+      }
+
+      getTrimresult()
+    }
+  }
+
   private fun saveFileToExternalStorage(file: File) {
     val intent = Intent(Intent.ACTION_CREATE_DOCUMENT)
     intent.addCategory(Intent.CATEGORY_OPENABLE)

package/android/src/main/java/com/margelo/nitro/videotrim/utils/VideoTrimmerUtil.java

@@ -13,8 +13,10 @@ import com.margelo.nitro.videotrim.enums.ErrorCode;
 import com.margelo.nitro.videotrim.interfaces.VideoTrimListener;
 
 import java.text.SimpleDateFormat;
+import java.util.ArrayList;
 import java.util.Date;
 import java.util.HashMap;
+import java.util.List;
 import java.util.Map;
 import java.util.TimeZone;
 
@@ -43,7 +45,7 @@ public class VideoTrimmerUtil {
   public static final int THUMB_WIDTH = UnitConverter.dpToPx(25); // x2 for better resolution
   private static final int THUMB_RESOLUTION_RES = 2; // double thumb resolution for better quality
 
-  public static FFmpegSession trim(String inputFile, String outputFile, int videoDuration, long startMs, long endMs, final VideoTrimListener callback) {
+  public static FFmpegSession trim(String inputFile, String outputFile, int videoDuration, long startMs, long endMs, boolean enableRotation, double rotationAngle, final VideoTrimListener callback) {
     // Get the current date and time
     Date currentDate = new Date();
 
@@ -55,26 +57,32 @@ public class VideoTrimmerUtil {
     // Format the current date and time
     String formattedDateTime = dateFormat.format(currentDate);
 
-    String[] cmds = {
-      "-ss",
-      startMs + "ms",
-      "-to",
-      endMs + "ms",
-      "-i",
-      inputFile,
-      "-c",
-      "copy",
-      "-metadata",
-      "creation_time=" + formattedDateTime,
-      outputFile
-    };
-    Log.d(TAG,"Command111: " + String.join(",", cmds));
-
-    FFmpegSession s = FFmpegKit.execute("-protocols");
-    Log.d(TAG, "1111getOutput: " + s.getOutput());
-    Log.d(TAG, "1111getAllLogs: " + s.getAllLogs());
-
-    return FFmpegKit.executeWithArgumentsAsync(cmds, session -> {
+    // create list to store commands
+    List<String> cmds = new ArrayList<>();
+    cmds.add("-ss");
+    cmds.add(startMs + "ms");
+    cmds.add("-to");
+    cmds.add(endMs + "ms");
+
+    if (enableRotation) {
+      // add "-display_rotation" and rotation angle to the command, contact, not creating new
+      cmds.add("-display_rotation");
+      cmds.add(String.valueOf(rotationAngle));
+    }
+
+    cmds.add("-i");
+    cmds.add(inputFile);
+    cmds.add("-c");
+    cmds.add("copy");
+    cmds.add("-metadata");
+    cmds.add("creation_time=" + formattedDateTime);
+    cmds.add(outputFile);
+
+    String[] command = cmds.toArray(new String[0]);
+
+    Log.d(TAG,"Command: " + String.join(",", command));
+
+    return FFmpegKit.executeWithArgumentsAsync(command, session -> {
       SessionState state = session.getState();
       ReturnCode returnCode = session.getReturnCode();
       if (ReturnCode.isSuccess(session.getReturnCode())) {

package/android/src/main/java/com/margelo/nitro/videotrim/widgets/VideoTrimmerView.java

@@ -87,6 +87,9 @@ public class VideoTrimmerView extends FrameLayout implements IVideoTrimmerView {
   private RelativeLayout trimmerContainerWrapper;
 
   private long startTime = 0, endTime = 0;
+  private boolean enableRotation = false;
+  private double rotationAngle = 0.0;
+
   private Vibrator vibrator;
   private boolean didClampWhilePanning = false;
 
@@ -374,6 +377,8 @@ public class VideoTrimmerView extends FrameLayout implements IVideoTrimmerView {
       mDuration,
       startTime,
       endTime,
+      enableRotation,
+      rotationAngle,
       mOnTrimVideoListener
     );
   }
@@ -484,12 +489,11 @@ public class VideoTrimmerView extends FrameLayout implements IVideoTrimmerView {
       headerView.setVisibility(View.VISIBLE);
 
     alertOnFailToLoad = config.getAlertOnFailToLoad();
-
-      alertOnFailTitle = config.getAlertOnFailTitle();
-
-      alertOnFailMessage = config.getAlertOnFailMessage();
-
-      alertOnFailCloseText = config.getAlertOnFailCloseText();
+    alertOnFailTitle = config.getAlertOnFailTitle();
+    alertOnFailMessage = config.getAlertOnFailMessage();
+    alertOnFailCloseText = config.getAlertOnFailCloseText();
+    enableRotation = config.getEnableRotation();
+    rotationAngle = config.getRotationAngle();
   }
 
   private void startTimingRunnable() {

package/ios/VideoTrim.swift

@@ -57,4 +57,11 @@ class VideoTrim: HybridVideoTrimSpec {
             return await self.impl.isValidFile(uri: url)
         }
     }
+    
+    func trim(url: String, options: TrimOptions) throws -> NitroModules.Promise<String> {
+        return Promise.async {
+            // This runs on a separate Thread, and can use```` `await` syntax!
+            return try await self.impl.trim(url: url, options: options)
+        }
+    }
 }