react-native-video-trim 3.0.9 → 4.0.0

package/LICENSE

@@ -1,6 +1,6 @@
 MIT License
 
-Copyright (c) 2023 Mai Trung Duc
+Copyright (c) 2025 Mai Trung Duc
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal
 in the Software without restriction, including without limitation the rights

package/README.md

@@ -1,3 +1,26 @@
+- [Installation](#installation)
+   * [For iOS (React Native CLI project)](#for-ios-react-native-cli-project)
+   * [For Expo project](#for-expo-project)
+   * [Usage](#usage)
+- [Methods](#methods)
+   * [showEditor(videoPath: string, config?: EditorConfig, onEvent?: (eventName: string, payload: Record<string, string>) => void)](#showeditorvideopath-string-config-editorconfig-onevent-eventname-string-payload-record--void)
+   * [isValidFile(videoPath: string)](#isvalidfilevideopath-string)
+   * [closeEditor()](#closeeditor)
+   * [listFiles()](#listfiles)
+   * [cleanFiles()](#cleanfiles)
+   * [deleteFile()](#deletefile)
+- [Callbacks (New arch)](#callbacks-new-arch)
+   * [showEditor](#showeditor)
+   * [closeEditor](#closeeditor-1)
+- [Events (Old arch)](#events-old-arch)
+- [Audio support](#audio-support)
+- [Cancel trimming](#cancel-trimming)
+- [Fail to load media](#fail-to-load-media)
+- [Android: update SDK version](#android-update-sdk-version)
+- [Thanks](#thanks)
+
+<!-- TOC end -->
+
 # React Native Video Trim
 <div align="center">
 <h2>Video trimmer for your React Native app</h2>
@@ -12,21 +35,33 @@
 - ✅ Save to Photos, Documents and Share to other apps
 - ✅ Check if file is valid video/audio
 - ✅ File operations: list, clean up, delete specific file
+- ✅ Support React Native New + Old Arch
 
 <div align="left">
 <img src="images/document_picker.png" width="300" />
 <img src="images/share_sheet.png" width="300" />
 </div>
 
-## Installation
+# Installation
 
 ```sh
-npm install react-native-video-trim
+# new arch
+npm install react-native-video-trim react-native-nitro-modules
+
+# old arch
+npm install react-native-video-trim@^3.0.0
 
 # or with yarn
 
-yarn add react-native-video-trim
+# new arch
+yarn add react-native-video-trim react-native-nitro-modules
+
+# old arch
+yarn add react-native-video-trim@^3.0.0
 ```
+
+> `react-native-nitro-modules` is required in New Arch as this library relies on [Nitro Modules](https://nitro.margelo.com/).
+
 ## For iOS (React Native CLI project)
 Run the following command to setup for iOS:
 ```
@@ -70,62 +105,8 @@ import {
 } from 'react-native';
 import { isValidFile, showEditor } from 'react-native-video-trim';
 import { launchImageLibrary } from 'react-native-image-picker';
-import { useEffect } from 'react';
 
 export default function App() {
-  useEffect(() => {
-    const eventEmitter = new NativeEventEmitter(NativeModules.VideoTrim);
-    const subscription = eventEmitter.addListener('VideoTrim', (event) => {
-      switch (event.name) {
-        case 'onLoad': {
-          // on media loaded successfully
-          console.log('onLoadListener', event);
-          break;
-        }
-        case 'onShow': {
-          console.log('onShowListener', event);
-          break;
-        }
-        case 'onHide': {
-          console.log('onHide', event);
-          break;
-        }
-        case 'onStartTrimming': {
-          console.log('onStartTrimming', event);
-          break;
-        }
-        case 'onFinishTrimming': {
-          console.log('onFinishTrimming', event);
-          break;
-        }
-        case 'onCancelTrimming': {
-          console.log('onCancelTrimming', event);
-          break;
-        }
-        case 'onCancel': {
-          console.log('onCancel', event);
-          break;
-        }
-        case 'onError': {
-          console.log('onError', event);
-          break;
-        }
-        case 'onLog': {
-          console.log('onLog', event);
-          break;
-        }
-        case 'onStatistics': {
-          console.log('onStatistics', event);
-          break;
-        }
-      }
-    });
-
-    return () => {
-      subscription.remove();
-    };
-  }, []);
-
   return (
     <View style={styles.container}>
       <TouchableOpacity
@@ -141,7 +122,11 @@ export default function App() {
 
           showEditor(result.assets![0]?.uri || '', {
             maxDuration: 20,
-          });
+          }, 
+          (eventName, payload) => {
+            console.log('Event:', eventName, 'Payload:', payload);
+          }
+          );
         }}
         style={{ padding: 10, backgroundColor: 'red' }}
       >
@@ -174,7 +159,7 @@ const styles = StyleSheet.create({
 
 # Methods
 
-## showEditor(videoPath: string, config?: EditorConfig)
+## showEditor(videoPath: string, config?: EditorConfig, onEvent?: (eventName: string, payload: Record<string, string>) => void)
 Main method to show Video Editor UI.
 
 *Params*:
@@ -226,7 +211,6 @@ Main method to show Video Editor UI.
   - `alertOnFailTitle` (`default = "Error"`)
   - `alertOnFailMessage` (`default = "Fail to load media. Possibly invalid file or no network connection"`)
   - `alertOnFailCloseText` (`default = "Close"`)
-  - `progressUpdateInterval` (`default = 0.1`): how fast the trimming progress update interval is, default is emit progress every 100ms (0.1 second)
 
 If `saveToPhoto = true`, you must ensure that you have request permission to write to photo/gallery
 - For Android: you need to have `<uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE" />` in AndroidManifest.xml
@@ -274,7 +258,26 @@ Clean all generated output files in app storage. Return number of successfully d
 ## deleteFile()
 Delete a file in app storage. Return `true` if success
 
-# Events
+# Callbacks (New arch)
+
+## showEditor
+
+```ts
+showEditor('file', config, (eventName, payload) => {
+  console.log(eventName, payload)
+})
+```
+
+## closeEditor
+
+```ts
+closeEditor(() => {
+  console.log('Editor closed')
+})
+```
+
+
+# Events (Old arch)
 To listen for events you interest, do the following:
 ```js
 useEffect(() => {

package/VideoTrim.podspec

@@ -0,0 +1,24 @@
+require "json"
+
+package = JSON.parse(File.read(File.join(__dir__, "package.json")))
+
+Pod::Spec.new do |s|
+  s.name         = "VideoTrim"
+  s.version      = package["version"]
+  s.summary      = package["description"]
+  s.homepage     = package["homepage"]
+  s.license      = package["license"]
+  s.authors      = package["author"]
+
+  s.platforms    = { :ios => min_ios_version_supported }
+  s.source       = { :git => "https://github.com/maitrungduc1410/react-native-video-trim.git", :tag => "#{s.version}" }
+
+  s.source_files = "ios/**/*.{h,m,mm,swift}"
+
+  s.dependency 'ffmpeg-mobile-min', '~> 6.0'
+
+  load 'nitrogen/generated/ios/VideoTrim+autolinking.rb'
+  add_nitrogen_files(s)
+
+ install_modules_dependencies(s)
+end

package/android/CMakeLists.txt

@@ -0,0 +1,24 @@
+project(videotrim)
+cmake_minimum_required(VERSION 3.9.0)
+
+set(PACKAGE_NAME videotrim)
+set(CMAKE_VERBOSE_MAKEFILE ON)
+set(CMAKE_CXX_STANDARD 20)
+
+# Define C++ library and add all sources
+add_library(${PACKAGE_NAME} SHARED src/main/cpp/cpp-adapter.cpp)
+
+# Add Nitrogen specs :)
+include(${CMAKE_SOURCE_DIR}/../nitrogen/generated/android/videotrim+autolinking.cmake)
+
+# Set up local includes
+include_directories("src/main/cpp" "../cpp")
+
+find_library(LOG_LIB log)
+
+# Link all libraries together
+target_link_libraries(
+        ${PACKAGE_NAME}
+        ${LOG_LIB}
+        android # <-- Android core
+)

package/android/build.gradle

@@ -1,70 +1,94 @@
 buildscript {
+  ext.getExtOrDefault = {name ->
+    return rootProject.ext.has(name) ? rootProject.ext.get(name) : project.properties['VideoTrim_' + name]
+  }
+
   repositories {
     google()
     mavenCentral()
   }
 
   dependencies {
-    classpath "com.android.tools.build:gradle:7.2.1"
+    classpath "com.android.tools.build:gradle:8.7.2"
+    // noinspection DifferentKotlinGradleVersion
+    classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:${getExtOrDefault('kotlinVersion')}"
   }
 }
 
-def isNewArchitectureEnabled() {
-  return rootProject.hasProperty("newArchEnabled") && rootProject.getProperty("newArchEnabled") == "true"
+def reactNativeArchitectures() {
+  def value = rootProject.getProperties().get("reactNativeArchitectures")
+  return value ? value.split(",") : ["armeabi-v7a", "x86", "x86_64", "arm64-v8a"]
 }
 
 apply plugin: "com.android.library"
+apply plugin: "kotlin-android"
+apply from: '../nitrogen/generated/android/videotrim+autolinking.gradle'
 
-
-def appProject = rootProject.allprojects.find { it.plugins.hasPlugin('com.android.application') }
-
-if (isNewArchitectureEnabled()) {
-  apply plugin: "com.facebook.react"
-}
-
-def getExtOrDefault(name) {
-  return rootProject.ext.has(name) ? rootProject.ext.get(name) : project.properties["VideoTrim_" + name]
-}
+apply plugin: "com.facebook.react"
 
 def getExtOrIntegerDefault(name) {
   return rootProject.ext.has(name) ? rootProject.ext.get(name) : (project.properties["VideoTrim_" + name]).toInteger()
 }
 
-def supportsNamespace() {
-  def parsed = com.android.Version.ANDROID_GRADLE_PLUGIN_VERSION.tokenize('.')
-  def major = parsed[0].toInteger()
-  def minor = parsed[1].toInteger()
-
-  // Namespace support was added in 7.3.0
-  if (major == 7 && minor >= 3) {
-    return true
-  }
+android {
+  namespace "com.margelo.nitro.videotrim"
 
-  return major >= 8
-}
+  compileSdkVersion getExtOrIntegerDefault("compileSdkVersion")
 
-def safeExtGet(String prop, String fallback) {
-  rootProject.ext.has(prop) ? rootProject.ext.get(prop) : fallback
-}
+  defaultConfig {
+    minSdkVersion getExtOrIntegerDefault("minSdkVersion")
+    targetSdkVersion getExtOrIntegerDefault("targetSdkVersion")
 
-android {
-  if (supportsNamespace()) {
-    namespace "com.videotrim"
-  } else {
-    sourceSets {
-      main {
-        manifest.srcFile "src/main/AndroidManifestDeprecated.xml"
+    externalNativeBuild {
+      cmake {
+        cppFlags "-frtti -fexceptions -Wall -fstack-protector-all"
+        arguments "-DANDROID_STL=c++_shared"
+        abiFilters (*reactNativeArchitectures())
+
+        buildTypes {
+          debug {
+            cppFlags "-O1 -g"
+          }
+          release {
+            cppFlags "-O2"
+          }
+        }
       }
     }
   }
 
-  compileSdkVersion getExtOrIntegerDefault("compileSdkVersion")
+  externalNativeBuild {
+    cmake {
+      path "CMakeLists.txt"
+    }
+  }
 
-  defaultConfig {
-    minSdkVersion getExtOrIntegerDefault("minSdkVersion")
-    targetSdkVersion getExtOrIntegerDefault("targetSdkVersion")
-    buildConfigField "boolean", "IS_NEW_ARCHITECTURE_ENABLED", isNewArchitectureEnabled().toString()
+  packagingOptions {
+    excludes = [
+            "META-INF",
+            "META-INF/**",
+            "**/libc++_shared.so",
+            "**/libfbjni.so",
+            "**/libjsi.so",
+            "**/libfolly_json.so",
+            "**/libfolly_runtime.so",
+            "**/libglog.so",
+            "**/libhermes.so",
+            "**/libhermes-executor-debug.so",
+            "**/libhermes_executor.so",
+            "**/libreactnative.so",
+            "**/libreactnativejni.so",
+            "**/libturbomodulejsijni.so",
+            "**/libreact_nativemodule_core.so",
+            "**/libjscexecutor.so"
+    ]
   }
+
+  buildFeatures {
+    buildConfig true
+    prefab true
+  }
+
   buildTypes {
     release {
       minifyEnabled false
@@ -80,6 +104,14 @@ android {
     targetCompatibility JavaVersion.VERSION_1_8
   }
 
+  sourceSets {
+    main {
+      java.srcDirs += [
+        "generated/java",
+        "generated/jni"
+      ]
+    }
+  }
 }
 
 repositories {
@@ -87,19 +119,13 @@ repositories {
   google()
 }
 
+def kotlin_version = getExtOrDefault("kotlinVersion")
 
 dependencies {
-  // For < 0.71, this will be from the local maven repo
-  // For > 0.71, this will be replaced by `com.facebook.react:react-android:$version` by react gradle plugin
-  //noinspection GradleDynamicVersion
-  implementation "com.facebook.react:react-native:+"
-  implementation 'androidx.recyclerview:recyclerview:1.3.1'
-}
+  implementation "com.facebook.react:react-android"
+  implementation "org.jetbrains.kotlin:kotlin-stdlib:$kotlin_version"
+  implementation project(":react-native-nitro-modules")
 
-if (isNewArchitectureEnabled()) {
-  react {
-    jsRootDir = file("../src/")
-    libraryName = "VideoTrim"
-    codegenJavaPackageName = "com.videotrim"
-  }
+  implementation 'io.github.maitrungduc1410:ffmpeg-kit-min:6.0.0'
 }
+

package/android/gradle.properties

@@ -1,5 +1,5 @@
-VideoTrim_kotlinVersion=1.7.0
-VideoTrim_minSdkVersion=21
-VideoTrim_targetSdkVersion=31
-VideoTrim_compileSdkVersion=31
-VideoTrim_ndkversion=21.4.7075529
+VideoTrim_kotlinVersion=2.0.21
+VideoTrim_minSdkVersion=24
+VideoTrim_targetSdkVersion=34
+VideoTrim_compileSdkVersion=35
+VideoTrim_ndkVersion=27.1.12297006

package/android/src/main/AndroidManifest.xml

@@ -1,6 +1,8 @@
-<manifest xmlns:android="http://schemas.android.com/apk/res/android" package="com.videotrim">
+<manifest
+  xmlns:android="http://schemas.android.com/apk/res/android"
+  package="com.margelo.nitro.videotrim">
 
-  <uses-permission android:name="android.permission.VIBRATE" />
+<uses-permission android:name="android.permission.VIBRATE" />
 
   <application>
     <!-- FileProvider setup -->

package/android/src/main/cpp/cpp-adapter.cpp

@@ -0,0 +1,6 @@
+#include <jni.h>
+#include "videotrimOnLoad.hpp"
+
+JNIEXPORT jint JNICALL JNI_OnLoad(JavaVM* vm, void*) {
+  return margelo::nitro::videotrim::initialize(vm);
+}