react-native-video-trim 2.2.8 → 2.2.10

package/README.md

@@ -477,11 +477,18 @@ buildscript {
 ```
 
 # Naming conflict with `ffmpeg-kit-react-native`
-This issue is due to this package and `ffmpeg-kit-react-native` share FFMPEG Kit under the hood. To fix it we need to synchronize the FFMPEG Kit version of the 2 packages.
+This issue is due to this package and `ffmpeg-kit-react-native` have same ffmpegkit class name under the hood:
 
-First find out exactly FFMPEG Kit version that `ffmpeg-kit-react-native` is using. By default (if you don't change), the ffmpeg package is `https` ([check here](https://github.com/arthenica/ffmpeg-kit/blob/main/react-native/ffmpeg-kit-react-native.podspec#L19)) and version is `version` in [package.json](https://github.com/arthenica/ffmpeg-kit/blob/main/react-native/package.json#L3)
+<img src="images/error_conflict_name.png"/>
 
-When you know the package name + version, simply follow the section [Customize FFMPEG version](#customize-ffmpeg-version) in this doc
+To fix it we need to synchronize the FFMPEG Kit version of the 2 packages. For example: as shown in the image above, `ffmpeg-kit-react-native` uses `https`, version `6.0`, hence we need to run this:
+```
+FFMPEGKIT_PACKAGE=https FFMPEG_KIT_PACKAGE_VERSION=6.0 pod install
+```
+
+Another way to find out exactly FFMPEG Kit version that `ffmpeg-kit-react-native` using is to ([check here for package name](https://github.com/arthenica/ffmpeg-kit/blob/main/react-native/ffmpeg-kit-react-native.podspec#L19)) and package version is `version` in [package.json](https://github.com/arthenica/ffmpeg-kit/blob/main/react-native/package.json#L3)
+
+When you know the package name + version, simply run `pod install` with `FFMPEGKIT_PACKAGE` and `FFMPEG_KIT_PACKAGE_VERSION` like above
 
 # Thanks
 - Android part is created by modified + fix bugs from: https://github.com/iknow4/Android-Video-Trimmer

package/android/src/main/java/com/videotrim/widgets/VideoTrimmerView.java

@@ -266,8 +266,6 @@ public class VideoTrimmerView extends FrameLayout implements IVideoTrimmerView {
       VideoTrimmerUtil.MAX_COUNT_RANGE = Math.max((VIDEO_FRAMES_WIDTH / VideoTrimmerUtil.mThumbWidth), VideoTrimmerUtil.MAX_COUNT_RANGE);
 
       startShootVideoThumbs(mContext, VideoTrimmerUtil.MAX_COUNT_RANGE, 0, mDuration);
-    } else {
-
     }
 
     // Set initial handle positions if mMaxDuration < video duration
@@ -348,7 +346,9 @@ public class VideoTrimmerView extends FrameLayout implements IVideoTrimmerView {
 
   public void onMediaPause() {
     mTimingHandler.removeCallbacks(mTimingRunnable);
-    mediaPlayer.pause();
+    if (mediaPlayer.isPlaying()) {
+      mediaPlayer.pause();
+    }
     setPlayPauseViewIcon(false);
   }
 
@@ -640,6 +640,7 @@ public class VideoTrimmerView extends FrameLayout implements IVideoTrimmerView {
 
   private void setHandleTouchListener(View handle, boolean isLeading) {
     handle.setOnTouchListener((view, event) -> {
+      boolean draggingDisabled = mDuration < mMinDuration; // if the video is shorter than the minimum duration, disable dragging
       switch (event.getAction()) {
         case MotionEvent.ACTION_DOWN:
           currentSelectedhandle = handle;
@@ -650,6 +651,10 @@ public class VideoTrimmerView extends FrameLayout implements IVideoTrimmerView {
           playHapticFeedback(true);
           break;
         case MotionEvent.ACTION_MOVE:
+          if (draggingDisabled) {
+            return false;
+          }
+
           boolean didClamp = false;
           float newX = event.getRawX() - ((float) view.getWidth() / 2);
           if (isLeading) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "react-native-video-trim",
-  "version": "2.2.8",
+  "version": "2.2.10",
   "description": "Video trimmer for your React Native app",
   "main": "lib/commonjs/index",
   "module": "lib/module/index",