react-native-video-trim 2.1.0 → 2.2.0

package/README.md

@@ -9,6 +9,12 @@
 ## Features
 - ✅ Support video and audio
 - ✅ Support local and remote files
+- ✅ Save to Photos, Documents and Share to other apps
+- ✅ Check if file is valid video/audio
+- ✅ File operations: list, clean up, delete specific file
+
+<img src="images/document_picker.png" width="300" />
+<img src="images/share_sheet.png" width="300" />
 
 ## Installation
 
@@ -76,6 +82,11 @@ export default function App() {
     const eventEmitter = new NativeEventEmitter(NativeModules.VideoTrim);
     const subscription = eventEmitter.addListener('VideoTrim', (event) => {
       switch (event.name) {
+        case 'onLoad': {
+          // on media loaded successfully
+          console.log('onLoadListener', event);
+          break;
+        }
         case 'onShow': {
           console.log('onShowListener', event);
           break;
@@ -96,10 +107,22 @@ export default function App() {
           console.log('onCancelTrimming', event);
           break;
         }
+        case 'onCancel': {
+          console.log('onCancel', event);
+          break;
+        }
         case 'onError': {
           console.log('onError', event);
           break;
         }
+        case 'onLog': {
+          console.log('onLog', event);
+          break;
+        }
+        case 'onStatistics': {
+          console.log('onStatistics', event);
+          break;
+        }
       }
     });
 
@@ -161,41 +184,83 @@ Main method to show Video Editor UI.
 
 *Params*:
 - `videoPath`: Path to video file, if this is an invalid path, `onError` event will be fired
-- `config` (optional): 
+- `config` (optional, every sub props of `config` is optional): 
   
-  - `type` (optional, `default = video`): which player to use, `video` or `audio`
-  - `outputExt` (optional, `default = mp4`): output file extension
-  - `enableHapticFeedback` (optional, `default = true`): whether to enable haptic feedback
-  - `saveToPhoto` (optional, Video-only, `default = false`): whether to save video to photo/gallery after editing
-  - `openDocumentsOnFinish` (optional, `default = false`): open Document Picker on done trimming
-  - `openShareSheetOnFinish` (optional, `default = false`): open Share Sheet on done trimming
-  - `removeAfterSavedToPhoto` (optional, `default = false`): whether to remove output file from storage after saved to Photo successfully
-  - `removeAfterFailedToSavePhoto` (optional, `default = false`): whether to remove output file if fail to save to Photo
-  - `removeAfterSavedToDocuments` (optional, `default = false`): whether to remove output file from storage after saved Documents successfully
-  - `removeAfterFailedToSaveDocuments` (optional, `default = false`): whether to remove output file from storage after fail to save to Documents
-  - `removeAfterShared` (optional, `default = false`): whether to remove output file from storage after saved Share successfully. iOS only, on Android you'll have to manually remove the file (this is because on Android there's no way to detect when sharing is successful)
-  - `removeAfterFailedToShare` (optional, `default = false`): whether to remove output file from storage after fail to Share. iOS only, on Android you'll have to manually remove the file
+  - `type` (`default = video`): which player to use, `video` or `audio`
+  - `outputExt` (`default = mp4`): output file extension
+  - `enableHapticFeedback` (`default = true`): whether to enable haptic feedback
+  - `saveToPhoto` (Video-only, `default = false`): whether to save video to photo/gallery after editing
+  - `openDocumentsOnFinish` (`default = false`): open Document Picker on done trimming
+  - `openShareSheetOnFinish` (`default = false`): open Share Sheet on done trimming
+  - `removeAfterSavedToPhoto` (`default = false`): whether to remove output file from storage after saved to Photo successfully
+  - `removeAfterFailedToSavePhoto` (`default = false`): whether to remove output file if fail to save to Photo
+  - `removeAfterSavedToDocuments` (`default = false`): whether to remove output file from storage after saved Documents successfully
+  - `removeAfterFailedToSaveDocuments` (`default = false`): whether to remove output file from storage after fail to save to Documents
+  - `removeAfterShared` (`default = false`): whether to remove output file from storage after saved Share successfully. iOS only, on Android you'll have to manually remove the file (this is because on Android there's no way to detect when sharing is successful)
+  - `removeAfterFailedToShare` (`default = false`): whether to remove output file from storage after fail to Share. iOS only, on Android you'll have to manually remove the file
   - `maxDuration` (optional): maximum duration for the trimmed video
-  - `minDuration` (optional): minimum duration for the trimmed video
-  - `cancelButtonText` (optional): text of left button in Editor dialog
-  - `saveButtonText` (optional): text of right button in Editor dialog
-  -  `enableCancelDialog` (optional, `default = true`): whether to show alert dialog on press Cancel
-  -  `cancelDialogTitle` (optional, `default = "Warning!"`)
-  -  `cancelDialogMessage` (optional, `default = "Are you sure want to cancel?"`)
-  -  `cancelDialogCancelText` (optional, `default = "Close"`)
-  -  `cancelDialogConfirmText` (optional, `default = "Proceed"`)
-  -  `enableSaveDialog` (optional, `default = true`): whether to show alert dialog on press Save
-  -  `saveDialogTitle` (optional, `default = "Confirmation!"`)
-  -  `saveDialogMessage` (optional, `default = "Are you sure want to save?"`)
-  -  `saveDialogCancelText` (optional, `default = "Close"`)
-  -  `saveDialogConfirmText` (optional, `default = "Proceed"`)
-  -  `fullScreenModalIOS` (optional, `default = false`): whether to open editor in fullscreen modal
-  -  `trimmingText` (optional, `default = "Trimming video..."`): trimming text on the progress dialog
+  - `minDuration` (`default = 1000`): minimum duration for the trimmed video
+  - `cancelButtonText` (`default= "Cancel"`): text of left button in Editor dialog
+  - `saveButtonText` (`default= "Save"`): text of right button in Editor dialog
+  - `enableCancelDialog` (`default = true`): whether to show alert dialog on press Cancel
+  - `cancelDialogTitle` (`default = "Warning!"`)
+  - `cancelDialogMessage` (`default = "Are you sure want to cancel?"`)
+  - `cancelDialogCancelText` (`default = "Close"`)
+  - `cancelDialogConfirmText` (`default = "Proceed"`)
+  - `enableSaveDialog` (`default = true`): whether to show alert dialog on press Save
+  - `saveDialogTitle` (`default = "Confirmation!"`)
+  - `saveDialogMessage` (`default = "Are you sure want to save?"`)
+  - `saveDialogCancelText` (`default = "Close"`)
+  - `saveDialogConfirmText` (`default = "Proceed"`)
+  - `fullScreenModalIOS` (`default = false`): whether to open editor in fullscreen modal
+  - `trimmingText` (`default = "Trimming video..."`): trimming text on the progress dialog
+  - `autoplay` (`default = false`): whether to autoplay media on load
+  - `jumpToPositionOnLoad` (optional): which time position should jump on media loaded (millisecond)
+  - `closeWhenFinish` (`default = true`): should editor close on finish trimming
+  - `enableCancelTrimming` (`default = true`): enable cancel trimming
+  - `cancelTrimmingButtonText` (`default = "Cancel"`)
+  - `enableCancelTrimmingDialog` (`default = true`)
+  - `cancelTrimmingDialogTitle` (`default = "Warning!"`)
+  - `cancelTrimmingDialogMessage` (`default = "Are you sure want to cancel trimming?"`)
+  - `cancelTrimmingDialogCancelText` (`default = "Close"`)
+  - `cancelTrimmingDialogConfirmText` (`default = "Proceed"`)
+  - `headerText` (optional)
+  - `headerTextSize` (`default = 16`)
+  - `headerTextColor` (`default = white`)
+  - `alertOnFailToLoad` (`default = true`)
+  - `alertOnFailTitle` (`default = "Error"`)
+  - `alertOnFailMessage` (`default = "Fail to load media. Possibly invalid file or no network connection"`)
+  - `alertOnFailCloseText` (`default = "Close"`)
 
 If `saveToPhoto = true`, you must ensure that you have request permission to write to photo/gallery
 - For Android: you need to have `<uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE" />` in AndroidManifest.xml
 - For iOS: you need `NSPhotoLibraryUsageDescription` in Info.plist
 
+If `openShareSheetOnFinish=true`, on Android you'll need to update `AndroidManifest.xml` like below:
+```xml
+</application>
+  ...
+  <provider
+    android:name="androidx.core.content.FileProvider"
+    android:authorities="${applicationId}.provider"
+    android:exported="false"
+    android:grantUriPermissions="true">
+    <meta-data
+      android:name="android.support.FILE_PROVIDER_PATHS"
+      android:resource="@xml/file_paths" />
+  </provider>
+</application>
+```
+
+If you face issue when building Android app related to `file_paths`, then you may need to create `res/xml/file_paths.xml`: with the following content:
+```xml
+<?xml version="1.0" encoding="utf-8"?>
+<paths xmlns:android="http://schemas.android.com/apk/res/android">
+  <files-path name="internal_files" path="." />
+  <external-path name="external_files" path="." />
+</paths>
+```
+
 ## isValidFile(videoPath: string)
 
 This method is to check if a path is a valid video/audio
@@ -220,43 +285,43 @@ useEffect(() => {
   const eventEmitter = new NativeEventEmitter(NativeModules.VideoTrim);
   const subscription = eventEmitter.addListener('VideoTrim', (event) => {
     switch (event.name) {
+      case 'onLoad': {
+        console.log('onLoadListener', event);
+        break;
+      }
       case 'onShow': {
-        // on Dialog show
         console.log('onShowListener', event);
         break;
       }
       case 'onHide': {
-        // on Dialog hide
         console.log('onHide', event);
         break;
       }
       case 'onStartTrimming': {
-        // on start trimming
         console.log('onStartTrimming', event);
         break;
       }
       case 'onFinishTrimming': {
-        // on trimming is done
         console.log('onFinishTrimming', event);
         break;
       }
       case 'onCancelTrimming': {
-        // when user clicks Cancel button
         console.log('onCancelTrimming', event);
         break;
       }
+      case 'onCancel': {
+        console.log('onCancel', event);
+        break;
+      }
       case 'onError': {
-        // any error occured: invalid file, lack of permissions to write to photo/gallery, unexpected error...
         console.log('onError', event);
         break;
       }
       case 'onLog': {
-        // FFMPEG logs (while trimming)
         console.log('onLog', event);
         break;
       }
       case 'onStatistics': {
-        // FFMPEG stats (while trimming)
         console.log('onStatistics', event);
         break;
       }
@@ -268,6 +333,52 @@ useEffect(() => {
   };
 }, []);
 ```
+# Audio support
+<img src="images/audio_android.jpg" width="200" />
+<img src="images/audio_ios.jpg" width="200" />
+
+For audio only you have to pass `type=audio` and `outputExt`:
+```ts
+showEditor(url, {
+  type: 'audio', // important
+  outputExt: 'wav', // important: any audio type for output file extension
+})
+```
+
+You must install FFMPEG version from "https" onwards, "min" version won't work. Eg.
+```gradle
+// Android: android/build.gradle > buildscript > ext
+
+buildscript {
+    ext {
+        ffmpegKitPackage = "full"
+    }
+
+---
+// iOS:
+
+FFMPEGKIT_PACKAGE=https npx pod-install ios
+
+// or
+
+FFMPEGKIT_PACKAGE=https pod install
+```
+
+# Cancel trimming
+<img src="images/progress.jpg" width="200" />
+<img src="images/cancel_confirm.jpg" width="200" />
+
+While trimming, you can press Cancel to terminate the process.
+
+Related props: `enableCancelTrimming, cancelTrimmingButtonText, enableCancelTrimmingDialog, cancelTrimmingDialogTitle, cancelTrimmingDialogMessage, cancelTrimmingDialogCancelText, cancelTrimmingDialogConfirmText`
+
+# Fail to load media
+<img src="images/fail_to_load_media.jpg" width="200" />
+
+If there's error while loading media, there'll be a prompt
+
+Related props: `alertOnFailToLoad, alertOnFailTitle, alertOnFailMessage, alertOnFailCloseText`
+
 # FFMPEG Version
 This library uses FFMPEG-Kit Android under the hood, by default FFMPEG-min is used, which gives smallest bundle size: https://github.com/arthenica/ffmpeg-kit#9-packages
 

package/android/src/main/java/com/videotrim/VideoTrimModule.java

@@ -12,8 +12,10 @@ import android.graphics.Color;
 import android.net.Uri;
 import android.os.Build;
 import android.util.Log;
+import android.util.TypedValue;
 import android.view.Gravity;
 import android.view.ViewGroup;
+import android.widget.Button;
 import android.widget.LinearLayout;
 import android.widget.ProgressBar;
 import android.widget.TextView;
@@ -21,6 +23,7 @@ import android.widget.TextView;
 import androidx.annotation.NonNull;
 import androidx.annotation.Nullable;
 import androidx.appcompat.app.AlertDialog;
+import androidx.core.content.ContextCompat;
 import androidx.core.content.FileProvider;
 
 import com.facebook.react.bridge.ActivityEventListener;
@@ -62,10 +65,17 @@ public class VideoTrimModule extends ReactContextBaseJavaModule implements Video
   private VideoTrimmerView trimmerView;
   private AlertDialog alertDialog;
   private AlertDialog mProgressDialog;
+  private AlertDialog cancelTrimmingConfirmDialog;
   private ProgressBar mProgressBar;
   private int listenerCount = 0;
-
-
+  private boolean enableCancelTrimming = true;
+
+  private String cancelTrimmingButtonText = "Cancel";
+  private boolean enableCancelTrimmingDialog = true;
+  private String cancelTrimmingDialogTitle = "Warning!";
+  private String cancelTrimmingDialogMessage = "Are you sure want to cancel trimming?";
+  private String cancelTrimmingDialogCancelText = "Close";
+  private String cancelTrimmingDialogConfirmText = "Proceed";
   private boolean enableCancelDialog = true;
   private String cancelDialogTitle = "Warning!";
   private String cancelDialogMessage = "Are you sure want to cancel?";
@@ -83,11 +93,12 @@ public class VideoTrimModule extends ReactContextBaseJavaModule implements Video
   private boolean removeAfterFailedToSavePhoto = false;
   private boolean removeAfterSavedToDocuments = false;
   private boolean removeAfterFailedToSaveDocuments = false;
-  private boolean removeAfterShared = false; // TODO: on Android there's no way to know if user shared the file or share sheet closed
-  private boolean removeAfterFailedToShare = false; // TODO: implement this
+  //  private boolean removeAfterShared = false; // TODO: on Android there's no way to know if user shared the file or share sheet closed
+//  private boolean removeAfterFailedToShare = false; // TODO: implement this
   private boolean openDocumentsOnFinish = false;
   private boolean openShareSheetOnFinish = false;
   private boolean isVideoType = true;
+  private boolean closeWhenFinish = true;
 
   private static final int REQUEST_CODE_SAVE_FILE = 1;
 
@@ -128,7 +139,7 @@ public class VideoTrimModule extends ReactContextBaseJavaModule implements Video
               StorageUtil.deleteFile(outputFile);
             }
           } finally {
-            hideDialog();
+            hideDialog(true);
           }
         }
       }
@@ -148,6 +159,14 @@ public class VideoTrimModule extends ReactContextBaseJavaModule implements Video
     if (trimmerView != null || alertDialog != null) {
       return;
     }
+    enableCancelTrimming = !config.hasKey("enableCancelTrimming") || config.getBoolean("enableCancelTrimming");
+
+    cancelTrimmingButtonText = config.hasKey("cancelTrimmingButtonText") ? config.getString("cancelTrimmingButtonText") : "Cancel";
+    enableCancelTrimmingDialog = !config.hasKey("enableCancelTrimmingDialog") || config.getBoolean("enableCancelTrimmingDialog");
+    cancelTrimmingDialogTitle = config.hasKey("cancelTrimmingDialogTitle") ? config.getString("cancelTrimmingDialogTitle") : "Warning!";
+    cancelTrimmingDialogMessage = config.hasKey("cancelTrimmingDialogMessage") ? config.getString("cancelTrimmingDialogMessage") : "Are you sure want to cancel trimming?";
+    cancelTrimmingDialogCancelText = config.hasKey("cancelTrimmingDialogCancelText") ? config.getString("cancelTrimmingDialogCancelText") : "Close";
+    cancelTrimmingDialogConfirmText = config.hasKey("cancelTrimmingDialogConfirmText") ? config.getString("cancelTrimmingDialogConfirmText") : "Proceed";
 
     enableCancelDialog = !config.hasKey("enableCancelDialog") || config.getBoolean("enableCancelDialog");
     cancelDialogTitle = config.hasKey("cancelDialogTitle") ? config.getString("cancelDialogTitle") : "Warning!";
@@ -167,13 +186,14 @@ public class VideoTrimModule extends ReactContextBaseJavaModule implements Video
     removeAfterFailedToSavePhoto = config.hasKey("removeAfterFailedToSavePhoto") && config.getBoolean("removeAfterFailedToSavePhoto");
     removeAfterSavedToDocuments = config.hasKey("removeAfterSavedToDocuments") && config.getBoolean("removeAfterSavedToDocuments");
     removeAfterFailedToSaveDocuments = config.hasKey("removeAfterFailedToSaveDocuments") && config.getBoolean("removeAfterFailedToSaveDocuments");
-    removeAfterShared = config.hasKey("removeAfterShared") && config.getBoolean("removeAfterShared");
-    removeAfterFailedToShare = config.hasKey("removeAfterFailedToShare") && config.getBoolean("removeAfterFailedToShare");
+//    removeAfterShared = config.hasKey("removeAfterShared") && config.getBoolean("removeAfterShared");
+//    removeAfterFailedToShare = config.hasKey("removeAfterFailedToShare") && config.getBoolean("removeAfterFailedToShare");
     openDocumentsOnFinish = config.hasKey("openDocumentsOnFinish") && config.getBoolean("openDocumentsOnFinish");
     openShareSheetOnFinish = config.hasKey("openShareSheetOnFinish") && config.getBoolean("openShareSheetOnFinish");
 
     isVideoType = !config.hasKey("type") || !Objects.equals(config.getString("type"), "audio");
 
+    closeWhenFinish = !config.hasKey("closeWhenFinish") || config.getBoolean("closeWhenFinish");
 
     Activity activity = getReactApplicationContext().getCurrentActivity();
 
@@ -202,7 +222,7 @@ public class VideoTrimModule extends ReactContextBaseJavaModule implements Video
           trimmerView.onDestroy();
           trimmerView = null;
         }
-        hideDialog();
+        hideDialog(true);
         sendEvent(getReactApplicationContext(), "onHide", null);
       });
       sendEvent(getReactApplicationContext(), "onShow", null);
@@ -230,7 +250,14 @@ public class VideoTrimModule extends ReactContextBaseJavaModule implements Video
 
   @Override
   public void onHostDestroy() {
-    hideDialog();
+    hideDialog(true);
+  }
+
+  @Override
+  public void onLoad(int duration) {
+    WritableMap map = Arguments.createMap();
+    map.putInt("duration", duration);
+    sendEvent(getReactApplicationContext(), "onLoad", map);
   }
 
   @Override
@@ -282,16 +309,21 @@ public class VideoTrimModule extends ReactContextBaseJavaModule implements Video
           StorageUtil.deleteFile(in);
         }
       } finally {
-        hideDialog();
+        hideDialog(closeWhenFinish);
       }
     } else if (openDocumentsOnFinish) {
       saveFileToExternalStorage(new File(in));
     } else if (openShareSheetOnFinish) {
-      hideDialog();
+      hideDialog(closeWhenFinish);
       shareFile(getReactApplicationContext(), new File(in));
     }
   }
 
+  @Override
+  public void onCancelTrim() {
+    sendEvent(getReactApplicationContext(), "onCancelTrimming", null);
+  }
+
   @Override
   public void onError(String errorMessage, ErrorCode errorCode) {
     WritableMap map = Arguments.createMap();
@@ -303,8 +335,8 @@ public class VideoTrimModule extends ReactContextBaseJavaModule implements Video
   @Override
   public void onCancel() {
     if (!enableCancelDialog) {
-      sendEvent(getReactApplicationContext(), "onCancelTrimming", null);
-      hideDialog();
+      sendEvent(getReactApplicationContext(), "onCancel", null);
+      hideDialog(true);
       return;
     }
 
@@ -314,8 +346,8 @@ public class VideoTrimModule extends ReactContextBaseJavaModule implements Video
     builder.setCancelable(false);
     builder.setPositiveButton(cancelDialogConfirmText, (dialog, which) -> {
       dialog.cancel();
-      sendEvent(getReactApplicationContext(), "onCancelTrimming", null);
-      hideDialog();
+      sendEvent(getReactApplicationContext(), "onCancel", null);
+      hideDialog(true);
     });
     builder.setNegativeButton(cancelDialogCancelText, (dialog, which) -> {
       dialog.cancel();
@@ -356,18 +388,28 @@ public class VideoTrimModule extends ReactContextBaseJavaModule implements Video
     sendEvent(getReactApplicationContext(), "onStatistics", statistics);
   }
 
-  private void hideDialog() {
+  private void hideDialog(boolean shouldCloseEditor) {
+    // handle the case when the cancel dialog is still showing but the trimming is finished
+    if (cancelTrimmingConfirmDialog != null) {
+      if (cancelTrimmingConfirmDialog.isShowing()) {
+        cancelTrimmingConfirmDialog.dismiss();
+      }
+      cancelTrimmingConfirmDialog = null;
+    }
+
     if (mProgressDialog != null) {
       if (mProgressDialog.isShowing()) mProgressDialog.dismiss();
       mProgressBar = null;
       mProgressDialog = null;
     }
 
-    if (alertDialog != null) {
-      if (alertDialog.isShowing()) {
-        alertDialog.dismiss();
+    if (shouldCloseEditor) {
+      if (alertDialog != null) {
+        if (alertDialog.isShowing()) {
+          alertDialog.dismiss();
+        }
+        alertDialog = null;
       }
-      alertDialog = null;
     }
   }
 
@@ -390,6 +432,7 @@ public class VideoTrimModule extends ReactContextBaseJavaModule implements Video
       ViewGroup.LayoutParams.WRAP_CONTENT
     ));
     textView.setText(trimmingText);
+    textView.setGravity(Gravity.CENTER);
     textView.setTextSize(18);
     layout.addView(textView);
 
@@ -402,6 +445,49 @@ public class VideoTrimModule extends ReactContextBaseJavaModule implements Video
     mProgressBar.setProgressTintList(ColorStateList.valueOf(Color.parseColor("#2196F3")));
     layout.addView(mProgressBar);
 
+    // Create button
+    if (enableCancelTrimming) {
+      Button button = new Button(activity);
+      button.setLayoutParams(new ViewGroup.LayoutParams(
+        ViewGroup.LayoutParams.WRAP_CONTENT,
+        ViewGroup.LayoutParams.WRAP_CONTENT
+      ));
+      // Set the text and style it like a text button
+      button.setText(cancelTrimmingButtonText);
+      button.setTextColor(ContextCompat.getColor(activity, android.R.color.holo_red_light)); // or use your custom color
+
+      // Apply ripple effect while keeping the button background transparent
+      TypedValue outValue = new TypedValue();
+      activity.getTheme().resolveAttribute(android.R.attr.selectableItemBackground, outValue, true);
+      button.setBackgroundResource(outValue.resourceId);
+      button.setOnClickListener(v -> {
+        if (enableCancelTrimmingDialog) {
+          AlertDialog.Builder builder = new AlertDialog.Builder(activity);
+          builder.setMessage(cancelTrimmingDialogMessage);
+          builder.setTitle(cancelTrimmingDialogTitle);
+          builder.setCancelable(false);
+          builder.setPositiveButton(cancelTrimmingDialogConfirmText, (dialog, which) -> {
+            trimmerView.onCancelTrimClicked();
+
+            if (mProgressDialog != null && mProgressDialog.isShowing()) {
+              mProgressDialog.dismiss();
+            }
+          });
+          builder.setNegativeButton(cancelTrimmingDialogCancelText, (dialog, which) -> {
+            dialog.cancel();
+          });
+          cancelTrimmingConfirmDialog = builder.create();
+          cancelTrimmingConfirmDialog.show();
+        } else {
+          trimmerView.onCancelTrimClicked();
+          if (mProgressDialog != null && mProgressDialog.isShowing()) {
+            mProgressDialog.dismiss();
+          }
+        }
+      });
+      layout.addView(button);
+    }
+
     // Create the AlertDialog
     AlertDialog.Builder builder = new AlertDialog.Builder(activity);
     builder.setCancelable(false);
@@ -461,7 +547,7 @@ public class VideoTrimModule extends ReactContextBaseJavaModule implements Video
 
   @ReactMethod
   private void closeEditor() {
-    hideDialog();
+    hideDialog(true);
   }
 
   @ReactMethod

package/android/src/main/java/com/videotrim/enums/ErrorCode.java

@@ -4,8 +4,7 @@ public enum ErrorCode {
   TRIMMING_FAILED,
   FAIL_TO_GET_VIDEO_INFO,
   FAIL_TO_INITIALIZE_AUDIO_PLAYER,
-  FAIL_TO_LOAD_AUDIO,
-  FAIL_TO_LOAD_VIDEO,
+  FAIL_TO_LOAD_MEDIA,
   FAIL_TO_SAVE_TO_PHOTO,
   FAIL_TO_SAVE_TO_DOCUMENTS
 }

package/android/src/main/java/com/videotrim/interfaces/VideoTrimListener.java

@@ -4,9 +4,11 @@ import com.facebook.react.bridge.WritableMap;
 import com.videotrim.enums.ErrorCode;
 
 public interface VideoTrimListener {
+  void onLoad(int duration);
   void onStartTrim();
   void onTrimmingProgress(int percentage);
   void onFinishTrim(String url, long startMs, long endMs, int videoDuration);
+  void onCancelTrim();
   void onError(String errorMessage, ErrorCode errorCode);
   void onCancel();
   void onSave();

package/android/src/main/java/com/videotrim/utils/VideoTrimmerUtil.java

@@ -1,8 +1,10 @@
 package com.videotrim.utils;
 
+import android.annotation.SuppressLint;
 import android.graphics.Bitmap;
 import android.media.MediaMetadataRetriever;
 import com.arthenica.ffmpegkit.FFmpegKit;
+import com.arthenica.ffmpegkit.FFmpegSession;
 import com.arthenica.ffmpegkit.ReturnCode;
 import com.arthenica.ffmpegkit.SessionState;
 import com.facebook.react.bridge.Arguments;
@@ -37,12 +39,12 @@ public class VideoTrimmerUtil {
   public static final int THUMB_HEIGHT = UnitConverter.dpToPx(50); // x2 for better resolution
   private static final int THUMB_RESOLUTION_RES = 2; // double thumb resolution for better quality
 
-  public static void trim(String inputFile, String outputFile, int videoDuration, long startMs, long endMs, final VideoTrimListener callback) {
+  public static FFmpegSession trim(String inputFile, String outputFile, int videoDuration, long startMs, long endMs, final VideoTrimListener callback) {
     // Get the current date and time
     Date currentDate = new Date();
 
     // Create a SimpleDateFormat object with the desired format
-    SimpleDateFormat dateFormat = new SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ss.SSSZ");
+    @SuppressLint("SimpleDateFormat") SimpleDateFormat dateFormat = new SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ss.SSSZ");
 
     // Set the timezone to UTC
     dateFormat.setTimeZone(TimeZone.getTimeZone("UTC"));
@@ -65,18 +67,19 @@ public class VideoTrimmerUtil {
       "creation_time=" + formattedDateTime,
       outputFile
     };
-    System.out.println("Commandddddd: " + String.join(",", cmds));
+    System.out.println("Command: " + String.join(",", cmds));
 
-    FFmpegKit.executeWithArgumentsAsync(cmds, session -> {
+    return FFmpegKit.executeWithArgumentsAsync(cmds, session -> {
       SessionState state = session.getState();
       ReturnCode returnCode = session.getReturnCode();
-
-      if (ReturnCode.isSuccess(returnCode)) {
+      if (ReturnCode.isSuccess(session.getReturnCode())) {
         // SUCCESS
         callback.onFinishTrim(outputFile, startMs, endMs, videoDuration);
-      }
-      else {
-        // CANCEL + FAILURE
+      } else if (ReturnCode.isCancel(session.getReturnCode())) {
+        // CANCEL
+        callback.onCancelTrim();
+      } else {
+        // FAILURE
         String errorMessage = String.format("Command failed with state %s and rc %s.%s", state, returnCode, session.getFailStackTrace());
         callback.onError(errorMessage, ErrorCode.TRIMMING_FAILED);
       }