react-native-video-trim 1.0.9 → 1.0.10

package/README.md

@@ -204,6 +204,18 @@ useEffect(() => {
   };
 }, []);
 ```
+# FFMPEG Version
+This library uses FFMPEG-Kit Android under the hood, by default FFMPEG-min is used, which gives smallest bundle size: https://github.com/arthenica/ffmpeg-kit#9-packages
 
+If you ever need to use other version of FFMPEG-Kit for Android, you can do the following, in your `android/build.gradle` > `buildscript` > `ext`:
+
+```gradle
+buildscript {
+    ext {
+        ffmpegKitPackage = "full" // default "min", if followed by lts then LTS version is use. Eg "full-lts"
+
+        ffmpegKitPackageVersion = "5.1.LTS" // use exact version, highest precedence, default 6.0-2 if ignored
+    }
+```
 # Thanks
 Android part is created by modified + fix bugs from  [original project](Android-Video-Trimmer)

package/ios/VideoTrim.swift

@@ -65,8 +65,13 @@ class VideoTrim: RCTEventEmitter, UIVideoEditorControllerDelegate, UINavigationC
                         root.present(editController, animated: true, completion: {
                             self.emitEventToJS("onShow", eventData: nil)
                             self.isShowing = true
-                                                        
-                            if let topItem = editController.navigationBar.topItem{
+                        })
+                        
+                        // run "during" presenting so that user sees texts update immediately
+                        // putting inside "present" will briefly show old texts then changed to new one, user can clearly see this
+                        // with out DispatchQueue.main.asyncAfter, topItem is still nil
+                        DispatchQueue.main.asyncAfter(deadline: .now() + 0.1) {
+                            if let topItem = editController.navigationBar.topItem {
                                 if let title = config["title"] as? String, !title.isEmpty {
                                     topItem.title = title
                                 }
@@ -82,7 +87,7 @@ class VideoTrim: RCTEventEmitter, UIVideoEditorControllerDelegate, UINavigationC
                                     topItem.rightBarButtonItem = UIBarButtonItem(title: saveBtnText, style: topItem.rightBarButtonItem?.style ?? .plain, target: topItem.rightBarButtonItem?.target, action: topItem.rightBarButtonItem?.action)
                                 }
                             }
-                        })
+                        }
                     }
                 }
             } else {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "react-native-video-trim",
-  "version": "1.0.9",
+  "version": "1.0.10",
   "description": "Video trimmer for your React Native app",
   "main": "lib/commonjs/index",
   "module": "lib/module/index",