react-native-video-trim 1.0.0 → 1.0.2

package/README.md

@@ -1,4 +1,4 @@
-# react-native-video-trim
+# React Native Video Trim
 <div align="center">
 <h2>Video trimmer for your React Native app</h2>
 
@@ -16,13 +16,23 @@ npm install react-native-video-trim
 yarn add react-native-video-trim
 ```
 
+Next for Android, under `android/app/build.gradle`, add `jcenter` to `repositories` this:
+
+```
+repositories {
+    ... other repos if any
+    jcenter()
+}
+```
+
 Next install CocoaPods deps:
 
 ```
-cd ios & pod install
+npx pod-install ios
 ```
 
 ## Usage
+>  Note that for iOS you have to try on real device
 
 ```js
 import { showEditor } from 'react-native-video-trim';

package/android/build.gradle

@@ -91,9 +91,8 @@ dependencies {
   //noinspection GradleDynamicVersion
   implementation "com.facebook.react:react-native:+"
   implementation 'com.github.iknow4:android-utils-sdk:1.1.2'
-  implementation 'nl.bravobit:android-ffmpeg:1.1.7'
-  implementation 'androidx.recyclerview:recyclerview:1.1.0'
-  implementation 'com.guolindev.permissionx:permissionx:1.7.1'
+  implementation 'androidx.recyclerview:recyclerview:1.3.1'
+  implementation 'com.arthenica:ffmpeg-kit-full:5.1.LTS'
 }
 
 if (isNewArchitectureEnabled()) {

package/android/src/main/java/com/videotrim/VideoTrimModule.java

@@ -1,14 +1,23 @@
 package com.videotrim;
 
 import static com.facebook.react.bridge.UiThreadUtil.runOnUiThread;
+
 import android.app.Activity;
-import android.app.ProgressDialog;
+import android.content.res.ColorStateList;
+import android.graphics.Color;
 import android.media.MediaMetadataRetriever;
 import android.net.Uri;
+import android.os.Build;
+import android.view.Gravity;
+import android.view.ViewGroup;
+import android.widget.LinearLayout;
+import android.widget.ProgressBar;
+import android.widget.TextView;
 
 import androidx.annotation.NonNull;
 import androidx.annotation.Nullable;
 import androidx.appcompat.app.AlertDialog;
+
 import com.facebook.react.bridge.Arguments;
 import com.facebook.react.bridge.LifecycleEventListener;
 import com.facebook.react.bridge.Promise;
@@ -23,9 +32,9 @@ import com.facebook.react.modules.core.DeviceEventManagerModule;
 import com.videotrim.interfaces.VideoTrimListener;
 import com.videotrim.utils.StorageUtil;
 import com.videotrim.widgets.VideoTrimmerView;
+
 import java.io.IOException;
 import iknow.android.utils.BaseUtils;
-import nl.bravobit.ffmpeg.FFmpeg;
 
 @ReactModule(name = VideoTrimModule.NAME)
 public class VideoTrimModule extends ReactContextBaseJavaModule implements VideoTrimListener, LifecycleEventListener {
@@ -33,11 +42,14 @@ public class VideoTrimModule extends ReactContextBaseJavaModule implements Video
   private static Boolean isInit = false;
   private VideoTrimmerView trimmerView;
   private AlertDialog alertDialog;
-  private ProgressDialog mProgressDialog;
+  private AlertDialog mProgressDialog;
+  private ProgressBar mProgressBar;
   private Boolean mSaveToPhoto = true;
   private int mMaxDuration = 0;
   private int listenerCount = 0;
 
+  private Promise showEditorPromise;
+
   public VideoTrimModule(ReactApplicationContext reactContext) {
     super(reactContext);
   }
@@ -50,7 +62,8 @@ public class VideoTrimModule extends ReactContextBaseJavaModule implements Video
 
 
   @ReactMethod
-  public void showEditor(String videoPath, ReadableMap config) {
+  public void showEditor(String videoPath, ReadableMap config, Promise promise) {
+    showEditorPromise = promise;
     if (trimmerView != null || alertDialog != null) {
       return;
     }
@@ -107,12 +120,6 @@ public class VideoTrimModule extends ReactContextBaseJavaModule implements Video
     isInit = true;
     // we have to init this before create videoTrimmerView
     BaseUtils.init(getReactApplicationContext());
-    if (!FFmpeg.getInstance(getReactApplicationContext()).isSupported()) {
-      // we have to call this for FFMPEG to initialize, otherwise it'll throw can't open ffmpeg (no such file or dir)
-      WritableMap mapE = Arguments.createMap();
-      mapE.putString("message", "Android CPU arch not supported");
-      sendEvent(getReactApplicationContext(), "onError", mapE);
-    }
   }
 
   @Override
@@ -136,25 +143,36 @@ public class VideoTrimModule extends ReactContextBaseJavaModule implements Video
   @Override public void onStartTrim() {
     sendEvent(getReactApplicationContext(), "onStartTrimming", null);
     runOnUiThread(() -> {
-      buildDialog(getReactApplicationContext().getResources().getString(R.string.trimming)).show();
+      buildDialog();
     });
   }
 
+  @Override public void onTrimmingProgress(int percentage) {
+    if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.N) {
+      mProgressBar.setProgress(percentage, true);
+    } else {
+      mProgressBar.setProgress(percentage);
+    }
+  }
+
+
   @Override public void onFinishTrim(String in) {
-    if (mProgressDialog.isShowing()) mProgressDialog.dismiss();
-    WritableMap map = Arguments.createMap();
-    map.putString("outputPath", in);
-    sendEvent(getReactApplicationContext(), "onFinishTrimming", map);
-    if (mSaveToPhoto) {
-      try {
-        StorageUtil.saveVideoToGallery(getReactApplicationContext(), in);
-      } catch (IOException e) {
-        e.printStackTrace();
-        WritableMap mapE = Arguments.createMap();
-        mapE.putString("message", "Fail to save to Gallery. Please check if you have correct permission");
-        sendEvent(getReactApplicationContext(), "onError", mapE);
+    runOnUiThread(() -> {
+      WritableMap map = Arguments.createMap();
+      map.putString("outputPath", in);
+      sendEvent(getReactApplicationContext(), "onFinishTrimming", map);
+      if (mSaveToPhoto) {
+        showEditorPromise.resolve(in);
+      } else {
+        hideDialog();
       }
-    }
+    });
+  }
+
+  @Override public void onError() {
+    WritableMap map = Arguments.createMap();
+    map.putString("message", "Error when trimming, please try again");
+    sendEvent(getReactApplicationContext(), "onError", map);
     this.hideDialog();
   }
 
@@ -163,7 +181,14 @@ public class VideoTrimModule extends ReactContextBaseJavaModule implements Video
     this.hideDialog();
   }
 
+  @ReactMethod
   private void hideDialog() {
+    if (mProgressDialog != null) {
+      if (mProgressDialog.isShowing()) mProgressDialog.dismiss();
+      mProgressBar = null;
+      mProgressDialog = null;
+    }
+
     if (alertDialog != null) {
       if(alertDialog.isShowing()) {
         alertDialog.dismiss();
@@ -172,12 +197,45 @@ public class VideoTrimModule extends ReactContextBaseJavaModule implements Video
     }
   }
 
-  private ProgressDialog buildDialog(String msg) {
-    if (mProgressDialog == null) {
-      mProgressDialog = ProgressDialog.show(getReactApplicationContext().getCurrentActivity(), "", msg);
-    }
-    mProgressDialog.setMessage(msg);
-    return mProgressDialog;
+  private void buildDialog() {
+    Activity activity =  getReactApplicationContext().getCurrentActivity();
+    // Create the parent layout for the dialog
+    LinearLayout layout = new LinearLayout(activity);
+    layout.setLayoutParams(new ViewGroup.LayoutParams(
+      ViewGroup.LayoutParams.WRAP_CONTENT,
+      ViewGroup.LayoutParams.WRAP_CONTENT
+    ));
+    layout.setOrientation(LinearLayout.VERTICAL);
+    layout.setGravity(Gravity.CENTER_HORIZONTAL);
+    layout.setPadding(16, 32, 16, 32);
+
+    // Create and add the TextView
+    TextView textView = new TextView(activity);
+    textView.setLayoutParams(new ViewGroup.LayoutParams(
+      ViewGroup.LayoutParams.WRAP_CONTENT,
+      ViewGroup.LayoutParams.WRAP_CONTENT
+    ));
+    textView.setText(getReactApplicationContext().getResources().getString(R.string.trimming));
+    textView.setTextSize(18);
+    layout.addView(textView);
+
+    // Create and add the ProgressBar
+    mProgressBar = new ProgressBar(activity, null, android.R.attr.progressBarStyleHorizontal);
+    mProgressBar.setLayoutParams(new ViewGroup.LayoutParams(
+      ViewGroup.LayoutParams.MATCH_PARENT,
+      ViewGroup.LayoutParams.WRAP_CONTENT
+    ));
+    mProgressBar.setProgressTintList(ColorStateList.valueOf(Color.parseColor("#2196F3")));
+    layout.addView(mProgressBar);
+
+    // Create the AlertDialog
+    AlertDialog.Builder builder = new AlertDialog.Builder(activity);
+    builder.setCancelable(false);
+    builder.setView(layout);
+
+    // Show the dialog
+    mProgressDialog = builder.create();
+    mProgressDialog.show();
   }
 
   @ReactMethod
@@ -202,6 +260,7 @@ public class VideoTrimModule extends ReactContextBaseJavaModule implements Video
     }
   }
 
+
   public boolean _isValidVideo(String filePath) {
     MediaMetadataRetriever retriever = new MediaMetadataRetriever();
 
@@ -220,4 +279,19 @@ public class VideoTrimModule extends ReactContextBaseJavaModule implements Video
   private void isValidVideo(String filePath, Promise promise) {
     promise.resolve(_isValidVideo(filePath));
   }
+
+  @ReactMethod
+  private void saveVideo(String filePath, Promise promise) {
+    try {
+      StorageUtil.saveVideoToGallery(getReactApplicationContext(), filePath);
+    } catch (IOException e) {
+      e.printStackTrace();
+      WritableMap mapE = Arguments.createMap();
+      mapE.putString("message", "Fail while copying file to Gallery");
+      sendEvent(getReactApplicationContext(), "onError", mapE);
+    }
+
+    this.hideDialog();
+    promise.resolve(null);
+  }
 }

package/android/src/main/java/com/videotrim/adapters/VideoTrimmerAdapter.java

@@ -1,6 +1,5 @@
 package com.videotrim.adapters;
 
-
 import android.content.Context;
 import android.graphics.Bitmap;
 import android.view.LayoutInflater;
@@ -8,23 +7,18 @@ import android.view.View;
 import android.view.ViewGroup;
 import android.widget.ImageView;
 import android.widget.LinearLayout;
-
 import androidx.annotation.NonNull;
 import androidx.recyclerview.widget.RecyclerView;
-
 import com.videotrim.R;
 import com.videotrim.utils.VideoTrimmerUtil;
-
 import java.util.ArrayList;
 import java.util.List;
 
 public class VideoTrimmerAdapter extends RecyclerView.Adapter {
-  private List<Bitmap> mBitmaps = new ArrayList<>();
-  private LayoutInflater mInflater;
-  private Context context;
+  private final List<Bitmap> mBitmaps = new ArrayList<>();
+  private final LayoutInflater mInflater;
 
   public VideoTrimmerAdapter(Context context) {
-    this.context = context;
     this.mInflater = LayoutInflater.from(context);
   }
 
@@ -42,10 +36,10 @@ public class VideoTrimmerAdapter extends RecyclerView.Adapter {
 
   public void addBitmaps(Bitmap bitmap) {
     mBitmaps.add(bitmap);
-    notifyDataSetChanged();
+    notifyItemInserted(mBitmaps.size() - 1);
   }
 
-  private final class TrimmerViewHolder extends RecyclerView.ViewHolder {
+  private static final class TrimmerViewHolder extends RecyclerView.ViewHolder {
     ImageView thumbImageView;
 
     TrimmerViewHolder(View itemView) {

package/android/src/main/java/com/videotrim/interfaces/VideoTrimListener.java

@@ -2,6 +2,8 @@ package com.videotrim.interfaces;
 
 public interface VideoTrimListener {
   void onStartTrim();
+  void onTrimmingProgress(int percentage);
   void onFinishTrim(String url);
+  void onError();
   void onCancel();
 }

package/android/src/main/java/com/videotrim/utils/StorageUtil.java

@@ -1,6 +1,5 @@
 package com.videotrim.utils;
 
-import android.Manifest;
 import android.annotation.SuppressLint;
 import android.content.ContentValues;
 import android.content.Context;
@@ -11,12 +10,7 @@ import android.os.Environment;
 import android.provider.MediaStore;
 import android.text.TextUtils;
 import android.util.Log;
-
-import androidx.fragment.app.FragmentActivity;
-
 import com.facebook.react.bridge.ReactApplicationContext;
-import com.permissionx.guolindev.PermissionX;
-
 import java.io.File;
 import java.io.FileInputStream;
 import java.io.FileOutputStream;
@@ -202,27 +196,19 @@ public class StorageUtil {
   }
 
   public static void saveVideoToGallery(ReactApplicationContext context, String videoFilePath) throws IOException {
-    PermissionX.init((FragmentActivity) context.getCurrentActivity())
-      .permissions(Manifest.permission.WRITE_EXTERNAL_STORAGE)
-      .request((allGranted, grantedList, deniedList) -> {
-        if (allGranted) {
-          File videoFile = new File(videoFilePath);
+    File videoFile = new File(videoFilePath);
 
-          if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.Q) {
-            // For Android 10 and higher (API >= 29)
-            saveVideoUsingMediaStore(context, videoFile);
-          } else {
-            // For Android 9 and below (API < 29)
-            try {
-              saveVideoUsingTraditionalStorage(context, videoFile);
-            } catch (IOException e) {
-              throw new RuntimeException(e);
-            }
-          }
-        } else {
-          throw new RuntimeException();
-        }
-      });
+    if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.Q) {
+      // For Android 10 and higher (API >= 29)
+      saveVideoUsingMediaStore(context, videoFile);
+    } else {
+      // For Android 9 and below (API < 29)
+      try {
+        saveVideoUsingTraditionalStorage(context, videoFile);
+      } catch (IOException e) {
+        throw new RuntimeException(e);
+      }
+    }
   }
 
   // Save video using MediaStore for API level >= 29

package/android/src/main/java/com/videotrim/utils/VideoTrimmerUtil.java

@@ -4,7 +4,16 @@ import android.content.Context;
 import android.graphics.Bitmap;
 import android.media.MediaMetadataRetriever;
 import android.net.Uri;
+import android.util.Log;
 
+import com.arthenica.ffmpegkit.FFmpegKit;
+import com.arthenica.ffmpegkit.FFmpegSession;
+import com.arthenica.ffmpegkit.FFmpegSessionCompleteCallback;
+import com.arthenica.ffmpegkit.LogCallback;
+import com.arthenica.ffmpegkit.ReturnCode;
+import com.arthenica.ffmpegkit.SessionState;
+import com.arthenica.ffmpegkit.Statistics;
+import com.arthenica.ffmpegkit.StatisticsCallback;
 import com.videotrim.interfaces.VideoTrimListener;
 
 import java.text.SimpleDateFormat;
@@ -15,8 +24,6 @@ import iknow.android.utils.DeviceUtil;
 import iknow.android.utils.UnitConverter;
 import iknow.android.utils.callback.SingleCallback;
 import iknow.android.utils.thread.BackgroundExecutor;
-import nl.bravobit.ffmpeg.ExecuteBinaryResponseHandler;
-import nl.bravobit.ffmpeg.FFmpeg;
 
 public class VideoTrimmerUtil {
 
@@ -25,37 +32,46 @@ public class VideoTrimmerUtil {
 //  public static final int VIDEO_MAX_TIME = 10;// max 10 seconds for trimming
 //  public static final long MAX_SHOOT_DURATION = VIDEO_MAX_TIME * 1000L;
   public static long maxShootDuration = 10 * 1000L;
-  public static final int MAX_COUNT_RANGE = 10;  // how many images in the highlight range of seek bar
-  public static final int SCREEN_WIDTH_FULL = DeviceUtil.getDeviceWidth();
+  public static int MAX_COUNT_RANGE = 10;  // how many images in the highlight range of seek bar
+  public static int SCREEN_WIDTH_FULL = DeviceUtil.getDeviceWidth();
   public static final int RECYCLER_VIEW_PADDING = UnitConverter.dpToPx(35);
-  public static final int VIDEO_FRAMES_WIDTH = SCREEN_WIDTH_FULL - RECYCLER_VIEW_PADDING * 2;
+  public static int VIDEO_FRAMES_WIDTH = SCREEN_WIDTH_FULL - RECYCLER_VIEW_PADDING * 2;
 //  public static final int THUMB_WIDTH = (SCREEN_WIDTH_FULL - RECYCLER_VIEW_PADDING * 2) / VIDEO_MAX_TIME;
   public static int mThumbWidth = 0; // make it automatic
   public static final int THUMB_HEIGHT = UnitConverter.dpToPx(50); // x2 for better resolution
   private static final int THUMB_RESOLUTION_RES = 2; // double thumb resolution for better quality
 
-  public static void trim(Context context, String inputFile, String outputFile, long startMs, long endMs, final VideoTrimListener callback) {
+  public static void trim(Context context, String inputFile, String outputFile, int videoDuration, long startMs, long endMs, final VideoTrimListener callback) {
     final String timeStamp = new SimpleDateFormat("yyyyMMdd_HHmmss", Locale.getDefault()).format(new Date());
     final String outputName = "trimmedVideo_" + timeStamp + ".mp4";
     outputFile = outputFile + "/" + outputName;
 
     String cmd = "-i " + inputFile + " -ss " + startMs + "ms" + " -to " + endMs + "ms -c copy " + outputFile;
     String[] command = cmd.split(" ");
-    try {
-      final String tempOutFile = outputFile;
-      FFmpeg.getInstance(context).execute(command, new ExecuteBinaryResponseHandler() {
+    final String tempOutFile = outputFile;
 
-        @Override public void onSuccess(String s) {
-          callback.onFinishTrim(tempOutFile);
-        }
+    callback.onStartTrim();
+    FFmpegKit.executeAsync(cmd, session -> {
+      SessionState state = session.getState();
+      ReturnCode returnCode = session.getReturnCode();
 
-        @Override public void onStart() {
-          callback.onStartTrim();
-        }
-      });
-    } catch (Exception e) {
-      e.printStackTrace();
-    }
+      Log.d(TAG, String.format("FFmpeg process exited with state %s and rc %s.%s", state, returnCode, session.getFailStackTrace()));
+
+      if (state.equals(SessionState.COMPLETED)) {
+        callback.onFinishTrim(tempOutFile);
+      } else {
+        callback.onError();
+      }
+    }, log -> {
+
+    }, statistics -> {
+      int timeInMilliseconds = statistics.getTime();
+      if (timeInMilliseconds > 0) {
+        int completePercentage =
+          (timeInMilliseconds * 100) / videoDuration;
+        callback.onTrimmingProgress(Math.min(Math.max(completePercentage, 0), 100));
+      }
+    });
   }
 
   public static void shootVideoThumbInBackground(final Context context, final Uri videoUri, final int totalThumbsCount, final long startPosition,
@@ -72,10 +88,6 @@ public class VideoTrimmerUtil {
             Bitmap bitmap = mediaMetadataRetriever.getFrameAtTime(frameTime * 1000, MediaMetadataRetriever.OPTION_CLOSEST_SYNC);
             if(bitmap == null) continue;
             try {
-              if (mThumbWidth <= 0) { // only take first item
-                int width = THUMB_HEIGHT * bitmap.getWidth() / bitmap.getHeight();
-                mThumbWidth = width;
-              }
               bitmap = Bitmap.createScaledBitmap(bitmap, mThumbWidth * THUMB_RESOLUTION_RES, THUMB_HEIGHT * THUMB_RESOLUTION_RES, false);
             } catch (final Throwable t) {
               t.printStackTrace();

package/android/src/main/java/com/videotrim/widgets/VideoTrimmerView.java

@@ -1,11 +1,14 @@
 package com.videotrim.widgets;
 
-import static com.videotrim.utils.VideoTrimmerUtil.MAX_COUNT_RANGE;
 import static com.videotrim.utils.VideoTrimmerUtil.RECYCLER_VIEW_PADDING;
 import static com.videotrim.utils.VideoTrimmerUtil.VIDEO_FRAMES_WIDTH;
 
 import android.animation.ValueAnimator;
 import android.content.Context;
+import android.content.pm.ActivityInfo;
+import android.content.res.Configuration;
+import android.graphics.Bitmap;
+import android.media.MediaMetadataRetriever;
 import android.media.MediaPlayer;
 import android.net.Uri;
 import android.os.Handler;
@@ -33,6 +36,7 @@ import com.videotrim.interfaces.VideoTrimListener;
 import com.videotrim.utils.StorageUtil;
 import com.videotrim.utils.VideoTrimmerUtil;
 
+import iknow.android.utils.DeviceUtil;
 import iknow.android.utils.thread.BackgroundExecutor;
 import iknow.android.utils.thread.UiThreadExecutor;
 
@@ -76,6 +80,7 @@ public class VideoTrimmerView extends FrameLayout implements IVideoTrimmerView {
   private Boolean mIsPrepared = false;
   private int mMaxDuration = 0;
 
+
   public VideoTrimmerView(ReactApplicationContext context, AttributeSet attrs) {
     this(context, attrs, 0);
   }
@@ -91,6 +96,9 @@ public class VideoTrimmerView extends FrameLayout implements IVideoTrimmerView {
 
   private void init(ReactApplicationContext context) {
     this.mContext = context;
+
+    // listen to onConfigurationChanged doesn't work for this, it runs too soon
+    context.getCurrentActivity().setRequestedOrientation(ActivityInfo.SCREEN_ORIENTATION_PORTRAIT);
     LayoutInflater.from(context).inflate(R.layout.video_trimmer_view, this, true);
 
     mLinearVideo = findViewById(R.id.layout_surface_view);
@@ -110,13 +118,19 @@ public class VideoTrimmerView extends FrameLayout implements IVideoTrimmerView {
   private void initRangeSeekBarView() {
     if(mRangeSeekBarView != null) return;
     mLeftProgressPos = 0;
+
+    VideoTrimmerUtil.SCREEN_WIDTH_FULL = this.getScreenWidthInPortraitMode();
+    VideoTrimmerUtil.VIDEO_FRAMES_WIDTH = VideoTrimmerUtil.SCREEN_WIDTH_FULL - RECYCLER_VIEW_PADDING * 2;
+    VideoTrimmerUtil.MAX_COUNT_RANGE = Math.max(((int) VIDEO_FRAMES_WIDTH / VideoTrimmerUtil.mThumbWidth),  VideoTrimmerUtil.MAX_COUNT_RANGE);
+
     if (mDuration <= VideoTrimmerUtil.maxShootDuration) {
-      mThumbsTotalCount = MAX_COUNT_RANGE;
+      mThumbsTotalCount = VideoTrimmerUtil.MAX_COUNT_RANGE;
       mRightProgressPos = mDuration;
     } else {
-      mThumbsTotalCount = (int) (mDuration * 1.0f / (VideoTrimmerUtil.maxShootDuration * 1.0f) * MAX_COUNT_RANGE);
+      mThumbsTotalCount = (int) (mDuration * 1.0f / (VideoTrimmerUtil.maxShootDuration * 1.0f) * VideoTrimmerUtil.MAX_COUNT_RANGE);
       mRightProgressPos = VideoTrimmerUtil.maxShootDuration;
     }
+
     mVideoThumbRecyclerView.addItemDecoration(new SpacesItemDecoration2(RECYCLER_VIEW_PADDING, mThumbsTotalCount));
     mRangeSeekBarView = new RangeSeekBarView(mContext, mLeftProgressPos, mRightProgressPos);
     mRangeSeekBarView.setSelectedMinValue(mLeftProgressPos);
@@ -126,8 +140,8 @@ public class VideoTrimmerView extends FrameLayout implements IVideoTrimmerView {
     mRangeSeekBarView.setNotifyWhileDragging(true);
     mRangeSeekBarView.setOnRangeSeekBarChangeListener(mOnRangeSeekBarChangeListener);
     mSeekBarLayout.addView(mRangeSeekBarView);
-    if(mThumbsTotalCount - MAX_COUNT_RANGE > 0) {
-      mAverageMsPx = (mDuration - VideoTrimmerUtil.maxShootDuration) / (float) (mThumbsTotalCount - MAX_COUNT_RANGE);
+    if(mThumbsTotalCount - VideoTrimmerUtil.MAX_COUNT_RANGE > 0) {
+      mAverageMsPx = (mDuration - VideoTrimmerUtil.maxShootDuration) / (float) (mThumbsTotalCount - VideoTrimmerUtil.MAX_COUNT_RANGE);
     } else {
       mAverageMsPx = 0f;
     }
@@ -174,6 +188,14 @@ public class VideoTrimmerView extends FrameLayout implements IVideoTrimmerView {
     mDuration = mVideoView.getDuration();
 
     VideoTrimmerUtil.maxShootDuration = mMaxDuration > 0 ? Math.min(mMaxDuration * 1000L, mDuration) : mDuration;
+
+    MediaMetadataRetriever mediaMetadataRetriever = new MediaMetadataRetriever();
+    mediaMetadataRetriever.setDataSource(mContext, mSourceUri);
+    // take first frame
+    Bitmap bitmap = mediaMetadataRetriever.getFrameAtTime(0, MediaMetadataRetriever.OPTION_CLOSEST_SYNC);
+    int width = VideoTrimmerUtil.THUMB_HEIGHT * bitmap.getWidth() / bitmap.getHeight();
+    VideoTrimmerUtil.mThumbWidth = width;
+
     if (!getRestoreState()) {
       seekTo((int) mRedProgressBarPos);
     } else {
@@ -277,6 +299,7 @@ public class VideoTrimmerView extends FrameLayout implements IVideoTrimmerView {
       VideoTrimmerUtil.trim(mContext,
         mSourceUri.getPath(),
         StorageUtil.getCacheDir(),
+        mDuration,
         mLeftProgressPos,
         mRightProgressPos,
         mOnTrimVideoListener);
@@ -433,11 +456,33 @@ public class VideoTrimmerView extends FrameLayout implements IVideoTrimmerView {
     }
   }
 
+  @Override
+  protected void onDetachedFromWindow() {
+    super.onDetachedFromWindow();
+    mContext.getCurrentActivity().setRequestedOrientation(ActivityInfo.SCREEN_ORIENTATION_UNSPECIFIED);
+  }
+
   /**
-   * Cancel trim thread execut action when finish
+   * Cancel trim thread execute action when finish
    */
   @Override public void onDestroy() {
     BackgroundExecutor.cancelAll("", true);
     UiThreadExecutor.cancelAll("");
+    mContext.getCurrentActivity().setRequestedOrientation(ActivityInfo.SCREEN_ORIENTATION_UNSPECIFIED);
+  }
+
+  private int getScreenWidthInPortraitMode() {
+    int screenWidth = DeviceUtil.getDeviceWidth();
+    int screenHeight = DeviceUtil.getDeviceHeight();
+
+    // Check the current orientation
+    int currentOrientation = getResources().getConfiguration().orientation;
+
+    // Swap width and height if the current orientation is landscape
+    if (currentOrientation == Configuration.ORIENTATION_LANDSCAPE) {
+      return screenHeight;
+    }
+
+    return screenWidth;
   }
 }

package/lib/commonjs/index.js

@@ -15,16 +15,35 @@ const VideoTrim = _reactNative.NativeModules.VideoTrim ? _reactNative.NativeModu
     throw new Error(LINKING_ERROR);
   }
 });
-function showEditor(videoPath) {
+async function showEditor(videoPath) {
   let config = arguments.length > 1 && arguments[1] !== undefined ? arguments[1] : {};
   const {
     maxDuration,
     saveToPhoto = true
   } = config;
-  VideoTrim.showEditor(videoPath, {
+  const outputPath = await VideoTrim.showEditor(videoPath, {
     saveToPhoto,
     maxDuration
   });
+  if (_reactNative.Platform.OS === 'android' && saveToPhoto) {
+    try {
+      const granted = await _reactNative.PermissionsAndroid.request(_reactNative.PermissionsAndroid.PERMISSIONS.WRITE_EXTERNAL_STORAGE, {
+        title: 'Video Trimmer Camera Access Required',
+        message: 'Grant access to your Camera to write output Video',
+        buttonNeutral: 'Ask Me Later',
+        buttonNegative: 'Cancel',
+        buttonPositive: 'OK'
+      });
+      if (granted === _reactNative.PermissionsAndroid.RESULTS.GRANTED) {
+        await VideoTrim.saveVideo(outputPath);
+      } else {
+        VideoTrim.hideDialog();
+        throw new Error('Camera permission denied');
+      }
+    } catch (err) {
+      throw err;
+    }
+  }
 }
 function isValidVideo(videoPath) {
   return VideoTrim.isValidVideo(videoPath);

package/lib/commonjs/index.js.map

@@ -1 +1 @@
-{"version":3,"names":["_reactNative","require","LINKING_ERROR","Platform","select","ios","default","VideoTrim","NativeModules","Proxy","get","Error","showEditor","videoPath","config","arguments","length","undefined","maxDuration","saveToPhoto","isValidVideo"],"sourceRoot":"../../src","sources":["index.tsx"],"mappings":";;;;;;;AAAA,IAAAA,YAAA,GAAAC,OAAA;AAEA,MAAMC,aAAa,GAChB,kFAAiF,GAClFC,qBAAQ,CAACC,MAAM,CAAC;EAAEC,GAAG,EAAE,gCAAgC;EAAEC,OAAO,EAAE;AAAG,CAAC,CAAC,GACvE,sDAAsD,GACtD,+BAA+B;AAEjC,MAAMC,SAAS,GAAGC,0BAAa,CAACD,SAAS,GACrCC,0BAAa,CAACD,SAAS,GACvB,IAAIE,KAAK,CACP,CAAC,CAAC,EACF;EACEC,GAAGA,CAAA,EAAG;IACJ,MAAM,IAAIC,KAAK,CAACT,aAAa,CAAC;EAChC;AACF,CACF,CAAC;AAOE,SAASU,UAAUA,CAACC,SAAiB,EAAmC;EAAA,IAAjCC,MAAoB,GAAAC,SAAA,CAAAC,MAAA,QAAAD,SAAA,QAAAE,SAAA,GAAAF,SAAA,MAAG,CAAC,CAAC;EACrE,MAAM;IAAEG,WAAW;IAAEC,WAAW,GAAG;EAAK,CAAC,GAAGL,MAAM;EAClDP,SAAS,CAACK,UAAU,CAACC,SAAS,EAAE;IAC9BM,WAAW;IACXD;EACF,CAAC,CAAC;AACJ;AAEO,SAASE,YAAYA,CAACP,SAAiB,EAAoB;EAChE,OAAON,SAAS,CAACa,YAAY,CAACP,SAAS,CAAC;AAC1C"}
+{"version":3,"names":["_reactNative","require","LINKING_ERROR","Platform","select","ios","default","VideoTrim","NativeModules","Proxy","get","Error","showEditor","videoPath","config","arguments","length","undefined","maxDuration","saveToPhoto","outputPath","OS","granted","PermissionsAndroid","request","PERMISSIONS","WRITE_EXTERNAL_STORAGE","title","message","buttonNeutral","buttonNegative","buttonPositive","RESULTS","GRANTED","saveVideo","hideDialog","err","isValidVideo"],"sourceRoot":"../../src","sources":["index.tsx"],"mappings":";;;;;;;AAAA,IAAAA,YAAA,GAAAC,OAAA;AAEA,MAAMC,aAAa,GAChB,kFAAiF,GAClFC,qBAAQ,CAACC,MAAM,CAAC;EAAEC,GAAG,EAAE,gCAAgC;EAAEC,OAAO,EAAE;AAAG,CAAC,CAAC,GACvE,sDAAsD,GACtD,+BAA+B;AAEjC,MAAMC,SAAS,GAAGC,0BAAa,CAACD,SAAS,GACrCC,0BAAa,CAACD,SAAS,GACvB,IAAIE,KAAK,CACP,CAAC,CAAC,EACF;EACEC,GAAGA,CAAA,EAAG;IACJ,MAAM,IAAIC,KAAK,CAACT,aAAa,CAAC;EAChC;AACF,CACF,CAAC;AAOE,eAAeU,UAAUA,CAC9BC,SAAiB,EAEF;EAAA,IADfC,MAAoB,GAAAC,SAAA,CAAAC,MAAA,QAAAD,SAAA,QAAAE,SAAA,GAAAF,SAAA,MAAG,CAAC,CAAC;EAEzB,MAAM;IAAEG,WAAW;IAAEC,WAAW,GAAG;EAAK,CAAC,GAAGL,MAAM;EAClD,MAAMM,UAAU,GAAG,MAAMb,SAAS,CAACK,UAAU,CAACC,SAAS,EAAE;IACvDM,WAAW;IACXD;EACF,CAAC,CAAC;EAEF,IAAIf,qBAAQ,CAACkB,EAAE,KAAK,SAAS,IAAIF,WAAW,EAAE;IAC5C,IAAI;MACF,MAAMG,OAAO,GAAG,MAAMC,+BAAkB,CAACC,OAAO,CAC9CD,+BAAkB,CAACE,WAAW,CAACC,sBAAsB,EACrD;QACEC,KAAK,EAAE,sCAAsC;QAC7CC,OAAO,EAAE,mDAAmD;QAC5DC,aAAa,EAAE,cAAc;QAC7BC,cAAc,EAAE,QAAQ;QACxBC,cAAc,EAAE;MAClB,CACF,CAAC;MACD,IAAIT,OAAO,KAAKC,+BAAkB,CAACS,OAAO,CAACC,OAAO,EAAE;QAClD,MAAM1B,SAAS,CAAC2B,SAAS,CAACd,UAAU,CAAC;MACvC,CAAC,MAAM;QACLb,SAAS,CAAC4B,UAAU,CAAC,CAAC;QACtB,MAAM,IAAIxB,KAAK,CAAC,0BAA0B,CAAC;MAC7C;IACF,CAAC,CAAC,OAAOyB,GAAG,EAAE;MACZ,MAAMA,GAAG;IACX;EACF;AACF;AAEO,SAASC,YAAYA,CAACxB,SAAiB,EAAoB;EAChE,OAAON,SAAS,CAAC8B,YAAY,CAACxB,SAAS,CAAC;AAC1C"}

package/lib/module/index.js

@@ -1,4 +1,4 @@
-import { NativeModules, Platform } from 'react-native';
+import { NativeModules, PermissionsAndroid, Platform } from 'react-native';
 const LINKING_ERROR = `The package 'react-native-video-trim' doesn't seem to be linked. Make sure: \n\n` + Platform.select({
   ios: "- You have run 'pod install'\n",
   default: ''
@@ -8,16 +8,35 @@ const VideoTrim = NativeModules.VideoTrim ? NativeModules.VideoTrim : new Proxy(
     throw new Error(LINKING_ERROR);
   }
 });
-export function showEditor(videoPath) {
+export async function showEditor(videoPath) {
   let config = arguments.length > 1 && arguments[1] !== undefined ? arguments[1] : {};
   const {
     maxDuration,
     saveToPhoto = true
   } = config;
-  VideoTrim.showEditor(videoPath, {
+  const outputPath = await VideoTrim.showEditor(videoPath, {
     saveToPhoto,
     maxDuration
   });
+  if (Platform.OS === 'android' && saveToPhoto) {
+    try {
+      const granted = await PermissionsAndroid.request(PermissionsAndroid.PERMISSIONS.WRITE_EXTERNAL_STORAGE, {
+        title: 'Video Trimmer Camera Access Required',
+        message: 'Grant access to your Camera to write output Video',
+        buttonNeutral: 'Ask Me Later',
+        buttonNegative: 'Cancel',
+        buttonPositive: 'OK'
+      });
+      if (granted === PermissionsAndroid.RESULTS.GRANTED) {
+        await VideoTrim.saveVideo(outputPath);
+      } else {
+        VideoTrim.hideDialog();
+        throw new Error('Camera permission denied');
+      }
+    } catch (err) {
+      throw err;
+    }
+  }
 }
 export function isValidVideo(videoPath) {
   return VideoTrim.isValidVideo(videoPath);

package/lib/module/index.js.map

@@ -1 +1 @@
-{"version":3,"names":["NativeModules","Platform","LINKING_ERROR","select","ios","default","VideoTrim","Proxy","get","Error","showEditor","videoPath","config","arguments","length","undefined","maxDuration","saveToPhoto","isValidVideo"],"sourceRoot":"../../src","sources":["index.tsx"],"mappings":"AAAA,SAASA,aAAa,EAAEC,QAAQ,QAAQ,cAAc;AAEtD,MAAMC,aAAa,GAChB,kFAAiF,GAClFD,QAAQ,CAACE,MAAM,CAAC;EAAEC,GAAG,EAAE,gCAAgC;EAAEC,OAAO,EAAE;AAAG,CAAC,CAAC,GACvE,sDAAsD,GACtD,+BAA+B;AAEjC,MAAMC,SAAS,GAAGN,aAAa,CAACM,SAAS,GACrCN,aAAa,CAACM,SAAS,GACvB,IAAIC,KAAK,CACP,CAAC,CAAC,EACF;EACEC,GAAGA,CAAA,EAAG;IACJ,MAAM,IAAIC,KAAK,CAACP,aAAa,CAAC;EAChC;AACF,CACF,CAAC;AAOL,OAAO,SAASQ,UAAUA,CAACC,SAAiB,EAAmC;EAAA,IAAjCC,MAAoB,GAAAC,SAAA,CAAAC,MAAA,QAAAD,SAAA,QAAAE,SAAA,GAAAF,SAAA,MAAG,CAAC,CAAC;EACrE,MAAM;IAAEG,WAAW;IAAEC,WAAW,GAAG;EAAK,CAAC,GAAGL,MAAM;EAClDN,SAAS,CAACI,UAAU,CAACC,SAAS,EAAE;IAC9BM,WAAW;IACXD;EACF,CAAC,CAAC;AACJ;AAEA,OAAO,SAASE,YAAYA,CAACP,SAAiB,EAAoB;EAChE,OAAOL,SAAS,CAACY,YAAY,CAACP,SAAS,CAAC;AAC1C"}
+{"version":3,"names":["NativeModules","PermissionsAndroid","Platform","LINKING_ERROR","select","ios","default","VideoTrim","Proxy","get","Error","showEditor","videoPath","config","arguments","length","undefined","maxDuration","saveToPhoto","outputPath","OS","granted","request","PERMISSIONS","WRITE_EXTERNAL_STORAGE","title","message","buttonNeutral","buttonNegative","buttonPositive","RESULTS","GRANTED","saveVideo","hideDialog","err","isValidVideo"],"sourceRoot":"../../src","sources":["index.tsx"],"mappings":"AAAA,SAASA,aAAa,EAAEC,kBAAkB,EAAEC,QAAQ,QAAQ,cAAc;AAE1E,MAAMC,aAAa,GAChB,kFAAiF,GAClFD,QAAQ,CAACE,MAAM,CAAC;EAAEC,GAAG,EAAE,gCAAgC;EAAEC,OAAO,EAAE;AAAG,CAAC,CAAC,GACvE,sDAAsD,GACtD,+BAA+B;AAEjC,MAAMC,SAAS,GAAGP,aAAa,CAACO,SAAS,GACrCP,aAAa,CAACO,SAAS,GACvB,IAAIC,KAAK,CACP,CAAC,CAAC,EACF;EACEC,GAAGA,CAAA,EAAG;IACJ,MAAM,IAAIC,KAAK,CAACP,aAAa,CAAC;EAChC;AACF,CACF,CAAC;AAOL,OAAO,eAAeQ,UAAUA,CAC9BC,SAAiB,EAEF;EAAA,IADfC,MAAoB,GAAAC,SAAA,CAAAC,MAAA,QAAAD,SAAA,QAAAE,SAAA,GAAAF,SAAA,MAAG,CAAC,CAAC;EAEzB,MAAM;IAAEG,WAAW;IAAEC,WAAW,GAAG;EAAK,CAAC,GAAGL,MAAM;EAClD,MAAMM,UAAU,GAAG,MAAMZ,SAAS,CAACI,UAAU,CAACC,SAAS,EAAE;IACvDM,WAAW;IACXD;EACF,CAAC,CAAC;EAEF,IAAIf,QAAQ,CAACkB,EAAE,KAAK,SAAS,IAAIF,WAAW,EAAE;IAC5C,IAAI;MACF,MAAMG,OAAO,GAAG,MAAMpB,kBAAkB,CAACqB,OAAO,CAC9CrB,kBAAkB,CAACsB,WAAW,CAACC,sBAAsB,EACrD;QACEC,KAAK,EAAE,sCAAsC;QAC7CC,OAAO,EAAE,mDAAmD;QAC5DC,aAAa,EAAE,cAAc;QAC7BC,cAAc,EAAE,QAAQ;QACxBC,cAAc,EAAE;MAClB,CACF,CAAC;MACD,IAAIR,OAAO,KAAKpB,kBAAkB,CAAC6B,OAAO,CAACC,OAAO,EAAE;QAClD,MAAMxB,SAAS,CAACyB,SAAS,CAACb,UAAU,CAAC;MACvC,CAAC,MAAM;QACLZ,SAAS,CAAC0B,UAAU,CAAC,CAAC;QACtB,MAAM,IAAIvB,KAAK,CAAC,0BAA0B,CAAC;MAC7C;IACF,CAAC,CAAC,OAAOwB,GAAG,EAAE;MACZ,MAAMA,GAAG;IACX;EACF;AACF;AAEA,OAAO,SAASC,YAAYA,CAACvB,SAAiB,EAAoB;EAChE,OAAOL,SAAS,CAAC4B,YAAY,CAACvB,SAAS,CAAC;AAC1C"}

package/lib/typescript/index.d.ts

@@ -2,6 +2,6 @@ export interface EditorConfig {
     saveToPhoto?: boolean;
     maxDuration?: number;
 }
-export declare function showEditor(videoPath: string, config?: EditorConfig): void;
+export declare function showEditor(videoPath: string, config?: EditorConfig): Promise<void>;
 export declare function isValidVideo(videoPath: string): Promise<boolean>;
 //# sourceMappingURL=index.d.ts.map

package/lib/typescript/index.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"index.d.ts","sourceRoot":"","sources":["../../src/index.tsx"],"names":[],"mappings":"AAmBA,MAAM,WAAW,YAAY;IAC3B,WAAW,CAAC,EAAE,OAAO,CAAC;IACtB,WAAW,CAAC,EAAE,MAAM,CAAC;CACtB;AAED,wBAAgB,UAAU,CAAC,SAAS,EAAE,MAAM,EAAE,MAAM,GAAE,YAAiB,GAAG,IAAI,CAM7E;AAED,wBAAgB,YAAY,CAAC,SAAS,EAAE,MAAM,GAAG,OAAO,CAAC,OAAO,CAAC,CAEhE"}
+{"version":3,"file":"index.d.ts","sourceRoot":"","sources":["../../src/index.tsx"],"names":[],"mappings":"AAmBA,MAAM,WAAW,YAAY;IAC3B,WAAW,CAAC,EAAE,OAAO,CAAC;IACtB,WAAW,CAAC,EAAE,MAAM,CAAC;CACtB;AAED,wBAAsB,UAAU,CAC9B,SAAS,EAAE,MAAM,EACjB,MAAM,GAAE,YAAiB,GACxB,OAAO,CAAC,IAAI,CAAC,CA6Bf;AAED,wBAAgB,YAAY,CAAC,SAAS,EAAE,MAAM,GAAG,OAAO,CAAC,OAAO,CAAC,CAEhE"}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "react-native-video-trim",
-  "version": "1.0.0",
+  "version": "1.0.2",
   "description": "Video trimmer for your React Native app",
   "main": "lib/commonjs/index",
   "module": "lib/module/index",

package/src/index.tsx

@@ -1,4 +1,4 @@
-import { NativeModules, Platform } from 'react-native';
+import { NativeModules, PermissionsAndroid, Platform } from 'react-native';
 
 const LINKING_ERROR =
   `The package 'react-native-video-trim' doesn't seem to be linked. Make sure: \n\n` +
@@ -22,12 +22,38 @@ export interface EditorConfig {
   maxDuration?: number;
 }
 
-export function showEditor(videoPath: string, config: EditorConfig = {}): void {
+export async function showEditor(
+  videoPath: string,
+  config: EditorConfig = {}
+): Promise<void> {
   const { maxDuration, saveToPhoto = true } = config;
-  VideoTrim.showEditor(videoPath, {
+  const outputPath = await VideoTrim.showEditor(videoPath, {
     saveToPhoto,
     maxDuration,
   });
+
+  if (Platform.OS === 'android' && saveToPhoto) {
+    try {
+      const granted = await PermissionsAndroid.request(
+        PermissionsAndroid.PERMISSIONS.WRITE_EXTERNAL_STORAGE!,
+        {
+          title: 'Video Trimmer Camera Access Required',
+          message: 'Grant access to your Camera to write output Video',
+          buttonNeutral: 'Ask Me Later',
+          buttonNegative: 'Cancel',
+          buttonPositive: 'OK',
+        }
+      );
+      if (granted === PermissionsAndroid.RESULTS.GRANTED) {
+        await VideoTrim.saveVideo(outputPath);
+      } else {
+        VideoTrim.hideDialog();
+        throw new Error('Camera permission denied');
+      }
+    } catch (err) {
+      throw err;
+    }
+  }
 }
 
 export function isValidVideo(videoPath: string): Promise<boolean> {