react-native-update 10.55.1 → 10.56.0

package/android/src/newarch/cn/reactnative/modules/update/UpdateModule.java

@@ -5,13 +5,16 @@ import com.facebook.react.bridge.ReactApplicationContext;
 import com.facebook.react.bridge.ReadableMap;
 import java.util.Map;
 
+/**
+ * New-architecture bridge: the codegen spec overrides only, every method
+ * forwards to UpdateModuleImpl.
+ */
 public class UpdateModule extends NativePushySpec {
-    private final UpdateContext updateContext;
+    private final UpdateModuleImpl impl;
 
     public UpdateModule(ReactApplicationContext reactContext, UpdateContext updateContext) {
         super(reactContext);
-        this.updateContext = updateContext;
-        UpdateEventEmitter.register(reactContext);
+        this.impl = new UpdateModuleImpl(reactContext, updateContext);
     }
 
     public UpdateModule(ReactApplicationContext reactContext) {
@@ -20,7 +23,7 @@ public class UpdateModule extends NativePushySpec {
 
     @Override
     protected Map<String, Object> getTypedExportedConstants() {
-        return UpdateModuleSupport.getConstants(updateContext);
+        return impl.getConstants();
     }
 
     @Override
@@ -30,87 +33,82 @@ public class UpdateModule extends NativePushySpec {
 
     @Override
     public void downloadFullUpdate(ReadableMap options, Promise promise) {
-        UpdateModuleImpl.downloadFullUpdate(updateContext, options, promise);
+        impl.downloadFullUpdate(options, promise);
     }
 
     @Override
     public void downloadAndInstallApk(ReadableMap options, Promise promise) {
-        UpdateModuleImpl.downloadAndInstallApk(
-            getReactApplicationContext(),
-            updateContext,
-            options,
-            promise
-        );
+        impl.downloadAndInstallApk(options, promise);
     }
 
     @Override
     public void downloadPatchFromPackage(ReadableMap options, Promise promise) {
-        UpdateModuleImpl.downloadPatchFromPackage(updateContext, options, promise);
+        impl.downloadPatchFromPackage(options, promise);
     }
 
     @Override
     public void downloadPatchFromPpk(ReadableMap options, Promise promise) {
-        UpdateModuleImpl.downloadPatchFromPpk(updateContext, options, promise);
+        impl.downloadPatchFromPpk(options, promise);
     }
 
     @Override
     public void reloadUpdate(ReadableMap options, Promise promise) {
-        UpdateModuleImpl.reloadUpdate(updateContext, getReactApplicationContext(), options, promise);
+        impl.reloadUpdate(options, promise);
     }
 
     @Override
     public void restartApp(Promise promise) {
-        UpdateModuleImpl.restartApp(updateContext, getReactApplicationContext(), null, promise);
+        impl.restartApp(null, promise);
     }
 
     @Override
     public void setNeedUpdate(ReadableMap options, Promise promise) {
-        UpdateModuleImpl.setNeedUpdate(updateContext, options, promise);
+        impl.setNeedUpdate(options, promise);
     }
 
     @Override
     public void markSuccess(Promise promise) {
-        UpdateModuleImpl.markSuccess(updateContext, promise);
+        impl.markSuccess(promise);
     }
 
     @Override
     public void getBundleHash(Promise promise) {
-        UpdateModuleImpl.getBundleHash(updateContext, promise);
+        impl.getBundleHash(promise);
     }
 
     @Override
     public void resetToPackagedBundle(Promise promise) {
-        UpdateModuleImpl.resetToPackagedBundle(updateContext, promise);
+        impl.resetToPackagedBundle(promise);
     }
 
     @Override
     public void setUuid(String uuid, Promise promise) {
-        UpdateModuleImpl.setUuid(updateContext, uuid, promise);
+        impl.setUuid(uuid, promise);
     }
 
     @Override
     public void syncNativeConfig(String config, Promise promise) {
-        UpdateModuleImpl.syncNativeConfig(updateContext, config, promise);
+        impl.syncNativeConfig(config, promise);
     }
 
     @Override
     public void getNativeCheckCache(Promise promise) {
-        UpdateModuleImpl.getNativeCheckCache(updateContext, promise);
+        impl.getNativeCheckCache(promise);
     }
 
     @Override
     public void markJsCheckCompleted(String config, Promise promise) {
-        UpdateModuleImpl.markJsCheckCompleted(updateContext, config, promise);
+        impl.markJsCheckCompleted(config, promise);
     }
 
     @Override
     public void setLocalHashInfo(String hash, String info, Promise promise) {
-        UpdateModuleImpl.setLocalHashInfo(updateContext, hash, info, promise);
+        impl.setLocalHashInfo(hash, info, promise);
     }
 
     @Override
     public void getLocalHashInfo(String hash, Promise promise) {
-        UpdateModuleImpl.getLocalHashInfo(updateContext, hash, promise);
+        impl.getLocalHashInfo(hash, promise);
     }
 
     @Override

package/android/src/oldarch/cn/reactnative/modules/update/UpdateModule.java

@@ -7,13 +7,18 @@ import com.facebook.react.bridge.ReactMethod;
 import com.facebook.react.bridge.ReadableMap;
 import java.util.Map;
 
+/**
+ * Old-architecture bridge: @ReactMethod declarations only, every method
+ * forwards to UpdateModuleImpl. Each state-changing method takes a trailing
+ * Promise, like the TurboModule spec, so a failed persistence rejects instead
+ * of resolving early (CODE_AUDIT 2.3).
+ */
 public class UpdateModule extends ReactContextBaseJavaModule {
-    private final UpdateContext updateContext;
+    private final UpdateModuleImpl impl;
 
     public UpdateModule(ReactApplicationContext reactContext, UpdateContext updateContext) {
         super(reactContext);
-        this.updateContext = updateContext;
-        UpdateEventEmitter.register(reactContext);
+        this.impl = new UpdateModuleImpl(reactContext, updateContext);
     }
 
     public UpdateModule(ReactApplicationContext reactContext) {
@@ -22,7 +27,7 @@ public class UpdateModule extends ReactContextBaseJavaModule {
 
     @Override
     public Map<String, Object> getConstants() {
-        return UpdateModuleSupport.getConstants(updateContext);
+        return impl.getConstants();
     }
 
     @Override
@@ -32,87 +37,82 @@ public class UpdateModule extends ReactContextBaseJavaModule {
 
     @ReactMethod
     public void downloadFullUpdate(ReadableMap options, Promise promise) {
-        UpdateModuleImpl.downloadFullUpdate(updateContext, options, promise);
+        impl.downloadFullUpdate(options, promise);
     }
 
     @ReactMethod
     public void downloadAndInstallApk(ReadableMap options, Promise promise) {
-        UpdateModuleImpl.downloadAndInstallApk(
-            getReactApplicationContext(),
-            updateContext,
-            options,
-            promise
-        );
+        impl.downloadAndInstallApk(options, promise);
     }
 
     @ReactMethod
     public void downloadPatchFromPackage(ReadableMap options, Promise promise) {
-        UpdateModuleImpl.downloadPatchFromPackage(updateContext, options, promise);
+        impl.downloadPatchFromPackage(options, promise);
     }
 
     @ReactMethod
     public void downloadPatchFromPpk(ReadableMap options, Promise promise) {
-        UpdateModuleImpl.downloadPatchFromPpk(updateContext, options, promise);
+        impl.downloadPatchFromPpk(options, promise);
     }
 
     @ReactMethod
     public void reloadUpdate(ReadableMap options, Promise promise) {
-        UpdateModuleImpl.reloadUpdate(updateContext, getReactApplicationContext(), options, promise);
+        impl.reloadUpdate(options, promise);
     }
 
     @ReactMethod
     public void restartApp(Promise promise) {
-        UpdateModuleImpl.restartApp(updateContext, getReactApplicationContext(), null, promise);
+        impl.restartApp(null, promise);
     }
 
     @ReactMethod
-    public void setNeedUpdate(ReadableMap options) {
-        UpdateModuleImpl.setNeedUpdate(updateContext, options);
+    public void setNeedUpdate(ReadableMap options, Promise promise) {
+        impl.setNeedUpdate(options, promise);
     }
 
     @ReactMethod
-    public void markSuccess() {
-        UpdateModuleImpl.markSuccess(updateContext);
+    public void markSuccess(Promise promise) {
+        impl.markSuccess(promise);
     }
 
     @ReactMethod
     public void getBundleHash(Promise promise) {
-        UpdateModuleImpl.getBundleHash(updateContext, promise);
+        impl.getBundleHash(promise);
     }
 
     @ReactMethod
     public void resetToPackagedBundle(Promise promise) {
-        UpdateModuleImpl.resetToPackagedBundle(updateContext, promise);
+        impl.resetToPackagedBundle(promise);
     }
 
     @ReactMethod
-    public void setUuid(String uuid) {
-        UpdateModuleImpl.setUuid(updateContext, uuid);
+    public void setUuid(String uuid, Promise promise) {
+        impl.setUuid(uuid, promise);
     }
 
     @ReactMethod
     public void syncNativeConfig(String config, Promise promise) {
-        UpdateModuleImpl.syncNativeConfig(updateContext, config, promise);
+        impl.syncNativeConfig(config, promise);
     }
 
     @ReactMethod
     public void getNativeCheckCache(Promise promise) {
-        UpdateModuleImpl.getNativeCheckCache(updateContext, promise);
+        impl.getNativeCheckCache(promise);
     }
 
     @ReactMethod
     public void markJsCheckCompleted(String config, Promise promise) {
-        UpdateModuleImpl.markJsCheckCompleted(updateContext, config, promise);
+        impl.markJsCheckCompleted(config, promise);
     }
 
     @ReactMethod
-    public void setLocalHashInfo(String hash, String info) {
-        UpdateModuleImpl.setLocalHashInfo(updateContext, hash, info);
+    public void setLocalHashInfo(String hash, String info, Promise promise) {
+        impl.setLocalHashInfo(hash, info, promise);
     }
 
     @ReactMethod
     public void getLocalHashInfo(String hash, Promise promise) {
-        UpdateModuleImpl.getLocalHashInfo(updateContext, hash, promise);
+        impl.getLocalHashInfo(hash, promise);
     }
 
     @ReactMethod

package/cpp/patch_core/archive_limits.h

@@ -31,6 +31,12 @@ constexpr long long kRatioCheckMinBytes = 1LL * 1024 * 1024;
 constexpr long long kMaxManifestBytes = 16LL * 1024 * 1024;
 // Free disk required beyond the bytes about to be written.
 constexpr long long kFreeDiskMarginBytes = 64LL * 1024 * 1024;
+// A download whose length is unknown up front (chunked / encoded body) can
+// only reserve the margin when the response arrives; the disk is re-probed
+// before any write that would run past the bytes reserved so far, each
+// probe reserving at least this many bytes ahead (a single larger chunk
+// reserves its own size), so no write can ever eat into the margin.
+constexpr long long kUnknownLengthFreeSpaceProbeBytes = 8LL * 1024 * 1024;
 
 }  // namespace archive_limits
 }  // namespace pushy

package/cpp/patch_core/jni_util.h

@@ -45,12 +45,16 @@ inline std::vector<std::string> JArrayToVector(
   return result;
 }
 
-inline void ThrowRuntimeException(JNIEnv* env, const std::string& message) {
+inline void ThrowRuntimeException(JNIEnv* env, const char* message) {
   jclass exception = env->FindClass("java/lang/RuntimeException");
   if (exception != nullptr) {
-    env->ThrowNew(exception, message.c_str());
+    env->ThrowNew(exception, message);
   }
 }
 
+inline void ThrowRuntimeException(JNIEnv* env, const std::string& message) {
+  ThrowRuntimeException(env, message.c_str());
+}
+
 }  // namespace jni_util
 }  // namespace pushy