react-native-update 10.48.3 → 10.50.0

package/src/error.ts

@@ -24,6 +24,9 @@ export type UpdateErrorCode =
   // A throw from a user-provided hook (e.g. beforeReload) — not an update
   // pipeline failure, and excluded from server-side patch-health telemetry.
   | 'USER_HOOK_ERROR'
+  // A second client/provider in the same process — a hard integration error;
+  // the SDK is a process-level singleton.
+  | 'SINGLETON_VIOLATION'
   // Native codes (see cpp/patch_core/error_codes.h)
   | 'INVALID_OPTIONS'
   | 'PATCH_FAILED'
@@ -47,6 +50,7 @@ const KNOWN_CODES = new Set<string>([
   'STORAGE_PERMISSION_ERROR',
   'APK_DOWNLOAD_FAILED',
   'USER_HOOK_ERROR',
+  'SINGLETON_VIOLATION',
   'INVALID_OPTIONS',
   'PATCH_FAILED',
   'FILE_OPERATION_FAILED',

package/src/isInRollout.ts

@@ -28,7 +28,8 @@ export function murmurhash3_32_gc(key: string, seed = 0) {
       ((key.charCodeAt(++i) & 0xff) << 24);
     ++i;
 
-    ((k1 & 0xffff) * c1 + ((((k1 >>> 16) * c1) & 0xffff) << 16)) & 0xffffffff;
+    k1 =
+      ((k1 & 0xffff) * c1 + ((((k1 >>> 16) * c1) & 0xffff) << 16)) & 0xffffffff;
     k1 = (k1 << 15) | (k1 >>> 17);
     k1 =
       ((k1 & 0xffff) * c2 + ((((k1 >>> 16) * c2) & 0xffff) << 16)) & 0xffffffff;

package/src/locales/en.ts

@@ -43,7 +43,13 @@ export default {
 
   // Error messages
   error_appkey_required: 'appKey is required',
+  error_client_singleton:
+    'A second update client was created: the SDK is a process-level singleton — create one client and reuse it everywhere (use client.setOptions to change options at runtime)',
+  error_provider_singleton:
+    'A second UpdateProvider was mounted: make sure the app renders exactly one UpdateProvider',
   error_parse_version_info: 'Failed to parse currentVersionInfo: {{info}}',
+  warn_unknown_bundle:
+    'The bundle embedded in this binary is not registered on the update platform; incremental updates are degraded to full downloads. Upload the package with pushy uploadIpa / uploadApk / uploadApp.',
   error_update_check_failed: 'Update check failed',
   error_cannot_connect_server:
     'Can not connect to update server. Please check your network.',

package/src/locales/zh.ts

@@ -41,7 +41,13 @@ export default {
 
   // Error messages
   error_appkey_required: '需要提供 appKey',
+  error_client_singleton:
+    '检测到重复创建热更新 client：SDK 是进程级单例，请只创建一个 client 并在全局复用（运行期改配置请调用 client.setOptions）',
+  error_provider_singleton:
+    '检测到同时挂载多个 UpdateProvider：请确保应用中只有一个 UpdateProvider',
   error_parse_version_info: '解析 currentVersionInfo 失败: {{info}}',
+  warn_unknown_bundle:
+    '当前二进制内嵌 bundle 未在更新平台注册，增量更新已降级为全量。请使用 pushy uploadIpa / uploadApk / uploadApp 上传对应安装包。',
   error_update_check_failed: '更新检查失败',
   error_cannot_connect_server: '无法连接到更新服务器。请检查网络连接。',
   error_cannot_connect_backup:

package/src/provider.tsx

@@ -37,6 +37,26 @@ export const UpdateProvider = ({
   client = useRef(client).current;
   const { options } = client;
 
+  // A second concurrently mounted provider is a hard integration error (the
+  // client is a process-level singleton); the client throws on the second
+  // claim. Also releases the claim on unmount.
+  useEffect(() => client.claimProviderMount?.(), [client]);
+
+  // options is mutated in place by client.setOptions (its identity never
+  // changes), so effects keyed on it would never re-run. The client bumps a
+  // version on every setOptions; mirroring it into state re-renders this
+  // provider and re-runs the effects that list it as a dependency.
+  const [optionsVersion, setOptionsVersion] = useState(
+    client.optionsVersion ?? 0
+  );
+  useEffect(
+    () =>
+      client.onOptionsChange?.(() => {
+        setOptionsVersion((version) => version + 1);
+      }),
+    [client]
+  );
+
   const stateListener = useRef<NativeEventSubscription>(undefined);
   const [updateInfo, setUpdateInfo] = useState<CheckResult>();
   const updateInfoRef = useRef(updateInfo);
@@ -279,6 +299,7 @@ export const UpdateProvider = ({
 
   const markSuccess = client.markSuccess;
 
+  // biome-ignore lint/correctness/useExhaustiveDependencies: optionsVersion re-runs this when setOptions mutates options in place
   useEffect(() => {
     if (!client.assertDebug('checkUpdate()')) {
       return;
@@ -313,8 +334,11 @@ export const UpdateProvider = ({
       }
       stateListener.current?.remove();
     };
-  }, [checkUpdate, options, markSuccess, client]);
+    // optionsVersion: checkStrategy/autoMarkSuccess are read from the
+    // in-place-mutated options object, so option changes must re-run this.
+  }, [checkUpdate, options, markSuccess, client, optionsVersion]);
 
+  // biome-ignore lint/correctness/useExhaustiveDependencies: optionsVersion re-runs this when setOptions mutates options in place
   useEffect(() => {
     const { dismissErrorAfter } = options;
     if (
@@ -329,17 +353,22 @@ export const UpdateProvider = ({
         clearTimeout(dismissErrorTimer);
       };
     }
-  }, [lastError, options, dismissError]);
+    // optionsVersion: dismissErrorAfter changes must reschedule a running
+    // timer, not only apply to the next error.
+  }, [lastError, options, dismissError, optionsVersion]);
 
   const parseTestPayload = useCallback(
     (payload: UpdateTestPayload) => {
       if (payload?.type?.startsWith('__rnPushy')) {
-        const logger = options.logger || (() => {});
-        options.logger = ({ type, data }) => {
-          logger({ type, data });
-          Alert.alert(type, JSON.stringify(data));
-        };
         if (payload.type === '__rnPushyVersionHash') {
+          // Wrap the logger only for the duration of this test check; wrapping
+          // on any other __rnPushy* payload would never be undone (the finally
+          // below is the only restore point).
+          const logger = options.logger || (() => {});
+          options.logger = ({ type, data }) => {
+            logger({ type, data });
+            Alert.alert(type, JSON.stringify(data));
+          };
           const toHash = payload.data;
           sharedState.toHash = toHash;
           checkUpdate({ extra: { toHash } })

package/src/telemetry.ts

@@ -53,6 +53,14 @@ export const resolveServerEventType = (
       return 'mark_success';
     case 'rollback':
       return 'rollback';
+    case 'downloadFallback':
+      // An incremental strategy failed but a later one rescued the download.
+      // When the incremental patch itself failed to apply (e.g. pdiff
+      // copiesCrc mismatch on a rebuilt binary), that is still a patch-health
+      // signal even though the end user got the update via full. Plain
+      // download errors that full rescued stay local-only — they are network
+      // noise, not patch health.
+      return code === 'PATCH_FAILED' ? 'patch_fail' : undefined;
     default:
       return undefined;
   }

package/src/type.ts

@@ -17,15 +17,37 @@ export interface VersionInfo {
 }
 
 interface RootResult {
-  upToDate?: true;
-  expired?: true;
+  upToDate?: boolean;
+  expired?: boolean;
   downloadUrl?: string;
-  update?: true;
+  update?: boolean;
   paused?: 'app' | 'package';
   message?: string;
   paths?: string[];
+  /**
+   * Server verdict on the reported bundleHash: 'matched' — the installed
+   * binary is registered; 'rebuiltSameJs' — repackaged binary with identical
+   * JS (no upload needed); 'unknownBundle' — unregistered binary, incremental
+   * updates degraded to full downloads until the package is uploaded.
+   */
+  bundleStatus?: 'matched' | 'rebuiltSameJs' | 'unknownBundle';
 }
 
+export type UpToDateCheckResult = RootResult & {
+  upToDate: true;
+};
+
+export type UpdateAvailableCheckResult = RootResult &
+  Partial<VersionInfo> & {
+    update: true;
+    expVersion?: VersionInfo;
+  };
+
+export type ExpiredCheckResult = RootResult & {
+  expired: true;
+  downloadUrl: string;
+};
+
 export type CheckResult = RootResult &
   Partial<VersionInfo> & {
     expVersion?: VersionInfo;
@@ -57,6 +79,15 @@ export type EventType =
   | 'errorMarkSuccess'
   | 'reset'
   | 'errorReset'
+  // Server reported bundleStatus: unknownBundle — the installed binary is not
+  // registered on the update platform (developer-facing only, local logger;
+  // not a server telemetry event).
+  | 'bundleMismatch'
+  // An incremental strategy (diff/pdiff) failed but a later strategy saved the
+  // download. Carries which strategy failed and why — the signal that watches
+  // pdiff copiesCrc verification failures (BUNDLEHASH_MIGRATION §4.2.1) in
+  // the field.
+  | 'downloadFallback'
   | 'errorRestart'
   | 'errorSwitchVersion'
   | 'downloadingApk'

package/src/utils.ts

@@ -147,6 +147,15 @@ export const fetchWithTimeout = (
   // Promise.race the losing fetch kept running (and kept the connection busy)
   // long after the caller had already moved on.
   const controller = new AbortController();
+  // The timeout controller replaces params.signal on the fetch call, so a
+  // caller-provided signal (e.g. the hedged endpoint race cancelling losers)
+  // must be chained onto it manually.
+  const externalSignal = (params as any)?.signal as AbortSignal | undefined;
+  if (externalSignal?.aborted) {
+    controller.abort();
+  } else if (externalSignal) {
+    externalSignal.addEventListener('abort', () => controller.abort());
+  }
   const timeoutId = setTimeout(() => {
     log('fetch timeout', url);
     controller.abort();
@@ -154,6 +163,10 @@ export const fetchWithTimeout = (
 
   return enhancedFetch(url, { ...params, signal: controller.signal as any })
     .catch((e: any) => {
+      if (externalSignal?.aborted) {
+        // Cancelled by the caller, not timed out; keep the abort semantics.
+        throw e;
+      }
       if (controller.signal.aborted) {
         throw Error(i18n.t('error_ping_timeout'));
       }