react-native-update 10.45.0 → 10.47.0

package/android/src/main/java/cn/reactnative/modules/update/ErrorCodes.java

@@ -0,0 +1,24 @@
+package cn.reactnative.modules.update;
+
+/**
+ * Stable, machine-readable error codes used as the promise rejection code so
+ * the JS layer and user loggers can aggregate errors across platforms.
+ *
+ * MUST stay in sync with cpp/patch_core/error_codes.h (the single source of
+ * truth) and src/error.ts (UpdateErrorCode). Messages are free-form; only the
+ * codes are part of the contract.
+ */
+final class ErrorCodes {
+    static final String INVALID_OPTIONS = "INVALID_OPTIONS";
+    static final String DOWNLOAD_FAILED = "DOWNLOAD_FAILED";
+    static final String PATCH_FAILED = "PATCH_FAILED";
+    static final String FILE_OPERATION_FAILED = "FILE_OPERATION_FAILED";
+    static final String SWITCH_VERSION_FAILED = "SWITCH_VERSION_FAILED";
+    static final String MARK_SUCCESS_FAILED = "MARK_SUCCESS_FAILED";
+    static final String RESTART_FAILED = "RESTART_FAILED";
+    static final String INVALID_HASH_INFO = "INVALID_HASH_INFO";
+    static final String UNSUPPORTED_PLATFORM = "UNSUPPORTED_PLATFORM";
+
+    private ErrorCodes() {
+    }
+}

package/android/src/main/java/cn/reactnative/modules/update/StateSerialRunner.java

@@ -43,6 +43,7 @@ final class StateSerialRunner {
 
     static void run(
         @Nullable final Promise promise,
+        final String errorCode,
         final String operationName,
         final Operation operation
     ) {
@@ -53,7 +54,7 @@ final class StateSerialRunner {
                     operation.run();
                 } catch (Throwable error) {
                     if (promise != null) {
-                        promise.reject(operationName + " failed", error);
+                        promise.reject(errorCode, operationName + " failed", error);
                     } else {
                         Log.e(UpdateContext.TAG, operationName + " failed", error);
                     }

package/android/src/main/java/cn/reactnative/modules/update/UiThreadRunner.java

@@ -15,6 +15,7 @@ final class UiThreadRunner {
 
     static void run(
         @Nullable final Promise promise,
+        final String errorCode,
         final String operationName,
         final Operation operation
     ) {
@@ -25,7 +26,7 @@ final class UiThreadRunner {
                     operation.run();
                 } catch (Throwable error) {
                     if (promise != null) {
-                        promise.reject(operationName + " failed", error);
+                        promise.reject(errorCode, operationName + " failed", error);
                     } else {
                         Log.e(UpdateContext.TAG, operationName + " failed", error);
                     }

package/android/src/main/java/cn/reactnative/modules/update/UpdateContext.java

@@ -207,8 +207,10 @@ public class UpdateContext {
     }
 
     private void persistEditor(SharedPreferences.Editor editor, String reason) {
-        if (!editor.commit() && DEBUG) {
-            Log.w(TAG, "Failed to persist update state for " + reason);
+        // A lost state write can mean a missed rollback or a version switch
+        // that silently never happens, so this must be visible in release too.
+        if (!editor.commit()) {
+            Log.e(TAG, "Failed to persist update state for " + reason);
         }
     }
 
@@ -367,6 +369,13 @@ public class UpdateContext {
             ignoreRollback,
             true
         );
+        if (launchState.didRollback) {
+            // The crash-protection rollback: the new version never called
+            // markSuccess. Keep this visible in release logs.
+            Log.e(TAG, "Version " + currentState.currentVersion
+                + " was not marked as successful, rolling back to "
+                + launchState.currentVersion);
+        }
         if (launchState.didRollback || launchState.consumedFirstTime) {
             SharedPreferences.Editor editor = sp.edit();
             applyState(editor, launchState);
@@ -411,6 +420,8 @@ public class UpdateContext {
             false,
             false
         );
+        Log.e(TAG, "Rolling back version " + currentState.currentVersion
+            + " to " + nextState.currentVersion);
         SharedPreferences.Editor editor = sp.edit();
         applyState(editor, nextState);
         persistEditor(editor, "rollback");

package/android/src/main/java/cn/reactnative/modules/update/UpdateModuleImpl.java

@@ -41,7 +41,7 @@ public class UpdateModuleImpl {
 
             @Override
             public void onDownloadFailed(Throwable error) {
-                promise.reject(error);
+                promise.reject(ErrorCodes.DOWNLOAD_FAILED, error);
             }
         });
     }
@@ -64,7 +64,7 @@ public class UpdateModuleImpl {
 
             @Override
             public void onDownloadFailed(Throwable error) {
-                promise.reject(error);
+                promise.reject(ErrorCodes.DOWNLOAD_FAILED, error);
             }
         });
     }
@@ -84,7 +84,7 @@ public class UpdateModuleImpl {
 
             @Override
             public void onDownloadFailed(Throwable error) {
-                promise.reject(error);
+                promise.reject(ErrorCodes.DOWNLOAD_FAILED, error);
             }
         });
     }
@@ -107,11 +107,11 @@ public class UpdateModuleImpl {
 
                 @Override
                 public void onDownloadFailed(Throwable error) {
-                    promise.reject(error);
+                    promise.reject(ErrorCodes.DOWNLOAD_FAILED, error);
                 }
             });
         } catch (Exception e) {
-            promise.reject("downloadPatchFromPpk failed: " + e.getMessage());
+            promise.reject(ErrorCodes.INVALID_OPTIONS, "downloadPatchFromPpk failed: " + e.getMessage(), e);
         }
     }
 
@@ -130,7 +130,7 @@ public class UpdateModuleImpl {
         @Nullable final String hash,
         final Promise promise
     ) {
-        UiThreadRunner.run(promise, "restartApp", new UiThreadRunner.Operation() {
+        UiThreadRunner.run(promise, ErrorCodes.RESTART_FAILED, "restartApp", new UiThreadRunner.Operation() {
             @Override
             public void run() throws Throwable {
                 ReactReloadManager.restartApp(updateContext, reactContext, hash);
@@ -149,7 +149,7 @@ public class UpdateModuleImpl {
         final Promise promise
     ) {
         final String hash = options.getString("hash");
-        StateSerialRunner.run(promise, "switchVersionLater", new StateSerialRunner.Operation() {
+        StateSerialRunner.run(promise, ErrorCodes.SWITCH_VERSION_FAILED, "switchVersionLater", new StateSerialRunner.Operation() {
             @Override
             public void run() {
                 setNeedUpdateInternal(updateContext, hash);
@@ -160,7 +160,7 @@ public class UpdateModuleImpl {
 
     public static void setNeedUpdate(final UpdateContext updateContext, final ReadableMap options) {
         final String hash = options.getString("hash");
-        StateSerialRunner.run(null, "switchVersionLater", new StateSerialRunner.Operation() {
+        StateSerialRunner.run(null, ErrorCodes.SWITCH_VERSION_FAILED, "switchVersionLater", new StateSerialRunner.Operation() {
             @Override
             public void run() {
                 setNeedUpdateInternal(updateContext, hash);
@@ -173,7 +173,7 @@ public class UpdateModuleImpl {
     }
 
     public static void markSuccess(final UpdateContext updateContext, final Promise promise) {
-        StateSerialRunner.run(promise, "markSuccess", new StateSerialRunner.Operation() {
+        StateSerialRunner.run(promise, ErrorCodes.MARK_SUCCESS_FAILED, "markSuccess", new StateSerialRunner.Operation() {
             @Override
             public void run() {
                 markSuccessInternal(updateContext);
@@ -183,7 +183,7 @@ public class UpdateModuleImpl {
     }
 
     public static void markSuccess(final UpdateContext updateContext) {
-        StateSerialRunner.run(null, "markSuccess", new StateSerialRunner.Operation() {
+        StateSerialRunner.run(null, ErrorCodes.MARK_SUCCESS_FAILED, "markSuccess", new StateSerialRunner.Operation() {
             @Override
             public void run() {
                 markSuccessInternal(updateContext);
@@ -200,7 +200,7 @@ public class UpdateModuleImpl {
         final String uuid,
         final Promise promise
     ) {
-        StateSerialRunner.run(promise, "setUuid", new StateSerialRunner.Operation() {
+        StateSerialRunner.run(promise, ErrorCodes.FILE_OPERATION_FAILED, "setUuid", new StateSerialRunner.Operation() {
             @Override
             public void run() {
                 setUuidInternal(updateContext, uuid);
@@ -210,7 +210,7 @@ public class UpdateModuleImpl {
     }
 
     public static void setUuid(final UpdateContext updateContext, final String uuid) {
-        StateSerialRunner.run(null, "setUuid", new StateSerialRunner.Operation() {
+        StateSerialRunner.run(null, ErrorCodes.FILE_OPERATION_FAILED, "setUuid", new StateSerialRunner.Operation() {
             @Override
             public void run() {
                 setUuidInternal(updateContext, uuid);
@@ -235,7 +235,7 @@ public class UpdateModuleImpl {
         final String info,
         final Promise promise
     ) {
-        StateSerialRunner.run(promise, "setLocalHashInfo", new StateSerialRunner.Operation() {
+        StateSerialRunner.run(promise, ErrorCodes.INVALID_HASH_INFO, "setLocalHashInfo", new StateSerialRunner.Operation() {
             @Override
             public void run() {
                 setLocalHashInfoInternal(updateContext, hash, info);
@@ -249,7 +249,7 @@ public class UpdateModuleImpl {
         final String hash,
         final String info
     ) {
-        StateSerialRunner.run(null, "setLocalHashInfo", new StateSerialRunner.Operation() {
+        StateSerialRunner.run(null, ErrorCodes.INVALID_HASH_INFO, "setLocalHashInfo", new StateSerialRunner.Operation() {
             @Override
             public void run() {
                 setLocalHashInfoInternal(updateContext, hash, info);
@@ -264,7 +264,7 @@ public class UpdateModuleImpl {
     ) {
         String value = updateContext.getKv("hash_" + hash);
         if (!isValidHashInfo(value)) {
-            promise.reject("getLocalHashInfo failed: invalid json string");
+            promise.reject(ErrorCodes.INVALID_HASH_INFO, "getLocalHashInfo failed: invalid json string");
             return;
         }
 

package/cpp/patch_core/error_codes.h

@@ -0,0 +1,43 @@
+#ifndef PUSHY_PATCH_CORE_ERROR_CODES_H_
+#define PUSHY_PATCH_CORE_ERROR_CODES_H_
+
+// Single source of truth for the stable, machine-readable error codes shared
+// by every platform. Native modules reject promises with one of these codes
+// so the JS layer (src/error.ts UpdateErrorCode) and user loggers can
+// aggregate errors across platforms and locales.
+//
+// Mirrors that cannot include this header MUST stay in sync by hand:
+//   - src/error.ts                      (UpdateErrorCode union, JS layer)
+//   - android/.../ErrorCodes.java      (Java constants)
+// iOS (RCTPushy.mm) includes this header directly.
+//
+// Human-readable messages are NOT part of this contract: they may differ per
+// platform and locale. Only the codes are stable.
+
+namespace pushy {
+namespace error_codes {
+
+// Method options missing or malformed (blank hash/url, wrong types).
+constexpr const char* kInvalidOptions = "INVALID_OPTIONS";
+// Native download failed (network error, bad HTTP status, truncated body).
+constexpr const char* kDownloadFailed = "DOWNLOAD_FAILED";
+// Unzip or hdiff patch application failed.
+constexpr const char* kPatchFailed = "PATCH_FAILED";
+// Local file or state persistence operation failed.
+constexpr const char* kFileOperationFailed = "FILE_OPERATION_FAILED";
+// switchVersion / setNeedUpdate state transition failed.
+constexpr const char* kSwitchVersionFailed = "SWITCH_VERSION_FAILED";
+// markSuccess state transition failed.
+constexpr const char* kMarkSuccessFailed = "MARK_SUCCESS_FAILED";
+// reloadUpdate / restartApp failed.
+constexpr const char* kRestartFailed = "RESTART_FAILED";
+// Stored or provided hash info is not a valid JSON object.
+constexpr const char* kInvalidHashInfo = "INVALID_HASH_INFO";
+// The method is not supported on this platform (e.g. downloadAndInstallApk
+// outside Android).
+constexpr const char* kUnsupportedPlatform = "UNSUPPORTED_PLATFORM";
+
+}  // namespace error_codes
+}  // namespace pushy
+
+#endif  // PUSHY_PATCH_CORE_ERROR_CODES_H_

package/harmony/pushy/src/main/ets/UpdateContext.ts

@@ -468,13 +468,22 @@ export class UpdateContext {
   public getBundleUrl() {
     UpdateContext.isUsingBundleUrl = true;
     this.trace('getBundleUrl:enter');
+    const stateBeforeLaunch = this.getStateSnapshot();
     const launchState = NativePatchCore.runStateCore(
       STATE_OP_RESOLVE_LAUNCH,
-      this.getStateSnapshot(),
+      stateBeforeLaunch,
       '',
       UpdateContext.ignoreRollback,
       true,
     );
+    if (launchState.didRollback) {
+      // The crash-protection rollback: the new version never called
+      // markSuccess. Keep this visible in release logs.
+      console.error(
+        `Version ${stateBeforeLaunch.currentVersion} was not marked as successful,` +
+          ` rolled back to ${launchState.currentVersion}`,
+      );
+    }
     if (launchState.didRollback || launchState.consumedFirstTime) {
       this.persistState(launchState, {
         markFirstLoadMarker: launchState.consumedFirstTime,
@@ -490,7 +499,12 @@ export class UpdateContext {
     );
 
     let version = launchState.loadVersion || '';
-    while (version) {
+    // Guard the rollback chain against cycles: a corrupted state returning an
+    // already-visited version would otherwise spin this loop forever during
+    // startup (Android has the same guard).
+    const visitedVersions = new Set<string>();
+    while (version && !visitedVersions.has(version)) {
+      visitedVersions.add(version);
       const bundleFile = this.getBundlePath(version);
       try {
         if (!fileIo.accessSync(bundleFile)) {
@@ -514,7 +528,11 @@ export class UpdateContext {
   }
 
   private rollBack(): string {
+    const stateBefore = this.getStateSnapshot();
     const nextState = this.runStateOperation(STATE_OP_ROLLBACK);
+    console.error(
+      `Rolling back version ${stateBefore.currentVersion} to ${nextState.currentVersion}`,
+    );
     return nextState.currentVersion || '';
   }
 

package/ios/RCTPushy/RCTPushy.mm

@@ -2,6 +2,7 @@
 #import "RCTPushyDownloader.h"
 #import "ZipArchive.h"
 #include "../../cpp/patch_core/archive_patch_core.h"
+#include "../../cpp/patch_core/error_codes.h"
 #include "../../cpp/patch_core/patch_core.h"
 #include "../../cpp/patch_core/state_core.h"
 
@@ -37,9 +38,15 @@ static NSString * const BUNDLE_FILE_NAME = @"index.bundlejs";
 static NSString * const SOURCE_PATCH_NAME = @"__diff.json";
 static NSString * const BUNDLE_PATCH_NAME = @"index.bundlejs.patch";
 
-// error def
+// error def — messages are human-readable; the stable cross-platform codes
+// live in cpp/patch_core/error_codes.h and travel in PushyErrorCodeKey.
 static NSString * const ERROR_OPTIONS = @"options error";
 static NSString * const ERROR_FILE_OPERATION = @"file operation error";
+static NSString * const PushyErrorCodeKey = @"PushyErrorCode";
+
+static NSString *PushyCode(const char *code) {
+    return [NSString stringWithUTF8String:code];
+}
 
 // event def
 static NSString * const EVENT_PROGRESS_DOWNLOAD = @"RCTPushyDownloadProgress";
@@ -80,7 +87,10 @@ static std::string PushyToStdString(NSString *value) {
 static NSError *PushyNSErrorFromStatus(const pushy::patch::Status &status) {
     return [NSError errorWithDomain:PushyErrorDomain
                                code:-1
-                           userInfo:@{ NSLocalizedDescriptionKey: [NSString stringWithUTF8String:status.message.c_str()] }];
+                           userInfo:@{
+                               NSLocalizedDescriptionKey: [NSString stringWithUTF8String:status.message.c_str()],
+                               PushyErrorCodeKey: PushyCode(pushy::error_codes::kPatchFailed),
+                           }];
 }
 
 static NSUserDefaults *PushyDefaults(void) {
@@ -118,21 +128,24 @@ static BOOL PushyStringIsBlank(NSString *value) {
 }
 
 static void PushyRejectError(RCTPromiseRejectBlock reject, NSError *error) {
-    reject([NSString stringWithFormat:@"%ld", (long)error.code], error.localizedDescription, error);
+    // Prefer the stable cross-platform code (error_codes.h); fall back to the
+    // numeric NSError code for system errors that were not classified.
+    NSString *code = error.userInfo[PushyErrorCodeKey];
+    if (code == nil) {
+        code = [NSString stringWithFormat:@"%ld", (long)error.code];
+    }
+    reject(code, error.localizedDescription, error);
 }
 
-static NSError *PushyErrorWithMessage(NSString *message) {
+static NSError *PushyErrorWithCode(const char *code, NSString *message) {
     return [NSError errorWithDomain:PushyErrorDomain
                                code:-1
                            userInfo:@{
                                NSLocalizedDescriptionKey: message ?: @"unknown error",
+                               PushyErrorCodeKey: PushyCode(code),
                            }];
 }
 
-static void PushyRejectMessage(RCTPromiseRejectBlock reject, NSString *message) {
-    PushyRejectError(reject, PushyErrorWithMessage(message));
-}
-
 static pushy::patch::PatchManifest PushyPatchManifestFromJson(NSDictionary *json) {
     pushy::patch::PatchManifest manifest;
 
@@ -257,6 +270,7 @@ RCT_EXPORT_MODULE(RCTPushy);
         }
 
         if (!state.current_version.empty()) {
+            std::string const versionBeforeLaunch = state.current_version;
             pushy::state::LaunchDecision decision = pushy::state::ResolveLaunchState(
                 state,
                 ignoreRollback.load(),
@@ -264,6 +278,13 @@ RCT_EXPORT_MODULE(RCTPushy);
             );
             state = decision.state;
 
+            if (decision.did_rollback) {
+                // The crash-protection rollback: the new version never called
+                // markSuccess. Keep this visible in release logs.
+                RCTLogWarn(@"RCTPushy -- version %@ was not marked as successful, rolled back to %@",
+                    PushyFromStdString(versionBeforeLaunch),
+                    PushyFromStdString(state.current_version));
+            }
             if (decision.did_rollback || decision.consumed_first_time) {
                 PushyApplyStateToDefaults(defaults, state);
             }
@@ -275,13 +296,18 @@ RCT_EXPORT_MODULE(RCTPushy);
 
             NSString *loadVersion = PushyFromStdString(decision.load_version);
             NSString *downloadDir = [RCTPushy downloadDir];
-            while (loadVersion.length) {
+            // Guard the rollback chain against cycles: a corrupted state
+            // returning an already-visited version would otherwise spin this
+            // loop forever during startup (Android has the same guard).
+            NSMutableSet<NSString *> *visitedVersions = [NSMutableSet set];
+            while (loadVersion.length && ![visitedVersions containsObject:loadVersion]) {
+                [visitedVersions addObject:loadVersion];
                 NSString *bundlePath = [[downloadDir stringByAppendingPathComponent:loadVersion] stringByAppendingPathComponent:BUNDLE_FILE_NAME];
                 if ([[NSFileManager defaultManager] fileExistsAtPath:bundlePath isDirectory:NULL]) {
                     resolvedURL = [NSURL fileURLWithPath:bundlePath];
                     return;
                 } else {
-                    RCTLogError(@"RCTPushy -- bundle version %@ not found", loadVersion);
+                    RCTLogError(@"RCTPushy -- bundle version %@ not found, rolling back", loadVersion);
                     state = pushy::state::Rollback(state);
                     PushyApplyStateToDefaults(defaults, state);
                     loadVersion = PushyFromStdString(state.current_version);
@@ -359,7 +385,7 @@ RCT_EXPORT_METHOD(setUuid:(NSString *)uuid  resolver:(RCTPromiseResolveBlock)res
                   rejecter:(RCTPromiseRejectBlock)reject)
 {
     if (PushyStringIsBlank(uuid)) {
-        PushyRejectError(reject, PushyErrorWithMessage(ERROR_OPTIONS));
+        PushyRejectError(reject, PushyErrorWithCode(pushy::error_codes::kInvalidOptions, ERROR_OPTIONS));
         return;
     }
 
@@ -373,7 +399,7 @@ RCT_EXPORT_METHOD(setLocalHashInfo:(NSString *)hash
                   rejecter:(RCTPromiseRejectBlock)reject)
 {
     if (PushyStringIsBlank(hash) || PushyStringIsBlank(value)) {
-        PushyRejectMessage(reject, ERROR_OPTIONS);
+        PushyRejectError(reject, PushyErrorWithCode(pushy::error_codes::kInvalidOptions, ERROR_OPTIONS));
         return;
     }
 
@@ -386,7 +412,9 @@ RCT_EXPORT_METHOD(setLocalHashInfo:(NSString *)hash
         
         resolve(@true);
     } else {
-        PushyRejectError(reject, error ?: PushyErrorWithMessage(@"json格式校验报错"));
+        PushyRejectError(reject, PushyErrorWithCode(
+            pushy::error_codes::kInvalidHashInfo,
+            error != nil ? error.localizedDescription : @"invalid json string"));
     }
 }
 
@@ -421,6 +449,15 @@ RCT_EXPORT_METHOD(downloadPatchFromPpk:(NSDictionary *)options
     [self downloadUpdate:PushyTypePatchFromPpk options:options resolver:resolve rejecter:reject];
 }
 
+RCT_EXPORT_METHOD(downloadAndInstallApk:(NSDictionary *)options
+                  resolver:(RCTPromiseResolveBlock)resolve
+                  rejecter:(RCTPromiseRejectBlock)reject)
+{
+    PushyRejectError(reject, PushyErrorWithCode(
+        pushy::error_codes::kUnsupportedPlatform,
+        @"downloadAndInstallApk is only supported on Android"));
+}
+
 RCT_EXPORT_METHOD(setNeedUpdate:(NSDictionary *)options
                   resolver:(RCTPromiseResolveBlock)resolve
                   rejecter:(RCTPromiseRejectBlock)reject)
@@ -502,6 +539,12 @@ RCT_EXPORT_METHOD(markSuccess:(RCTPromiseResolveBlock)resolve
 {
     [self performUpdate:type options:options callback:^(NSError *error) {
         if (error != nil) {
+            if (error.userInfo[PushyErrorCodeKey] == nil) {
+                // Unclassified (system/network) errors from the download
+                // pipeline; keep the original message.
+                error = PushyErrorWithCode(pushy::error_codes::kDownloadFailed,
+                                           error.localizedDescription);
+            }
             PushyRejectError(reject, error);
             return;
         }
@@ -527,24 +570,38 @@ RCT_EXPORT_METHOD(markSuccess:(RCTPromiseResolveBlock)resolve
     NSString *hash = PushyOptionString(options, @"hash");
 
     if (PushyStringIsBlank(updateUrl) || PushyStringIsBlank(hash)) {
-        callback(PushyErrorWithMessage(ERROR_OPTIONS));
+        callback(PushyErrorWithCode(pushy::error_codes::kInvalidOptions, ERROR_OPTIONS));
         return;
     }
     NSString *originHash = PushyOptionString(options, @"originHash");
     if (type == PushyTypePatchFromPpk && PushyStringIsBlank(originHash)) {
-        callback(PushyErrorWithMessage(ERROR_OPTIONS));
+        callback(PushyErrorWithCode(pushy::error_codes::kInvalidOptions, ERROR_OPTIONS));
         return;
     }
     
     NSString *dir = [RCTPushy downloadDir];
     BOOL success = [self ensureDirectoryExistsAtPath:dir];
     if (!success) {
-        callback(PushyErrorWithMessage(ERROR_FILE_OPERATION));
+        callback(PushyErrorWithCode(pushy::error_codes::kFileOperationFailed, ERROR_FILE_OPERATION));
         return;
     }
 
     NSString *zipFilePath = [dir stringByAppendingPathComponent:[NSString stringWithFormat:@"%@%@",hash, [self zipExtension:type]]];
 
+    // On failure, remove the partial version directory like Android/Harmony
+    // do: a half-unzipped/half-patched dir leaks disk and could later be
+    // mistaken for a complete version. hash is validated non-blank above, so
+    // this can never resolve to the download root itself.
+    NSString *unzipDir = [dir stringByAppendingPathComponent:hash];
+    void (^completion)(NSError *) = ^(NSError *error) {
+        if (error != nil) {
+            dispatch_async(self->_fileQueue, ^{
+                [[NSFileManager defaultManager] removeItemAtPath:unzipDir error:nil];
+            });
+        }
+        callback(error);
+    };
+
     RCTLogInfo(@"RCTPushy -- download file %@", updateUrl);
     [RCTPushyDownloader download:updateUrl savePath:zipFilePath progressHandler:^(long long receivedBytes, long long totalBytes) {
         if (self->hasListeners) {
@@ -556,14 +613,14 @@ RCT_EXPORT_METHOD(markSuccess:(RCTPromiseResolveBlock)resolve
         }
     } completionHandler:^(NSString *path, NSError *error) {
         if (error != nil) {
-            callback(error);
+            completion(error);
             return;
         }
         [self unzipDownloadedPackage:zipFilePath
                                 hash:hash
                                 type:type
                           originHash:originHash
-                            callback:callback];
+                            callback:completion];
     }];
 }
 
@@ -629,18 +686,21 @@ RCT_EXPORT_METHOD(markSuccess:(RCTPromiseResolveBlock)resolve
     NSString *destination = [unzipDir stringByAppendingPathComponent:BUNDLE_FILE_NAME];
     NSData *data = [NSData dataWithContentsOfFile:sourcePatch];
     if (data == nil) {
-        callback(PushyErrorWithMessage(@"missing patch manifest"));
+        callback(PushyErrorWithCode(pushy::error_codes::kPatchFailed, @"missing patch manifest"));
         return;
     }
 
     NSError *error = nil;
     id jsonObject = [NSJSONSerialization JSONObjectWithData:data options:NSJSONReadingAllowFragments error:&error];
     if (error != nil) {
-        callback(error);
+        // Classify as a patch failure like the sibling manifest branches;
+        // unclassified errors would otherwise be tagged DOWNLOAD_FAILED by the
+        // downloadUpdate fallback even though the download itself succeeded.
+        callback(PushyErrorWithCode(pushy::error_codes::kPatchFailed, error.localizedDescription));
         return;
     }
     if (![jsonObject isKindOfClass:[NSDictionary class]]) {
-        callback(PushyErrorWithMessage(@"invalid patch manifest"));
+        callback(PushyErrorWithCode(pushy::error_codes::kPatchFailed, @"invalid patch manifest"));
         return;
     }
     NSDictionary *json = (NSDictionary *)jsonObject;
@@ -695,7 +755,7 @@ RCT_EXPORT_METHOD(markSuccess:(RCTPromiseResolveBlock)resolve
 {
     if (PushyStringIsBlank(hash)) {
         if (error != NULL) {
-            *error = PushyErrorWithMessage(ERROR_OPTIONS);
+            *error = PushyErrorWithCode(pushy::error_codes::kInvalidOptions, ERROR_OPTIONS);
         }
         return NO;
     }
@@ -758,7 +818,7 @@ RCT_EXPORT_METHOD(markSuccess:(RCTPromiseResolveBlock)resolve
 
             NSError *unzipError = error;
             if (!succeeded && unzipError == nil) {
-                unzipError = PushyErrorWithMessage(@"unzip failed");
+                unzipError = PushyErrorWithCode(pushy::error_codes::kPatchFailed, @"unzip failed");
             }
             completionHandler(unzipError);
         }];

package/ios/RCTPushy/RCTPushyDownloader.mm

@@ -113,7 +113,8 @@ didFinishDownloadingToURL:(NSURL *)location
     // before touching savePath so an existing valid package is not destroyed.
     NSURLResponse *response = downloadTask.response;
     if ([response isKindOfClass:[NSHTTPURLResponse class]]) {
-        NSInteger statusCode = ((NSHTTPURLResponse *)response).statusCode;
+        NSHTTPURLResponse *httpResponse = (NSHTTPURLResponse *)response;
+        NSInteger statusCode = httpResponse.statusCode;
         if (statusCode < 200 || statusCode >= 300) {
             self.fileError = [NSError errorWithDomain:RCTPushyDownloaderErrorDomain
                                                  code:statusCode
@@ -122,6 +123,26 @@ didFinishDownloadingToURL:(NSURL *)location
             }];
             return;
         }
+
+        // Reject truncated transfers like Android/Harmony do. Skip the check
+        // for encoded responses (e.g. gzip): NSURLSession decompresses them
+        // transparently, so the on-disk size legitimately differs from the
+        // Content-Length of the encoded body.
+        NSString *contentEncoding = [httpResponse.allHeaderFields[@"Content-Encoding"] lowercaseString];
+        BOOL isEncodedBody = contentEncoding.length > 0 && ![contentEncoding isEqualToString:@"identity"];
+        long long expectedLength = httpResponse.expectedContentLength;
+        if (!isEncodedBody && expectedLength > 0) {
+            NSNumber *fileSize = [[NSFileManager defaultManager] attributesOfItemAtPath:location.path
+                                                                                  error:nil][NSFileSize];
+            if (fileSize != nil && fileSize.longLongValue != expectedLength) {
+                self.fileError = [NSError errorWithDomain:RCTPushyDownloaderErrorDomain
+                                                     code:-1
+                                                 userInfo:@{
+                    NSLocalizedDescriptionKey: [NSString stringWithFormat:@"download incomplete: expected %lld bytes, got %lld", expectedLength, fileSize.longLongValue],
+                }];
+                return;
+            }
+        }
     }
 
     NSFileManager *fileManager = [NSFileManager defaultManager];

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "react-native-update",
-  "version": "10.45.0",
+  "version": "10.47.0",
   "description": "react-native hot update",
   "main": "src/index",
   "types": "src/index.ts",
@@ -15,6 +15,7 @@
     "test": "bun test src/__tests__",
     "test:patch-core": "./scripts/test-patch-core.sh",
     "build:harmony-har": "node scripts/build-harmony-har.js",
+    "build:harmony-e2e": "bash Example/e2etest/scripts/build-harmony-e2e.sh",
     "build:so": "bun submodule && bash scripts/build-android-so.sh",
     "build:ios-debug": "cd Example/e2etest && bun && detox build --configuration ios.sim.debug",
     "build:ios-release": "cd Example/e2etest && bun && detox build --configuration ios.sim.release",