react-native-unistyles 3.0.0-beta.6 → 3.0.0-beta.8

package/README.md

@@ -18,6 +18,19 @@
 yarn add react-native-unistyles@beta
 ```
 
+Install dependencies:
+
+```shell
+yarn add react-native-edge-to-edge react-native-nitro-modules@0.22.1
+```
+
+> Always use fixed version of `react-native-nitro-modules` to avoid unexpected behaviors.
+
+| react-native-unistyles | react-native-nitro-modules |
+|------------------------|----------------------------|
+| 3.0.0.beta.7           | 0.22.1                     |
+| 3.0.0.nightly-20250226 | 0.24.1                     |
+
 Then follow [installation guides](https://unistyl.es/v3/start/getting-started) for your platform.
 
 ## [Documentation](https://unistyl.es/)
@@ -74,6 +87,12 @@ Then follow [installation guides](https://unistyl.es/v3/start/getting-started) f
 <a href="https://github.com/4cc3ssX">
      <img src="https://avatars.githubusercontent.com/u/57473799?v=4" height="70px" width="70px" alt="4cc3ssX" />
 </a>
+<a href="https://github.com/dacoto97">
+     <img src="https://avatars.githubusercontent.com/u/16915053?v=4" height="70px" width="70px" alt="dacoto97" />
+</a>
+<a href="https://github.com/chinamcafee">
+     <img src="https://avatars.githubusercontent.com/u/3439961?v=4" height="70px" width="70px" alt="chinamcafee" />
+</a>
 
 ## Past sponsors
 

package/android/CMakeLists.txt

@@ -23,7 +23,8 @@ include_directories(
     ../cxx/shadowTree
 )
 
-string(APPEND CMAKE_CXX_FLAGS "-DFOLLY_NO_CONFIG=1 -DFOLLY_CFG_NO_COROUTINES=1 -DFOLLY_MOBILE=1")
+# Nitro appends all Folly Flags, leaving it empty
+string(APPEND CMAKE_CXX_FLAGS " ")
 
 set_target_properties(unistyles PROPERTIES
     CXX_STANDARD 20

package/android/src/main/java/com/unistyles/NativePlatform+android.kt

@@ -6,11 +6,13 @@ import android.os.Build
 import android.util.DisplayMetrics
 import android.view.View
 import android.view.WindowManager
+import androidx.annotation.Keep
 import androidx.core.text.TextUtilsCompat
 import androidx.core.view.ViewCompat
 import androidx.core.view.WindowCompat
 import androidx.core.view.WindowInsetsCompat
 import androidx.core.view.WindowInsetsControllerCompat
+import com.facebook.proguard.annotations.DoNotStrip
 import com.facebook.react.bridge.LifecycleEventListener
 import com.facebook.react.bridge.ReactApplicationContext
 import com.margelo.nitro.unistyles.ColorScheme
@@ -22,6 +24,8 @@ import com.margelo.nitro.unistyles.UnistyleDependency
 import com.margelo.nitro.unistyles.UnistylesNativeMiniRuntime
 import java.util.Locale
 
+@Keep
+@DoNotStrip
 class NativePlatformAndroid(private val reactContext: ReactApplicationContext): HybridNativePlatformSpec(), LifecycleEventListener {
     private val _insets = NativePlatformInsets(reactContext, this::getMiniRuntime) { this.diffMiniRuntime() }
     private var _miniRuntime: UnistylesNativeMiniRuntime = buildMiniRuntime()

package/android/src/main/java/com/unistyles/NativePlatform+insets.kt

@@ -5,9 +5,11 @@ import android.os.Build
 import android.view.View
 import android.view.Window
 import android.view.WindowManager
+import androidx.annotation.Keep
 import androidx.core.view.ViewCompat
 import androidx.core.view.WindowInsetsAnimationCompat
 import androidx.core.view.WindowInsetsCompat
+import com.facebook.proguard.annotations.DoNotStrip
 import com.facebook.react.bridge.ReactApplicationContext
 import com.margelo.nitro.unistyles.Insets
 import com.margelo.nitro.unistyles.UnistyleDependency
@@ -15,14 +17,28 @@ import com.margelo.nitro.unistyles.UnistylesNativeMiniRuntime
 
 typealias CxxImeListener = (miniRuntime: UnistylesNativeMiniRuntime) -> Unit
 
+@Keep
+@DoNotStrip
 class NativePlatformInsets(
     private val reactContext: ReactApplicationContext,
     private val getMiniRuntime: () -> UnistylesNativeMiniRuntime,
     private val diffMiniRuntime: () -> Array<UnistyleDependency>
 ) {
+    private var _shouldListenToImeEvents = false
     private val _imeListeners: MutableList<CxxImeListener> = mutableListOf()
     private var _insets: Insets = Insets(0.0, 0.0, 0.0, 0.0, 0.0)
 
+    init {
+        // get initial insets
+        reactContext.currentActivity?.let { activity ->
+            val insets = ViewCompat.getRootWindowInsets(activity.window.decorView)
+
+            insets?.let { windowInsets ->
+                setInsets(windowInsets, activity.window, null, true)
+            }
+        }
+    }
+
     fun onDestroy() {
         this.removeImeListeners()
     }
@@ -39,7 +55,7 @@ class NativePlatformInsets(
         )
     }
 
-    fun setInsets(insetsCompat: WindowInsetsCompat, window: Window, animatedBottomInsets: Double?) {
+    fun setInsets(insetsCompat: WindowInsetsCompat, window: Window, animatedBottomInsets: Double?, skipUpdate: Boolean = false) {
         // below Android 11, we need to use window flags to detect status bar visibility
         val isStatusBarVisible = when(Build.VERSION.SDK_INT) {
             in 30..Int.MAX_VALUE -> {
@@ -86,6 +102,10 @@ class NativePlatformInsets(
             imeInsets
         )
 
+        if (skipUpdate) {
+            return
+        }
+
         diffMiniRuntime()
 
         if (shouldEmitImeEvent) {
@@ -94,6 +114,8 @@ class NativePlatformInsets(
     }
 
     fun startInsetsListener() {
+        _shouldListenToImeEvents = true
+
         reactContext.currentActivity?.let { activity ->
             activity.findViewById<View>(android.R.id.content)?.let { mainView ->
                 ViewCompat.setOnApplyWindowInsetsListener(mainView) { _, insets ->
@@ -111,6 +133,10 @@ class NativePlatformInsets(
                                 insets: WindowInsetsCompat,
                                 runningAnimations: List<WindowInsetsAnimationCompat>
                             ): WindowInsetsCompat {
+                                if (!_shouldListenToImeEvents) {
+                                    return insets
+                                }
+
                                 runningAnimations.firstOrNull()?.let {
                                     val bottomInset = insets.getInsets(WindowInsetsCompat.Type.ime()).bottom.toDouble() - this@NativePlatformInsets._insets.bottom
                                     val nextBottomInset = if (bottomInset < 0) {
@@ -141,9 +167,10 @@ class NativePlatformInsets(
         reactContext.currentActivity?.let { activity ->
             activity.window?.decorView?.let { view ->
                 ViewCompat.setOnApplyWindowInsetsListener(view, null)
-                ViewCompat.setWindowInsetsAnimationCallback(view, null)
             }
         }
+
+        _shouldListenToImeEvents = false
     }
 
     fun addImeListener(listener: CxxImeListener) {

package/android/src/main/java/com/unistyles/NativePlatform+listener.kt

@@ -6,12 +6,16 @@ import android.content.Intent
 import android.content.IntentFilter
 import android.os.Handler
 import android.os.Looper
+import androidx.annotation.Keep
+import com.facebook.proguard.annotations.DoNotStrip
 import com.facebook.react.bridge.ReactApplicationContext
 import com.margelo.nitro.unistyles.UnistyleDependency
 import com.margelo.nitro.unistyles.UnistylesNativeMiniRuntime
 
 typealias CxxDependencyListener = (dependencies: Array<UnistyleDependency>, miniRuntime: UnistylesNativeMiniRuntime) -> Unit
 
+@Keep
+@DoNotStrip
 class NativePlatformListener(
     private val reactContext: ReactApplicationContext,
     private val getMiniRuntime: () -> UnistylesNativeMiniRuntime,

package/android/src/main/java/com/unistyles/UnistylesModule.kt

@@ -11,6 +11,7 @@ import com.facebook.react.turbomodule.core.interfaces.TurboModuleWithJSIBindings
 import com.facebook.react.uimanager.UIManagerHelper
 import com.facebook.react.uimanager.common.UIManagerType
 import com.margelo.nitro.unistyles.HybridNativePlatformSpec
+import com.margelo.nitro.unistyles.unistylesOnLoad.Companion.initializeNative
 
 @Suppress("KotlinJniMissingFunction")
 class UnistylesModule(reactContext: ReactApplicationContext): NativeTurboUnistylesSpec(reactContext), TurboModuleWithJSIBindings {
@@ -20,6 +21,10 @@ class UnistylesModule(reactContext: ReactApplicationContext): NativeTurboUnistyl
 
     companion object {
         const val NAME = NativeTurboUnistylesSpec.NAME
+
+        init {
+            initializeNative()
+        }
     }
 
     init {

package/cxx/common/Helpers.h

@@ -225,4 +225,89 @@ inline static jsi::Array dependenciesToJSIArray(jsi::Runtime& rt, const std::vec
     return result;
 }
 
+inline void debugPrintJSIObject(jsi::Runtime& rt, std::string& name, jsi::Object& obj) {
+    auto console = rt.global().getPropertyAsObject(rt, "console");
+    auto log = console.getPropertyAsFunction(rt, "log");
+    auto parser = [&](const std::string& key, jsi::Value& value){
+        if (value.isBool()) {
+            std::string output = key + ": " + (value.getBool() ? "true" : "false");
+            log.call(rt, output);
+
+            return;
+        }
+
+        if (value.isNumber()) {
+            std::string output = key + ": " + std::to_string(value.getNumber());
+            log.call(rt, output);
+
+            return;
+        }
+
+        if (value.isString()) {
+            std::string output = key + ": " + value.getString(rt).utf8(rt);
+            log.call(rt, output);
+
+            return;
+        }
+
+        if (value.isUndefined()) {
+            std::string output = key + ": undefined";
+            log.call(rt, output);
+
+            return;
+        }
+
+        if (value.isNull()) {
+            std::string output = key + ": null";
+            log.call(rt, output);
+
+            return;
+        }
+    };
+
+    log.call(rt, "===" + name + "===");
+
+    enumerateJSIObject(rt, obj, [&](const std::string& key, jsi::Value& value){
+        if (value.isObject()) {
+            if (value.asObject(rt).isArray(rt)) {
+                iterateJSIArray(rt, value.asObject(rt).asArray(rt), [&](size_t i, jsi::Value& nestedValue){
+                    std::string printableKey = key + ": Array[" + std::to_string(i) + "]";
+
+                    log.call(rt, printableKey);
+
+                    if (nestedValue.isObject()) {
+                        enumerateJSIObject(rt, nestedValue.asObject(rt), [&](const std::string& nestedKey, jsi::Value& nestedValue){
+                            parser(nestedKey, nestedValue);
+                        });
+                    } else {
+                        parser(printableKey, nestedValue);
+                    }
+
+                    std::string endKey = key + ": Array[end]";
+
+                    log.call(rt, endKey);
+                });
+            }
+
+            if (value.asObject(rt).isFunction(rt)) {
+                std::string output = key + ": [Function]";
+
+                log.call(rt, output);
+
+                return;
+            }
+
+            enumerateJSIObject(rt, value.asObject(rt), [&](const std::string& nestedKey, jsi::Value& nestedValue){
+                parser(nestedKey, nestedValue);
+            });
+
+            return;
+        }
+
+        parser(key, value);
+    });
+
+    log.call(rt, "===/" + name + "===");
+}
+
 }

package/cxx/core/HashGenerator.cpp

@@ -17,7 +17,7 @@ std::string HashGenerator::generateHash(const std::string& input) {
     std::stringstream ss;
     ss << std::hex << std::setfill('0') << std::setw(8) << (combinedHash & 0xFFFFFFFF);
 
-    return "unistyles-" + ss.str();
+    return "unistyles_" + ss.str();
 }
 
 }

package/cxx/core/HostUnistyle.cpp

@@ -39,14 +39,40 @@ jsi::Value HostUnistyle::get(jsi::Runtime& rt, const jsi::PropNameID& propNameId
     auto& unistyle = this->_stylesheet->unistyles[propertyName];
 
     // check if Unistyles recomputed new style in the background
-    // ()when no node was mounted), if so we need to simply rebuild unistyle to get fresh data
+    // (when no node was mounted), if so we need to simply rebuild unistyle to get fresh data
     if (unistyle->isDirty) {
+        this->_cache.erase(propertyName);
+
         auto parser = parser::Parser(this->_unistylesRuntime);
 
         parser.rebuildUnistyle(rt, unistyle, this->_variants, std::nullopt);
     }
 
-    return valueFromUnistyle(rt, this->_unistylesRuntime, this->_stylesheet->unistyles[propertyName], this->_variants);
+    if (unistyle->type == UnistyleType::DynamicFunction) {
+        // for dynamic functions we will also bind "this"
+        auto styleFn = valueFromUnistyle(rt, this->_unistylesRuntime, unistyle, this->_variants);
+
+        // construct newThis
+        jsi::Object newThis = jsi::Object(rt);
+        newThis.setProperty(rt, helpers::STYLESHEET_VARIANTS.c_str(), helpers::variantsToValue(rt, this->_variants));
+
+        auto functionPrototype = rt.global()
+            .getPropertyAsObject(rt, "Function")
+            .getPropertyAsObject(rt, "prototype")
+            .getPropertyAsFunction(rt, "bind");
+
+        return functionPrototype.callWithThis(rt, styleFn.asObject(rt), newThis);
+    }
+
+    if (this->_cache.contains(propertyName)) {
+        return jsi::Value(rt, this->_cache[propertyName]);
+    }
+
+    auto style = valueFromUnistyle(rt, this->_unistylesRuntime, unistyle, this->_variants);
+
+    this->_cache.emplace(propertyName, jsi::Value(rt, style));
+
+    return style;
 }
 
 void HostUnistyle::set(jsi::Runtime& rt, const jsi::PropNameID& propNameId, const jsi::Value& value) {}
@@ -73,8 +99,6 @@ jsi::Function HostUnistyle::createAddVariantsProxyFunction(jsi::Runtime& rt) {
             }
         });
 
-        this->_variants = variants;
-
         auto style = std::make_shared<core::HostUnistyle>(this->_stylesheet, this->_unistylesRuntime, variants);
         auto styleHostObject = jsi::Object::createFromHostObject(rt, style);
 

package/cxx/core/HostUnistyle.h

@@ -22,6 +22,7 @@ private:
     Variants _variants;
     std::shared_ptr<StyleSheet> _stylesheet;
     std::shared_ptr<HybridUnistylesRuntime> _unistylesRuntime;
+    std::unordered_map<std::string, jsi::Value> _cache;
 };
 
 }

package/cxx/core/UnistyleWrapper.h

@@ -35,7 +35,7 @@ inline static Unistyle::Shared unistyleFromStaticStyleSheet(jsi::Runtime& rt, js
 
 inline static std::vector<std::string> getUnistylesHashKeys(jsi::Runtime& rt, jsi::Object& object) {
     std::vector<std::string> matchingKeys{};
-    const std::string prefix = "unistyles-";
+    const std::string prefix = "unistyles_";
 
     auto propertyNames = object.getPropertyNames(rt);
     size_t length = propertyNames.length(rt);
@@ -82,13 +82,13 @@ inline static std::vector<Unistyle::Shared> unistylesFromNonExistentNativeState(
 
 You likely altered unistyle hash key and we're not able to recover C++ state attached to this node.)");
     }
-    
+
     // someone merged unistyles, and will be warned in JS
     // the best we can do is to return first unistyle
     if (unistyles.size() > 1) {
         return {unistyles.at(0)};
     }
-    
+
     return unistyles;
 }
 
@@ -137,7 +137,7 @@ inline static jsi::Value objectFromUnistyle(jsi::Runtime& rt, std::shared_ptr<Hy
     auto parsedArguments = arguments.has_value()
         ? helpers::parseDynamicFunctionArguments(rt, arguments.value())
         : std::optional<std::vector<folly::dynamic>>{};
-    
+
     if (arguments.has_value()) {
         // this is required for HybridShadowRegistry::link
         helpers::defineHiddenProperty(rt, secrets, helpers::ARGUMENTS.c_str(), arguments.value());
@@ -148,7 +148,7 @@ inline static jsi::Value objectFromUnistyle(jsi::Runtime& rt, std::shared_ptr<Hy
 
     // this is required for withUnistyles
     helpers::defineHiddenProperty(rt, secrets, helpers::STYLE_DEPENDENCIES.c_str(), helpers::dependenciesToJSIArray(rt, unistyle->dependencies));
-    
+
     // this is required for withUnistyles
     auto hostFn = jsi::Function::createFromHostFunction(
         rt,
@@ -160,7 +160,7 @@ inline static jsi::Value objectFromUnistyle(jsi::Runtime& rt, std::shared_ptr<Hy
 
         return jsi::Value(rt, unistyle->parsedStyle.value()).asObject(rt);
     });
-    
+
     helpers::defineHiddenProperty(rt, secrets, helpers::GET_STYLES.c_str(), std::move(hostFn));
 
     obj.setProperty(rt, unistyleID, secrets);

package/cxx/core/UnistylesCommitHook.cpp

@@ -29,21 +29,24 @@ RootShadowNode::Unshared core::UnistylesCommitHook::shadowTreeWillCommit(
     // this is React Native / Reanimated commit
     // merge Unistyles updates before it completes
     auto& registry = core::UnistylesRegistry::get();
-    auto& shadowLeafUpdates = registry.trafficController.getUpdates();
-
-    // oops, no updates from Unistyles yet, skip it!
-    if (shadowLeafUpdates.size() == 0) {
-        return newRootShadowNode;
-    }
-
-    auto affectedNodes = shadow::ShadowTreeManager::findAffectedNodes(*rootNode, shadowLeafUpdates);
-
-    registry.trafficController.stopUnistylesTraffic();
-
-    // we have few updates, so merge it
-    return std::static_pointer_cast<RootShadowNode>(shadow::ShadowTreeManager::cloneShadowTree(
-        *rootNode,
-        shadowLeafUpdates,
-        affectedNodes
-    ));
+    
+    return registry.trafficController.withLock([&](){
+        auto& shadowLeafUpdates = registry.trafficController.getUpdates();
+
+        // oops, no updates from Unistyles yet, skip it!
+        if (shadowLeafUpdates.size() == 0) {
+            return newRootShadowNode;
+        }
+
+        auto affectedNodes = shadow::ShadowTreeManager::findAffectedNodes(*rootNode, shadowLeafUpdates);
+
+        registry.trafficController.stopUnistylesTraffic();
+        
+        // we have few updates, so merge it
+        return std::static_pointer_cast<RootShadowNode>(shadow::ShadowTreeManager::cloneShadowTree(
+            *rootNode,
+            shadowLeafUpdates,
+            affectedNodes
+        ));
+    });
 }

package/cxx/core/UnistylesMountHook.cpp

@@ -22,7 +22,7 @@ void core::UnistylesMountHook::shadowTreeDidMount(RootShadowNode::Shared const &
     // one more time merge Unistyles changes
     auto& registry = core::UnistylesRegistry::get();
 
-    if (!registry.trafficController.shouldStop()) {
-        shadow::ShadowTreeManager::updateShadowTree(this->_uiManager->getShadowTreeRegistry());
+    if (registry.trafficController.shouldStop()) {
+        registry.trafficController.resumeUnistylesTraffic();
     }
 }

package/cxx/core/UnistylesMountHook.h

@@ -3,15 +3,13 @@
 #include <react/renderer/uimanager/UIManager.h>
 #include <react/renderer/uimanager/UIManagerMountHook.h>
 #include "ShadowTreeManager.h"
-#include "HybridUnistylesRuntime.h"
 
 namespace margelo::nitro::unistyles::core {
 
 using namespace facebook::react;
 
 struct UnistylesMountHook : public UIManagerMountHook {
-    UnistylesMountHook(std::shared_ptr<UIManager> uiManager, std::shared_ptr<HybridUnistylesRuntime> unistylesRuntime)
-        : _uiManager{uiManager}, _unistylesRuntime{unistylesRuntime} {
+    UnistylesMountHook(std::shared_ptr<UIManager> uiManager): _uiManager{uiManager} {
         _uiManager->registerMountHook(*this);
     }
 
@@ -21,7 +19,6 @@ struct UnistylesMountHook : public UIManagerMountHook {
 
 private:
     std::shared_ptr<UIManager> _uiManager;
-    std::shared_ptr<HybridUnistylesRuntime> _unistylesRuntime;
 };
 
 }

package/cxx/core/UnistylesRegistry.cpp

@@ -108,12 +108,14 @@ void core::UnistylesRegistry::removeDuplicatedUnistyles(jsi::Runtime& rt, const
 }
 
 void core::UnistylesRegistry::unlinkShadowNodeWithUnistyles(jsi::Runtime& rt, const ShadowNodeFamily* shadowNodeFamily) {
-    this->_shadowRegistry[&rt].erase(shadowNodeFamily);
-    this->trafficController.removeShadowNode(shadowNodeFamily);
-
-    if (this->_shadowRegistry[&rt].empty()) {
-        this->_shadowRegistry.erase(&rt);
-    }
+    this->trafficController.withLock([this, &rt, shadowNodeFamily](){
+        this->_shadowRegistry[&rt].erase(shadowNodeFamily);
+        this->trafficController.removeShadowNode(shadowNodeFamily);
+        
+        if (this->_shadowRegistry[&rt].empty()) {
+            this->_shadowRegistry.erase(&rt);
+        }
+    });
 }
 
 std::shared_ptr<core::StyleSheet> core::UnistylesRegistry::addStyleSheet(jsi::Runtime& rt, int unid, core::StyleSheetType type, jsi::Object&& rawValue) {

package/cxx/hybridObjects/HybridShadowRegistry.cpp

@@ -49,7 +49,6 @@ jsi::Value HybridShadowRegistry::link(jsi::Runtime &rt, const jsi::Value &thisVa
     }
 
     auto parser = parser::Parser(this->_unistylesRuntime);
-    auto parsedStyleSheet = jsi::Value::undefined();
     std::vector<std::shared_ptr<core::UnistyleData>> unistylesData{};
 
     // create unistyleData based on wrappers
@@ -77,10 +76,8 @@ jsi::Value HybridShadowRegistry::link(jsi::Runtime &rt, const jsi::Value &thisVa
         );
 
         // before linking we need to check if given unistyle is affected by scoped theme
-        if (scopedTheme.has_value()) {
-            if (parsedStyleSheet.isUndefined()) {
-                parsedStyleSheet = parser.getParsedStyleSheetForScopedTheme(rt, unistyle, scopedTheme.value());
-            }
+        if (scopedTheme.has_value() && unistyle->styleKey != helpers::EXOTIC_STYLE_KEY) {
+            auto parsedStyleSheet = parser.getParsedStyleSheetForScopedTheme(rt, unistyle, scopedTheme.value());
 
             // if so we need to force update
             parser.rebuildUnistyleWithScopedTheme(rt, parsedStyleSheet, unistyleData);

package/cxx/hybridObjects/HybridStyleSheet.cpp

@@ -261,7 +261,7 @@ void HybridStyleSheet::registerHooks(jsi::Runtime& rt) {
     core::UnistylesRegistry::get().trafficController.restore();
 
     this->_unistylesCommitHook = std::make_shared<core::UnistylesCommitHook>(this->_uiManager);
-    this->_unistylesMountHook = std::make_shared<core::UnistylesMountHook>(this->_uiManager, this->_unistylesRuntime);
+    this->_unistylesMountHook = std::make_shared<core::UnistylesMountHook>(this->_uiManager);
 }
 
 void HybridStyleSheet::onPlatformDependenciesChange(std::vector<UnistyleDependency> dependencies) {

package/cxx/hybridObjects/HybridUnistylesRuntime.cpp

@@ -73,9 +73,13 @@ void HybridUnistylesRuntime::setTheme(const std::string &themeName) {
     helpers::assertThat(*_rt, !this->getHasAdaptiveThemes(), "Unistyles: You're trying to set theme to: '" + themeName + "', but adaptiveThemes are enabled.");
 
     auto& state = core::UnistylesRegistry::get().getState(*_rt);
+    auto currentThemeName = state.getCurrentThemeName();
 
     state.setTheme(themeName);
-    this->_onDependenciesChange({UnistyleDependency::THEME, UnistyleDependency::THEMENAME});
+
+    if (currentThemeName.value() != themeName) {
+        this->_onDependenciesChange({UnistyleDependency::THEME, UnistyleDependency::THEMENAME});
+    }
 };
 
 void HybridUnistylesRuntime::setAdaptiveThemes(bool isEnabled) {