react-native-unistyles 3.0.0-alpha.1 → 3.0.0-alpha.10

package/Unistyles.podspec

@@ -0,0 +1,33 @@
+require "json"
+
+package = JSON.parse(File.read(File.join(__dir__, "package.json")))
+
+Pod::Spec.new do |s|
+  s.name         = "Unistyles"
+  s.version      = package["version"]
+  s.summary      = package["description"]
+  s.homepage     = package["homepage"]
+  s.license      = package["license"]
+  s.authors      = package["author"]
+
+  s.platforms    = { :ios => min_ios_version_supported }
+  s.source       = { :git => package["repository"], :tag => "#{s.version}" }
+
+  s.source_files = [
+    "ios/**/*.{swift,h,mm}",
+    "cxx/**/*.{h,cpp,hpp}"
+  ]
+  s.pod_target_xcconfig = {
+    "CLANG_CXX_LANGUAGE_STANDARD" => "c++20",
+    "GCC_PREPROCESSOR_DEFINITIONS" => "$(inherited) FOLLY_NO_CONFIG FOLLY_CFG_NO_COROUTINES"
+  }
+
+  s.public_header_files = [
+    "ios/Unistyles.h"
+  ]
+
+  load 'nitrogen/generated/ios/Unistyles+autolinking.rb'
+  add_nitrogen_files(s)
+
+  install_modules_dependencies(s)
+end

package/cxx/common/Constants.h

@@ -5,6 +5,7 @@ namespace margelo::nitro::unistyles::helpers {
 static const std::string UNISTYLES_ID = "__unid";
 static const std::string ADD_VARIANTS_FN = "useVariants";
 static const std::string STYLE_DEPENDENCIES = "uni__dependencies";
+static const std::string STYLE_VARIANTS = "uni__variants";
 static const std::string WEB_STYLE_KEY = "_web";
 
 }

package/cxx/common/Helpers.h

@@ -1,12 +1,16 @@
 #pragma once
 
 #include <jsi/jsi.h>
+#include <jsi/JSIDynamic.h>
+#include <folly/dynamic.h>
 #include <unordered_set>
 
 using namespace facebook;
 
 namespace margelo::nitro::unistyles::helpers {
 
+using Variants = std::vector<std::pair<std::string, std::string>>;
+
 inline void assertThat(jsi::Runtime& rt, bool condition, const std::string& message) {
     if (!condition) {
         throw jsi::JSError(rt, message);
@@ -90,4 +94,92 @@ inline bool isPlatformColor(jsi::Runtime& rt, jsi::Object& maybePlatformColor) {
     return maybePlatformColor.hasProperty(rt, "resource_paths") && maybePlatformColor.getProperty(rt, "resource_paths").isObject();
 }
 
+inline Variants variantsToPairs(jsi::Runtime& rt, jsi::Object&& variants) {
+    Variants pairs{};
+
+    helpers::enumerateJSIObject(rt, variants, [&](const std::string& variantName, jsi::Value& variantValue){
+        if (variantValue.isUndefined() || variantValue.isNull()) {
+            return;
+        }
+
+        if (variantValue.isBool()) {
+            pairs.emplace_back(std::make_pair(variantName, variantValue.asBool() ? "true" : "false"));
+
+            return;
+        }
+
+        if (variantValue.isString()) {
+            pairs.emplace_back(std::make_pair(variantName, variantValue.asString(rt).utf8(rt)));
+        }
+    });
+
+    return pairs;
+}
+
+inline jsi::Object variantsToValue(jsi::Runtime& rt, Variants& variants) {
+    jsi::Object rawVariants = jsi::Object(rt);
+    
+    std::for_each(variants.begin(), variants.end(), [&](std::pair<std::string, std::string>& pair){
+        rawVariants.setProperty(rt, pair.first.c_str(), jsi::String::createFromUtf8(rt, pair.second));
+    });
+    
+    return rawVariants;
+}
+
+inline std::vector<folly::dynamic> parseDynamicFunctionArguments(jsi::Runtime& rt, jsi::Array& arguments) {
+    std::vector<folly::dynamic> parsedArgument{};
+    size_t count = arguments.size(rt);
+
+    parsedArgument.reserve(count);
+
+    for (size_t i = 0; i < count; i++) {
+        jsi::Value arg = arguments.getValueAtIndex(rt, i);
+
+        if (arg.isBool()) {
+            parsedArgument.push_back(folly::dynamic(arg.asBool()));
+
+            continue;
+        }
+
+        if (arg.isNumber()) {
+            parsedArgument.push_back(folly::dynamic(arg.asNumber()));
+
+            continue;
+        }
+
+        if (arg.isString()) {
+            parsedArgument.push_back(folly::dynamic(arg.asString(rt).utf8(rt)));
+
+            continue;
+        }
+
+        if (arg.isUndefined()) {
+            parsedArgument.push_back(folly::dynamic());
+
+            continue;
+        }
+
+        if (arg.isNull()) {
+            parsedArgument.push_back(folly::dynamic(nullptr));
+
+            continue;
+        }
+
+        if (!arg.isObject()) {
+            continue;;
+        }
+
+        auto argObj = arg.asObject(rt);
+
+        // allow arrays and objects too
+        if (!argObj.isFunction(rt) && !argObj.isArrayBuffer(rt)) {
+            parsedArgument.push_back(jsi::dynamicFromValue(rt, arg));
+
+            continue;
+        }
+    }
+
+    return parsedArgument;
+}
+
 }

package/cxx/core/HostStyle.cpp

@@ -7,10 +7,12 @@ using namespace facebook;
 std::vector<jsi::PropNameID> HostStyle::getPropertyNames(jsi::Runtime& rt) {
     auto propertyNames = std::vector<jsi::PropNameID> {};
 
+    propertyNames.reserve(8);
+
     for (const auto& pair : this->_styleSheet->unistyles) {
         propertyNames.emplace_back(jsi::PropNameID::forUtf8(rt, pair.first));
     }
-    
+
     return propertyNames;
 }
 
@@ -20,7 +22,7 @@ jsi::Value HostStyle::get(jsi::Runtime& rt, const jsi::PropNameID& propNameId) {
     if (propertyName == helpers::UNISTYLES_ID) {
         return jsi::Value(this->_styleSheet->tag);
     }
-    
+
     if (propertyName == helpers::ADD_VARIANTS_FN) {
         return this->createAddVariantsProxyFunction(rt);
     }
@@ -29,6 +31,10 @@ jsi::Value HostStyle::get(jsi::Runtime& rt, const jsi::PropNameID& propNameId) {
         return valueFromUnistyle(rt, this->_styleSheet->unistyles[propertyName]);
     }
     
+    if (propertyName == helpers::STYLE_VARIANTS) {
+        return helpers::variantsToValue(rt, this->_variants);
+    }
+
     return jsi::Value::undefined();
 }
 
@@ -36,20 +42,20 @@ jsi::Function HostStyle::createAddVariantsProxyFunction(jsi::Runtime& rt) {
     auto useVariantsFnName = jsi::PropNameID::forUtf8(rt, helpers::ADD_VARIANTS_FN);
 
     return jsi::Function::createFromHostFunction(rt, useVariantsFnName, 1, [&](jsi::Runtime &rt, const jsi::Value &thisVal, const jsi::Value *arguments, size_t count){
-        helpers::assertThat(rt, count == 1, "useVariants expected to be called with one argument.");
-        helpers::assertThat(rt, arguments[0].isObject(), "useVariants expected to be called with object.");
+        helpers::assertThat(rt, count == 1, "Unistyles: useVariants expected to be called with one argument.");
+        helpers::assertThat(rt, arguments[0].isObject(), "Unistyles: useVariants expected to be called with object.");
 
         auto parser = parser::Parser(this->_unistylesRuntime);
-        auto pairs = parser.variantsToPairs(rt, arguments[0].asObject(rt));
-        
-        if (pairs == this->_styleSheet->variants) {
+        auto pairs = helpers::variantsToPairs(rt, arguments[0].asObject(rt));
+
+        if (pairs == this->_variants) {
             return jsi::Value::undefined();
         }
-        
-        this->_styleSheet->variants = pairs;
-        
-        parser.rebuildUnistylesWithVariants(rt, this->_styleSheet);
-        
+
+        this->_variants = pairs;
+
+        parser.rebuildUnistylesWithVariants(rt, this->_styleSheet, this->_variants);
+
         return jsi::Value::undefined();
     });
 }

package/cxx/core/HostStyle.h

@@ -8,6 +8,8 @@
 
 namespace margelo::nitro::unistyles::core {
 
+using Variants = std::vector<std::pair<std::string, std::string>>;
+
 struct JSI_EXPORT HostStyle : public jsi::HostObject {
     HostStyle(std::shared_ptr<StyleSheet> styleSheet, std::shared_ptr<HybridUnistylesRuntime> unistylesRuntime)
         : _styleSheet{styleSheet}, _unistylesRuntime{unistylesRuntime} {};
@@ -20,6 +22,7 @@ struct JSI_EXPORT HostStyle : public jsi::HostObject {
 private:
     std::shared_ptr<StyleSheet> _styleSheet;
     std::shared_ptr<HybridUnistylesRuntime> _unistylesRuntime;
+    std::vector<std::pair<std::string, std::string>> _variants{};    
 };
 
 }

package/cxx/core/StyleSheet.h

@@ -26,7 +26,6 @@ struct StyleSheet {
     StyleSheetType type;
     jsi::Object rawValue;
     std::unordered_map<std::string, Unistyle::Shared> unistyles{};
-    std::vector<std::pair<std::string, std::string>> variants{};
 };
 
 }

package/cxx/core/StyleSheetRegistry.cpp

@@ -4,20 +4,18 @@
 using namespace margelo::nitro::unistyles::core;
 using namespace facebook;
 
-std::shared_ptr<StyleSheet> StyleSheetRegistry::addStyleSheetFromValue(jsi::Runtime& rt, jsi::Object rawStyleSheet) {
-    static unsigned int tag = 0;
-
+std::shared_ptr<StyleSheet> StyleSheetRegistry::addStyleSheetFromValue(jsi::Runtime& rt, jsi::Object rawStyleSheet, int unid) {
     if (rawStyleSheet.isFunction(rt)) {
-        return this->addFromFunction(rt, ++tag, rawStyleSheet.asFunction(rt));
+        return this->addFromFunction(rt, unid, rawStyleSheet.asFunction(rt));
     }
 
-    return this->addFromObject(rt, ++tag, std::move(rawStyleSheet));
+    return this->addFromObject(rt, unid, std::move(rawStyleSheet));
 }
 
-std::shared_ptr<StyleSheet> StyleSheetRegistry::addFromFunction(jsi::Runtime& rt, unsigned int tag, jsi::Function styleSheetFn) {
+std::shared_ptr<StyleSheet> StyleSheetRegistry::addFromFunction(jsi::Runtime& rt, int unid, jsi::Function styleSheetFn) {
     auto numberOfArgs = styleSheetFn.getProperty(rt, "length").getNumber();
 
-    helpers::assertThat(rt, numberOfArgs <= 2, "expected up to 2 arguments.");
+    helpers::assertThat(rt, numberOfArgs <= 2, "StyleSheet.create expected up to 2 arguments.");
     
     auto& registry = UnistylesRegistry::get();
 
@@ -25,21 +23,20 @@ std::shared_ptr<StyleSheet> StyleSheetRegistry::addFromFunction(jsi::Runtime& rt
     if (numberOfArgs == 0) {
         auto staticStyleSheet = styleSheetFn.call(rt).asObject(rt);
 
-        return registry.addStyleSheet(tag, core::StyleSheetType::Static, std::move(staticStyleSheet));
+        return registry.addStyleSheet(rt, unid, core::StyleSheetType::Static, std::move(staticStyleSheet));
     }
 
     // stylesheet depends only on theme
     if (numberOfArgs == 1) {
-        return registry.addStyleSheet(tag, core::StyleSheetType::Themable, std::move(styleSheetFn));
+        return registry.addStyleSheet(rt, unid, core::StyleSheetType::Themable, std::move(styleSheetFn));
     }
 
     // stylesheet depends on theme and mini runtime
-    return registry.addStyleSheet(tag, core::StyleSheetType::ThemableWithMiniRuntime, std::move(styleSheetFn));
+    return registry.addStyleSheet(rt, unid, core::StyleSheetType::ThemableWithMiniRuntime, std::move(styleSheetFn));
 }
 
-std::shared_ptr<StyleSheet> StyleSheetRegistry::addFromObject(jsi::Runtime& rt, unsigned int tag, jsi::Object rawStyleSheet) {
+std::shared_ptr<StyleSheet> StyleSheetRegistry::addFromObject(jsi::Runtime& rt, int tag, jsi::Object rawStyleSheet) {
     auto& registry = UnistylesRegistry::get();
     
-    return registry.addStyleSheet(tag, core::StyleSheetType::Static, std::move(rawStyleSheet));
+    return registry.addStyleSheet(rt, tag, core::StyleSheetType::Static, std::move(rawStyleSheet));
 }
-

package/cxx/core/StyleSheetRegistry.h

@@ -16,11 +16,11 @@ struct StyleSheetRegistry {
     StyleSheetRegistry(const StyleSheetRegistry&) = delete;
     StyleSheetRegistry(StyleSheetRegistry&&) = delete;
 
-    virtual std::shared_ptr<StyleSheet> addStyleSheetFromValue(jsi::Runtime& rt, jsi::Object rawStyleSheet);
-
+    virtual std::shared_ptr<StyleSheet> addStyleSheetFromValue(jsi::Runtime& rt, jsi::Object rawStyleSheet, int unid);
+    
 private:
-    virtual std::shared_ptr<StyleSheet> addFromFunction(jsi::Runtime& rt, unsigned int tag, jsi::Function styleSheetFn);
-    virtual std::shared_ptr<StyleSheet> addFromObject(jsi::Runtime& rt, unsigned int tag, jsi::Object rawStyleSheet);
+    virtual std::shared_ptr<StyleSheet> addFromFunction(jsi::Runtime& rt, int unid, jsi::Function styleSheetFn);
+    virtual std::shared_ptr<StyleSheet> addFromObject(jsi::Runtime& rt, int unid, jsi::Object rawStyleSheet);
 };
 
 }

package/cxx/core/Unistyle.h

@@ -14,11 +14,6 @@ enum class UnistyleType {
     DynamicFunction
 };
 
-struct DynamicFunctionMetadata {
-    size_t count;
-    std::vector<folly::dynamic> arguments;
-};
-
 struct Unistyle {
     using Shared = std::shared_ptr<Unistyle>;
 
@@ -75,7 +70,6 @@ struct UnistyleDynamicFunction: public Unistyle {
 
     std::optional<jsi::Object> unprocessedValue;
     std::optional<jsi::Function> proxiedFunction = std::nullopt;
-    std::optional<DynamicFunctionMetadata> dynamicFunctionMetadata = std::nullopt;
 };
 
 }

package/cxx/core/UnistyleData.h

@@ -0,0 +1,23 @@
+#pragma once
+
+#include <jsi/jsi.h>
+#include "Unistyle.h"
+
+namespace margelo::nitro::unistyles::core {
+
+using Variants = std::vector<std::pair<std::string, std::string>>;
+
+struct UnistyleData {
+    UnistyleData(Unistyle::Shared unistyle, const Variants& variants, std::vector<folly::dynamic>& arguments)
+        : unistyle{unistyle}, variants(std::move(variants)), dynamicFunctionMetadata{std::move(arguments)} {}
+
+    UnistyleData(const UnistyleData&) = delete;
+    UnistyleData(UnistyleData&& other): unistyle{other.unistyle}, variants(std::move(other.variants)) {}
+
+    core::Unistyle::Shared unistyle;
+    core::Variants variants;
+    std::optional<jsi::Object> parsedStyle = std::nullopt;
+    std::optional<std::vector<folly::dynamic>> dynamicFunctionMetadata = std::nullopt;
+};
+
+}

package/cxx/core/UnistyleWrapper.h

@@ -26,24 +26,24 @@ inline static Unistyle::Shared unistyleFromValue(jsi::Runtime& rt, const jsi::Va
 
 inline static jsi::Value valueFromUnistyle(jsi::Runtime& rt, Unistyle::Shared unistyle) {
     auto wrappedUnistyle = std::make_shared<UnistyleWrapper>(unistyle);
-    
+
     if (unistyle->type == UnistyleType::Object) {
         jsi::Object obj = jsi::Object(rt);
-        
+
         obj.setNativeState(rt, std::move(wrappedUnistyle));
         helpers::defineHiddenProperty(rt, obj, helpers::UNISTYLES_ID.c_str(), unistyle->styleKey);
-        
+
         helpers::mergeJSIObjects(rt, obj, unistyle->parsedStyle.value());
-        
+
         return obj;
     }
-    
+
     auto unistyleFn = std::dynamic_pointer_cast<UnistyleDynamicFunction>(unistyle);
     auto hostFn = jsi::Value(rt, unistyleFn->proxiedFunction.value()).asObject(rt).asFunction(rt);
 
     hostFn.setNativeState(rt, std::move(wrappedUnistyle));
     hostFn.setProperty(rt, helpers::UNISTYLES_ID.c_str(), unistyleFn->styleKey);
-    
+
     return std::move(hostFn);
 }
 

package/cxx/core/UnistylesCommitHook.cpp

@@ -3,12 +3,9 @@
 using namespace margelo::nitro::unistyles;
 using namespace facebook::react;
 
-core::UnistylesCommitHook::UnistylesCommitHook(UIManager& uiManager, std::shared_ptr<HybridUnistylesRuntime> unistylesRuntime)
-    : _unistylesRuntime{unistylesRuntime} {
-        uiManager.registerCommitHook(*this);
-    };
-
-core::UnistylesCommitHook::~UnistylesCommitHook() noexcept {}
+core::UnistylesCommitHook::~UnistylesCommitHook() noexcept {
+    _uiManager->unregisterCommitHook(*this);
+}
 
 void core::UnistylesCommitHook::commitHookWasRegistered(const UIManager &uiManager) noexcept {}
 void core::UnistylesCommitHook::commitHookWasUnregistered(const UIManager &uiManager) noexcept {}
@@ -24,6 +21,7 @@ RootShadowNode::Unshared core::UnistylesCommitHook::shadowTreeWillCommit(
     // skip only unistyles commits
     if (unistylesRootNode->hasUnistylesCommitTrait()) {
         unistylesRootNode->removeUnistylesCommitTrait();
+        unistylesRootNode->addUnistylesMountTrait();
         
         return newRootShadowNode;
     }
@@ -46,8 +44,11 @@ RootShadowNode::Unshared core::UnistylesCommitHook::shadowTreeWillCommit(
 
 shadow::ShadowLeafUpdates core::UnistylesCommitHook::getUnistylesUpdates() {
     auto& registry = core::UnistylesRegistry::get();
+    auto& rt = this->_unistylesRuntime->getRuntime();
     auto parser = parser::Parser(this->_unistylesRuntime);
-    auto dependencyMap = registry.buildDependencyMap();
+    auto dependencyMap = registry.buildDependencyMap(rt);
+    
+    parser.rebuildUnistylesInDependencyMap(rt, dependencyMap);
     
     return parser.dependencyMapToShadowLeafUpdates(dependencyMap);
 }

package/cxx/core/UnistylesCommitHook.h

@@ -11,7 +11,11 @@ namespace margelo::nitro::unistyles::core {
 using namespace facebook::react;
 
 struct UnistylesCommitHook : public UIManagerCommitHook {
-    UnistylesCommitHook(UIManager& uiManager, std::shared_ptr<HybridUnistylesRuntime> unistylesRuntime);
+    UnistylesCommitHook(std::shared_ptr<UIManager> uiManager, std::shared_ptr<HybridUnistylesRuntime> unistylesRuntime)
+        : _unistylesRuntime{unistylesRuntime}, _uiManager{uiManager} {
+            _uiManager->registerCommitHook(*this);
+        }
+    
     ~UnistylesCommitHook() noexcept override;
 
     void commitHookWasRegistered(const UIManager &uiManager) noexcept override;
@@ -22,6 +26,7 @@ struct UnistylesCommitHook : public UIManagerCommitHook {
     
 private:
     std::shared_ptr<HybridUnistylesRuntime> _unistylesRuntime;
+    std::shared_ptr<UIManager> _uiManager;
 };
 
 }

package/cxx/core/UnistylesCommitShadowNode.h

@@ -8,6 +8,7 @@ namespace margelo::nitro::unistyles::core {
 // React Native uses 0-10
 // Reanimated uses 27-28
 constexpr shadow::ShadowNodeTraits::Trait UnistylesCommitTrait{1 << 30};
+constexpr shadow::ShadowNodeTraits::Trait UnistylesMountTrait{1 << 31};
 
 struct UnistylesCommitShadowNode: public shadow::ShadowNode {
     inline void addUnistylesCommitTrait() {
@@ -21,6 +22,18 @@ struct UnistylesCommitShadowNode: public shadow::ShadowNode {
     inline bool hasUnistylesCommitTrait() {
         return traits_.check(UnistylesCommitTrait);
     }
+    
+    inline void addUnistylesMountTrait() {
+        traits_.set(UnistylesMountTrait);
+    }
+    
+    inline void removeUnistylesMountTrait() {
+        traits_.unset(UnistylesMountTrait);
+    }
+    
+    inline bool hasUnistylesMountTrait() {
+        return traits_.check(UnistylesMountTrait);
+    }
 };
 
 }

package/cxx/core/UnistylesMountHook.cpp

@@ -0,0 +1,40 @@
+#include "UnistylesMountHook.h"
+#include "ShadowTreeManager.h"
+
+using namespace margelo::nitro::unistyles;
+using namespace facebook::react;
+
+core::UnistylesMountHook::~UnistylesMountHook() noexcept {
+    _uiManager->unregisterMountHook(*this);
+}
+
+void core::UnistylesMountHook::shadowTreeDidMount(RootShadowNode::Shared const &rootShadowNode, double mountTime) noexcept {
+    auto rootNode = std::const_pointer_cast<RootShadowNode>(rootShadowNode);
+    auto unistylesRootNode = std::reinterpret_pointer_cast<core::UnistylesCommitShadowNode>(rootNode);
+
+    // skip only unistyles commits
+    if (unistylesRootNode->hasUnistylesMountTrait()) {
+        unistylesRootNode->removeUnistylesMountTrait();
+
+        return;
+    }
+
+    auto shadowLeafUpdates = this->getUnistylesUpdates();
+
+    if (shadowLeafUpdates.size() == 0) {
+        return;
+    }
+
+    shadow::ShadowTreeManager::updateShadowTree(this->_unistylesRuntime->getRuntime(), shadowLeafUpdates);
+}
+
+shadow::ShadowLeafUpdates core::UnistylesMountHook::getUnistylesUpdates() {
+    auto& registry = core::UnistylesRegistry::get();
+    auto& rt = this->_unistylesRuntime->getRuntime();
+    auto parser = parser::Parser(this->_unistylesRuntime);
+    auto dependencyMap = registry.buildDependencyMap(rt);
+
+    parser.rebuildUnistylesInDependencyMap(rt, dependencyMap);
+
+    return parser.dependencyMapToShadowLeafUpdates(dependencyMap);
+}

package/cxx/core/UnistylesMountHook.h

@@ -0,0 +1,30 @@
+#pragma once
+
+#include <react/renderer/uimanager/UIManager.h>
+#include <react/renderer/uimanager/UIManagerMountHook.h>
+#include "HybridUnistylesRuntime.h"
+#include "Parser.h"
+#include "ShadowTreeManager.h"
+
+namespace margelo::nitro::unistyles::core {
+
+using namespace facebook::react;
+
+struct UnistylesMountHook : public UIManagerMountHook {
+    UnistylesMountHook(std::shared_ptr<UIManager> uiManager, std::shared_ptr<HybridUnistylesRuntime> unistylesRuntime)
+        : _unistylesRuntime{unistylesRuntime}, _uiManager{uiManager} {
+            _uiManager->registerMountHook(*this);
+        }
+
+    ~UnistylesMountHook() noexcept override;
+
+    void shadowTreeDidMount(RootShadowNode::Shared const &rootShadowNode, double mountTime) noexcept override;
+
+    shadow::ShadowLeafUpdates getUnistylesUpdates();
+
+private:
+    std::shared_ptr<HybridUnistylesRuntime> _unistylesRuntime;
+    std::shared_ptr<UIManager> _uiManager;
+};
+
+}