react-native-ui-lib 7.46.3-snapshot.7403 → 7.46.3-snapshot.7414

package/lib/ios/reactnativeuilib/keyboardtrackingview/KeyboardTrackingViewTempManager.m

@@ -173,11 +173,14 @@ typedef NS_ENUM(NSUInteger, KeyboardTrackingScrollBehavior) {
     CGFloat bottomSafeArea = [self getBottomSafeArea];
     CGFloat tabBarHeight = [self getTabBarHeight];
     CGFloat yOffset = MIN(-bottomSafeArea, -_ObservingInputAccessoryViewTemp.keyboardHeight + tabBarHeight);
+    
     if (self.frame.origin.y != yOffset) {
+        [self removeObserver:self forKeyPath:@"frame"];
         self.frame = CGRectMake(self.frame.origin.x,
                                 yOffset,
                                 self.frame.size.width,
                                 self.frame.size.height);
+        [self addObserver:self forKeyPath:@"frame" options:NSKeyValueObservingOptionNew context:NULL];
     }
     
     [self updateBottomViewFrame];
@@ -431,7 +434,9 @@ typedef NS_ENUM(NSUInteger, KeyboardTrackingScrollBehavior) {
 
 - (void)_updateScrollViewInsets
 {
-    if(self.scrollViewToManage != nil)
+    // Because our view is now being transformed inside it's superview (from RN77 it inherited a RCTLegacyViewManagerInteropComponentView as superview) we no longer need the scrollview to also update because it's inside our view
+    return;
+    /*if(self.scrollViewToManage != nil)
     {
         UIEdgeInsets insets = self.scrollViewToManage.contentInset;
         CGFloat bottomSafeArea = [self getBottomSafeArea];
@@ -441,6 +446,7 @@ typedef NS_ENUM(NSUInteger, KeyboardTrackingScrollBehavior) {
         CGPoint originalOffset = self.scrollViewToManage.contentOffset;
         
         bottomInset += (_ObservingInputAccessoryViewTemp.keyboardHeight == 0 ? bottomSafeArea : 0);
+        
         if(self.scrollIsInverted)
         {
             insets.top = bottomInset;
@@ -477,7 +483,7 @@ typedef NS_ENUM(NSUInteger, KeyboardTrackingScrollBehavior) {
             insets.bottom = bottomInset;
         }
         self.scrollViewToManage.scrollIndicatorInsets = insets;
-    }
+    }*/
 }
 
 #pragma mark - bottom view
@@ -590,7 +596,11 @@ typedef NS_ENUM(NSUInteger, KeyboardTrackingScrollBehavior) {
     }
     [self updateBottomViewFrame];
     
-    self.transform = CGAffineTransformMakeTranslation(0, accessoryTranslation);
+    CGAffineTransform oldTransform = self.transform;
+    CGAffineTransform newTransform = CGAffineTransformMakeTranslation(0, accessoryTranslation);
+    if (oldTransform.tx != newTransform.tx || oldTransform.ty != newTransform.ty) {
+        self.transform = CGAffineTransformMakeTranslation(0, accessoryTranslation);
+    }
     
     [self _updateScrollViewInsets];
 }

package/lib/package.json

@@ -1,6 +1,6 @@
 {
   "name": "uilib-native",
-  "version": "5.0.0-snapshot.7403",
+  "version": "5.0.0-snapshot.7414",
   "homepage": "https://github.com/wix/react-native-ui-lib",
   "description": "uilib native components (separated from js components)",
   "main": "components/index",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "react-native-ui-lib",
-  "version": "7.46.3-snapshot.7403",
+  "version": "7.46.3-snapshot.7414",
   "main": "src/index.js",
   "types": "src/index.d.ts",
   "author": "Ethan Sharabi <ethan.shar@gmail.com>",

package/src/components/hint/index.d.ts

@@ -3,20 +3,12 @@ import { HintPositions, HintProps } from './types';
 declare const Hint: {
     (props: HintProps): string | number | true | React.JSX.Element | Iterable<React.ReactNode> | null;
     displayName: string;
-    defaultProps: {
-        position: HintPositions;
-        useModal: boolean;
-    };
     positions: typeof HintPositions;
 };
 export { HintProps, Hint };
 declare const _default: React.ForwardRefExoticComponent<HintProps & React.RefAttributes<any>> & {
     (props: HintProps): string | number | true | React.JSX.Element | Iterable<React.ReactNode> | null;
     displayName: string;
-    defaultProps: {
-        position: HintPositions;
-        useModal: boolean;
-    };
     positions: typeof HintPositions;
 };
 export default _default;

package/src/components/hint/index.js

@@ -22,8 +22,8 @@ const HINT_MIN_WIDTH = 68;
 const Hint = props => {
   const {
     visible,
-    useModal,
-    position,
+    useModal = true,
+    position = HintPositions.BOTTOM,
     children,
     message,
     containerWidth = Constants.windowWidth,
@@ -69,6 +69,7 @@ const Hint = props => {
     if (targetRef.current && hintRef.current) {
       focusAccessibilityOnHint(targetRef.current, hintRef.current);
     }
+    // eslint-disable-next-line react-hooks/exhaustive-deps
   }, []);
   const targetLayout = useMemo(() => {
     return isUsingModal ? targetLayoutInWindowState : targetLayoutState;
@@ -78,6 +79,7 @@ const Hint = props => {
     if (hintRef.current) {
       focusAccessibilityOnHint(targetRef.current, hintRef.current);
     }
+    // eslint-disable-next-line react-hooks/exhaustive-deps
   }, []);
   const showHint = !!targetLayout;
   const {
@@ -240,10 +242,6 @@ const styles = StyleSheet.create({
   }
 });
 Hint.displayName = 'Hint';
-Hint.defaultProps = {
-  position: HintPositions.BOTTOM,
-  useModal: true
-};
 Hint.positions = HintPositions;
 export { HintProps, Hint };
 

package/src/components/tabController/TabPage.js

@@ -24,7 +24,7 @@ export default function TabPage({
   } = useContext(TabBarContext);
   const [shouldLoad, setLoaded] = useState(!lazy);
 
-  // TODO: RN 77 hack - remove the state in future RN\reanimated release (ticket 4838 \ https://github.com/software-mansion/react-native-reanimated/issues/8517)
+  // TODO: RN 77 hack - remove the state in future RN\reanimated release (ticket 4838 \ https://github.com/software-mansion/react-native-reanimated/issues/8517) when fixed we should revert to the original logic (see this PR: https://github.com/wix/react-native-ui-lib/pull/3829)
   const [isActive, setIsActive] = useState(currentPage.value === index);
   // const [focused, setFocused] = useState(false);