react-native-tvos 0.84.1-0 → 0.85.0-0

package/Libraries/StyleSheet/processBoxShadow.js

@@ -11,8 +11,15 @@
 import type {ProcessedColorValue} from './processColor';
 import type {BoxShadowValue} from './StyleSheetTypes';
 
+import {enableOptimizedBoxShadowParsing} from '../../src/private/featureflags/ReactNativeFeatureFlags';
 import processColor from './processColor';
 
+// Pre-compiled regex patterns for performance - avoids regex compilation on each call
+const COMMA_SPLIT_REGEX = /,(?![^()]*\))/;
+const WHITESPACE_SPLIT_REGEX = /\s+(?![^(]*\))/;
+const LENGTH_PARSE_REGEX = /^([+-]?\d*\.?\d+)(px)?$/;
+const NEWLINE_REGEX = /\n/g;
+
 export type ParsedBoxShadow = {
   offsetX: number,
   offsetY: number,
@@ -23,7 +30,7 @@ export type ParsedBoxShadow = {
 };
 
 export default function processBoxShadow(
-  rawBoxShadows: ?($ReadOnlyArray<BoxShadowValue> | string),
+  rawBoxShadows: ?(ReadonlyArray<BoxShadowValue> | string),
 ): Array<ParsedBoxShadow> {
   const result: Array<ParsedBoxShadow> = [];
   if (rawBoxShadows == null) {
@@ -32,7 +39,12 @@ export default function processBoxShadow(
 
   const boxShadowList =
     typeof rawBoxShadows === 'string'
-      ? parseBoxShadowString(rawBoxShadows.replace(/\n/g, ' '))
+      ? parseBoxShadowString(
+          rawBoxShadows.replace(
+            enableOptimizedBoxShadowParsing() ? NEWLINE_REGEX : /\n/g,
+            ' ',
+          ),
+        )
       : rawBoxShadows;
 
   for (const rawBoxShadow of boxShadowList) {
@@ -109,7 +121,9 @@ function parseBoxShadowString(rawBoxShadows: string): Array<BoxShadowValue> {
   let result: Array<BoxShadowValue> = [];
 
   for (const rawBoxShadow of rawBoxShadows
-    .split(/,(?![^()]*\))/) // split by comma that is not in parenthesis
+    .split(
+      enableOptimizedBoxShadowParsing() ? COMMA_SPLIT_REGEX : /,(?![^()]*\))/,
+    ) // split by comma that is not in parenthesis
     .map(bS => bS.trim())
     .filter(bS => bS !== '')) {
     const boxShadow: BoxShadowValue = {
@@ -123,7 +137,11 @@ function parseBoxShadowString(rawBoxShadows: string): Array<BoxShadowValue> {
     let lengthCount = 0;
 
     // split rawBoxShadow string by all whitespaces that are not in parenthesis
-    const args = rawBoxShadow.split(/\s+(?![^(]*\))/);
+    const args = rawBoxShadow.split(
+      enableOptimizedBoxShadowParsing()
+        ? WHITESPACE_SPLIT_REGEX
+        : /\s+(?![^(]*\))/,
+    );
     for (const arg of args) {
       const processedColor = processColor(arg);
       if (processedColor != null) {
@@ -192,6 +210,28 @@ function parseBoxShadowString(rawBoxShadows: string): Array<BoxShadowValue> {
 }
 
 function parseLength(length: string): ?number {
+  if (enableOptimizedBoxShadowParsing()) {
+    // Use pre-compiled regex for performance
+    const match = LENGTH_PARSE_REGEX.exec(length);
+
+    if (!match) {
+      return null;
+    }
+
+    const value = parseFloat(match[1]);
+    if (Number.isNaN(value)) {
+      return null;
+    }
+
+    // match[2] is 'px' or undefined
+    // If no unit and value is not 0, return null
+    if (match[2] == null && value !== 0) {
+      return null;
+    }
+
+    return value;
+  }
+
   // matches on args with units like "1.5 5% -80deg"
   const argsWithUnitsRegex = /([+-]?\d*(\.\d+)?)([\w\W]+)?/g;
   const match = argsWithUnitsRegex.exec(length);

package/Libraries/StyleSheet/processColorArray.js

@@ -17,8 +17,8 @@ import processColor, {type ProcessedColorValue} from './processColor';
 const TRANSPARENT = 0; // rgba(0, 0, 0, 0)
 
 function processColorArray(
-  colors: ?$ReadOnlyArray<ColorValue>,
-): ?$ReadOnlyArray<ProcessedColorValue> {
+  colors: ?ReadonlyArray<ColorValue>,
+): ?ReadonlyArray<ProcessedColorValue> {
   return colors == null ? null : colors.map(processColorElement);
 }
 

package/Libraries/StyleSheet/processFilter.js

@@ -35,8 +35,8 @@ type ParsedDropShadow = {
 };
 
 export default function processFilter(
-  filter: ?($ReadOnlyArray<FilterFunction> | string),
-): $ReadOnlyArray<ParsedFilter> {
+  filter: ?(ReadonlyArray<FilterFunction> | string),
+): ReadonlyArray<ParsedFilter> {
   let result: Array<ParsedFilter> = [];
   if (filter == null) {
     return result;

package/Libraries/Text/Text/RCTDynamicTypeRamp.mm

@@ -34,7 +34,7 @@ UIFontMetrics *RCTUIFontMetricsForDynamicTypeRamp(RCTDynamicTypeRamp dynamicType
   static NSDictionary<NSNumber *, UIFontTextStyle> *mapping;
   static dispatch_once_t onceToken;
   dispatch_once(&onceToken, ^{
-    mapping = @{
+    NSMutableDictionary<NSNumber *, UIFontTextStyle> *mutableMapping = [@{
       @(RCTDynamicTypeRampCaption2) : UIFontTextStyleCaption2,
       @(RCTDynamicTypeRampCaption1) : UIFontTextStyleCaption1,
       @(RCTDynamicTypeRampFootnote) : UIFontTextStyleFootnote,
@@ -45,12 +45,13 @@ UIFontMetrics *RCTUIFontMetricsForDynamicTypeRamp(RCTDynamicTypeRamp dynamicType
       @(RCTDynamicTypeRampTitle3) : UIFontTextStyleTitle3,
       @(RCTDynamicTypeRampTitle2) : UIFontTextStyleTitle2,
       @(RCTDynamicTypeRampTitle1) : UIFontTextStyleTitle1,
+    } mutableCopy];
 #if TARGET_OS_TV
-      @(RCTDynamicTypeRampLargeTitle): UIFontTextStyleTitle1,
+    mutableMapping[@(RCTDynamicTypeRampLargeTitle)] = UIFontTextStyleTitle1;
 #else
-      @(RCTDynamicTypeRampLargeTitle) : UIFontTextStyleLargeTitle,
+    mutableMapping[@(RCTDynamicTypeRampLargeTitle)] = UIFontTextStyleLargeTitle;
 #endif
-    };
+    mapping = [mutableMapping copy];
   });
 
   id textStyle =