react-native-tvos 0.80.1-0 → 0.81.0-0

package/scripts/cocoapods/utils.rb

@@ -6,6 +6,7 @@
 require 'shellwords'
 
 require_relative "./helpers.rb"
+require_relative "./jsengine.rb"
 
 # Utilities class for React Native Cocoapods
 class ReactNativePodsUtils
@@ -32,7 +33,7 @@ class ReactNativePodsUtils
             flags[:hermes_enabled] = true
         end
 
-        if ENV['USE_HERMES'] == '0'
+        if !use_hermes()
             flags[:hermes_enabled] = false
         end
 
@@ -60,7 +61,7 @@ class ReactNativePodsUtils
         # this is needed for Xcode 14, see more details here https://github.com/facebook/react-native/issues/34673
         # we should be able to remove this once CocoaPods catches up to it, see more details here https://github.com/CocoaPods/CocoaPods/issues/11402
         installer.target_installation_results.pod_target_installation_results.each do |pod_name, target_installation_result|
-            if pod_name.to_s == 'React-Core'
+            if target_installation_result.target.root_spec.name == 'React-Core'
                 target_installation_result.resource_bundle_targets.each do |resource_bundle_target|
                     resource_bundle_target.build_configurations.each do |config|
                         config.build_settings['CODE_SIGNING_ALLOWED'] = 'NO'
@@ -177,32 +178,16 @@ class ReactNativePodsUtils
         end
     end
 
-    def self.apply_xcode_15_patch(installer, xcodebuild_manager: Xcodebuild)
-        projects = self.extract_projects(installer)
-
-        other_ld_flags_key = 'OTHER_LDFLAGS'
-        xcode15_compatibility_flags = '-Wl -ld_classic '
-
-        projects.each do |project|
-            project.build_configurations.each do |config|
-                # fix for weak linking
-                self.safe_init(config, other_ld_flags_key)
-                if self.is_using_xcode15_0(:xcodebuild_manager => xcodebuild_manager)
-                    self.add_value_to_setting_if_missing(config, other_ld_flags_key, xcode15_compatibility_flags)
-                else
-                    self.remove_value_from_setting_if_present(config, other_ld_flags_key, xcode15_compatibility_flags)
-                end
-            end
-            project.save()
-        end
-
-    end
-
     private
 
     def self.add_build_settings_to_pod(installer, settings_name, settings_value, target_pod_name, configuration_type)
         installer.target_installation_results.pod_target_installation_results.each do |pod_name, target_installation_result|
-            if pod_name.to_s == target_pod_name
+            # https://github.com/CocoaPods/CocoaPods/blob/master/lib/cocoapods/target/pod_target.rb
+            # In multitarget project, pod_name may contain scope_suffix, namely: platform, OS version, swift version, etc.
+            # E.g. hermes-engine-tvOS16.0
+            # Root spec name is the original pod name, without any scope suffix.
+            original_pod_name = target_installation_result.target.root_spec.name
+            if original_pod_name == target_pod_name
                 target_installation_result.native_target.build_configurations.each do |config|
                         if configuration_type == nil || (configuration_type != nil && config.type == configuration_type)
                             config.build_settings[settings_name] ||= '$(inherited) '
@@ -275,18 +260,26 @@ class ReactNativePodsUtils
     end
 
     def self.create_header_search_path_for_frameworks(base_folder, pod_name, framework_name, additional_paths, include_base_path = true)
-        platforms = $RN_PLATFORMS != nil ? $RN_PLATFORMS : []
         search_paths = []
 
-        if platforms.empty?() || platforms.length() == 1
-            base_path = File.join("${#{base_folder}}", pod_name, "#{framework_name}.framework", "Headers")
-            self.add_search_path_to_result(search_paths, base_path, additional_paths, include_base_path)
-        else
-            platforms.each { |platform|
-                base_path = File.join("${#{base_folder}}", "#{pod_name}-#{platform}", "#{framework_name}.framework", "Headers")
+        # When building using the prebuilt rncore we can't use framework folders as search paths since these aren't created
+        if ReactNativeCoreUtils.build_rncore_from_source()
+            platforms = $RN_PLATFORMS != nil ? $RN_PLATFORMS : []
+
+            if platforms.empty?() || platforms.length() == 1
+                base_path = File.join("${#{base_folder}}", pod_name, "#{framework_name}.framework", "Headers")
                 self.add_search_path_to_result(search_paths, base_path, additional_paths, include_base_path)
-            }
+            else
+                platforms.each { |platform|
+                    base_path = File.join("${#{base_folder}}", "#{pod_name}-#{platform}", "#{framework_name}.framework", "Headers")
+                    self.add_search_path_to_result(search_paths, base_path, additional_paths, include_base_path)
+                }
+            end
+        else
+            base_path = File.join("${PODS_ROOT}", "#{pod_name}")
+            self.add_search_path_to_result(search_paths, base_path, additional_paths, include_base_path)
         end
+
         return search_paths
     end
 
@@ -373,7 +366,7 @@ class ReactNativePodsUtils
 
             # Set "RCT_DYNAMIC_FRAMEWORKS=1" if pod are installed with USE_FRAMEWORKS=dynamic
             # This helps with backward compatibility.
-            if pod_name == 'React-RCTFabric' && ENV['USE_FRAMEWORKS'] == 'dynamic'
+            if target_installation_result.target.root_spec.name == 'React-RCTFabric' && ENV['USE_FRAMEWORKS'] == 'dynamic'
                 Pod::UI.puts "Setting -DRCT_DYNAMIC_FRAMEWORKS=1 to React-RCTFabric".green
                 rct_dynamic_framework_flag = " -DRCT_DYNAMIC_FRAMEWORKS=1"
                 target_installation_result.native_target.build_configurations.each do |config|
@@ -427,16 +420,6 @@ class ReactNativePodsUtils
         end
     end
 
-    def self.is_using_xcode15_0(xcodebuild_manager: Xcodebuild)
-        xcodebuild_version = xcodebuild_manager.version
-
-        if version = self.parse_xcode_version(xcodebuild_version)
-            return version["major"] == 15 && version["minor"] == 0
-        end
-
-        return false
-    end
-
     def self.parse_xcode_version(version_string)
         # The output of xcodebuild -version is something like
         # Xcode 15.0
@@ -647,7 +630,6 @@ class ReactNativePodsUtils
             "React-logger",
             "React-oscompat",
             "React-perflogger",
-            "React-rncore",
             "React-runtimeexecutor",
             "React-timing",
             "ReactCommon",
@@ -726,4 +708,51 @@ class ReactNativePodsUtils
             end
         end
     end
+
+    # Computes the core release version on which a TV release version is based
+    def self.core_version_for_tv_version(version)
+        # See if the release version string has a dash (true for all TV releases)
+        match = version.match(/(.+)-(.+)/)
+        if match.nil?
+            # This is not a TV release or prerelease
+            # Check for the override used to build RNTester for PRs on RNTV main
+            if ENV.has_key?('REACT_NATIVE_OVERRIDE_NIGHTLY_BUILD_VERSION')
+                utils_log("core_version_for_tv_version = ENV['REACT_NATIVE_OVERRIDE_NIGHTLY_BUILD_VERSION'] = #{ENV['REACT_NATIVE_OVERRIDE_NIGHTLY_BUILD_VERSION']}")
+                return ENV['REACT_NATIVE_OVERRIDE_NIGHTLY_BUILD_VERSION']
+            end
+            # Otherwise, return the entire version string
+            utils_log("core_version_for_tv_version = #{version}")
+            return version
+        end
+
+        core_base_version = match[1]
+        prerelease = match[2]
+        # Check to see if this matches the convention for TV prereleases ("0.79.0-0rc1", etc.)
+        prerelease_match = prerelease.match(/0rc(\d+)/)
+        if prerelease_match.nil?
+            # If not, return the core version part ("0.79.0")
+            utils_log("core_version_for_tv_version = #{core_base_version}")
+            return core_base_version
+        end
+
+        # This is a TV prerelease, so return the core prerelease version ("0.79.0-rc.1")
+        cv = "#{core_base_version}-rc.#{prerelease_match[1]}"
+        utils_log("core_version_for_tv_version = #{cv}")
+        return cv
+    end
+
+    def self.utils_log(message, level = :info)
+        if !Object.const_defined?("Pod::UI")
+            return
+        end
+        log_message = '[PodsUtils] ' + message
+        case level
+        when :info
+            Pod::UI.puts log_message.green
+        when :error
+            Pod::UI.puts log_message.red
+        else
+            Pod::UI.puts log_message.yellow
+        end
+    end
 end

package/scripts/codegen/codegen-utils.js

@@ -4,6 +4,7 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
+ * @flow strict-local
  * @format
  */
 
@@ -19,11 +20,13 @@
  *
  * @return an object that can generate the code for the New Architecture.
  */
-function getCodegen() {
+function getCodegen() /*: $FlowFixMe */ {
   let RNCodegen;
   try {
+    // $FlowIgnore[cannot-resolve-module]
     RNCodegen = require('../../packages/react-native-codegen/lib/generators/RNCodegen.js');
   } catch (e) {
+    // $FlowIgnore[cannot-resolve-module]
     RNCodegen = require('@react-native/codegen/lib/generators/RNCodegen.js');
   }
   if (!RNCodegen) {
@@ -32,11 +35,13 @@ function getCodegen() {
   return RNCodegen;
 }
 
-function getCombineJSToSchema() {
+function getCombineJSToSchema() /*: $FlowFixMe */ {
   let combineJSToSchema;
   try {
+    // $FlowIgnore[cannot-resolve-module]
     combineJSToSchema = require('../../packages/react-native-codegen/lib/cli/combine/combine-js-to-schema.js');
   } catch (e) {
+    // $FlowIgnore[cannot-resolve-module]
     combineJSToSchema = require('@react-native/codegen/lib/cli/combine/combine-js-to-schema.js');
   }
   if (!combineJSToSchema) {
@@ -46,6 +51,6 @@ function getCombineJSToSchema() {
 }
 
 module.exports = {
-  getCodegen: getCodegen,
-  getCombineJSToSchema: getCombineJSToSchema,
+  getCodegen,
+  getCombineJSToSchema,
 };

package/scripts/codegen/generate-artifacts-executor/constants.js

@@ -4,6 +4,7 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
+ * @flow strict-local
  * @format
  */
 
@@ -21,54 +22,47 @@ const REACT_NATIVE_REPOSITORY_ROOT = path.join(
   '..',
 );
 
-const REACT_NATIVE_PACKAGE_ROOT_FOLDER = path.join(__dirname, '..', '..', '..');
+const REACT_NATIVE_PACKAGE_ROOT_FOLDER = path.join(
+    __dirname,
+    '..',
+    '..',
+    '..',
+  ) /*:: as string */;
 const CODEGEN_REPO_PATH = `${REACT_NATIVE_REPOSITORY_ROOT}/packages/react-native-codegen`;
 
-const RNCORE_CONFIGS = {
-  ios: path.join(REACT_NATIVE_PACKAGE_ROOT_FOLDER, 'ReactCommon'),
-  android: path.join(
-    REACT_NATIVE_PACKAGE_ROOT_FOLDER,
-    'ReactAndroid',
-    'build',
-    'generated',
-    'source',
-    'codegen',
-  ),
-};
-
 const CORE_LIBRARIES_WITH_OUTPUT_FOLDER = {
-  rncore: RNCORE_CONFIGS,
-  FBReactNativeSpec: {
-    ios: path.join(
-      REACT_NATIVE_PACKAGE_ROOT_FOLDER,
-      'React',
-      'FBReactNativeSpec',
-    ),
-    android: path.join(
-      REACT_NATIVE_PACKAGE_ROOT_FOLDER,
-      'ReactAndroid',
-      'build',
-      'generated',
-      'source',
-      'codegen',
-    ),
-  },
-};
+    FBReactNativeSpec: {
+      ios: path.join(
+        REACT_NATIVE_PACKAGE_ROOT_FOLDER,
+        'React',
+        'FBReactNativeSpec',
+      ) /*:: as string */,
+      android: path.join(
+        REACT_NATIVE_PACKAGE_ROOT_FOLDER,
+        'ReactAndroid',
+        'build',
+        'generated',
+        'source',
+        'codegen',
+      ) /*:: as string */,
+    },
+  } /*:: as {[string]: $FlowFixMe} */;
 
 const packageJsonPath = path.join(
   REACT_NATIVE_PACKAGE_ROOT_FOLDER,
   'package.json',
 );
 
-const packageJson = JSON.parse(fs.readFileSync(packageJsonPath));
+// $FlowFixMe[signature-verification-failure]
+const packageJson = JSON.parse(fs.readFileSync(packageJsonPath, 'utf8'));
 const REACT_NATIVE = packageJson.name;
 
 const TEMPLATES_FOLDER_PATH = path.join(
-  REACT_NATIVE_PACKAGE_ROOT_FOLDER,
-  'scripts',
-  'codegen',
-  'templates',
-);
+    REACT_NATIVE_PACKAGE_ROOT_FOLDER,
+    'scripts',
+    'codegen',
+    'templates',
+  ) /*:: as string */;
 
 module.exports = {
   CODEGEN_REPO_PATH,

package/scripts/codegen/generate-artifacts-executor/generateAppDependencyProvider.js

@@ -4,6 +4,7 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
+ * @flow strict-local
  * @format
  */
 
@@ -28,7 +29,7 @@ const APP_DEPENDENCY_PROVIDER_PODSPEC_TEMPLATE_PATH = path.join(
   'ReactAppDependencyProvider.podspec.template',
 );
 
-function generateAppDependencyProvider(outputDir) {
+function generateAppDependencyProvider(outputDir /*: string */) {
   fs.mkdirSync(outputDir, {recursive: true});
   codegenLog('Generating RCTAppDependencyProvider');
 

package/scripts/codegen/generate-artifacts-executor/generateCustomURLHandlers.js

@@ -4,6 +4,7 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
+ * @flow strict-local
  * @format
  */
 
@@ -13,6 +14,7 @@ const {TEMPLATES_FOLDER_PATH} = require('./constants');
 const {parseiOSAnnotations} = require('./utils');
 const fs = require('fs');
 const path = require('path');
+
 const MODULES_PROTOCOLS_H_TEMPLATE_PATH = path.join(
   TEMPLATES_FOLDER_PATH,
   'RCTModulesConformingToProtocolsProviderH.template',
@@ -23,13 +25,17 @@ const MODULES_PROTOCOLS_MM_TEMPLATE_PATH = path.join(
   'RCTModulesConformingToProtocolsProviderMM.template',
 );
 
-function generateCustomURLHandlers(libraries, outputDir) {
+function generateCustomURLHandlers(
+  libraries /*: $ReadOnlyArray<$FlowFixMe> */,
+  outputDir /*: string */,
+) {
   const iosAnnotations = parseiOSAnnotations(libraries);
 
-  const imageURLLoaderModules = new Set();
-  const imageDataDecoderModules = new Set();
-  const urlRequestHandlersModules = new Set();
+  const imageURLLoaderModules = new Set /*::<string>*/();
+  const imageDataDecoderModules = new Set /*::<string>*/();
+  const urlRequestHandlersModules = new Set /*::<string>*/();
 
+  // $FlowFixMe[missing-local-annot]]
   const wrapInArrayIfNecessary = value =>
     Array.isArray(value) || value == null ? value : [value];
   // Old API

package/scripts/codegen/generate-artifacts-executor/generateFBReactNativeSpecIOS.js

@@ -4,6 +4,7 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
+ * @flow strict-local
  * @format
  */
 
@@ -18,7 +19,7 @@ const {
 } = require('./utils');
 
 function generateFBReactNativeSpecIOS(projectRoot /*: string */) /*: void*/ {
-  const ios = 'ios';
+  const platform = 'ios';
   buildCodegenIfNeeded();
   const pkgJson = readPkgJsonInDirectory(projectRoot);
   const fbReactNativeSpecLib = findProjectRootLibraries(
@@ -27,11 +28,14 @@ function generateFBReactNativeSpecIOS(projectRoot /*: string */) /*: void*/ {
   ).filter(library => library.config.name === 'FBReactNativeSpec')[0];
   if (!fbReactNativeSpecLib) {
     throw new Error(
-      "[Codegen] Can't find FBReactNativeSpec library. Failed to generate rncore artifacts",
+      "[Codegen] Can't find FBReactNativeSpec library. Failed to generate artifacts",
     );
   }
-  const fbReactNativeSchemaInfo = generateSchemaInfo(fbReactNativeSpecLib, ios);
-  generateCode('', fbReactNativeSchemaInfo, false, ios);
+  const fbReactNativeSchemaInfo = generateSchemaInfo(
+    fbReactNativeSpecLib,
+    platform,
+  );
+  generateCode('', fbReactNativeSchemaInfo, false, platform);
 }
 
 module.exports = {

package/scripts/codegen/generate-artifacts-executor/generateNativeCode.js

@@ -4,6 +4,7 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
+ * @flow strict-local
  * @format
  */
 
@@ -17,25 +18,22 @@ const os = require('os');
 const path = require('path');
 
 function generateNativeCode(
-  outputPath,
-  schemaInfos,
-  includesGeneratedCode,
-  platform,
-) {
+  outputPath /*: string */,
+  schemaInfos /*: $ReadOnlyArray<$FlowFixMe> */,
+  includesGeneratedCode /*: boolean */,
+  platform /*: string */,
+) /*: Array<void> */ {
   return schemaInfos.map(schemaInfo => {
     generateCode(outputPath, schemaInfo, includesGeneratedCode, platform);
   });
 }
 
-function generateCode(outputPath, schemaInfo, includesGeneratedCode, platform) {
-  if (shouldSkipGenerationForRncore(schemaInfo, platform)) {
-    codegenLog(
-      '[Codegen - rncore] Skipping iOS code generation for rncore as it has been generated already.',
-      true,
-    );
-    return;
-  }
-
+function generateCode(
+  outputPath /*: string */,
+  schemaInfo /*: $FlowFixMe */,
+  includesGeneratedCode /*: boolean */,
+  platform /*: string */,
+) {
   if (shouldSkipGenerationForFBReactNativeSpec(schemaInfo, platform)) {
     codegenLog(
       '[Codegen - FBReactNativeSpec] Skipping iOS code generation for FBReactNativeSpec as it has been generated already.',
@@ -65,30 +63,24 @@ function generateCode(outputPath, schemaInfo, includesGeneratedCode, platform) {
   const outputDir =
     reactNativeCoreLibraryOutputPath(libraryName, platform) ?? outputPath;
   fs.mkdirSync(outputDir, {recursive: true});
+  // $FlowIssue[prop-missing] - `fs.cpSync` is missing in Flow libdefs.
   fs.cpSync(tmpOutputDir, outputDir, {recursive: true});
   codegenLog(`Generated artifacts: ${outputDir}`);
 }
 
-function shouldSkipGenerationForRncore(schemaInfo, platform) {
-  if (platform !== 'ios' || schemaInfo.library.config.name !== 'rncore') {
-    return false;
-  }
-  const rncoreOutputPath = CORE_LIBRARIES_WITH_OUTPUT_FOLDER.rncore.ios;
-  const rncoreAbsolutePath = path.resolve(rncoreOutputPath);
-  return (
-    rncoreAbsolutePath.includes('node_modules') &&
-    fs.existsSync(rncoreAbsolutePath) &&
-    fs.readdirSync(rncoreAbsolutePath).length > 0
-  );
-}
-
-function reactNativeCoreLibraryOutputPath(libraryName, platform) {
+function reactNativeCoreLibraryOutputPath(
+  libraryName /*: string */,
+  platform /*: string */,
+) {
   return CORE_LIBRARIES_WITH_OUTPUT_FOLDER[libraryName]
     ? CORE_LIBRARIES_WITH_OUTPUT_FOLDER[libraryName][platform]
     : null;
 }
 
-function shouldSkipGenerationForFBReactNativeSpec(schemaInfo, platform) {
+function shouldSkipGenerationForFBReactNativeSpec(
+  schemaInfo /*: $FlowFixMe */,
+  platform /*: string */,
+) {
   if (
     platform !== 'ios' ||
     schemaInfo.library.config.name !== 'FBReactNativeSpec'

package/scripts/codegen/generate-artifacts-executor/generateRCTModuleProviders.js

@@ -4,6 +4,7 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
+ * @flow strict-local
  * @format
  */
 
@@ -28,10 +29,10 @@ const MODULE_PROVIDERS_MM_TEMPLATE_PATH = path.join(
 );
 
 function generateRCTModuleProviders(
-  projectRoot,
-  pkgJson,
-  libraries,
-  outputDir,
+  projectRoot /*: string */,
+  pkgJson /*: $FlowFixMe */,
+  libraries /*: $ReadOnlyArray<$FlowFixMe> */,
+  outputDir /*: string */,
 ) {
   fs.mkdirSync(outputDir, {recursive: true});
   // Generate Header File
@@ -42,7 +43,7 @@ function generateRCTModuleProviders(
   codegenLog(`Generated artifact: ${finalPathH}`);
 
   codegenLog('Generating RCTModuleProviders.mm');
-  let modulesInLibraries = {};
+  let modulesInLibraries = {} /*:: as {[string]: Array<$FlowFixMe>}  */;
 
   let app = pkgJson.codegenConfig
     ? {config: pkgJson.codegenConfig, libraryPath: projectRoot}
@@ -64,7 +65,7 @@ function generateRCTModuleProviders(
   // Old API
   moduleLibraries.forEach(({config, libraryPath}) => {
     const libraryName = JSON.parse(
-      fs.readFileSync(path.join(libraryPath, 'package.json')),
+      fs.readFileSync(path.join(libraryPath, 'package.json'), 'utf8'),
     ).name;
 
     if (config.ios?.modulesProvider) {

package/scripts/codegen/generate-artifacts-executor/generateRCTThirdPartyComponents.js

@@ -4,6 +4,7 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
+ * @flow strict-local
  * @format
  */
 
@@ -28,7 +29,10 @@ const THIRD_PARTY_COMPONENTS_MM_TEMPLATE_PATH = path.join(
   'RCTThirdPartyComponentsProviderMM.template',
 );
 
-function generateRCTThirdPartyComponents(libraries, outputDir) {
+function generateRCTThirdPartyComponents(
+  libraries /*: $ReadOnlyArray<$FlowFixMe> */,
+  outputDir /*: string */,
+) {
   fs.mkdirSync(outputDir, {recursive: true});
   // Generate Header File
   codegenLog('Generating RCTThirdPartyComponentsProvider.h');
@@ -41,7 +45,7 @@ function generateRCTThirdPartyComponents(libraries, outputDir) {
   codegenLog(`Generated artifact: ${finalPathH}`);
 
   codegenLog('Generating RCTThirdPartyComponentsProvider.mm');
-  let componentsInLibraries = {};
+  let componentsInLibraries = {} /*:: as {[string]: Array<$FlowFixMe>} */;
 
   const componentLibraries = libraries.filter(({config, libraryPath}) => {
     if (isReactNativeCoreLibrary(config.name) || config.type === 'modules') {
@@ -50,7 +54,7 @@ function generateRCTThirdPartyComponents(libraries, outputDir) {
     return true;
   });
 
-  const librariesToCrawl = {};
+  const librariesToCrawl = {} /*:: as {[string]: $FlowFixMe} */;
 
   // Using new API explicitly or not using any config field to define components.
   const componentLibrariesUsingNewApi = [];
@@ -71,7 +75,7 @@ function generateRCTThirdPartyComponents(libraries, outputDir) {
   componentLibrariesUsingOldApi.forEach(library => {
     const {config, libraryPath} = library;
     const libraryName = JSON.parse(
-      fs.readFileSync(path.join(libraryPath, 'package.json')),
+      fs.readFileSync(path.join(libraryPath, 'package.json'), 'utf8'),
     ).name;
 
     librariesToCrawl[libraryName] = library;
@@ -152,7 +156,10 @@ function generateRCTThirdPartyComponents(libraries, outputDir) {
 
 // Given a path, return the paths of all the files with extension .mm in
 // the path dir and all its subdirectories.
-function findFilesWithExtension(filePath, extension) {
+function findFilesWithExtension(
+  filePath /*: string */,
+  extension /*: string */,
+) /*: Array<string> */ {
   const files = [];
   const dir = fs.readdirSync(filePath);
   dir.forEach(file => {
@@ -184,7 +191,7 @@ function findFilesWithExtension(filePath, extension) {
 
 // Given a filepath, read the file and look for a string that starts with 'Class<RCTComponentViewProtocol> '
 // and ends with 'Cls(void)'. Return the string between the two.
-function findRCTComponentViewProtocolClass(filepath) {
+function findRCTComponentViewProtocolClass(filepath /*: string */) {
   const fileContent = fs.readFileSync(filepath, 'utf8');
   const regex = /Class<RCTComponentViewProtocol> (.*)Cls\(/;
   const match = fileContent.match(regex);

package/scripts/codegen/generate-artifacts-executor/generateReactCodegenPodspec.js

@@ -4,6 +4,7 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
+ * @flow strict-local
  * @format
  */
 
@@ -25,10 +26,10 @@ const REACT_CODEGEN_PODSPEC_TEMPLATE_PATH = path.join(
 );
 
 function generateReactCodegenPodspec(
-  appPath,
-  appPkgJson,
-  outputPath,
-  baseOutputPath,
+  appPath /*: string */,
+  appPkgJson /*: $FlowFixMe */,
+  outputPath /*: string */,
+  baseOutputPath /*: string */,
 ) {
   const inputFiles = getInputFiles(appPath, appPkgJson);
   const codegenScript = codegenScripts(appPath, baseOutputPath);
@@ -42,8 +43,8 @@ function generateReactCodegenPodspec(
   codegenLog(`Generated podspec: ${finalPathPodspec}`);
 }
 
-function getInputFiles(appPath, appPkgJSon) {
-  const jsSrcsDir = appPkgJSon.codegenConfig?.jsSrcsDir;
+function getInputFiles(appPath /*: string */, appPkgJson /*: $FlowFixMe */) {
+  const jsSrcsDir = appPkgJson.codegenConfig?.jsSrcsDir;
   if (!jsSrcsDir) {
     return '[]';
   }
@@ -70,7 +71,7 @@ function getInputFiles(appPath, appPkgJSon) {
   return `[${list}]`;
 }
 
-function codegenScripts(appPath, outputPath) {
+function codegenScripts(appPath /*: string */, outputPath /*: string */) {
   const relativeAppPath = path.relative(outputPath, appPath);
   return `<<-SCRIPT
 pushd "$PODS_ROOT/../" > /dev/null