react-native-smooth-clip-view 0.2.6 → 0.2.7

package/src/driverState.ts

@@ -48,6 +48,14 @@ export function detachDriverState(state: DriverState): void {
   if (statesById.get(state.driverId) === state) {
     statesById.delete(state.driverId);
   }
+  // Requests pending at teardown were settled by rejectDriverRequests, but
+  // their completion deferrals can no longer be released: the late-scheduled
+  // resolver's releaseDriverCompletions no-ops against a detached state. An
+  // effect replay reattaches THIS same object, so a stale positive count
+  // would queue every future completion forever. The deferrals died with
+  // their requests — reset them.
+  state.completionDeferrals = 0;
+  state.deferredCompletions.length = 0;
 }
 
 export function createDriverState(

package/src/drivers.native.ts

@@ -107,9 +107,19 @@ function animationIsFinite(
     return false;
   }
   if (animation.type === 'timing') {
+    const [x1, , x2] = animation.controlPoints;
     return (
       Number.isFinite(animation.duration) &&
-      animation.controlPoints.every(Number.isFinite)
+      animation.controlPoints.every(Number.isFinite) &&
+      // A cubic-bezier easing is only defined for x within [0,1] (the CSS /
+      // CoreAnimation / Reanimated Easing.bezier contract). Out-of-range x
+      // makes the Android parameter solve meaningless while CoreAnimation
+      // silently clamps — reject like any other invalid input instead of
+      // diverging per platform.
+      x1 >= 0 &&
+      x1 <= 1 &&
+      x2 >= 0 &&
+      x2 <= 1
     );
   }
   if (animation.type === 'spring') {
@@ -322,6 +332,10 @@ export function useSmoothClipDriver(
       animation: SmoothClipAnimation
     ): number => {
       'worklet';
+      // Cleanup owns the terminal state. Check it before validation so even an
+      // invalid stale call cannot mint a native rejection id/completion against
+      // a driver whose listener and registry entry are already gone.
+      if (disposed.value !== 0) return 0;
       if (
         !isFiniteClipPresentation(target) ||
         !animationIsFinite(target, animation)
@@ -334,8 +348,6 @@ export function useSmoothClipDriver(
       // rejectAnimation, which would mint an id and a completion for a driver
       // whose JS state is already detached. This is the "unsupported dispatch"
       // arm of the documented 0 contract.
-      if (disposed.value !== 0) return 0;
-
       const from = animation.from;
       if (from !== undefined) {
         // Fused hot write: exactly setScalars(from…) issued immediately
@@ -475,8 +487,10 @@ export function useSmoothClipDriver(
         // dispatch. A missing driver is accepted when this call carries the
         // authoritative interactive start above; a start-less missing-state
         // request remains unsupported rather than inventing zero geometry.
-        // Validation failures never get here (they reject before any side
-        // effect with a fresh id and one finished:false completion).
+        // Validation failures never get here: they reject before any side
+        // effect, with a fresh id and one finished:false completion once the
+        // native entry exists — in the pre-seed window rejectAnimation has no
+        // entry and returns the bare 0 sentinel with no completion instead.
         ownership.value = INTERACTIVE;
         presentation.value = start;
         if (scalarsWereStale) scalarsStale.value = 1;
@@ -568,7 +582,14 @@ export function useSmoothClipDriver(
           return promise;
         },
         set(next) {
-          const { requestId, promise } = createReactRequest<void>(driverId);
+          // Teardown resolves (undefined) rather than rejects: `set` is a
+          // documented fire-and-forget call, and a promise discarded with
+          // `void` must not become an unhandled rejection at unmount.
+          const { requestId, promise } = createReactRequest<void>(
+            driverId,
+            false,
+            { value: undefined }
+          );
           scheduleOnUI(() => {
             'worklet';
             setOnUI(next);
@@ -577,9 +598,12 @@ export function useSmoothClipDriver(
           return promise;
         },
         animateTo(target, animation) {
+          // Teardown resolves with the documented 0 rejection sentinel (see
+          // `set` above): the README's own example voids this promise.
           const { requestId, promise } = createReactRequest<number>(
             driverId,
-            true
+            true,
+            { value: 0 }
           );
           scheduleOnUI(() => {
             'worklet';

package/src/reactRequests.ts

@@ -6,6 +6,11 @@ import {
 type PendingRequest = {
   resolve(value: unknown): void;
   reject(error: Error): void;
+  // Set for calls whose documented usage is fire-and-forget (`void
+  // driver.react.animateTo(...)`): teardown resolves them with this benign
+  // sentinel instead of rejecting, so a discarded promise cannot surface as
+  // an unhandled rejection during ordinary unmount.
+  teardownResolution?: { value: unknown };
 };
 
 const requests = new Map<number, PendingRequest>();
@@ -14,7 +19,8 @@ let nextRequestId = 0;
 
 export function createReactRequest<T>(
   driverId: number,
-  deferCompletions = false
+  deferCompletions = false,
+  teardownResolution?: { value: unknown }
 ): { requestId: number; promise: Promise<T> } {
   nextRequestId = (nextRequestId % 0x7ffffffe) + 1;
   const requestId = nextRequestId;
@@ -27,6 +33,7 @@ export function createReactRequest<T>(
   requests.set(requestId, {
     resolve: resolveRequest as (value: unknown) => void,
     reject: rejectRequest,
+    teardownResolution,
   });
   const driverRequests = requestsByDriver.get(driverId) ?? new Set<number>();
   driverRequests.add(requestId);
@@ -58,7 +65,12 @@ export function rejectDriverRequests(driverId: number): void {
   for (const requestId of driverRequests) {
     const request = requests.get(requestId);
     requests.delete(requestId);
-    request?.reject(new Error('[SmoothClipView] Driver was destroyed.'));
+    if (!request) continue;
+    if (request.teardownResolution) {
+      request.resolve(request.teardownResolution.value);
+    } else {
+      request.reject(new Error('[SmoothClipView] Driver was destroyed.'));
+    }
   }
   requestsByDriver.delete(driverId);
 }