react-native-queue-player 1.1.0 → 1.1.1

package/android/src/main/java/com/margelo/nitro/queueplayer/PlaybackService.kt

@@ -762,8 +762,15 @@ class PlaybackService : HeadlessJsMediaService() {
    * (the same one ExoPlayer drives for HTTP playback), so consumer
    * `userAgent` + custom HTTP headers configured on the player's
    * `MediaSource.Factory` propagate into artwork fetches without a
-   * second HTTP client. `CacheBitmapLoader` deduplicates repeat
-   * requests for the same URI inside a single foreground session.
+   * second HTTP client. It mirrors Media3's own default loader config:
+   * `setMaximumOutputDimension(MediaSession.getBitmapDimensionLimit(...))`
+   * downsamples an oversized consumer image during decode (device-adaptive
+   * cap; no full-resolution bitmap for a small control), and
+   * `setMakeShared(true)` puts the bitmap in shared memory so the System UI
+   * process reuses it instead of copying. Supplying our own loader (for the
+   * placeholder guarantee below) had otherwise dropped both defaults, which
+   * is what left artwork decoding unbounded. `CacheBitmapLoader` deduplicates
+   * repeat requests for the same URI inside a single foreground session.
    * The outer [PlaceholderFallbackBitmapLoader] guarantees a bitmap
    * always reaches the notification — the OEM-skin failure mode
    * where a null bitmap drops the transport controls is closed.
@@ -776,7 +783,12 @@ class PlaybackService : HeadlessJsMediaService() {
   @VisibleForTesting
   internal fun buildBitmapLoader(): PlaceholderFallbackBitmapLoader =
     PlaceholderFallbackBitmapLoader(
-      delegate = CacheBitmapLoader(DataSourceBitmapLoader.Builder(this).build()),
+      delegate = CacheBitmapLoader(
+        DataSourceBitmapLoader.Builder(this)
+          .setMaximumOutputDimension(MediaSession.getBitmapDimensionLimit(this))
+          .setMakeShared(true)
+          .build()
+      ),
       // Read on each fallback so a placeholder set at `configure` (after
       // this loader was built in onCreate) is reflected — `PlaceholderArtwork`
       // returns the consumer image when one is configured, else the built-in.

package/android/src/test/java/com/margelo/nitro/queueplayer/PlaybackServiceArtworkLoaderTest.kt

@@ -3,7 +3,9 @@ package com.margelo.nitro.queueplayer
 import androidx.media3.common.util.UnstableApi
 import androidx.media3.datasource.DataSourceBitmapLoader
 import androidx.media3.session.CacheBitmapLoader
+import androidx.media3.session.MediaSession
 import org.junit.After
+import org.junit.Assert.assertEquals
 import org.junit.Assert.assertNotNull
 import org.junit.Assert.assertSame
 import org.junit.Assert.assertTrue
@@ -78,6 +80,32 @@ class PlaybackServiceArtworkLoaderTest {
     )
   }
 
+  @Test
+  fun `DataSourceBitmapLoader mirrors Media3's default cap + shared-memory bitmap`() {
+    val loader = service.buildBitmapLoader()
+    val cached = loader.javaClass.getDeclaredField("delegate")
+      .apply { isAccessible = true }.get(loader) as CacheBitmapLoader
+    val backing = cached.javaClass.getDeclaredField("bitmapLoader")
+      .apply { isAccessible = true }.get(cached) as DataSourceBitmapLoader
+    val maxDim = DataSourceBitmapLoader::class.java
+      .getDeclaredField("maximumOutputDimension")
+      .apply { isAccessible = true }
+      .getInt(backing)
+    assertEquals(
+      "artwork decode is capped to Media3's device-adaptive limit (no full-res allocation)",
+      MediaSession.getBitmapDimensionLimit(service),
+      maxDim
+    )
+    val makeShared = DataSourceBitmapLoader::class.java
+      .getDeclaredField("makeShared")
+      .apply { isAccessible = true }
+      .getBoolean(backing)
+    assertTrue(
+      "decoded bitmap is shared-memory so the System UI process reuses it instead of copying",
+      makeShared
+    )
+  }
+
   @Test
   fun `repeat builds reuse the same placeholder bitmap`() {
     // The loader holds a placeholder *provider* closure; invoking it

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "react-native-queue-player",
-  "version": "1.1.0",
+  "version": "1.1.1",
   "description": "Nitro Modules audio playback library for React Native — gapless, EQ, crossfade, automotive, voice, casting",
   "main": "./lib/module/index.js",
   "types": "./lib/typescript/index.d.ts",