react-native-purchases-ui 9.10.3 → 9.10.5

package/RNPaywalls.podspec

@@ -17,6 +17,6 @@ Pod::Spec.new do |spec|
   spec.pod_target_xcconfig = { 'DEFINES_MODULE' => 'YES' }
 
   spec.dependency   "React-Core"
-  spec.dependency   "PurchasesHybridCommonUI", '17.41.0'
+  spec.dependency   "PurchasesHybridCommonUI", '17.41.1'
   spec.swift_version    = '5.7'
 end

package/android/build.gradle

@@ -59,7 +59,7 @@ android {
     minSdkVersion getExtOrIntegerDefault("minSdkVersion")
     targetSdkVersion getExtOrIntegerDefault("targetSdkVersion")
     versionCode 1
-    versionName '9.10.3'
+    versionName '9.10.5'
   }
 
   buildTypes {
@@ -91,7 +91,7 @@ dependencies {
   //noinspection GradleDynamicVersion
   implementation "com.facebook.react:react-native:+"
   implementation "org.jetbrains.kotlin:kotlin-stdlib:$kotlin_version"
-  implementation 'com.revenuecat.purchases:purchases-hybrid-common-ui:17.41.0'
+  implementation 'com.revenuecat.purchases:purchases-hybrid-common-ui:17.41.1'
   implementation 'androidx.compose.ui:ui-android:1.5.4'
   implementation "androidx.appcompat:appcompat:1.6.1"
 }

package/ios/PaywallViewWrapper.m

@@ -23,6 +23,8 @@ API_AVAILABLE(ios(15.0))
 
 @property(strong, nonatomic) RCPaywallViewController *paywallViewController;
 @property(nonatomic) BOOL addedToHierarchy;
+@property(nonatomic) BOOL didReceiveInitialOptions;
+@property(strong, nonatomic) NSDictionary *pendingOptions;
 
 @end
 
@@ -31,7 +33,10 @@ API_AVAILABLE(ios(15.0))
 - (instancetype)initWithPaywallViewController:(RCPaywallViewController *)paywallViewController API_AVAILABLE(ios(15.0)) {
     NSParameterAssert(paywallViewController);
 
-    if ((self = [super initWithFrame:paywallViewController.view.bounds])) {
+    // Don't access paywallViewController.view here - it triggers viewDidLoad which sets up
+    // the hostingController, making it impossible to set custom variables afterwards.
+    // See: https://github.com/RevenueCat/react-native-purchases/issues/1622
+    if ((self = [super initWithFrame:CGRectZero])) {
         _paywallViewController = paywallViewController;
     }
 
@@ -41,29 +46,32 @@ API_AVAILABLE(ios(15.0))
 
 - (void)reactSetFrame:(CGRect)frame
 {
-    NSLog(@"RNPaywalls - reactSetFrame: %@", NSStringFromCGRect(frame));
-
     [super reactSetFrame: frame];
 }
 
 - (void)layoutSubviews {
     [super layoutSubviews];
 
-    CGSize size = self.bounds.size;
-    NSLog(@"RNPaywalls - Size on layoutSubviews: %@", NSStringFromCGSize(size));
-
     // Need to wait for this view to be in the hierarchy to look for the parent UIVC.
     // This is required to add a SwiftUI `UIHostingController` to the hierarchy in a way that allows
     // UIKit to read properties from the environment, like traits and safe area.
-    if (!self.addedToHierarchy) {
+    //
+    // IMPORTANT: We also need to wait for setOptions: to be called (via didReceiveInitialOptions).
+    // Custom variables MUST be applied before accessing the PaywallViewController's view,
+    // because viewDidLoad sets up the hostingController which makes custom variables immutable.
+    // Note: options can be nil/empty (default usage), so we track the flag separately.
+    // See: https://github.com/RevenueCat/react-native-purchases/issues/1622
+    if (!self.addedToHierarchy && self.didReceiveInitialOptions) {
         UIViewController *parentController = self.parentViewController;
         if (parentController) {
+            // Apply custom variables BEFORE accessing .view (which triggers viewDidLoad).
+            [self applyCustomVariablesFromPendingOptions];
+
             self.paywallViewController.view.translatesAutoresizingMaskIntoConstraints = NO;
             [parentController addChildViewController:self.paywallViewController];
             [self addSubview:self.paywallViewController.view];
             [self.paywallViewController didMoveToParentViewController:parentController];
 
-            NSLog(@"RNPaywalls - Activating constraints");
             [NSLayoutConstraint activateConstraints:@[
                 [self.paywallViewController.view.topAnchor constraintEqualToAnchor:self.topAnchor],
                 [self.paywallViewController.view.bottomAnchor constraintEqualToAnchor:self.bottomAnchor],
@@ -72,13 +80,51 @@ API_AVAILABLE(ios(15.0))
             ]];
 
             self.addedToHierarchy = YES;
+
+            // Apply remaining options after adding to hierarchy
+            [self applyNonCustomVariableOptionsFromPendingOptions];
         }
     }
 }
 
 - (void)setOptions:(NSDictionary *)options {
     if (@available(iOS 15.0, *)) {
-        NSDictionary *offering = options[@"offering"];
+        self.pendingOptions = options ?: @{};
+        self.didReceiveInitialOptions = YES;
+
+        if (self.addedToHierarchy) {
+            // View is already in hierarchy, apply non-custom-variable options only.
+            // Custom variables cannot be set after the PaywallViewController has loaded
+            // (the SDK will assert if we try). They must be set before viewDidLoad.
+            // See: https://github.com/RevenueCat/react-native-purchases/issues/1622
+            [self applyNonCustomVariableOptionsFromPendingOptions];
+        } else {
+            // View is not yet in hierarchy, trigger layout to apply options.
+            // Custom variables will be applied before adding to hierarchy in layoutSubviews.
+            [self setNeedsLayout];
+        }
+    } else {
+        NSLog(@"Error: attempted to present paywalls on unsupported iOS version.");
+    }
+}
+
+- (void)applyCustomVariablesFromPendingOptions {
+    if (@available(iOS 15.0, *)) {
+        NSDictionary *customVariables = self.pendingOptions[@"customVariables"];
+        if (customVariables && [customVariables isKindOfClass:[NSDictionary class]]) {
+            for (NSString *key in customVariables) {
+                NSString *value = customVariables[key];
+                if ([value isKindOfClass:[NSString class]]) {
+                    [self.paywallViewController setCustomVariable:value forKey:key];
+                }
+            }
+        }
+    }
+}
+
+- (void)applyNonCustomVariableOptionsFromPendingOptions {
+    if (@available(iOS 15.0, *)) {
+        NSDictionary *offering = self.pendingOptions[@"offering"];
         if (offering && ![offering isKindOfClass:[NSNull class]]) {
             NSString *identifier = offering[@"identifier"];
             if (identifier) {
@@ -88,28 +134,16 @@ API_AVAILABLE(ios(15.0))
             }
         }
 
-        NSString *fontFamily = options[@"fontFamily"];
+        NSString *fontFamily = self.pendingOptions[@"fontFamily"];
         if (fontFamily && [fontFamily isKindOfClass:[NSString class]] && fontFamily.length > 0) {
             [self.paywallViewController updateFontWithFontName:fontFamily];
         }
 
-        NSNumber *displayCloseButtonValue = options[@"displayCloseButton"];
+        NSNumber *displayCloseButtonValue = self.pendingOptions[@"displayCloseButton"];
         BOOL displayCloseButton = [displayCloseButtonValue isKindOfClass:[NSNumber class]] ? [displayCloseButtonValue boolValue] : NO;
         if (displayCloseButton) {
             [self.paywallViewController updateWithDisplayCloseButton:displayCloseButton];
         }
-
-        NSDictionary *customVariables = options[@"customVariables"];
-        if (customVariables && [customVariables isKindOfClass:[NSDictionary class]]) {
-            for (NSString *key in customVariables) {
-                NSString *value = customVariables[key];
-                if ([value isKindOfClass:[NSString class]]) {
-                    [self.paywallViewController setCustomVariable:value forKey:key];
-                }
-            }
-        }
-    } else {
-        NSLog(@"Error: attempted to present paywalls on unsupported iOS version.");
     }
 }
 
@@ -204,7 +238,6 @@ didFailRestoringWithErrorDictionary:(NSDictionary *)errorDictionary API_AVAILABL
 }
 
 - (void)paywallViewController:(RCPaywallViewController *)controller didChangeSizeTo:(CGSize)size API_AVAILABLE(ios(15.0)) {
-    NSLog(@"RNPaywalls - Paywall view wrapper did change size to: %@", NSStringFromCGSize(size));
 }
 
 - (void)paywallViewController:(RCPaywallViewController *)controller

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "react-native-purchases-ui",
   "title": "React Native Purchases UI",
-  "version": "9.10.3",
+  "version": "9.10.5",
   "description": "React Native in-app purchases and subscriptions made easy. Supports iOS and Android.",
   "main": "lib/commonjs/index",
   "module": "lib/module/index",
@@ -78,7 +78,7 @@
   "peerDependencies": {
     "react": "*",
     "react-native": ">= 0.73.0",
-    "react-native-purchases": "9.10.3",
+    "react-native-purchases": "9.10.5",
     "react-native-web": "*"
   },
   "peerDependenciesMeta": {
@@ -125,6 +125,6 @@
     ]
   },
   "dependencies": {
-    "@revenuecat/purchases-typescript-internal": "17.41.0"
+    "@revenuecat/purchases-typescript-internal": "17.41.1"
   }
 }