react-native-pirate-wallet 0.2.1 → 0.3.0

package/README.md

@@ -76,8 +76,8 @@ await sdk.configureAccountStorage({
 - `scripts/`
 - `src/`
 
-The Android native libraries are distributed in the exact-version
-`react-native-pirate-wallet-android` companion package.
+Native libraries are distributed in exact-version Android ARM, Android x86_64,
+iOS device, and iOS simulator companion packages.
 
 ## Preparing native artifacts in this repo
 
@@ -89,8 +89,8 @@ bash scripts/prepare-react-native-plugin.sh
 
 That copies:
 
-- Android JNI libraries into `bindings/react-native-pirate-wallet-android/`
-- the iOS XCFramework into this package
+- Android JNI libraries into the two Android companion packages
+- iOS XCFramework slices into the two iOS companion packages
 
 There is also a minimal consumer app in:
 
@@ -289,13 +289,18 @@ Receive-address APIs are shielded and wallet-scoped:
   - returns generated external receive addresses
 - `listAddressBalances(walletId, keyId?)`
   - RPC: `list_address_balances`
-  - returns per-address balance entries
+  - without `keyId`, returns external receive-address balance entries only
+  - with `keyId`, also returns internal change-address entries for that key group
 
 These APIs return shielded receive addresses. Newly generated addresses use
-Sapling before Ironwood activation and Ironwood after activation. The current
-address can still be an older Sapling address until the wallet rotates, and
-`listAddresses(walletId)` can contain both Sapling and Ironwood receive
-addresses over time.
+Sapling before Ironwood activation and Ironwood after activation. At activation,
+both current- and next-address calls select Ironwood; existing Sapling addresses
+remain valid, so `listAddresses(walletId)` can contain both pools over time.
+
+Internal change is always included in `getBalance(walletId)`. Do not sum an
+unfiltered `listAddressBalances(walletId)` response to calculate the wallet
+total, because its default external-only view intentionally omits internal
+address rows.
 
 - `getBalance(walletId)`
   - RPC: `get_balance`
@@ -529,9 +534,10 @@ npm install react-native-pirate-wallet
 cd ios && pod install
 ```
 
-On Android, npm installs the exact-version
-`react-native-pirate-wallet-android` companion automatically. The wrapper
-autolinks as a standard React Native native module and adds the companion's JNI
-libraries to the build.
+On Android, npm installs the exact-version ARM and x86_64 companions
+automatically. The wrapper autolinks as a standard React Native native module
+and adds their JNI libraries to the build.
 
-On iOS, the podspec links the vendored `PirateWalletNative.xcframework`.
+On macOS, npm installs the exact-version device and simulator companions.
+During `pod install`, the podspec assembles and links
+`PirateWalletNative.xcframework` from those packages.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "react-native-pirate-wallet",
-  "version": "0.2.1",
+  "version": "0.3.0",
   "description": "React Native wrapper for the Pirate Unified Wallet native SDK surfaces",
   "keywords": [
     "react-native",
@@ -43,7 +43,6 @@
     "test": "node test/smoke.js",
     "verify:package": "node scripts/verify-package.js",
     "prepare:native": "node scripts/assemble-ios-framework.js",
-    "postinstall": "npm run prepare:native",
     "prepack": "node scripts/verify-package.js --publish-layout"
   },
   "engines": {
@@ -53,10 +52,10 @@
     "react-native": ">=0.71.0 <1.0.0"
   },
   "optionalDependencies": {
-    "react-native-pirate-wallet-android": "0.2.1",
-    "react-native-pirate-wallet-android-x86_64": "0.2.1",
-    "react-native-pirate-wallet-ios-device": "0.2.1",
-    "react-native-pirate-wallet-ios-simulator": "0.2.1"
+    "react-native-pirate-wallet-android": "0.3.0",
+    "react-native-pirate-wallet-android-x86_64": "0.3.0",
+    "react-native-pirate-wallet-ios-device": "0.3.0",
+    "react-native-pirate-wallet-ios-simulator": "0.3.0"
   },
   "publishConfig": {
     "access": "public"

package/react-native-pirate-wallet.podspec

@@ -2,6 +2,16 @@ require "json"
 
 package = JSON.parse(File.read(File.join(__dir__, "package.json")))
 
+assembly_script = File.join(__dir__, "scripts", "assemble-ios-framework.js")
+framework_path = File.join(__dir__, "ios", "Frameworks", "PirateWalletNative.xcframework")
+
+# npm may block dependency lifecycle scripts, so assemble the split iOS binary
+# packages when CocoaPods actually needs the framework.
+Pod::Executable.execute_command("node", [assembly_script, "--force"])
+unless File.directory?(framework_path)
+  raise Pod::Informative, "PirateWalletNative.xcframework could not be assembled"
+end
+
 Pod::Spec.new do |s|
   s.name         = package["name"]
   s.version      = package["version"]

package/test/smoke.js

@@ -48,6 +48,12 @@ function createMockNativeModule() {
           ])
         case 'get_active_wallet':
           return ok('wallet-1')
+        case 'current_receive_address':
+          assert.strictEqual(request.wallet_id, 'wallet-1')
+          return ok('pirate1current')
+        case 'next_receive_address':
+          assert.strictEqual(request.wallet_id, 'wallet-1')
+          return ok('pirate1next')
         case 'get_balance':
           return ok({ total: '1000', spendable: '900', pending: '100' })
         case 'format_amount':
@@ -158,6 +164,9 @@ async function main() {
   const latestBirthdayHeight = await sdk.getLatestBirthdayHeight('wallet-1')
   assert.strictEqual(latestBirthdayHeight, 345678)
 
+  assert.strictEqual(await sdk.getCurrentAddress('wallet-1'), 'pirate1current')
+  assert.strictEqual(await sdk.getNextAddress('wallet-1'), 'pirate1next')
+
   const groups = await sdk.advancedKeyManagement.listKeyGroups('wallet-1')
   assert.strictEqual(groups.length, 1)