react-native-pdf417-scanner 1.2.0 → 1.4.0

package/README.md

@@ -13,7 +13,15 @@ A comprehensive React Native SDK for live PDF417 barcode scanning with **native
 - **🛡️ Error Handling**: Comprehensive error reporting and recovery
 - **📝 TypeScript Support**: Full TypeScript definitions included
 
-## What's New in v1.2.0
+## What's New in v1.4.0
+
+- **🔧 Camera Fixes**: Resolved "Failed to start preview" errors with enhanced error handling
+- **🔄 Retry Logic**: Automatic camera initialization retry (up to 3 attempts)
+- **📱 Better Compatibility**: Improved Camera2 API configuration for various devices
+- **🛠️ Enhanced Debugging**: Comprehensive logging and troubleshooting guide
+- **⚡ Stability Improvements**: Better threading and surface texture handling
+
+## Previous Updates (v1.2.0)
 
 - **Native Camera View Component**: Show live camera feed instead of black screen
 - **Real-time Preview**: See exactly what the camera sees while scanning
@@ -529,24 +537,61 @@ const ScannerWithLifecycle = () => {
 
 ### Common Issues
 
-1. **Camera Permission Denied**
+1. **"Failed to start preview" Error**
+   - **Cause**: Camera initialization issues, surface texture not ready, or device compatibility
+   - **Solution**: The package now includes automatic retry logic (up to 3 attempts)
+   - **Manual Fix**: Restart the app, check camera permissions, or try on a different device
+
+2. **Camera Permission Denied**
    - Ensure permissions are declared in AndroidManifest.xml
    - Request permissions before starting scanning
    - Handle permission denial gracefully
 
-2. **Build Errors**
+3. **Camera Already in Use**
+   - Close other camera applications
+   - Restart the device if the issue persists
+   - Check if another part of your app is using the camera
+
+4. **Build Errors**
    - Verify all Gradle configurations are correct
    - Ensure ZXing dependencies are properly resolved
    - Clean and rebuild the project
 
-3. **Scanner Not Working**
+5. **Scanner Not Working**
    - Check device camera functionality
    - Verify proper lighting conditions
    - Ensure PDF417 barcode is clearly visible
 
+### Camera Error Recovery
+
+The package now includes enhanced error recovery:
+
+```typescript
+const handleScanError = (error: PDF417ScanError) => {
+  if (error.code === 'CAMERA_ERROR') {
+    if (error.message.includes('permission')) {
+      // Handle permission issues
+      requestCameraPermission();
+    } else if (error.message.includes('preview')) {
+      // Handle camera preview issues - retry automatically
+      setTimeout(() => startScanning(), 1000);
+    }
+  }
+};
+```
+
+### Device-Specific Issues
+
+- **Samsung Devices**: Disable "Camera Assistant" if experiencing issues
+- **Huawei/Honor**: Check "Phone Manager" permissions
+- **Xiaomi**: Grant "Display pop-up windows" permission in MIUI settings
+
 ### Debug Mode
 
-Enable debug logging by setting the log level in your native module configuration.
+Enable debug logging by checking Android logs:
+```bash
+adb logcat | grep -E "(PDF417|Camera|ERROR)"
+```
 
 ## Requirements
 

package/android/src/main/java/com/pdf417scanner/PDF417CameraView.java

@@ -1,6 +1,8 @@
 package com.pdf417scanner;
 
+import android.Manifest;
 import android.content.Context;
+import android.content.pm.PackageManager;
 import android.graphics.SurfaceTexture;
 import android.hardware.camera2.CameraAccessException;
 import android.hardware.camera2.CameraCaptureSession;
@@ -18,6 +20,7 @@ import android.view.Surface;
 import android.view.TextureView;
 
 import androidx.annotation.NonNull;
+import androidx.core.app.ActivityCompat;
 
 import java.util.Arrays;
 import java.util.concurrent.Semaphore;
@@ -67,9 +70,24 @@ public class PDF417CameraView extends TextureView implements TextureView.Surface
     }
 
     public void startCamera() {
+        Log.d(TAG, "Starting camera...");
         startBackgroundThread();
-        if (isAvailable()) {
-            openCamera(getWidth(), getHeight());
+        
+        // Add a small delay to ensure background thread is ready
+        if (backgroundHandler != null) {
+            backgroundHandler.post(() -> {
+                if (isAvailable()) {
+                    openCamera(getWidth(), getHeight());
+                } else {
+                    Log.d(TAG, "Surface texture not available yet, waiting...");
+                    // Will be called from onSurfaceTextureAvailable
+                }
+            });
+        } else {
+            Log.e(TAG, "Background handler not ready");
+            if (cameraReadyListener != null) {
+                cameraReadyListener.onCameraError("Camera initialization failed");
+            }
         }
     }
 
@@ -118,21 +136,47 @@ public class PDF417CameraView extends TextureView implements TextureView.Surface
 
     private void openCamera(int width, int height) {
         try {
+            // Check camera permission first
+            if (ActivityCompat.checkSelfPermission(getContext(), Manifest.permission.CAMERA) 
+                != PackageManager.PERMISSION_GRANTED) {
+                Log.e(TAG, "Camera permission not granted");
+                if (cameraReadyListener != null) {
+                    cameraReadyListener.onCameraError("Camera permission not granted");
+                }
+                return;
+            }
+
             if (!cameraOpenCloseLock.tryAcquire(2500, TimeUnit.MILLISECONDS)) {
                 throw new RuntimeException("Time out waiting to lock camera opening.");
             }
 
             cameraId = selectCamera();
             if (cameraId == null) {
+                Log.e(TAG, "No suitable camera found");
                 if (cameraReadyListener != null) {
                     cameraReadyListener.onCameraError("No suitable camera found");
                 }
+                cameraOpenCloseLock.release();
                 return;
             }
 
+            Log.d(TAG, "Opening camera: " + cameraId);
             cameraManager.openCamera(cameraId, stateCallback, backgroundHandler);
+        } catch (CameraAccessException e) {
+            Log.e(TAG, "Camera access exception", e);
+            cameraOpenCloseLock.release();
+            if (cameraReadyListener != null) {
+                cameraReadyListener.onCameraError("Camera access denied: " + e.getMessage());
+            }
+        } catch (SecurityException e) {
+            Log.e(TAG, "Security exception opening camera", e);
+            cameraOpenCloseLock.release();
+            if (cameraReadyListener != null) {
+                cameraReadyListener.onCameraError("Camera security error: " + e.getMessage());
+            }
         } catch (Exception e) {
-            Log.e(TAG, "Error opening camera", e);
+            Log.e(TAG, "Unexpected error opening camera", e);
+            cameraOpenCloseLock.release();
             if (cameraReadyListener != null) {
                 cameraReadyListener.onCameraError("Failed to open camera: " + e.getMessage());
             }
@@ -193,44 +237,93 @@ public class PDF417CameraView extends TextureView implements TextureView.Surface
     private void createCameraPreviewSession() {
         try {
             SurfaceTexture texture = getSurfaceTexture();
+            if (texture == null) {
+                Log.e(TAG, "Surface texture not available, retrying...");
+                // Retry after a short delay
+                backgroundHandler.postDelayed(() -> {
+                    if (cameraDevice != null) {
+                        createCameraPreviewSession();
+                    }
+                }, 100);
+                return;
+            }
+            
+            // Ensure surface texture is properly configured
+            if (previewSize == null) {
+                Log.e(TAG, "Preview size not set");
+                if (cameraReadyListener != null) {
+                    cameraReadyListener.onCameraError("Preview size not configured");
+                }
+                return;
+            }
+            
             texture.setDefaultBufferSize(previewSize.getWidth(), previewSize.getHeight());
             Surface surface = new Surface(texture);
 
             CaptureRequest.Builder builder = cameraDevice.createCaptureRequest(CameraDevice.TEMPLATE_PREVIEW);
             builder.addTarget(surface);
+            
+            // Enhanced camera settings for better compatibility
             builder.set(CaptureRequest.CONTROL_AF_MODE, CaptureRequest.CONTROL_AF_MODE_CONTINUOUS_PICTURE);
+            builder.set(CaptureRequest.CONTROL_AE_MODE, CaptureRequest.CONTROL_AE_MODE_ON);
+            builder.set(CaptureRequest.CONTROL_AWB_MODE, CaptureRequest.CONTROL_AWB_MODE_AUTO);
+            
+            // Set initial flash mode
+            builder.set(CaptureRequest.FLASH_MODE, torchEnabled ? 
+                CaptureRequest.FLASH_MODE_TORCH : CaptureRequest.FLASH_MODE_OFF);
 
             cameraDevice.createCaptureSession(Arrays.asList(surface),
                 new CameraCaptureSession.StateCallback() {
                     @Override
                     public void onConfigured(@NonNull CameraCaptureSession session) {
-                        if (cameraDevice == null) return;
+                        if (cameraDevice == null) {
+                            Log.w(TAG, "Camera device null during session configuration");
+                            return;
+                        }
                         
                         captureSession = session;
                         try {
-                            session.setRepeatingRequest(builder.build(), null, backgroundHandler);
+                            CaptureRequest request = builder.build();
+                            session.setRepeatingRequest(request, null, backgroundHandler);
+                            Log.d(TAG, "Camera preview started successfully");
                             if (cameraReadyListener != null) {
                                 cameraReadyListener.onCameraReady();
                             }
                         } catch (CameraAccessException e) {
                             Log.e(TAG, "Error starting camera preview", e);
                             if (cameraReadyListener != null) {
-                                cameraReadyListener.onCameraError("Failed to start preview");
+                                cameraReadyListener.onCameraError("Failed to start preview: " + e.getMessage());
+                            }
+                        } catch (IllegalStateException e) {
+                            Log.e(TAG, "Camera in illegal state", e);
+                            if (cameraReadyListener != null) {
+                                cameraReadyListener.onCameraError("Camera state error: " + e.getMessage());
                             }
                         }
                     }
 
                     @Override
                     public void onConfigureFailed(@NonNull CameraCaptureSession session) {
+                        Log.e(TAG, "Camera session configuration failed");
                         if (cameraReadyListener != null) {
-                            cameraReadyListener.onCameraError("Failed to configure camera");
+                            cameraReadyListener.onCameraError("Failed to configure camera session");
                         }
                     }
-                }, null);
+                    
+                    @Override
+                    public void onClosed(@NonNull CameraCaptureSession session) {
+                        Log.d(TAG, "Camera session closed");
+                    }
+                }, backgroundHandler);
         } catch (CameraAccessException e) {
             Log.e(TAG, "Error creating camera preview session", e);
             if (cameraReadyListener != null) {
-                cameraReadyListener.onCameraError("Failed to create preview session");
+                cameraReadyListener.onCameraError("Failed to create preview session: " + e.getMessage());
+            }
+        } catch (Exception e) {
+            Log.e(TAG, "Unexpected error in camera preview session", e);
+            if (cameraReadyListener != null) {
+                cameraReadyListener.onCameraError("Unexpected camera error: " + e.getMessage());
             }
         }
     }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "react-native-pdf417-scanner",
-  "version": "1.2.0",
+  "version": "1.4.0",
   "description": "React Native SDK for PDF417 barcode scanning with native camera view",
   "main": "lib/index.js",
   "types": "lib/index.d.ts",