react-native-pdf 6.7.5 → 6.7.7

package/PdfView.js

@@ -40,6 +40,8 @@ export default class PdfView extends Component {
         singlePage: PropTypes.bool,
         onPageSingleTap: PropTypes.func,
         onScaleChanged: PropTypes.func,
+        showsHorizontalScrollIndicator: PropTypes.bool,
+        showsVerticalScrollIndicator: PropTypes.bool,
     };
 
     static defaultProps = {
@@ -62,6 +64,8 @@ export default class PdfView extends Component {
         },
         onScaleChanged: (scale) => {
         },
+        showsHorizontalScrollIndicator: true,
+        showsVerticalScrollIndicator: true,
     };
 
     constructor(props) {

package/README.md

@@ -168,8 +168,21 @@ react-native run-ios
 ### ChangeLog
 <details>
   <summary>ChangeLog details</summary>
-v6.7.5
+v6.7.7
+1. Added: add support for customizable scroll indicators in PdfView component (#904)
+2. Fixed: fix field values not being visible on android. issue #864 :bug: (#896)
+
+v6.7.6
+1. Fixed: Add missing 'enableDoubleTapZoom' to fabric codegen source (#832)
+2. Fixed: added missing 'scrollEnabled' prop (#842)
+3. Fixed: java.lang.IllegalStateException: Tried to access a JS module before the React instance was fully set up (#840)
+4. Fixed: an issue that crashes when cancel is not present (#852)
+5. Added: add load method (#861)
+6. Fixed: encoded accented character is decoded incorrectly (#873)
+7. Fixed: enableDoubleTapZoom bugfix
+
 
+v6.7.5
 1. Added progressContainerStyle prop
 2. Improved: Added enableDoubleTapZoom option
 3. Fixed: Fix app crash with this.lastRNBFTask.cancel is not a function (#827)
@@ -307,6 +320,7 @@ const styles = StyleSheet.create({
 | horizontal                     |                             bool                              |          false           | draw page direction, if you want to listen the orientation change, you can use [[react-native-orientation-locker]](https://github.com/wonday/react-native-orientation-locker) | ✔   | ✔       | ✔                           | <3.0                     |
 | showsHorizontalScrollIndicator |                             bool                              |           true           | shows or hides the horizontal scroll bar indicator on iOS                                                                                                                     | ✔   |         |                             | 6.6                      |
 | showsVerticalScrollIndicator   |                             bool                              |           true           | shows or hides the vertical scroll bar indicator on iOS                                                                                                                       | ✔   |         |                             | 6.6                      |
+| scrollEnabled   |                             bool                              |           true           | enable or disable scroll                                                                                                                       | ✔   |         |                             | 6.6                      |
 | fitWidth                       |                             bool                              |          false           | if true fit the width of view, can not use fitWidth=true together with scale                                                                                                  | ✔   | ✔       | ✔                           | <3.0, abandoned from 3.0 |
 | fitPolicy                      |                            number                             |            2             | 0:fit width, 1:fit height, 2:fit both(default)                                                                                                                                | ✔   | ✔       | ✔                           | 3.0                      |
 | spacing                        |                            number                             |            10            | the breaker size between pages                                                                                                                                                | ✔   | ✔       | ✔                           | <3.0                     |
@@ -377,5 +391,4 @@ Set the current page of the PDF component. pageNumber is a positive integer. If
 Example:
 ```
 this.pdf.setPage(42); // Display the answer to the Ultimate Question of Life, the Universe, and Everything
-```
-
+```

package/android/build.gradle

@@ -126,6 +126,6 @@ dependencies {
     // The repo from zacharee is based on PdfiumAndroidKt, a much newer fork of PdfiumAndroid, with better maintenance and updated native libraries.
     implementation 'com.github.zacharee:AndroidPdfViewer:4.0.1'
     // Depend on PdfiumAndroidKt directly so this can be updated independently of AndroidPdfViewer as updates are provided.
-    implementation 'io.legere:pdfiumandroid:1.0.19'
+    implementation 'io.legere:pdfiumandroid:1.0.24'
     implementation 'com.google.code.gson:gson:2.8.5'
 }

package/android/src/main/java/org/wonday/pdf/PdfManager.java

@@ -104,6 +104,11 @@ public class PdfManager extends SimpleViewManager<PdfView> implements RNPDFPdfVi
         // NOOP on Android
     }
 
+    @ReactProp(name = "scrollEnabled")
+    public void setScrollEnabled(PdfView view, boolean scrollEnabled) {
+        pdfView.setScrollEnabled(scrollEnabled);
+    }
+
     @ReactProp(name = "spacing")
     public void setSpacing(PdfView pdfView, int spacing) {
         pdfView.setSpacing(spacing);

package/android/src/main/java/org/wonday/pdf/PdfView.java

@@ -22,6 +22,8 @@ import android.view.MotionEvent;
 import android.graphics.Canvas;
 
 
+import com.facebook.react.uimanager.ThemedReactContext;
+import com.facebook.react.uimanager.UIManagerHelper;
 import com.github.barteksc.pdfviewer.PDFView;
 import com.github.barteksc.pdfviewer.listener.OnPageChangeListener;
 import com.github.barteksc.pdfviewer.listener.OnLoadCompleteListener;
@@ -34,17 +36,15 @@ import com.github.barteksc.pdfviewer.util.Constants;
 import com.github.barteksc.pdfviewer.link.LinkHandler;
 import com.github.barteksc.pdfviewer.model.LinkTapEvent;
 
-import com.facebook.react.bridge.NativeModule;
 import com.facebook.react.bridge.ReactContext;
 import com.facebook.react.bridge.Arguments;
 import com.facebook.react.bridge.WritableMap;
-import com.facebook.react.uimanager.SimpleViewManager;
-import com.facebook.react.uimanager.annotations.ReactProp;
+import com.facebook.react.bridge.ReactContext;
+import com.facebook.react.uimanager.UIManagerModule;
+import com.facebook.react.uimanager.events.EventDispatcher;
+import com.facebook.react.uimanager.events.Event;
 import com.facebook.react.uimanager.events.RCTEventEmitter;
-import com.facebook.react.common.MapBuilder;
-import com.facebook.react.modules.core.DeviceEventManagerModule;
-import com.facebook.common.logging.FLog;
-import com.facebook.react.common.ReactConstants;
+
 
 import static java.lang.String.format;
 
@@ -53,6 +53,8 @@ import java.io.InputStream;
 
 import com.google.gson.Gson;
 
+import org.wonday.pdf.events.TopChangeEvent;
+
 public class PdfView extends PDFView implements OnPageChangeListener,OnLoadCompleteListener,OnErrorListener,OnTapListener,OnDrawListener,OnPageScrollListener, LinkHandler {
     private int page = 1;               // start from 1
     private boolean horizontal = false;
@@ -72,6 +74,7 @@ public class PdfView extends PDFView implements OnPageChangeListener,OnLoadCompl
     private boolean pageSnap = false;
     private FitPolicy fitPolicy = FitPolicy.WIDTH;
     private boolean singlePage = false;
+    private boolean scrollEnabled = true;
 
     private float originalWidth = 0;
     private float lastPageWidth = 0;
@@ -94,12 +97,23 @@ public class PdfView extends PDFView implements OnPageChangeListener,OnLoadCompl
 
         WritableMap event = Arguments.createMap();
         event.putString("message", "pageChanged|"+page+"|"+numberOfPages);
-        ReactContext reactContext = (ReactContext)this.getContext();
-        reactContext.getJSModule(RCTEventEmitter.class).receiveEvent(
-            this.getId(),
-            "topChange",
-            event
-         );
+
+        ThemedReactContext context = (ThemedReactContext) getContext();
+        EventDispatcher dispatcher = UIManagerHelper.getEventDispatcherForReactTag(context, getId());
+        int surfaceId = UIManagerHelper.getSurfaceId(this);
+
+        TopChangeEvent tce = new TopChangeEvent(surfaceId, getId(), event);
+
+        if (dispatcher != null) {
+            dispatcher.dispatchEvent(tce);
+        }
+
+//        ReactContext reactContext = (ReactContext)this.getContext();
+//        reactContext.getJSModule(RCTEventEmitter.class).receiveEvent(
+//            this.getId(),
+//            "topChange",
+//            event
+//         );
     }
 
     // In some cases Yoga (I think) will measure the view only along one axis first, resulting in
@@ -135,12 +149,22 @@ public class PdfView extends PDFView implements OnPageChangeListener,OnLoadCompl
         //create a new json Object for the TableOfContents
         Gson gson = new Gson();
         event.putString("message", "loadComplete|"+numberOfPages+"|"+width+"|"+height+"|"+gson.toJson(this.getTableOfContents()));
-        ReactContext reactContext = (ReactContext)this.getContext();
-        reactContext.getJSModule(RCTEventEmitter.class).receiveEvent(
-            this.getId(),
-            "topChange",
-            event
-         );
+
+        ThemedReactContext context = (ThemedReactContext) getContext();
+        EventDispatcher dispatcher = UIManagerHelper.getEventDispatcherForReactTag(context, getId());
+        int surfaceId = UIManagerHelper.getSurfaceId(this);
+
+        TopChangeEvent tce = new TopChangeEvent(surfaceId, getId(), event);
+
+        if (dispatcher != null) {
+            dispatcher.dispatchEvent(tce);
+        }
+        //        ReactContext reactContext = (ReactContext)this.getContext();
+//        reactContext.getJSModule(RCTEventEmitter.class).receiveEvent(
+//            this.getId(),
+//            "topChange",
+//            event
+//         );
 
         //Log.e("ReactNative", gson.toJson(this.getTableOfContents()));
 
@@ -155,12 +179,22 @@ public class PdfView extends PDFView implements OnPageChangeListener,OnLoadCompl
             event.putString("message", "error|"+t.getMessage());
         }
 
-        ReactContext reactContext = (ReactContext)this.getContext();
-        reactContext.getJSModule(RCTEventEmitter.class).receiveEvent(
-            this.getId(),
-            "topChange",
-            event
-         );
+        ThemedReactContext context = (ThemedReactContext) getContext();
+        EventDispatcher dispatcher = UIManagerHelper.getEventDispatcherForReactTag(context, getId());
+        int surfaceId = UIManagerHelper.getSurfaceId(this);
+
+        TopChangeEvent tce = new TopChangeEvent(surfaceId, getId(), event);
+
+        if (dispatcher != null) {
+            dispatcher.dispatchEvent(tce);
+        }
+
+//        ReactContext reactContext = (ReactContext)this.getContext();
+//        reactContext.getJSModule(RCTEventEmitter.class).receiveEvent(
+//            this.getId(),
+//            "topChange",
+//            event
+//         );
     }
 
     @Override
@@ -182,12 +216,21 @@ public class PdfView extends PDFView implements OnPageChangeListener,OnLoadCompl
         WritableMap event = Arguments.createMap();
         event.putString("message", "pageSingleTap|"+page+"|"+e.getX()+"|"+e.getY());
 
-        ReactContext reactContext = (ReactContext)this.getContext();
-        reactContext.getJSModule(RCTEventEmitter.class).receiveEvent(
-            this.getId(),
-            "topChange",
-            event
-         );
+        ThemedReactContext context = (ThemedReactContext) getContext();
+        EventDispatcher dispatcher = UIManagerHelper.getEventDispatcherForReactTag(context, getId());
+        int surfaceId = UIManagerHelper.getSurfaceId(this);
+
+        TopChangeEvent tce = new TopChangeEvent(surfaceId, getId(), event);
+
+        if (dispatcher != null) {
+            dispatcher.dispatchEvent(tce);
+        }
+//        ReactContext reactContext = (ReactContext)this.getContext();
+//        reactContext.getJSModule(RCTEventEmitter.class).receiveEvent(
+//            this.getId(),
+//            "topChange",
+//            event
+//         );
 
         // process as tap
          return true;
@@ -207,13 +250,21 @@ public class PdfView extends PDFView implements OnPageChangeListener,OnLoadCompl
 
             WritableMap event = Arguments.createMap();
             event.putString("message", "scaleChanged|"+(pageWidth/originalWidth));
+            ThemedReactContext context = (ThemedReactContext) getContext();
+            EventDispatcher dispatcher = UIManagerHelper.getEventDispatcherForReactTag(context, getId());
+            int surfaceId = UIManagerHelper.getSurfaceId(this);
+
+            TopChangeEvent tce = new TopChangeEvent(surfaceId, getId(), event);
 
-            ReactContext reactContext = (ReactContext)this.getContext();
-            reactContext.getJSModule(RCTEventEmitter.class).receiveEvent(
-                this.getId(),
-                "topChange",
-                event
-             );
+            if (dispatcher != null) {
+                dispatcher.dispatchEvent(tce);
+            }
+//            ReactContext reactContext = (ReactContext)this.getContext();
+//            reactContext.getJSModule(RCTEventEmitter.class).receiveEvent(
+//                this.getId(),
+//                "topChange",
+//                event
+//             );
         }
 
         lastPageWidth = pageWidth;
@@ -269,7 +320,7 @@ public class PdfView extends PDFView implements OnPageChangeListener,OnLoadCompl
                 .pageSnap(this.pageSnap)
                 .autoSpacing(this.autoSpacing)
                 .pageFling(this.pageFling)
-                .enableSwipe(!this.singlePage)
+                .enableSwipe(!this.singlePage && this.scrollEnabled)
                 .enableDoubletap(!this.singlePage && this.enableDoubleTapZoom)
                 .enableAnnotationRendering(this.enableAnnotationRendering)
                 .linkHandler(this);
@@ -314,6 +365,10 @@ public class PdfView extends PDFView implements OnPageChangeListener,OnLoadCompl
         this.horizontal = horizontal;
     }
 
+    public void setScrollEnabled(boolean scrollEnabled) {
+        this.scrollEnabled = scrollEnabled;
+    }
+
     public void setSpacing(int spacing) {
         this.spacing = spacing;
     }
@@ -385,12 +440,22 @@ public class PdfView extends PDFView implements OnPageChangeListener,OnLoadCompl
         WritableMap event = Arguments.createMap();
         event.putString("message", "linkPressed|"+uri);
 
-        ReactContext reactContext = (ReactContext)this.getContext();
-        reactContext.getJSModule(RCTEventEmitter.class).receiveEvent(
-            this.getId(),
-            "topChange",
-            event
-        );
+        ThemedReactContext context = (ThemedReactContext) getContext();
+        EventDispatcher dispatcher = UIManagerHelper.getEventDispatcherForReactTag(context, getId());
+        int surfaceId = UIManagerHelper.getSurfaceId(this);
+
+        TopChangeEvent tce = new TopChangeEvent(surfaceId, getId(), event);
+
+        if (dispatcher != null) {
+            dispatcher.dispatchEvent(tce);
+        }
+
+//        ReactContext reactContext = (ReactContext)this.getContext();
+//        reactContext.getJSModule(RCTEventEmitter.class).receiveEvent(
+//            this.getId(),
+//            "topChange",
+//            event
+//        );
     }
 
     /**
@@ -437,4 +502,4 @@ public class PdfView extends PDFView implements OnPageChangeListener,OnLoadCompl
             }
         }
     }
-}
+}

package/android/src/main/java/org/wonday/pdf/events/TopChangeEvent.java

@@ -0,0 +1,26 @@
+package org.wonday.pdf.events;
+
+import androidx.annotation.Nullable;
+
+import com.facebook.react.bridge.WritableMap;
+import com.facebook.react.uimanager.events.Event;
+
+public class TopChangeEvent extends Event<TopChangeEvent> {
+    private WritableMap eventData;
+
+    public TopChangeEvent(int surfaceId, int viewTag, WritableMap data) {
+        super(surfaceId, viewTag);
+        eventData = data;
+    }
+
+    @Override
+    public String getEventName() {
+        return "topChange";
+    }
+
+    @Nullable
+    @Override
+    protected WritableMap getEventData() {
+        return eventData;
+    }
+}

package/android/src/paper/java/com/facebook/react/viewmanagers/RNPDFPdfViewManagerDelegate.java

@@ -13,9 +13,10 @@ import android.view.View;
 import androidx.annotation.Nullable;
 import com.facebook.react.bridge.ReadableArray;
 import com.facebook.react.uimanager.BaseViewManagerDelegate;
-import com.facebook.react.uimanager.BaseViewManagerInterface;
+import com.facebook.react.uimanager.BaseViewManager;
+import com.facebook.react.uimanager.LayoutShadowNode;
 
-public class RNPDFPdfViewManagerDelegate<T extends View, U extends BaseViewManagerInterface<T> & RNPDFPdfViewManagerInterface<T>> extends BaseViewManagerDelegate<T, U> {
+public class RNPDFPdfViewManagerDelegate<T extends View, U extends BaseViewManager<T, ? extends LayoutShadowNode> & RNPDFPdfViewManagerInterface<T>> extends BaseViewManagerDelegate<T, U> {
   public RNPDFPdfViewManagerDelegate(U viewManager) {
     super(viewManager);
   }
@@ -46,6 +47,9 @@ public class RNPDFPdfViewManagerDelegate<T extends View, U extends BaseViewManag
       case "showsVerticalScrollIndicator":
         mViewManager.setShowsVerticalScrollIndicator(view, value == null ? false : (boolean) value);
         break;
+      case "scrollEnabled":
+        mViewManager.setScrollEnabled(view, value == null ? false : (boolean) value);
+        break;
       case "enablePaging":
         mViewManager.setEnablePaging(view, value == null ? false : (boolean) value);
         break;

package/android/src/paper/java/com/facebook/react/viewmanagers/RNPDFPdfViewManagerInterface.java

@@ -21,6 +21,7 @@ public interface RNPDFPdfViewManagerInterface<T extends View> {
   void setHorizontal(T view, boolean value);
   void setShowsHorizontalScrollIndicator(T view, boolean value);
   void setShowsVerticalScrollIndicator(T view, boolean value);
+  void setScrollEnabled(T view, boolean value);
   void setEnablePaging(T view, boolean value);
   void setEnableRTL(T view, boolean value);
   void setEnableAnnotationRendering(T view, boolean value);

package/fabric/RNPDFPdfNativeComponent.js

@@ -24,7 +24,9 @@
    enableAnnotationRendering: ?boolean,
    showsHorizontalScrollIndicator: ?boolean,
    showsVerticalScrollIndicator: ?boolean,
+   scrollEnabled: ?boolean,
    enableAntialiasing: ?boolean,
+   enableDoubleTapZoom: ?boolean,
    fitPolicy: ?Int32,
    spacing: ?Int32,
    password: ?string,
@@ -43,4 +45,4 @@ export const Commands: NativeCommands = codegenNativeCommands<NativeCommands>({
   supportedCommands: ['setNativePage'],
 });
 
- export default codegenNativeComponent<NativeProps>('RNPDFPdfView');
+ export default codegenNativeComponent<NativeProps>('RNPDFPdfView');

package/index.d.ts

@@ -38,6 +38,7 @@ export interface PdfProps {
     horizontal?: boolean,
     showsHorizontalScrollIndicator?: boolean,
     showsVerticalScrollIndicator?: boolean,
+    scrollEnabled?: boolean,
     spacing?: number,
     password?: string,
     renderActivityIndicator?: (progress: number) => React.ReactElement,
@@ -46,7 +47,13 @@ export interface PdfProps {
     enableRTL?: boolean,
     enableAnnotationRendering?: boolean,
     enableDoubleTapZoom?: boolean;
-    fitPolicy?: number,
+    /**
+     * Fit policy.  This will adjust the initial zoom of the PDF based on the initial size of the view and the scale factor.
+     * 0 = fit width
+     * 1 = fit height
+     * 2 = fit both
+     */
+    fitPolicy?: 0 | 1 | 2,
     trustAllCerts?: boolean,
     singlePage?: boolean,
     onLoadProgress?: (percent: number,) => void,

package/index.js

@@ -51,6 +51,7 @@ export default class Pdf extends Component {
         enableAnnotationRendering: PropTypes.bool,
         showsHorizontalScrollIndicator: PropTypes.bool,
         showsVerticalScrollIndicator: PropTypes.bool,
+        scrollEnabled: PropTypes.bool,
         enablePaging: PropTypes.bool,
         enableRTL: PropTypes.bool,
         fitPolicy: PropTypes.number,
@@ -86,6 +87,7 @@ export default class Pdf extends Component {
         enableAnnotationRendering: true,
         showsHorizontalScrollIndicator: true,
         showsVerticalScrollIndicator: true,
+        scrollEnabled: true,
         enablePaging: false,
         enableRTL: false,
         trustAllCerts: true,
@@ -127,7 +129,7 @@ export default class Pdf extends Component {
 
         if ((nextSource.uri !== curSource.uri)) {
             // if has download task, then cancel it.
-            if (this.lastRNBFTask) {
+            if (this.lastRNBFTask && this.lastRNBFTask.cancel) {
                 this.lastRNBFTask.cancel(err => {
                     this._loadFromSource(this.props.source);
                 });
@@ -233,7 +235,7 @@ export default class Pdf extends Component {
                 } else {
                     if (this._mounted) {
                        this.setState({
-                            path: unescape(uri.replace(/file:\/\//i, '')),
+                            path: decodeURIComponent(uri.replace(/file:\/\//i, '')),
                             isDownloaded: true,
                         });
                     }

package/index.js.flow

@@ -41,6 +41,7 @@ export type Props = {
   horizontal?: boolean,
   showsHorizontalScrollIndicator?: boolean,
   showsVerticalScrollIndicator?: boolean,
+  scrollEnabled?: boolean,
   maxScale?: number,
   minScale?: number,
   singlePage?: boolean,

package/ios/RNPDFPdf/RNPDFPdfView.h

@@ -40,6 +40,7 @@ UIView
 @property(nonatomic) BOOL horizontal;
 @property(nonatomic) BOOL showsVerticalScrollIndicator;
 @property(nonatomic) BOOL showsHorizontalScrollIndicator;
+@property(nonatomic) BOOL scrollEnabled;
 @property(nonatomic) BOOL enablePaging;
 @property(nonatomic) BOOL enableRTL;
 @property(nonatomic) BOOL enableAnnotationRendering;

package/ios/RNPDFPdf/RNPDFPdfView.mm

@@ -86,6 +86,12 @@ using namespace facebook::react;
   return concreteComponentDescriptorProvider<RNPDFPdfViewComponentDescriptor>();
 }
 
+// Needed because of this: https://github.com/facebook/react-native/pull/37274
++ (void)load
+{
+  [super load];
+}
+
 - (instancetype)initWithFrame:(CGRect)frame
 {
     if (self = [super initWithFrame:frame]) {
@@ -165,6 +171,11 @@ using namespace facebook::react;
         [updatedPropNames addObject:@"showsVerticalScrollIndicator"];
     }
 
+    if (_scrollEnabled != newProps.scrollEnabled) {
+        _scrollEnabled = newProps.scrollEnabled;
+        [updatedPropNames addObject:@"scrollEnabled"];
+    }
+
     [super updateProps:props oldProps:oldProps];
     [self didSetProps:updatedPropNames];
 }
@@ -252,6 +263,7 @@ using namespace facebook::react;
     _singlePage = NO;
     _showsHorizontalScrollIndicator = YES;
     _showsVerticalScrollIndicator = YES;
+    _scrollEnabled = YES;
 
     // init and config PDFView
     _pdfView = [[PDFView alloc] initWithFrame:CGRectMake(0, 0, 500, 500)];
@@ -467,37 +479,23 @@ using namespace facebook::react;
             }
         }
 
-        if (_pdfDocument && ([changedProps containsObject:@"path"] || [changedProps containsObject:@"showsHorizontalScrollIndicator"])) {
-            if (_showsHorizontalScrollIndicator) {
-                for (UIView *subview in _pdfView.subviews) {
-                    if ([subview isKindOfClass:[UIScrollView class]]) {
-                        UIScrollView *scrollView = (UIScrollView *)subview;
-                        scrollView.showsHorizontalScrollIndicator = YES;
-                    }
-                }
-            } else {
-                for (UIView *subview in _pdfView.subviews) {
-                    if ([subview isKindOfClass:[UIScrollView class]]) {
-                        UIScrollView *scrollView = (UIScrollView *)subview;
-                        scrollView.showsHorizontalScrollIndicator = NO;
-                    }
-                }
-            }
+        if (_pdfDocument && ([changedProps containsObject:@"path"] || [changedProps containsObject:@"showsHorizontalScrollIndicator"] || [changedProps containsObject:@"showsVerticalScrollIndicator"])) {
+            [self setScrollIndicators:self horizontal:_showsHorizontalScrollIndicator vertical:_showsVerticalScrollIndicator depth:0];
         }
 
-        if (_pdfDocument && ([changedProps containsObject:@"path"] || [changedProps containsObject:@"showsVerticalScrollIndicator"])) {
-            if (_showsVerticalScrollIndicator) {
+        if (_pdfDocument && ([changedProps containsObject:@"path"] || [changedProps containsObject:@"scrollEnabled"])) {
+            if (_scrollEnabled) {
                 for (UIView *subview in _pdfView.subviews) {
                     if ([subview isKindOfClass:[UIScrollView class]]) {
                         UIScrollView *scrollView = (UIScrollView *)subview;
-                        scrollView.showsVerticalScrollIndicator = YES;
+                        scrollView.scrollEnabled = YES;
                     }
                 }
             } else {
                 for (UIView *subview in _pdfView.subviews) {
                     if ([subview isKindOfClass:[UIScrollView class]]) {
                         UIScrollView *scrollView = (UIScrollView *)subview;
-                        scrollView.showsVerticalScrollIndicator = NO;
+                        scrollView.scrollEnabled = NO;
                     }
                 }
             }
@@ -732,7 +730,7 @@ using namespace facebook::react;
     });
 
     // Event appears to be consumed; broadcast for JS.
-    _onChange(@{ @"message": @"pageDoubleTap" });
+    // _onChange(@{ @"message": @"pageDoubleTap" });
 
     if (!_enableDoubleTapZoom) {
         return;
@@ -898,6 +896,23 @@ using namespace facebook::react;
     return !_singlePage;
 }
 
+- (void)setScrollIndicators:(UIView *)view horizontal:(BOOL)horizontal vertical:(BOOL)vertical depth:(int)depth {
+    // max depth, prevent infinite loop
+    if (depth > 10) {
+        return;
+    }
+    
+    if ([view isKindOfClass:[UIScrollView class]]) {
+        UIScrollView *scrollView = (UIScrollView *)view;
+        scrollView.showsHorizontalScrollIndicator = horizontal;
+        scrollView.showsVerticalScrollIndicator = vertical;
+    }
+    
+    for (UIView *subview in view.subviews) {
+        [self setScrollIndicators:subview horizontal:horizontal vertical:vertical depth:depth + 1];
+    }
+}
+
 @end
 
 #ifdef RCT_NEW_ARCH_ENABLED

package/ios/RNPDFPdf/RNPDFPdfViewManager.mm

@@ -35,6 +35,7 @@ RCT_EXPORT_VIEW_PROPERTY(maxScale, float);
 RCT_EXPORT_VIEW_PROPERTY(horizontal, BOOL);
 RCT_EXPORT_VIEW_PROPERTY(showsHorizontalScrollIndicator, BOOL);
 RCT_EXPORT_VIEW_PROPERTY(showsVerticalScrollIndicator, BOOL);
+RCT_EXPORT_VIEW_PROPERTY(scrollEnabled, BOOL);
 RCT_EXPORT_VIEW_PROPERTY(enablePaging, BOOL);
 RCT_EXPORT_VIEW_PROPERTY(enableRTL, BOOL);
 RCT_EXPORT_VIEW_PROPERTY(enableAnnotationRendering, BOOL);

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "react-native-pdf",
-    "version": "6.7.5",
+    "version": "6.7.7",
     "summary": "A react native PDF view component",
     "description": "A react native PDF view component, support ios and android platform",
     "main": "index.js",