react-native-pdf 6.7.1 → 6.7.2

package/PdfView.js

@@ -8,7 +8,7 @@
 
 'use strict';
 import React, {Component} from 'react';
-import {ScrollView, FlatList, View, StyleSheet} from 'react-native';
+import {ScrollView, View, StyleSheet} from 'react-native';
 import {ViewPropTypes} from 'deprecated-react-native-prop-types';
 import PropTypes from 'prop-types';
 
@@ -413,4 +413,4 @@ const styles = StyleSheet.create({
     container: {
         flex: 1
     }
-});
+});

package/PdfViewFlatList.js

@@ -7,7 +7,6 @@
  */
 
 'use strict';
-import React, {Component} from 'react';
 import {
     FlatList,
 } from 'react-native';
@@ -28,4 +27,4 @@ export default class PdfViewFlatList extends FlatList {
         this._listRef._scrollRef.scrollTo({x: x, y: y, animated: false});
     }
 
-}
+}

package/README.md

@@ -169,6 +169,11 @@ react-native run-ios
 <details>
   <summary>ChangeLog details</summary>
 
+v6.7.2
+1. Fixed: fix iOS double tap zoom scrolling
+2. Fixed: fix RN 73 compatibility
+3. Fixed: bump crypto-js to avoid critical vulnerability
+
 v6.7.1
 1. Fixed: fix ios project setting
 2. Fixed: fix typo in RNPDFPdfViewManagerInterface interface causing android build error

package/android/build.gradle

@@ -79,6 +79,10 @@ if (isNewArchitectureEnabled()) {
 }
 
 android {
+    def agpVersion = com.android.Version.ANDROID_GRADLE_PLUGIN_VERSION
+    if (agpVersion.tokenize('.')[0].toInteger() >= 7) {
+        namespace "com.wonday.rnpdf"
+    }
     compileSdkVersion safeExtGet('compileSdkVersion', 31)
 
     defaultConfig {

package/android/src/main/AndroidManifest.xml

@@ -1,5 +1,4 @@
-<manifest xmlns:android="http://schemas.android.com/apk/res/android"
-          package="org.wonday.pdf">
+<manifest xmlns:android="http://schemas.android.com/apk/res/android">
 
 
-</manifest>
+</manifest>

package/index.d.ts

@@ -27,7 +27,7 @@ export type Source = {
     method?: string;
 };
 
-interface Props {
+interface PdfProps {
     style?: ReactNative.StyleProp<ReactNative.ViewStyle>,
     source: Source | number,
     page?: number,
@@ -56,7 +56,7 @@ interface Props {
     onPressLink?: (url: string) => void,
 }
 
-declare class Pdf extends React.Component<Props, any> {
+declare class Pdf extends React.Component<PdfProps, any> {
     setPage: (pageNumber: number) => void;
 }
 

package/index.js

@@ -14,7 +14,8 @@ import {
     Platform,
     StyleSheet,
     Image,
-    Text
+    Text,
+    requireNativeComponent
 } from 'react-native';
 import PdfViewNativeComponent, {
     Commands as PdfViewCommands,

package/ios/RNPDFPdf/RNPDFPdfView.mm

@@ -74,6 +74,7 @@ const float MIN_SCALE = 1.0f;
     UITapGestureRecognizer *_singleTapRecognizer;
     UIPinchGestureRecognizer *_pinchRecognizer;
     UILongPressGestureRecognizer *_longPressRecognizer;
+    UITapGestureRecognizer *_doubleTapEmptyRecognizer;
 }
 
 #ifdef RCT_NEW_ARCH_ENABLED
@@ -187,6 +188,7 @@ using namespace facebook::react;
     [self removeGestureRecognizer:_singleTapRecognizer];
     [self removeGestureRecognizer:_pinchRecognizer];
     [self removeGestureRecognizer:_longPressRecognizer];
+    [self removeGestureRecognizer:_doubleTapEmptyRecognizer];
 
     [self initCommonProps];
 }
@@ -556,6 +558,7 @@ using namespace facebook::react;
     _singleTapRecognizer = nil;
     _pinchRecognizer = nil;
     _longPressRecognizer = nil;
+    _doubleTapEmptyRecognizer = nil;
 }
 
 #pragma mark notification process
@@ -687,6 +690,13 @@ using namespace facebook::react;
 
 #pragma mark gesture process
 
+/**
+ *  Empty double tap handler
+ *
+ *
+ */
+- (void)handleDoubleTapEmpty:(UITapGestureRecognizer *)recognizer {}
+
 /**
  *  Tap
  *  zoom reset or zoom in
@@ -836,6 +846,12 @@ using namespace facebook::react;
     [self addGestureRecognizer:longPressRecognizer];
     _longPressRecognizer = longPressRecognizer;
 
+    // Override the _pdfView double tap gesture recognizer so that it doesn't confilict with custom double tap
+    UITapGestureRecognizer *doubleTapEmptyRecognizer = [[UITapGestureRecognizer alloc] initWithTarget:self
+                                                                                          action:@selector(handleDoubleTapEmpty:)];
+    doubleTapEmptyRecognizer.numberOfTapsRequired = 2;
+    [_pdfView addGestureRecognizer:doubleTapEmptyRecognizer];
+    _doubleTapEmptyRecognizer = doubleTapEmptyRecognizer;
 }
 
 - (BOOL)gestureRecognizerShouldBegin:(UIGestureRecognizer *)gestureRecognizer

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "react-native-pdf",
-    "version": "6.7.1",
+    "version": "6.7.2",
     "summary": "A react native PDF view component",
     "description": "A react native PDF view component, support ios and android platform",
     "main": "index.js",
@@ -28,7 +28,7 @@
         "url": "https://github.com/wonday/react-native-pdf/issues"
     },
     "dependencies": {
-        "crypto-js": "^3.2.0",
+        "crypto-js": "4.2.0",
         "deprecated-react-native-prop-types": "^2.3.0"
     },
     "devDependencies": {