react-native-pdf 6.6.2 → 6.7.1

package/README.md

@@ -114,14 +114,14 @@ in the app `.vcxproj` file, before `<None Include="packages.config" />`.
 <details>
   <summary>FAQ details</summary>
 
-Q1. After installation and running, I can not see the pdf file.
+Q1. After installation and running, I can not see the pdf file.  
 A1: maybe you forgot to excute ```react-native link``` or it does not run correctly.
 You can add it manually. For detail you can see the issue [`#24`](https://github.com/wonday/react-native-pdf/issues/24) and [`#2`](https://github.com/wonday/react-native-pdf/issues/2)
 
-Q2. When running, it shows ```'Pdf' has no propType for native prop RCTPdf.acessibilityLabel of native type 'String'```
+Q2. When running, it shows ```'Pdf' has no propType for native prop RCTPdf.acessibilityLabel of native type 'String'```  
 A2. Your react-native version is too old, please upgrade it to 0.47.0+ see also [`#39`](https://github.com/wonday/react-native-pdf/issues/39)
 
-Q3. When I run the example app I get a white/gray screen / the loading bar isn't progressing .
+Q3. When I run the example app I get a white/gray screen / the loading bar isn't progressing .  
 A3. Check your uri, if you hit a pdf that is hosted on a `http` you will need to do the following:
 
 **iOS:**
@@ -151,10 +151,10 @@ add an exception for the server hosting the pdf in the ios `info.plist`. Here is
 **Android:**
 [`see here`](https://stackoverflow.com/questions/54818098/cleartext-http-traffic-not-permitted)
 
-Q4. why doesn't it work with react native expo?.
+Q4. why doesn't it work with react native expo?.  
 A4. Expo does not support native module. you can read more expo caveats [`here`](https://facebook.github.io/react-native/docs/getting-started.html#caveats)
 
-Q5. Why can't I run the iOS example? `'Failed to build iOS project. We ran "xcodebuild" command but it exited with error code 65.'`
+Q5. Why can't I run the iOS example? `'Failed to build iOS project. We ran "xcodebuild" command but it exited with error code 65.'`  
 A5. Run the following commands in the project folder (e.g. `react-native-pdf/example`) to ensure that all dependencies are available:
 ```
 yarn install (or npm install)
@@ -169,6 +169,16 @@ react-native run-ios
 <details>
   <summary>ChangeLog details</summary>
 
+v6.7.1
+1. Fixed: fix ios project setting
+2. Fixed: fix typo in RNPDFPdfViewManagerInterface interface causing android build error
+
+v6.7.0
+1. Fixed: fix(iOS): center page at tap point after double tap to zoom
+2. Fixed: add PDFKit to podspec to make ios compile
+3. Improved: Update build.gradle to support RN 0.71 on new arch
+4. Fixed: fix some small bugs and documents.
+
 v6.6.2
 1. Fixed: Migrate to ViewPropTypes exported from 'deprecated-react-native-prop-types'
 2. Added: Decode File Path for iOS
@@ -200,42 +210,6 @@ v6.3.0
 1. Add windows support
 2. Fixed some bugs
 
-v6.2.2
-1. Fixed incorrect type of onPageSingleTap and onScaleChanged argument
-2. Fixed included missing setPage method in TypeScript and Flow types
-3. fixed Xcode 12 compatibility
-
-v6.2.1
-1. Fixed typescript `onLoadComplete()` definition
-2. Switched the AndroidPdfViewer dependency from Barteksc repo to TalbotGooday
-3. Add singlePage property
-
-v6.2.0
-1. Fixed ReferenceError, url should be source.uri
-2. Dependency bump to support React-Native >= 0.62
-
-v6.1.2
-1. Fixed wrong scale returned from onScaleChanged()
-2. Fixed iOS Double Tap zoom
-3. Fixed Some critical typo fixes
-
-v6.1.1
-1. Fixed undefined is not an object, crashing on ios
-
-v6.1.0
-1. Fixed react-native warning on `componentWill*`
-2. Fixed onPageSingleTap
-3. Set the PDF View background color to be transparent On iOS
-
-v6.0.1
-1. Expose prop to trust self-signed SSL certs
-2. Use ViewStyleProp in index.js.flow, not deprecated StyleSheet.Styles
-
-v6.0.0
-1. Add JS callback onPressLink for pdf link press listener
-2. Fix calling setState while unmounted
-
-
 [[more]](https://github.com/wonday/react-native-pdf/releases)
 
 </details>
@@ -314,6 +288,8 @@ const styles = StyleSheet.create({
 | minScale         | number        | 1.0              | min scale| ✔   | ✔ | ✔ | 5.0.5 |
 | maxScale         | number        | 3.0              | max scale| ✔   | ✔ | ✔ | 5.0.5 |
 | horizontal    | bool          | false            | draw page direction, if you want to listen the orientation change, you can use  [[react-native-orientation-locker]](https://github.com/wonday/react-native-orientation-locker)| ✔   | ✔ | ✔ | <3.0 |
+| showsHorizontalScrollIndicator    | bool          | true            | shows or hides the horizontal scroll bar indicator on iOS| ✔   |  |  | 6.6 |
+| showsVerticalScrollIndicator    | bool          | true            | shows or hides the vertical scroll bar indicator on iOS| ✔   |  |  | 6.6 |
 | fitWidth      | bool          | false            | if true fit the width of view, can not use fitWidth=true together with scale| ✔   | ✔ | ✔ | <3.0, abandoned from 3.0 |
 | fitPolicy     | number        | 2                | 0:fit width, 1:fit height, 2:fit both(default)| ✔   | ✔ | ✔ | 3.0 |
 | spacing       | number        | 10               | the breaker size between pages| ✔   | ✔ | ✔ | <3.0 |

package/android/build.gradle

@@ -1,46 +1,100 @@
 description = 'react-native-pdf'
 
 buildscript {
+    ext.safeExtGet = {prop, fallback ->
+        rootProject.ext.has(prop) ? rootProject.ext.get(prop) : fallback
+    }
     repositories {
         mavenCentral()
         google()
     }
 
     dependencies {
-        classpath 'com.android.tools.build:gradle:3.1.4'
+        classpath("com.android.tools.build:gradle:7.2.0")
     }
 }
 
 repositories {
     mavenCentral()
     maven {
-        url 'https://jitpack.io'
+        // All of React Native (JS, Obj-C sources, Android binaries) is installed from npm
+        url "$projectDir/../node_modules/react-native/android"
         content {
             // Use Jitpack only for AndroidPdfViewer; the rest is hosted at mavenCentral.
             includeGroup "com.github.TalbotGooday"
         }
     }
+    maven { url 'https://jitpack.io' }
 }
 
 apply plugin: 'com.android.library'
 
-def _ext = rootProject.ext
+def resolveReactNativeDirectory() {
+    def reactNativeLocation = safeExtGet("REACT_NATIVE_NODE_MODULES_DIR", null)
+    if (reactNativeLocation != null) {
+        return file(reactNativeLocation)
+    }
+
+    // monorepo workaround
+    // react-native can be hoisted or in project's own node_modules
+    def reactNativeFromProjectNodeModules = file("${rootProject.projectDir}/../node_modules/react-native")
+    if (reactNativeFromProjectNodeModules.exists()) {
+        return reactNativeFromProjectNodeModules
+    }
+
+    def reactNativeFromNodeModulesWithPDF = file("${projectDir}/../../react-native")
+    if (reactNativeFromNodeModulesWithPDF.exists()) {
+        return reactNativeFromNodeModulesWithPDF
+    }
+
+    throw new Exception(
+            "[react-native-pdf] Unable to resolve react-native location in " +
+                    "node_modules. You should add project extension property (in app/build.gradle) " +
+                    "`REACT_NATIVE_NODE_MODULES_DIR` with path to react-native."
+    )
+}
+
+def getReactNativeMinorVersion() {
+    def REACT_NATIVE_DIR = resolveReactNativeDirectory()
 
-def _reactNativeVersion = _ext.has('reactNative') ? _ext.reactNative : '+'
-def _compileSdkVersion = _ext.has('compileSdkVersion') ? _ext.compileSdkVersion : 28
-def _buildToolsVersion = _ext.has('buildToolsVersion') ? _ext.buildToolsVersion : '28.0.3'
-def _minSdkVersion = _ext.has('minSdkVersion') ? _ext.minSdkVersion : 16
-def _targetSdkVersion = _ext.has('targetSdkVersion') ? _ext.targetSdkVersion : 28
+    def reactProperties = new Properties()
+    file("$REACT_NATIVE_DIR/ReactAndroid/gradle.properties").withInputStream { reactProperties.load(it) }
 
+    def REACT_NATIVE_VERSION = reactProperties.getProperty("VERSION_NAME")
+    def REACT_NATIVE_MINOR_VERSION = REACT_NATIVE_VERSION.startsWith("0.0.0-") ? 1000 : REACT_NATIVE_VERSION.split("\\.")[1].toInteger()
 
+    return REACT_NATIVE_MINOR_VERSION
+}
+
+def isNewArchitectureEnabled() {
+    // To opt-in for the New Architecture, you can either:
+    // - Set `newArchEnabled` to true inside the `gradle.properties` file
+    // - Invoke gradle with `-newArchEnabled=true`
+    // - Set an environment variable `ORG_GRADLE_PROJECT_newArchEnabled=true`
+    return project.hasProperty("newArchEnabled") && project.newArchEnabled == "true"
+}
+
+if (isNewArchitectureEnabled()) {
+    apply plugin: "com.facebook.react"
+}
 
 android {
-    compileSdkVersion _compileSdkVersion
-    buildToolsVersion _buildToolsVersion
+    compileSdkVersion safeExtGet('compileSdkVersion', 31)
 
     defaultConfig {
-        minSdkVersion _minSdkVersion
-        targetSdkVersion _targetSdkVersion
+        minSdkVersion safeExtGet('minSdkVersion', 21)
+        targetSdkVersion safeExtGet('targetSdkVersion', 31)
+        buildConfigField("boolean", "IS_NEW_ARCHITECTURE_ENABLED", isNewArchitectureEnabled().toString())
+    }
+
+    sourceSets.main {
+        java {
+            if (!isNewArchitectureEnabled()) {
+                srcDirs += [
+                    "src/paper/java",
+                ]
+            }
+        }
     }
 
     lintOptions {
@@ -58,7 +112,11 @@ android {
 }
 
 dependencies {
-    implementation "com.facebook.react:react-native:${_reactNativeVersion}"
+    if (isNewArchitectureEnabled() && getReactNativeMinorVersion() < 71) {
+        implementation project(":ReactAndroid")
+    } else {
+        implementation 'com.facebook.react:react-native:+'
+    }
     // NOTE: The original repo at com.github.barteksc is abandoned by the maintainer; there will be no more updates coming from that repo.
     //       It was taken over by com.github.TalbotGooday; from now on please use this repo until (if ever) the Barteksc repo is resumed.
     implementation 'com.github.TalbotGooday:AndroidPdfViewer:3.1.0-beta.3'

package/android/src/main/java/org/wonday/pdf/{RCTPdfManager.java → PdfManager.java}

@@ -8,39 +8,43 @@
 
 package org.wonday.pdf;
 
-import java.io.File;
-
 import android.content.Context;
-import android.view.ViewGroup;
-import android.util.Log;
-import android.graphics.PointF;
-import android.net.Uri;
 
-import com.facebook.react.bridge.NativeModule;
+import androidx.annotation.NonNull;
+import androidx.annotation.Nullable;
+
+import com.facebook.infer.annotation.Assertions;
 import com.facebook.react.bridge.ReactApplicationContext;
-import com.facebook.react.bridge.ReactContext;
-import com.facebook.react.bridge.Arguments;
-import com.facebook.react.bridge.WritableMap;
+import com.facebook.react.bridge.ReadableArray;
+import com.facebook.react.module.annotations.ReactModule;
 import com.facebook.react.uimanager.SimpleViewManager;
 import com.facebook.react.uimanager.ThemedReactContext;
 import com.facebook.react.uimanager.annotations.ReactProp;
-import com.facebook.react.uimanager.events.RCTEventEmitter;
-import com.facebook.react.common.MapBuilder;
-import com.facebook.react.modules.core.DeviceEventManagerModule;
-
-import static java.lang.String.format;
-import java.lang.ClassCastException;
 
-import com.github.barteksc.pdfviewer.util.FitPolicy;
+import com.facebook.react.uimanager.ViewManagerDelegate;
+import com.facebook.react.viewmanagers.RNPDFPdfViewManagerDelegate;
+import com.facebook.react.viewmanagers.RNPDFPdfViewManagerInterface;
 
-public class RCTPdfManager extends SimpleViewManager<PdfView> {
-    private static final String REACT_CLASS = "RCTPdf";
+@ReactModule(name = PdfManager.REACT_CLASS)
+public class PdfManager extends SimpleViewManager<PdfView> implements RNPDFPdfViewManagerInterface<PdfView> {
+    public static final String REACT_CLASS = "RNPDFPdfView";
     private Context context;
     private PdfView pdfView;
+    private final ViewManagerDelegate<PdfView> mDelegate;
+
+    @Nullable
+    @Override
+    protected ViewManagerDelegate<PdfView> getDelegate() {
+        return mDelegate;
+    }
 
+    public PdfManager() {
+        mDelegate = new RNPDFPdfViewManagerDelegate<>(this);
+    }
 
-    public RCTPdfManager(ReactApplicationContext reactContext){
+    public PdfManager(ReactApplicationContext reactContext){
         this.context = reactContext;
+        mDelegate = new RNPDFPdfViewManagerDelegate<>(this);
     }
 
     @Override
@@ -90,6 +94,16 @@ public class RCTPdfManager extends SimpleViewManager<PdfView> {
         pdfView.setHorizontal(horizontal);
     }
 
+    @Override
+    public void setShowsHorizontalScrollIndicator(PdfView view, boolean value) {
+        // NOOP on Android
+    }
+
+    @Override
+    public void setShowsVerticalScrollIndicator(PdfView view, boolean value) {
+        // NOOP on Android
+    }
+
     @ReactProp(name = "spacing")
     public void setSpacing(PdfView pdfView, int spacing) {
         pdfView.setSpacing(spacing);
@@ -115,8 +129,13 @@ public class RCTPdfManager extends SimpleViewManager<PdfView> {
         pdfView.setEnablePaging(enablePaging);
     }
 
+    @Override
+    public void setEnableRTL(PdfView view, boolean value) {
+        // NOOP on Android
+    }
+
     @ReactProp(name = "fitPolicy")
-    public void setFitPolycy(PdfView pdfView, int fitPolicy) {
+    public void setFitPolicy(PdfView pdfView, int fitPolicy) {
         pdfView.setFitPolicy(fitPolicy);
     }
 
@@ -125,6 +144,23 @@ public class RCTPdfManager extends SimpleViewManager<PdfView> {
         pdfView.setSinglePage(singlePage);
     }
 
+    // It seems funny, but this method is called through delegate on Paper, but on Fabric we need to
+    // use `receiveCommand` method and call this one there
+    @Override
+    public void setNativePage(PdfView view, int page) {
+        pdfView.setPage(page);
+    }
+
+    @Override
+    public void receiveCommand(@NonNull PdfView root, String commandId, @androidx.annotation.Nullable ReadableArray args) {
+        Assertions.assertNotNull(root);
+        if ("setNativePage".equals(commandId)) {
+            Assertions.assertNotNull(args);
+            assert args != null;
+            setNativePage(root, args.getInt(0));
+        }
+    }
+
     @Override
     public void onAfterUpdateTransaction(PdfView pdfView) {
         super.onAfterUpdateTransaction(pdfView);

package/android/src/main/java/org/wonday/pdf/PdfView.java

@@ -87,6 +87,10 @@ public class PdfView extends PDFView implements OnPageChangeListener,OnLoadCompl
     private float lastPageWidth = 0;
     private float lastPageHeight = 0;
 
+    // used to store the parameters for `super.onSizeChanged`
+    private int oldW = 0;
+    private int oldH = 0;
+
     public PdfView(ThemedReactContext context, AttributeSet set){
         super(context,set);
         this.context = context;
@@ -110,6 +114,27 @@ public class PdfView extends PDFView implements OnPageChangeListener,OnLoadCompl
          );
     }
 
+    // In some cases Yoga (I think) will measure the view only along one axis first, resulting in
+    // onSizeChanged being called with either w or h set to zero. This in turn starts the rendering
+    // of the pdf under the hood with one dimension being set to zero and the follow-up call to
+    // onSizeChanged with the correct dimensions doesn't have any effect on the already started process.
+    // The offending class is DecodingAsyncTask, which tries to get width and height of the pdfView
+    // in the constructor, and is created as soon as the measurement is complete, which in some cases
+    // may be incomplete as described above.
+    // By delaying calling super.onSizeChanged until the size in both dimensions is correct we are able
+    // to prevent this from happening.
+    //
+    // I'm not sure whether the second condition is necessary, but without it, it would be impossible
+    // to set the dimensions to zero after first measurement.
+    @Override
+    protected void onSizeChanged(int w, int h, int oldw, int oldh) {
+        if ((w > 0 && h > 0) || this.oldW > 0 || this.oldH > 0) {
+            super.onSizeChanged(w, h, this.oldW, this.oldH);
+            this.oldW = w;
+            this.oldH = h;
+        }
+    }
+
     @Override
     public void loadComplete(int numberOfPages) {
         SizeF pageSize = getPageSize(0);

package/android/src/main/java/org/wonday/pdf/{RCTPdfView.java → RNPDFPackage.java}

@@ -8,7 +8,6 @@
 
 package org.wonday.pdf;
 
-import java.util.Arrays;
 import java.util.Collections;
 import java.util.List;
 import java.util.ArrayList;
@@ -19,7 +18,7 @@ import com.facebook.react.bridge.NativeModule;
 import com.facebook.react.bridge.ReactApplicationContext;
 import com.facebook.react.uimanager.ViewManager;
 
-public class RCTPdfView implements ReactPackage {
+public class RNPDFPackage implements ReactPackage {
 
     @Override
     public List<NativeModule> createNativeModules(ReactApplicationContext reactContext) {
@@ -34,7 +33,7 @@ public class RCTPdfView implements ReactPackage {
     @Override
     public List<ViewManager> createViewManagers(ReactApplicationContext reactContext) {
         List<ViewManager> modules = new ArrayList<>();
-        modules.add(new RCTPdfManager(reactContext));
+        modules.add(new PdfManager(reactContext));
         return modules;
     }
 }

package/android/src/paper/java/com/facebook/react/viewmanagers/RNPDFPdfViewManagerDelegate.java

@@ -0,0 +1,86 @@
+/**
+* This code was generated by [react-native-codegen](https://www.npmjs.com/package/react-native-codegen).
+*
+* Do not edit this file as changes may cause incorrect behavior and will be lost
+* once the code is regenerated.
+*
+* @generated by codegen project: GeneratePropsJavaDelegate.js
+*/
+
+package com.facebook.react.viewmanagers;
+
+import android.view.View;
+import androidx.annotation.Nullable;
+import com.facebook.react.bridge.ReadableArray;
+import com.facebook.react.uimanager.BaseViewManagerDelegate;
+import com.facebook.react.uimanager.BaseViewManagerInterface;
+
+public class RNPDFPdfViewManagerDelegate<T extends View, U extends BaseViewManagerInterface<T> & RNPDFPdfViewManagerInterface<T>> extends BaseViewManagerDelegate<T, U> {
+  public RNPDFPdfViewManagerDelegate(U viewManager) {
+    super(viewManager);
+  }
+  @Override
+  public void setProperty(T view, String propName, @Nullable Object value) {
+    switch (propName) {
+      case "path":
+        mViewManager.setPath(view, value == null ? null : (String) value);
+        break;
+      case "page":
+        mViewManager.setPage(view, value == null ? 0 : ((Double) value).intValue());
+        break;
+      case "scale":
+        mViewManager.setScale(view, value == null ? 0f : ((Double) value).floatValue());
+        break;
+      case "minScale":
+        mViewManager.setMinScale(view, value == null ? 0f : ((Double) value).floatValue());
+        break;
+      case "maxScale":
+        mViewManager.setMaxScale(view, value == null ? 0f : ((Double) value).floatValue());
+        break;
+      case "horizontal":
+        mViewManager.setHorizontal(view, value == null ? false : (boolean) value);
+        break;
+      case "showsHorizontalScrollIndicator":
+        mViewManager.setShowsHorizontalScrollIndicator(view, value == null ? false : (boolean) value);
+        break;
+      case "showsVerticalScrollIndicator":
+        mViewManager.setShowsVerticalScrollIndicator(view, value == null ? false : (boolean) value);
+        break;
+      case "enablePaging":
+        mViewManager.setEnablePaging(view, value == null ? false : (boolean) value);
+        break;
+      case "enableRTL":
+        mViewManager.setEnableRTL(view, value == null ? false : (boolean) value);
+        break;
+      case "enableAnnotationRendering":
+        mViewManager.setEnableAnnotationRendering(view, value == null ? false : (boolean) value);
+        break;
+      case "enableAntialiasing":
+        mViewManager.setEnableAntialiasing(view, value == null ? false : (boolean) value);
+        break;
+      case "fitPolicy":
+        mViewManager.setFitPolicy(view, value == null ? 0 : ((Double) value).intValue());
+        break;
+      case "spacing":
+        mViewManager.setSpacing(view, value == null ? 0 : ((Double) value).intValue());
+        break;
+      case "password":
+        mViewManager.setPassword(view, value == null ? null : (String) value);
+        break;
+      case "singlePage":
+        mViewManager.setSinglePage(view, value == null ? false : (boolean) value);
+        break;
+      default:
+        super.setProperty(view, propName, value);
+    }
+  }
+
+  @Override
+  public void receiveCommand(T view, String commandName, ReadableArray args) {
+    switch (commandName) {
+      case "setNativePage":
+        mViewManager.setNativePage(view, args.getInt(0));
+        break;
+    }
+  }
+}

package/android/src/paper/java/com/facebook/react/viewmanagers/RNPDFPdfViewManagerInterface.java

@@ -0,0 +1,33 @@
+/**
+* This code was generated by [react-native-codegen](https://www.npmjs.com/package/react-native-codegen).
+*
+* Do not edit this file as changes may cause incorrect behavior and will be lost
+* once the code is regenerated.
+*
+* @generated by codegen project: GeneratePropsJavaInterface.js
+*/
+
+package com.facebook.react.viewmanagers;
+
+import android.view.View;
+import androidx.annotation.Nullable;
+
+public interface RNPDFPdfViewManagerInterface<T extends View> {
+  void setPath(T view, @Nullable String value);
+  void setPage(T view, int value);
+  void setScale(T view, float value);
+  void setMinScale(T view, float value);
+  void setMaxScale(T view, float value);
+  void setHorizontal(T view, boolean value);
+  void setShowsHorizontalScrollIndicator(T view, boolean value);
+  void setShowsVerticalScrollIndicator(T view, boolean value);
+  void setEnablePaging(T view, boolean value);
+  void setEnableRTL(T view, boolean value);
+  void setEnableAnnotationRendering(T view, boolean value);
+  void setEnableAntialiasing(T view, boolean value);
+  void setFitPolicy(T view, int value);
+  void setSpacing(T view, int value);
+  void setPassword(T view, @Nullable String value);
+  void setSinglePage(T view, boolean value);
+  void setNativePage(T view, int page);
+}

package/fabric/RNPDFPdfNativeComponent.js

@@ -0,0 +1,46 @@
+/**
+ * @flow
+ * @format
+ */
+ 'use strict';
+
+ import codegenNativeComponent from 'react-native/Libraries/Utilities/codegenNativeComponent';
+ import codegenNativeCommands from 'react-native/Libraries/Utilities/codegenNativeCommands';
+ 
+ type ChangeEvent = $ReadOnly<{|
+   message: ?string,
+ |}>;
+ 
+ export type NativeProps = $ReadOnly<{|
+   ...ViewProps,
+   path: ?string,
+   page: ?Int32,
+   scale: ?Float,
+   minScale: ?Float,
+   maxScale: ?Float,
+   horizontal: ?boolean,
+   enablePaging: ?boolean,
+   enableRTL: ?boolean,
+   enableAnnotationRendering: ?boolean,
+   showsHorizontalScrollIndicator: ?boolean,
+   showsVerticalScrollIndicator: ?boolean,
+   enableAntialiasing: ?boolean,
+   fitPolicy: ?Int32,
+   spacing: ?Int32,
+   password: ?string,
+   onChange: ?BubblingEventHandler<ChangeEvent>,
+   singlePage: ?boolean,
+ |}>;
+
+ interface NativeCommands {
+  +setNativePage: (
+    viewRef: React.ElementRef<ComponentType>,
+    page: Int32,
+  ) => void;
+}
+
+export const Commands: NativeCommands = codegenNativeCommands<NativeCommands>({
+  supportedCommands: ['setNativePage'],
+});
+
+ export default codegenNativeComponent<NativeProps>('RNPDFPdfView');

package/index.d.ts

@@ -35,6 +35,8 @@ interface Props {
     minScale?: number,
     maxScale?: number,
     horizontal?: boolean,
+    showsHorizontalScrollIndicator?: boolean,
+    showsVerticalScrollIndicator?: boolean,
     spacing?: number,
     password?: string,
     renderActivityIndicator?: (progress: number) => React.ReactElement,