react-native-ota-hot-update 2.0.1 → 2.0.3

package/README.md

@@ -1,6 +1,6 @@
 # react-native-ota-hot-update
 
-A React Native module that allows you to control hot update same as Code Push, less config than Code Push, you can control version manager, hosting bundle js by your self, this library just control install the hot update after bundle js downloaded from your side. As we know, Code push is going to retirement in next year, that why i create that library for you can control bundle js from your backend side.
+A React Native module that allows you to control hot update same as Code Push, less config than Code Push, you can control version manager, hosting bundle js by your self, this library just control install the hot update after bundle js downloaded from your side. As we know, Code push is going to retirement soon, that why i create that library for you can control bundle js from your backend side.
 
 
 iOS GIF             | Android GIF
@@ -12,7 +12,7 @@ iOS GIF             | Android GIF
 
 ## New architecture supported
 
-New architecture backward compatibility supported from version 2, it also supported old architecture, for source code of old architecture please refer to branch `oldArch`
+New architecture backward compatibility supported from version 2, it also supported old architecture, for source code of version 1.x.x please refer to branch `oldArch`, you might need install version 1.x.x if you are using react native < 0.70
 
 ## Installation
 
@@ -86,29 +86,31 @@ android:requestLegacyExternalStorage="true"
 `
 
 ## That's it, can check the example code
+`Remember hot update just work at release mode, debug mode won't working`
+
 
 Here is the guideline to control bundle js by yourself, in here i am using Firebase storage to store bundlejs file and a json file that announce new version is comming:
 
-#### 1.Add these script into your package.json to export bundlejs file:
+#### 1.Add these script into your package.json to export bundlejs file and source map file:
 
 - For react native CLI:
 ```bash
 "scripts": {
-  "export-android": "mkdir -p android/output && react-native bundle --platform android --dev false --entry-file index.js --bundle-output android/output/index.android.bundle --assets-dest android/output  && cd android && find output -type f | zip index.android.bundle.zip -@ && cd .. && rm -rf android/output",
-  "export-ios": "mkdir -p ios/output && react-native bundle --platform ios --dev false --entry-file index.js --bundle-output ios/output/main.jsbundle --assets-dest ios/output && cd ios && find output -type f | zip main.jsbundle.zip -@ && cd .. && rm -rf ios/output"
+  "export-android": "mkdir -p android/output && react-native bundle --platform android --dev false --entry-file index.js --bundle-output android/output/index.android.bundle --assets-dest android/output --sourcemap-output android/sourcemap.js && cd android && find output -type f | zip index.android.bundle.zip -@ && zip sourcemap.zip sourcemap.js && cd .. && rm -rf android/output && rm -rf android/sourcemap.js",
+  "export-ios": "mkdir -p ios/output && react-native bundle --platform ios --dev false --entry-file index.js --bundle-output ios/output/main.jsbundle --assets-dest ios/output --sourcemap-output ios/sourcemap.js && cd ios && find output -type f | zip main.jsbundle.zip -@ && zip sourcemap.zip sourcemap.js && cd .. && rm -rf ios/output && rm -rf ios/sourcemap.js"
 }
 ```
 - For expo / expo bare project:
 
 ```bash
 "scripts": {
-  "export-android": "mkdir -p android/output && npx expo export:embed --platform android --entry-file node_modules/expo/AppEntry.js --bundle-output android/output/index.android.bundle --dev false  --assets-dest android/output && cd android && find output -type f | zip index.android.bundle.zip -@ && cd .. && rm -rf android/output",
-  "export-ios": "mkdir -p ios/output && npx expo export:embed --platform ios --entry-file node_modules/expo/AppEntry.js --bundle-output ios/output/main.jsbundle --dev false  --assets-dest ios/output && cd ios && find output -type f | zip main.jsbundle.zip -@ && cd .. && rm -rf ios/output"
+  "export-android": "mkdir -p android/output && npx expo export:embed --platform android --entry-file node_modules/expo/AppEntry.js --bundle-output android/output/index.android.bundle --dev false  --assets-dest android/output --sourcemap-output android/sourcemap.js && cd android && find output -type f | zip index.android.bundle.zip -@ && zip sourcemap.zip sourcemap.js && cd .. && rm -rf android/output && rm -rf android/sourcemap.js",
+  "export-ios": "mkdir -p ios/output && npx expo export:embed --platform ios --entry-file node_modules/expo/AppEntry.js --bundle-output ios/output/main.jsbundle --dev false  --assets-dest ios/output --sourcemap-output ios/sourcemap.js && cd ios && find output -type f | zip main.jsbundle.zip -@ && zip sourcemap.zip sourcemap.js && cd .. && rm -rf ios/output && rm -rf ios/sourcemap.js"
 }
 ```
 For expo you might need check path of `--entry-file node_modules/expo/AppEntry.js`, get it from package.json / main
 
-These commands are export bundle file and compress it as a zip file, one for android and one for ios. You can create your own script that export and auto upload to your server.
+These commands are export bundle file and source map file then compress it as a zip file, one for android and one for ios. You can create your own script that export and auto upload to your server. For source map file you can ignore or use that with your purpose to debug in release mode.
 
 Then create an json file: `update.json` like that:
 ```bash
@@ -191,4 +193,8 @@ The same method as `react-native-blob-util` or `rn-fetch-blob`
 
 ## License
 
-[MIT](LICENSE.md)
+[MIT](LICENSE)
+
+
+### Sponsor this project
+https://paypal.me/vantuan88291

package/android/src/main/java/com/otahotupdate/OtaHotUpdateModule.kt

@@ -84,17 +84,21 @@ class OtaHotUpdateModule internal constructor(context: ReactApplicationContext)
   @ReactMethod
   override fun setupBundlePath(path: String?, extension: String?, promise: Promise) {
     if (path != null) {
-      deleteOldBundleIfneeded()
       val file = File(path)
       if (file.exists() && file.isFile) {
+        deleteOldBundleIfneeded()
         val fileUnzip = extractZipFile(file, extension ?: ".bundle")
-        Log.d("setupBundlePath----: ", fileUnzip!!)
         if (fileUnzip != null) {
+          Log.d("setupBundlePath----: ", fileUnzip)
           file.delete()
           val sharedPrefs = SharedPrefs(reactApplicationContext)
           sharedPrefs.putString(PATH, fileUnzip)
           promise.resolve(true)
         } else {
+          file.delete()
+          deleteDirectory(file.parentFile)
+          val sharedPrefs = SharedPrefs(reactApplicationContext)
+          sharedPrefs.putString(PATH, "")
           promise.resolve(false)
         }
       } else {

package/ios/OtaHotUpdate.mm

@@ -171,8 +171,8 @@ RCT_EXPORT_METHOD(setupBundlePath:(NSString *)path extension:(NSString *)extensi
         [self removeBundleIfNeeded];
         //Unzip file
         NSString *extractedFilePath = [self unzipFileAtPath:path extension:(extension != nil) ? extension : @".jsbundle"];
-        NSLog(@"file extraction----- %@", extractedFilePath);
         if (extractedFilePath) {
+            NSLog(@"file extraction----- %@", extractedFilePath);
             NSUserDefaults *defaults = [NSUserDefaults standardUserDefaults];
             [defaults setObject:extractedFilePath forKey:@"PATH"];
             [defaults synchronize];

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "react-native-ota-hot-update",
-  "version": "2.0.1",
+  "version": "2.0.3",
   "description": "Hot update for react native",
   "source": "./src/index.tsx",
   "main": "./lib/commonjs/index.js",
@@ -46,9 +46,15 @@
     "release": "release-it"
   },
   "keywords": [
-    "react-native",
-    "ios",
-    "android"
+    "hot-update",
+    "ota",
+    "code-push",
+    "update",
+    "react-native-hotupdate",
+    "react-native-codepush",
+    "ota-hot-update",
+    "custom-ota",
+    "rn-hotupdate"
   ],
   "repository": {
     "type": "git",