react-native-onyx 3.0.66 → 3.0.67

package/dist/OnyxUtils.d.ts

@@ -257,6 +257,10 @@ declare function mergeCollectionWithPatches<TKey extends CollectionKeyBase>({ co
 declare function partialSetCollection<TKey extends CollectionKeyBase>({ collectionKey, collection }: SetCollectionParams<TKey>, retryAttempt?: number): Promise<void>;
 declare function logKeyChanged(onyxMethod: Extract<OnyxMethod, 'set' | 'merge'>, key: OnyxKey, value: unknown, hasChanged: boolean): void;
 declare function logKeyRemoved(onyxMethod: Extract<OnyxMethod, 'set' | 'merge'>, key: OnyxKey): void;
+/**
+ * Getter - returns the callback to state mapping, useful in test environments.
+ */
+declare function getCallbackToStateMapping(): Record<number, CallbackToStateMapping<OnyxKey>>;
 /**
  * Clear internal variables used in this file, useful in test environments.
  */
@@ -316,6 +320,7 @@ declare const OnyxUtils: {
     setWithRetry: typeof setWithRetry;
     multiSetWithRetry: typeof multiSetWithRetry;
     setCollectionWithRetry: typeof setCollectionWithRetry;
+    getCallbackToStateMapping: typeof getCallbackToStateMapping;
 };
 export type { OnyxMethod };
 export default OnyxUtils;

package/dist/OnyxUtils.js

@@ -866,6 +866,24 @@ function subscribeToKey(connectOptions) {
     const subscriptionID = lastSubscriptionID++;
     callbackToStateMapping[subscriptionID] = mapping;
     callbackToStateMapping[subscriptionID].subscriptionID = subscriptionID;
+    // If the subscriber is attempting to connect to a collection member whose ID is skippable (e.g. "undefined", "null", etc.)
+    // we suppress wiring the subscription fully to avoid unnecessary callback emissions such as for "report_undefined".
+    // We still return a valid subscriptionID so callers can disconnect safely.
+    try {
+        const skippableIDs = getSkippableCollectionMemberIDs();
+        if (skippableIDs.size) {
+            const [, collectionMemberID] = OnyxKeys_1.default.splitCollectionMemberKey(mapping.key);
+            if (skippableIDs.has(collectionMemberID)) {
+                // Clean up the provisional mapping to avoid retaining unused subscribers.
+                OnyxCache_1.default.addNullishStorageKey(mapping.key);
+                delete callbackToStateMapping[subscriptionID];
+                return subscriptionID;
+            }
+        }
+    }
+    catch (e) {
+        // Not a collection member key, proceed as usual.
+    }
     // When keyChanged is called, a key is passed and the method looks through all the Subscribers in callbackToStateMapping for the matching key to get the subscriptionID
     // to avoid having to loop through all the Subscribers all the time (even when just one connection belongs to one key),
     // We create a mapping from key to lists of subscriptionIDs to access the specific list of subscriptionIDs.
@@ -1374,6 +1392,12 @@ function logKeyChanged(onyxMethod, key, value, hasChanged) {
 function logKeyRemoved(onyxMethod, key) {
     Logger.logInfo(`${onyxMethod} called for key: ${key} => null passed, so key was removed`);
 }
+/**
+ * Getter - returns the callback to state mapping, useful in test environments.
+ */
+function getCallbackToStateMapping() {
+    return callbackToStateMapping;
+}
 /**
  * Clear internal variables used in this file, useful in test environments.
  */
@@ -1432,5 +1456,6 @@ const OnyxUtils = {
     setWithRetry,
     multiSetWithRetry,
     setCollectionWithRetry,
+    getCallbackToStateMapping,
 };
 exports.default = OnyxUtils;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "react-native-onyx",
-  "version": "3.0.66",
+  "version": "3.0.67",
   "author": "Expensify, Inc.",
   "homepage": "https://expensify.com",
   "description": "State management for React Native",