react-native-onyx 3.0.41 → 3.0.43

package/dist/storage/providers/SQLiteProvider.js

@@ -86,7 +86,7 @@ const provider = {
         if (!provider.store) {
             throw new Error('Store is not initialized!');
         }
-        const query = 'REPLACE INTO keyvaluepairs (record_key, valueJSON) VALUES (?, json(?));';
+        const query = 'REPLACE INTO keyvaluepairs (record_key, valueJSON) VALUES (?, ?);';
         const params = pairs.map((pair) => [pair[0], JSON.stringify(pair[1] === undefined ? null : pair[1])]);
         if (utils_1.default.isEmptyObject(params)) {
             return Promise.resolve();
@@ -100,12 +100,16 @@ const provider = {
         const commands = [];
         // Query to merge the change into the DB value.
         const patchQuery = `INSERT INTO keyvaluepairs (record_key, valueJSON)
-            VALUES (:key, JSON(:value))
+            VALUES (:key, :value)
             ON CONFLICT DO UPDATE
-            SET valueJSON = JSON_PATCH(valueJSON, JSON(:value));
+            SET valueJSON = JSON_PATCH(valueJSON, :value);
         `;
         const patchQueryArguments = [];
         // Query to fully replace the nested objects of the DB value.
+        // NOTE: The JSON() wrapper around the replacement value is required here. Unlike JSON_PATCH (which
+        // parses both arguments as JSON internally), JSON_REPLACE treats a plain TEXT binding as a quoted
+        // JSON string. Without JSON(), objects would be stored as string values (e.g. "{...}") instead of
+        // actual JSON objects, corrupting the stored data.
         const replaceQuery = `UPDATE keyvaluepairs
             SET valueJSON = JSON_REPLACE(valueJSON, ?, JSON(?))
             WHERE record_key = ?;

package/dist/useOnyx.js

@@ -164,6 +164,10 @@ function useOnyx(key, options, dependencies = []) {
             OnyxConnectionManager_1.default.addToEvictionBlockList(connectionRef.current);
         }
     }, [key, options === null || options === void 0 ? void 0 : options.canEvict]);
+    // Tracks the last memoizedSelector reference that getSnapshot() has computed with.
+    // When the selector changes, this mismatch forces getSnapshot() to re-evaluate
+    // even if all other conditions (isFirstConnection, shouldGetCachedValue, key) are false.
+    const lastComputedSelectorRef = (0, react_1.useRef)(memoizedSelector);
     const getSnapshot = (0, react_1.useCallback)(() => {
         var _a, _b, _c, _d;
         // Check if we have any cache for this Onyx key
@@ -186,10 +190,12 @@ function useOnyx(key, options, dependencies = []) {
         // We get the value from cache while the first connection to Onyx is being made or if the key has changed,
         // so we can return any cached value right away. For the case where the key has changed, If we don't return the cached value right away, then the UI will show the incorrect (previous) value for a brief period which looks like a UI glitch to the user. After the connection is made, we only
         // update `newValueRef` when `Onyx.connect()` callback is fired.
-        if (isFirstConnectionRef.current || shouldGetCachedValueRef.current || key !== previousKey) {
+        const hasSelectorChanged = lastComputedSelectorRef.current !== memoizedSelector;
+        if (isFirstConnectionRef.current || shouldGetCachedValueRef.current || key !== previousKey || hasSelectorChanged) {
             // Gets the value from cache and maps it with selector. It changes `null` to `undefined` for `useOnyx` compatibility.
             const value = OnyxUtils_1.default.tryGetCachedValue(key);
             const selectedValue = memoizedSelector ? memoizedSelector(value) : value;
+            lastComputedSelectorRef.current = memoizedSelector;
             newValueRef.current = (selectedValue !== null && selectedValue !== void 0 ? selectedValue : undefined);
             // We set this flag to `false` again since we don't want to get the newest cached value every time `getSnapshot()` is executed,
             // and only when `Onyx.connect()` callback is fired.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "react-native-onyx",
-  "version": "3.0.41",
+  "version": "3.0.43",
   "author": "Expensify, Inc.",
   "homepage": "https://expensify.com",
   "description": "State management for React Native",