react-native-onyx 2.0.100 → 2.0.102

package/dist/Onyx.js

@@ -28,7 +28,6 @@ var __importDefault = (this && this.__importDefault) || function (mod) {
 Object.defineProperty(exports, "__esModule", { value: true });
 /* eslint-disable no-continue */
 const underscore_1 = __importDefault(require("underscore"));
-const pick_1 = __importDefault(require("lodash/pick"));
 const Logger = __importStar(require("./Logger"));
 const OnyxCache_1 = __importStar(require("./OnyxCache"));
 const PerformanceUtils = __importStar(require("./PerformanceUtils"));
@@ -41,7 +40,7 @@ const OnyxConnectionManager_1 = __importDefault(require("./OnyxConnectionManager
 const GlobalSettings = __importStar(require("./GlobalSettings"));
 const metrics_1 = __importDefault(require("./metrics"));
 /** Initialize the store with actions and listening for storage events */
-function init({ keys = {}, initialKeyStates = {}, safeEvictionKeys = [], maxCachedKeysCount = 1000, shouldSyncMultipleInstances = Boolean(global.localStorage), debugSetState = false, enablePerformanceMetrics = false, skippableCollectionMemberIDs = [], }) {
+function init({ keys = {}, initialKeyStates = {}, safeEvictionKeys = [], maxCachedKeysCount = 1000, shouldSyncMultipleInstances = !!global.localStorage, debugSetState = false, enablePerformanceMetrics = false, skippableCollectionMemberIDs = [], }) {
     var _a;
     if (enablePerformanceMetrics) {
         GlobalSettings.setPerformanceMetricsEnabled(true);
@@ -540,51 +539,6 @@ function clear(keysToPreserve = []) {
         .then(() => undefined);
     return OnyxCache_1.default.captureTask(OnyxCache_1.TASK.CLEAR, promise);
 }
-function updateSnapshots(data) {
-    const snapshotCollectionKey = OnyxUtils_1.default.getSnapshotKey();
-    if (!snapshotCollectionKey)
-        return [];
-    const promises = [];
-    const snapshotCollection = OnyxUtils_1.default.getCachedCollection(snapshotCollectionKey);
-    const snapshotCollectionKeyLength = snapshotCollectionKey.length;
-    Object.entries(snapshotCollection).forEach(([snapshotKey, snapshotValue]) => {
-        // Snapshots may not be present in cache. We don't know how to update them so we skip.
-        if (!snapshotValue) {
-            return;
-        }
-        let updatedData = {};
-        data.forEach(({ key, value }) => {
-            // snapshots are normal keys so we want to skip update if they are written to Onyx
-            if (OnyxUtils_1.default.isCollectionMemberKey(snapshotCollectionKey, key, snapshotCollectionKeyLength)) {
-                return;
-            }
-            if (typeof snapshotValue !== 'object' || !('data' in snapshotValue)) {
-                return;
-            }
-            const snapshotData = snapshotValue.data;
-            if (!snapshotData || !snapshotData[key]) {
-                return;
-            }
-            if (Array.isArray(value) || Array.isArray(snapshotData[key])) {
-                updatedData[key] = value || [];
-                return;
-            }
-            if (value === null) {
-                updatedData[key] = value;
-                return;
-            }
-            const oldValue = updatedData[key] || {};
-            const newValue = (0, pick_1.default)(value, Object.keys(snapshotData[key]));
-            updatedData = Object.assign(Object.assign({}, updatedData), { [key]: Object.assign(oldValue, newValue) });
-        });
-        // Skip the update if there's no data to be merged
-        if (utils_1.default.isEmptyObject(updatedData)) {
-            return;
-        }
-        promises.push(() => merge(snapshotKey, { data: updatedData }));
-    });
-    return promises;
-}
 /**
  * Insert API responses and lifecycle data into Onyx
  *
@@ -699,7 +653,7 @@ function update(data) {
             promises.push(() => merge(key, batchedChanges));
         }
     });
-    const snapshotPromises = updateSnapshots(data);
+    const snapshotPromises = OnyxUtils_1.default.updateSnapshots(data, merge);
     // We need to run the snapshot updates before the other updates so the snapshot data can be updated before the loading state in the snapshot
     const finalPromises = snapshotPromises.concat(promises);
     return clearPromise.then(() => Promise.all(finalPromises.map((p) => p()))).then(() => undefined);

package/dist/OnyxCache.js

@@ -169,10 +169,9 @@ class OnyxCache {
             temp.push(value);
             numKeysToRemove--;
         }
-        // eslint-disable-next-line @typescript-eslint/prefer-for-of
-        for (let i = 0; i < temp.length; ++i) {
-            delete this.storageMap[temp[i]];
-            this.recentKeys.delete(temp[i]);
+        for (const key of temp) {
+            delete this.storageMap[key];
+            this.recentKeys.delete(key);
         }
     }
     /** Set the recent keys list size */

package/dist/OnyxUtils.d.ts

@@ -1,6 +1,7 @@
 import type { ValueOf } from 'type-fest';
 import type Onyx from './Onyx';
-import type { CollectionKey, CollectionKeyBase, ConnectOptions, DeepRecord, KeyValueMapping, Mapping, OnyxCollection, OnyxEntry, OnyxInput, OnyxKey, OnyxMergeCollectionInput, OnyxValue } from './types';
+import type { CollectionKey, CollectionKeyBase, ConnectOptions, DeepRecord, KeyValueMapping, Mapping, OnyxCollection, OnyxEntry, OnyxInput, OnyxKey, OnyxMergeCollectionInput, OnyxUpdate, OnyxValue, Selector } from './types';
+import type { WithOnyxState } from './withOnyx/types';
 import type { DeferredTask } from './createDeferredTask';
 declare const METHOD: {
     readonly SET: "set";
@@ -66,6 +67,12 @@ declare function sendActionToDevTools(method: Exclude<OnyxMethod, typeof METHOD.
  */
 declare function maybeFlushBatchUpdates(): Promise<void>;
 declare function batchUpdates(updates: () => void): Promise<void>;
+/**
+ * Takes a collection of items (eg. {testKey_1:{a:'a'}, testKey_2:{b:'b'}})
+ * and runs it through a reducer function to return a subset of the data according to a selector.
+ * The resulting collection will only contain items that are returned by the selector.
+ */
+declare function reduceCollectionWithSelector<TKey extends CollectionKeyBase, TMap, TReturn>(collection: OnyxCollection<KeyValueMapping[TKey]>, selector: Selector<TKey, TMap, TReturn>, withOnyxInstanceState: WithOnyxState<TMap> | undefined): Record<string, TReturn>;
 /** Get some data from the store */
 declare function get<TKey extends OnyxKey, TValue extends OnyxValue<TKey>>(key: TKey): Promise<TValue>;
 declare function multiGet<TKey extends OnyxKey>(keys: CollectionKeyBase[]): Promise<Map<OnyxKey, OnyxValue<TKey>>>;
@@ -78,6 +85,19 @@ declare function multiGet<TKey extends OnyxKey>(keys: CollectionKeyBase[]): Prom
 declare function tupleGet<Keys extends readonly OnyxKey[]>(keys: Keys): Promise<{
     [Index in keyof Keys]: OnyxValue<Keys[Index]>;
 }>;
+/**
+ * Stores a subscription ID associated with a given key.
+ *
+ * @param subscriptionID - A subscription ID of the subscriber.
+ * @param key - A key that the subscriber is subscribed to.
+ */
+declare function storeKeyBySubscriptions(key: OnyxKey, subscriptionID: number): void;
+/**
+ * Deletes a subscription ID associated with its corresponding key.
+ *
+ * @param subscriptionID - The subscription ID to be deleted.
+ */
+declare function deleteKeyBySubscriptions(subscriptionID: number): void;
 /** Returns current key names stored in persisted storage */
 declare function getAllKeys(): Promise<Set<OnyxKey>>;
 /**
@@ -144,7 +164,7 @@ declare function getCachedCollection<TKey extends CollectionKeyBase>(collectionK
 /**
  * When a collection of keys change, search for any callbacks matching the collection key and trigger those callbacks
  */
-declare function keysChanged<TKey extends CollectionKeyBase>(collectionKey: TKey, partialCollection: OnyxCollection<KeyValueMapping[TKey]>, partialPreviousCollection: OnyxCollection<KeyValueMapping[TKey]> | undefined, notifyRegularSubscibers?: boolean, notifyWithOnyxSubscibers?: boolean): void;
+declare function keysChanged<TKey extends CollectionKeyBase>(collectionKey: TKey, partialCollection: OnyxCollection<KeyValueMapping[TKey]>, partialPreviousCollection: OnyxCollection<KeyValueMapping[TKey]> | undefined, notifyConnectSubscribers?: boolean, notifyWithOnyxSubscribers?: boolean): void;
 /**
  * When a key change happens, search for any callbacks matching the key or collection key and trigger those callbacks
  *
@@ -158,6 +178,11 @@ declare function keyChanged<TKey extends OnyxKey>(key: TKey, value: OnyxValue<TK
  *     - triggers the callback function
  */
 declare function sendDataToConnection<TKey extends OnyxKey>(mapping: Mapping<TKey>, value: OnyxValue<TKey> | null, matchedKey: TKey | undefined, isBatched: boolean): void;
+/**
+ * We check to see if this key is flagged as safe for eviction and add it to the recentlyAccessedKeys list so that when we
+ * run out of storage the least recently accessed key can be removed.
+ */
+declare function addKeyToRecentlyAccessedIfNeeded<TKey extends OnyxKey>(mapping: Mapping<TKey>): void;
 /**
  * Gets the data for a given an array of matching keys, combines them into an object, and sends the result back to the subscriber.
  */
@@ -242,6 +267,7 @@ declare function subscribeToKey<TKey extends OnyxKey>(connectOptions: ConnectOpt
  * @param subscriptionID Subscription ID returned by calling `OnyxUtils.subscribeToKey()`.
  */
 declare function unsubscribeFromKey(subscriptionID: number): void;
+declare function updateSnapshots(data: OnyxUpdate[], mergeFn: typeof Onyx.merge): Array<() => Promise<void>>;
 declare const OnyxUtils: {
     METHOD: {
         readonly SET: "set";
@@ -298,6 +324,11 @@ declare const OnyxUtils: {
     getEvictionBlocklist: typeof getEvictionBlocklist;
     getSkippableCollectionMemberIDs: typeof getSkippableCollectionMemberIDs;
     setSkippableCollectionMemberIDs: typeof setSkippableCollectionMemberIDs;
+    storeKeyBySubscriptions: typeof storeKeyBySubscriptions;
+    deleteKeyBySubscriptions: typeof deleteKeyBySubscriptions;
+    addKeyToRecentlyAccessedIfNeeded: typeof addKeyToRecentlyAccessedIfNeeded;
+    reduceCollectionWithSelector: typeof reduceCollectionWithSelector;
+    updateSnapshots: typeof updateSnapshots;
 };
 export type { OnyxMethod };
 export default OnyxUtils;

package/dist/OnyxUtils.js

@@ -26,10 +26,10 @@ var __importDefault = (this && this.__importDefault) || function (mod) {
     return (mod && mod.__esModule) ? mod : { "default": mod };
 };
 Object.defineProperty(exports, "__esModule", { value: true });
-/* eslint-disable @typescript-eslint/prefer-for-of */
 /* eslint-disable no-continue */
 const fast_equals_1 = require("fast-equals");
 const clone_1 = __importDefault(require("lodash/clone"));
+const pick_1 = __importDefault(require("lodash/pick"));
 const DevTools_1 = __importDefault(require("./DevTools"));
 const Logger = __importStar(require("./Logger"));
 const OnyxCache_1 = __importStar(require("./OnyxCache"));
@@ -526,7 +526,7 @@ function getCachedCollection(collectionKey, collectionMemberKeys) {
 /**
  * When a collection of keys change, search for any callbacks matching the collection key and trigger those callbacks
  */
-function keysChanged(collectionKey, partialCollection, partialPreviousCollection, notifyRegularSubscibers = true, notifyWithOnyxSubscibers = true) {
+function keysChanged(collectionKey, partialCollection, partialPreviousCollection, notifyConnectSubscribers = true, notifyWithOnyxSubscribers = true) {
     // We prepare the "cached collection" which is the entire collection + the new partial data that
     // was merged in via mergeCollection().
     const cachedCollection = getCachedCollection(collectionKey);
@@ -536,8 +536,8 @@ function keysChanged(collectionKey, partialCollection, partialPreviousCollection
     // and does not represent all of the combined keys and values for a collection key. It is just the "new" data that was merged in via mergeCollection().
     const stateMappingKeys = Object.keys(callbackToStateMapping);
     const collectionKeyLength = collectionKey.length;
-    for (let i = 0; i < stateMappingKeys.length; i++) {
-        const subscriber = callbackToStateMapping[stateMappingKeys[i]];
+    for (const stateMappingKey of stateMappingKeys) {
+        const subscriber = callbackToStateMapping[stateMappingKey];
         if (!subscriber) {
             continue;
         }
@@ -555,7 +555,7 @@ function keysChanged(collectionKey, partialCollection, partialPreviousCollection
         const isSubscribedToCollectionMemberKey = isCollectionMemberKey(collectionKey, subscriber.key, collectionKeyLength);
         // Regular Onyx.connect() subscriber found.
         if (typeof subscriber.callback === 'function') {
-            if (!notifyRegularSubscibers) {
+            if (!notifyConnectSubscribers) {
                 continue;
             }
             // If they are subscribed to the collection key and using waitForCollectionCallback then we'll
@@ -568,8 +568,7 @@ function keysChanged(collectionKey, partialCollection, partialPreviousCollection
                 // If they are not using waitForCollectionCallback then we notify the subscriber with
                 // the new merged data but only for any keys in the partial collection.
                 const dataKeys = Object.keys(partialCollection !== null && partialCollection !== void 0 ? partialCollection : {});
-                for (let j = 0; j < dataKeys.length; j++) {
-                    const dataKey = dataKeys[j];
+                for (const dataKey of dataKeys) {
                     if ((0, fast_equals_1.deepEqual)(cachedCollection[dataKey], previousCollection[dataKey])) {
                         continue;
                     }
@@ -591,7 +590,7 @@ function keysChanged(collectionKey, partialCollection, partialPreviousCollection
         }
         // React component subscriber found.
         if (utils_1.default.hasWithOnyxInstance(subscriber)) {
-            if (!notifyWithOnyxSubscibers) {
+            if (!notifyWithOnyxSubscribers) {
                 continue;
             }
             // We are subscribed to a collection key so we must update the data in state with the new
@@ -618,8 +617,7 @@ function keysChanged(collectionKey, partialCollection, partialPreviousCollection
                     const prevCollection = (_a = prevState === null || prevState === void 0 ? void 0 : prevState[subscriber.statePropertyName]) !== null && _a !== void 0 ? _a : {};
                     const finalCollection = (0, clone_1.default)(prevCollection);
                     const dataKeys = Object.keys(partialCollection !== null && partialCollection !== void 0 ? partialCollection : {});
-                    for (let j = 0; j < dataKeys.length; j++) {
-                        const dataKey = dataKeys[j];
+                    for (const dataKey of dataKeys) {
                         finalCollection[dataKey] = cachedCollection[dataKey];
                     }
                     if ((0, fast_equals_1.deepEqual)(prevCollection, finalCollection)) {
@@ -718,8 +716,8 @@ function keyChanged(key, value, previousValue, canUpdateSubscriber = () => true,
         }
     }
     const cachedCollections = {};
-    for (let i = 0; i < stateMappingKeys.length; i++) {
-        const subscriber = callbackToStateMapping[stateMappingKeys[i]];
+    for (const stateMappingKey of stateMappingKeys) {
+        const subscriber = callbackToStateMapping[stateMappingKey];
         if (!subscriber || !isKeyMatch(subscriber.key, key) || !canUpdateSubscriber(subscriber)) {
             continue;
         }
@@ -1092,7 +1090,7 @@ function subscribeToKey(connectOptions) {
         // Performance improvement
         // If the mapping is connected to an onyx key that is not a collection
         // we can skip the call to getAllKeys() and return an array with a single item
-        if (Boolean(mapping.key) && typeof mapping.key === 'string' && !isCollectionKey(mapping.key) && OnyxCache_1.default.getAllKeys().has(mapping.key)) {
+        if (!!mapping.key && typeof mapping.key === 'string' && !isCollectionKey(mapping.key) && OnyxCache_1.default.getAllKeys().has(mapping.key)) {
             return new Set([mapping.key]);
         }
         return getAllKeys();
@@ -1171,6 +1169,51 @@ function unsubscribeFromKey(subscriptionID) {
     deleteKeyBySubscriptions(lastSubscriptionID);
     delete callbackToStateMapping[subscriptionID];
 }
+function updateSnapshots(data, mergeFn) {
+    const snapshotCollectionKey = OnyxUtils.getSnapshotKey();
+    if (!snapshotCollectionKey)
+        return [];
+    const promises = [];
+    const snapshotCollection = OnyxUtils.getCachedCollection(snapshotCollectionKey);
+    const snapshotCollectionKeyLength = snapshotCollectionKey.length;
+    Object.entries(snapshotCollection).forEach(([snapshotEntryKey, snapshotEntryValue]) => {
+        // Snapshots may not be present in cache. We don't know how to update them so we skip.
+        if (!snapshotEntryValue) {
+            return;
+        }
+        let updatedData = {};
+        data.forEach(({ key, value }) => {
+            // snapshots are normal keys so we want to skip update if they are written to Onyx
+            if (OnyxUtils.isCollectionMemberKey(snapshotCollectionKey, key, snapshotCollectionKeyLength)) {
+                return;
+            }
+            if (typeof snapshotEntryValue !== 'object' || !('data' in snapshotEntryValue)) {
+                return;
+            }
+            const snapshotData = snapshotEntryValue.data;
+            if (!snapshotData || !snapshotData[key]) {
+                return;
+            }
+            if (Array.isArray(value) || Array.isArray(snapshotData[key])) {
+                updatedData[key] = value || [];
+                return;
+            }
+            if (value === null) {
+                updatedData[key] = value;
+                return;
+            }
+            const oldValue = updatedData[key] || {};
+            const newValue = (0, pick_1.default)(value, Object.keys(snapshotData[key]));
+            updatedData = Object.assign(Object.assign({}, updatedData), { [key]: Object.assign(oldValue, newValue) });
+        });
+        // Skip the update if there's no data to be merged
+        if (utils_1.default.isEmptyObject(updatedData)) {
+            return;
+        }
+        promises.push(() => mergeFn(snapshotEntryKey, { data: updatedData }));
+    });
+    return promises;
+}
 const OnyxUtils = {
     METHOD,
     getMergeQueue,
@@ -1220,6 +1263,11 @@ const OnyxUtils = {
     getEvictionBlocklist,
     getSkippableCollectionMemberIDs,
     setSkippableCollectionMemberIDs,
+    storeKeyBySubscriptions,
+    deleteKeyBySubscriptions,
+    addKeyToRecentlyAccessedIfNeeded,
+    reduceCollectionWithSelector,
+    updateSnapshots,
 };
 GlobalSettings.addGlobalSettingsChangeListener(({ enablePerformanceMetrics }) => {
     if (!enablePerformanceMetrics) {

package/dist/utils.js

@@ -1,5 +1,4 @@
 "use strict";
-/* eslint-disable @typescript-eslint/prefer-for-of */
 Object.defineProperty(exports, "__esModule", { value: true });
 /** Checks whether the given object is an object and not null/undefined. */
 function isEmptyObject(obj) {
@@ -132,8 +131,7 @@ function checkCompatibilityWithExistingValue(value, existingValue) {
 function filterObject(obj, condition, include) {
     const result = {};
     const entries = Object.entries(obj);
-    for (let i = 0; i < entries.length; i++) {
-        const [key, value] = entries[i];
+    for (const [key, value] of entries) {
         let shouldInclude;
         if (Array.isArray(condition)) {
             shouldInclude = condition.includes(key);
@@ -142,7 +140,7 @@ function filterObject(obj, condition, include) {
             shouldInclude = key === condition;
         }
         else {
-            shouldInclude = condition(entries[i]);
+            shouldInclude = condition([key, value]);
         }
         if (include ? shouldInclude : !shouldInclude) {
             result[key] = value;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "react-native-onyx",
-  "version": "2.0.100",
+  "version": "2.0.102",
   "author": "Expensify, Inc.",
   "homepage": "https://expensify.com",
   "description": "State management for React Native",
@@ -31,12 +31,14 @@
     "lint": "eslint .",
     "typecheck": "tsc --noEmit",
     "test": "jest",
+    "perf-test": "npx reassure",
     "build": "tsc -p tsconfig.build.json",
     "build:watch": "nodemon --watch lib --ext js,json,ts,tsx --exec \"npm run build && npm pack\"",
     "prebuild:docs": "npm run build",
     "build:docs": "ts-node buildDocs.ts",
     "lint-tests": "eslint tests/**",
-    "prettier": "prettier --write ."
+    "prettier": "prettier --write .",
+    "gh-actions-build": "./.github/scripts/buildActions.sh"
   },
   "dependencies": {
     "ascii-table": "0.0.9",
@@ -66,8 +68,10 @@
     "@types/underscore": "^1.11.15",
     "@typescript-eslint/eslint-plugin": "^6.19.0",
     "@typescript-eslint/parser": "^6.19.0",
+    "@vercel/ncc": "0.38.1",
+    "date-fns": "^4.1.0",
     "eslint": "^8.56.0",
-    "eslint-config-expensify": "^2.0.44",
+    "eslint-config-expensify": "^2.0.81",
     "eslint-config-prettier": "^8.8.0",
     "eslint-plugin-import": "^2.29.1",
     "eslint-plugin-jsx-a11y": "^6.8.0",
@@ -87,7 +91,7 @@
     "react-native-performance": "^2.0.0",
     "react-native-quick-sqlite": "^8.0.6",
     "react-test-renderer": "18.1.0",
-    "reassure": "^0.11.0",
+    "reassure": "1.4.0",
     "ts-node": "^10.9.2",
     "type-fest": "^3.12.0",
     "typescript": "^5.4.5"