react-native-onyx 1.0.73 → 1.0.75

package/lib/DevTools.js

@@ -1,6 +1,12 @@
-import {connectViaExtension} from 'remotedev';
 import _ from 'underscore';
 
+const {connectViaExtension} = process.env.NODE_ENV === 'production' ? require('remotedev') : {
+    connectViaExtension: () => ({
+        init: () => {},
+        send: () => {},
+    }),
+};
+
 class DevTools {
     /**
      * @callback onStateChange
@@ -42,7 +48,7 @@ class DevTools {
      */
     clearState(keysToBeRemoved = []) {
         const pairs = _.map(keysToBeRemoved, key => [key, undefined]);
-        this.registerAction('CLEAR', undefined, _.object((pairs)));
+        this.registerAction('CLEAR', undefined, _.object(pairs));
     }
 }
 

package/lib/Onyx.js

@@ -28,8 +28,8 @@ let lastConnectionID = 0;
 // Holds a mapping of all the react components that want their state subscribed to a store key
 const callbackToStateMapping = {};
 
-// Stores all of the keys that Onyx can use. Must be defined in init().
-let onyxKeys = {};
+// Keeps a copy of the values of the onyx collection keys as a map for faster lookups
+let onyxCollectionKeyMap = new Map();
 
 // Holds a list of keys that have been directly subscribed to or recently modified from least to most recent
 let recentlyAccessedKeys = [];
@@ -147,7 +147,7 @@ function getAllKeys() {
  * @returns {Boolean}
  */
 function isCollectionKey(key) {
-    return _.contains(_.values(onyxKeys.COLLECTION), key);
+    return onyxCollectionKeyMap.has(key);
 }
 
 /**
@@ -1428,8 +1428,13 @@ function init({
         cache.setRecentKeysLimit(maxCachedKeysCount);
     }
 
-    // Let Onyx know about all of our keys
-    onyxKeys = keys;
+    // We need the value of the collection keys later for checking if a
+    // key is a collection. We store it in a map for faster lookup.
+    const collectionValues = _.values(keys.COLLECTION);
+    onyxCollectionKeyMap = _.reduce(collectionValues, (acc, val) => {
+        acc.set(val, true);
+        return acc;
+    }, new Map());
 
     // Set our default key states to use when initializing and clearing Onyx data
     defaultKeyStates = initialKeyStates;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "react-native-onyx",
-  "version": "1.0.73",
+  "version": "1.0.75",
   "author": "Expensify, Inc.",
   "homepage": "https://expensify.com",
   "description": "State management for React Native",