react-native-onyx 1.0.31 → 1.0.33

package/lib/Onyx.js

@@ -799,8 +799,7 @@ function notifyCollectionSubscribersOnNextTick(key, value) {
  * @return {Promise}
  */
 function remove(key) {
-    // Cache the fact that the value was removed
-    cache.set(key, null);
+    cache.drop(key);
     notifySubscribersOnNextTick(key, null);
     return Storage.removeItem(key);
 }
@@ -847,8 +846,9 @@ function evictStorageAndRetry(error, onyxMethod, ...args) {
  * @returns {Promise}
  */
 function set(key, value) {
-    // Logging properties only since values could be sensitive things we don't want to log
-    Logger.logInfo(`set() called for key: ${key}${_.isObject(value) ? ` properties: ${_.keys(value).join(',')}` : ''}`);
+    if (_.isNull(value)) {
+        return remove(key);
+    }
 
     // eslint-disable-next-line no-use-before-define
     if (hasPendingMergeForKey(key)) {
@@ -1294,6 +1294,7 @@ const Onyx = {
     mergeCollection,
     update,
     clear,
+    getAllKeys,
     init,
     registerLogger: Logger.registerLogger,
     addToEvictionBlockList,

package/lib/OnyxCache.js

@@ -104,6 +104,8 @@ class OnyxCache {
      */
     drop(key) {
         delete this.storageMap[key];
+        this.storageKeys.delete(key);
+        this.recentKeys.delete(key);
     }
 
     /**

package/lib/storage/NativeStorage.js

@@ -1,3 +1,3 @@
-import Storage from './providers/AsyncStorage';
+import SQLiteStorage from './providers/SQLiteStorage';
 
-export default Storage;
+export default SQLiteStorage;

package/lib/storage/providers/SQLiteStorage.js

@@ -0,0 +1,118 @@
+/**
+ * The SQLiteStorage provider stores everything in a key/value store by
+ * converting the value to a JSON string
+ */
+import {open} from 'react-native-quick-sqlite';
+import _ from 'underscore';
+
+const DB_NAME = 'OnyxDB';
+const db = open({name: DB_NAME});
+
+db.execute('CREATE TABLE IF NOT EXISTS keyvaluepairs (record_key TEXT NOT NULL PRIMARY KEY , valueJSON JSON NOT NULL) WITHOUT ROWID;');
+
+// All of the 3 pragmas below were suggested by SQLite team.
+// You can find more info about them here: https://www.sqlite.org/pragma.html
+db.execute('PRAGMA CACHE_SIZE=-20000;');
+db.execute('PRAGMA synchronous=NORMAL;');
+db.execute('PRAGMA journal_mode=WAL;');
+
+const provider = {
+    /**
+    * Get the value of a given key or return `null` if it's not available in storage
+    * @param {String} key
+    * @return {Promise<*>}
+    */
+    getItem(key) {
+        return db.executeAsync('SELECT record_key, valueJSON FROM keyvaluepairs WHERE record_key = ?;', [key]).then(({rows}) => {
+            if (rows.length === 0) {
+                return null;
+            }
+            const result = rows.item(0);
+            return JSON.parse(result.valueJSON);
+        });
+    },
+
+    /**
+    * Get multiple key-value pairs for the given array of keys in a batch
+    * @param {String[]} keys
+    * @return {Promise<Array<[key, value]>>}
+    */
+    multiGet(keys) {
+        const placeholders = _.map(keys, () => '?').join(',');
+        const command = `SELECT record_key, valueJSON FROM keyvaluepairs WHERE record_key IN (${placeholders});`;
+        return db.executeAsync(command, keys)
+            .then(({rows}) => {
+                // eslint-disable-next-line no-underscore-dangle
+                const result = _.map(rows._array, row => [row.record_key, JSON.parse(row.valueJSON)]);
+                return result;
+            });
+    },
+
+    /**
+    * Sets the value for a given key. The only requirement is that the value should be serializable to JSON string
+    * @param {String} key
+    * @param {*} value
+    * @return {Promise<void>}
+    */
+    setItem(key, value) {
+        return db.executeAsync('REPLACE INTO keyvaluepairs (record_key, valueJSON) VALUES (?, ?);', [key, JSON.stringify(value)]);
+    },
+
+    /**
+    * Stores multiple key-value pairs in a batch
+    * @param {Array<[key, value]>} pairs
+    * @return {Promise<void>}
+    */
+    multiSet(pairs) {
+        const stringifiedPairs = _.map(pairs, pair => [
+            pair[0],
+            JSON.stringify(pair[1]),
+        ]);
+        return db.executeBatchAsync([['REPLACE INTO keyvaluepairs (record_key, valueJSON) VALUES (?, json(?));', stringifiedPairs]]);
+    },
+
+    /**
+    * Multiple merging of existing and new values in a batch
+    * @param {Array<[key, value]>} pairs
+    * @return {Promise<void>}
+    */
+    multiMerge(pairs) {
+        // Note: We use `ON CONFLICT DO UPDATE` here instead of `INSERT OR REPLACE INTO`
+        // so the new JSON value is merged into the old one if there's an existing value
+        const query = `INSERT INTO keyvaluepairs (record_key, valueJSON) 
+             VALUES (:key, JSON(:value)) 
+             ON CONFLICT DO UPDATE 
+             SET valueJSON = JSON_PATCH(valueJSON, JSON(:value)); 
+        `;
+        const queryArguments = _.map(pairs, (pair) => {
+            const value = JSON.stringify(pair[1]);
+            return [pair[0], value];
+        });
+        return db.executeBatchAsync([[query, queryArguments]]);
+    },
+
+    /**
+    * Returns all keys available in storage
+    * @returns {Promise<String[]>}
+    */
+    getAllKeys: () => db.executeAsync('SELECT record_key FROM keyvaluepairs;').then(({rows}) => {
+        // eslint-disable-next-line no-underscore-dangle
+        const result = _.map(rows._array, row => row.record_key);
+        return result;
+    }),
+
+    /**
+    * Removes given key and it's value from storage
+    * @param {String} key
+    * @returns {Promise<void>}
+    */
+    removeItem: key => db.executeAsync('DELETE FROM keyvaluepairs WHERE record_key = ?;', [key]),
+
+    /**
+    * Clears absolutely everything from storage
+    * @returns {Promise<void>}
+    */
+    clear: () => db.executeAsync('DELETE FROM keyvaluepairs;', []),
+};
+
+export default provider;

package/lib/storage/providers/__mocks__/SQLiteStorage.js

@@ -0,0 +1,3 @@
+import provider from '../AsyncStorage';
+
+export default provider;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "react-native-onyx",
-  "version": "1.0.31",
+  "version": "1.0.33",
   "author": "Expensify, Inc.",
   "homepage": "https://expensify.com",
   "description": "State management for React Native",
@@ -48,7 +48,7 @@
     "@babel/core": "^7.17.10",
     "@babel/plugin-proposal-class-properties": "^7.16.7",
     "@babel/runtime": "^7.11.2",
-    "@react-native-async-storage/async-storage": "^1.15.5",
+    "@react-native-async-storage/async-storage": "^1.17.11",
     "@react-native-community/eslint-config": "^2.0.0",
     "@testing-library/jest-native": "^3.4.2",
     "@testing-library/react-native": "^7.0.2",
@@ -60,27 +60,31 @@
     "babel-plugin-transform-class-properties": "^6.24.1",
     "eslint": "^7.6.0",
     "eslint-config-expensify": "^2.0.24",
+    "eslint-plugin-jsx-a11y": "^6.6.1",
+    "eslint-plugin-react": "^7.31.10",
     "expensify-common": "git+https://github.com/Expensify/expensify-common.git#427295da130a4eacc184d38693664280d020dffd",
     "jest": "^26.5.2",
     "jest-cli": "^26.5.2",
     "jsdoc-to-markdown": "^7.1.0",
     "localforage": "^1.10.0",
-    "metro-react-native-babel-preset": "^0.61.0",
+    "metro-react-native-babel-preset": "^0.72.3",
     "prop-types": "^15.7.2",
-    "react": "^17.0.2",
-    "react-native": "0.64.1",
+    "react": "18.1.0",
+    "react-native": "0.70.0",
     "react-native-performance": "^2.0.0",
-    "react-test-renderer": "16.13.1",
+    "react-native-quick-sqlite": "^5.0.3",
+    "react-test-renderer": "18.1.0",
     "webpack": "^5.72.1",
     "webpack-cli": "^4.9.2",
     "webpack-merge": "^5.8.0"
   },
   "peerDependencies": {
-    "@react-native-async-storage/async-storage": "^1.15.5",
+    "@react-native-async-storage/async-storage": "^1.17.11",
     "expensify-common": ">=1",
     "localforage": "^1.10.0",
-    "react": ">=17.0.2",
-    "react-native-performance": "^2.0.0"
+    "react": ">=18.1.0",
+    "react-native-performance": "^4.0.0",
+    "react-native-quick-sqlite": "^5.0.3"
   },
   "peerDependenciesMeta": {
     "react-native-performance": {
@@ -89,10 +93,17 @@
     "@react-native-async-storage/async-storage": {
       "optional": true
     },
+    "react-native-quick-sqlite": {
+      "optional": true
+    },
     "localforage": {
       "optional": true
     }
   },
+  "engines": {
+    "node": "16.15.1",
+    "npm": "8.11.0"
+  },
   "jest": {
     "preset": "react-native",
     "transform": {
@@ -116,7 +127,8 @@
     "timers": "fake",
     "testEnvironment": "jsdom",
     "setupFilesAfterEnv": [
-      "@testing-library/jest-native/extend-expect"
+      "@testing-library/jest-native/extend-expect",
+      "./jestSetup.js"
     ]
   },
   "sideEffects": false