react-native-notify-kit 9.4.0 → 9.6.0

package/android/src/test/java/app/notifee/core/NotifeeAlarmManagerSetAlarmClockTest.java

@@ -0,0 +1,264 @@
+package app.notifee.core;
+
+/*
+ * Copyright (c) 2016-present Invertase Limited & Contributors
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this library except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNotNull;
+import static org.mockito.ArgumentMatchers.any;
+import static org.mockito.ArgumentMatchers.anyInt;
+import static org.mockito.ArgumentMatchers.anyLong;
+import static org.mockito.ArgumentMatchers.eq;
+import static org.mockito.Mockito.doThrow;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.mockStatic;
+import static org.mockito.Mockito.never;
+import static org.mockito.Mockito.times;
+import static org.mockito.Mockito.verify;
+import static org.mockito.Mockito.when;
+
+import android.app.AlarmManager;
+import android.app.PendingIntent;
+import android.os.Bundle;
+import app.notifee.core.model.NotificationModel;
+import app.notifee.core.model.TimestampTriggerModel;
+import app.notifee.core.utility.AlarmUtils;
+import org.junit.After;
+import org.junit.Before;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.mockito.ArgumentCaptor;
+import org.mockito.MockedStatic;
+import org.robolectric.RobolectricTestRunner;
+import org.robolectric.RuntimeEnvironment;
+import org.robolectric.annotation.Config;
+
+/**
+ * Unit coverage for the {@link TimestampTriggerModel.AlarmType#SET_ALARM_CLOCK} branch of {@link
+ * NotifeeAlarmManager#scheduleTimestampTriggerNotification} and its supporting helper {@link
+ * NotifeeAlarmManager#buildShowIntentPressActionBundle}. This branch was added in upstream {@code
+ * invertase/notifee#749} (closing {@code #655}) and refactored in this fork to reuse the {@code
+ * pressAction} path that the 9.1.19 / 9.3.0 fixes rely on — see the commit that introduces this
+ * file for the full rationale.
+ *
+ * <p>Three scenarios are guarded:
+ *
+ * <ol>
+ *   <li><b>Happy path</b> — a non-repeating TIMESTAMP trigger with {@code
+ *       AlarmType.SET_ALARM_CLOCK} results in exactly one {@link
+ *       AlarmManager#setAlarmClock(AlarmManager.AlarmClockInfo, PendingIntent)} call, the captured
+ *       {@link AlarmManager.AlarmClockInfo} carries a non-null show intent, and the inexact
+ *       fallback path is not exercised.
+ *   <li><b>SecurityException fallback</b> — if {@code setAlarmClock} throws (Android 12+ can reject
+ *       even after {@code canScheduleExactAlarms()} returns true, e.g. when the permission is
+ *       revoked between the pre-check and the schedule call), the catch in {@code
+ *       scheduleTimestampTriggerNotification} must route to {@code setAndAllowWhileIdle} so the
+ *       notification still fires as an inexact alarm rather than disappearing silently.
+ *   <li><b>Show-intent pressAction resolution</b> — a regression guard for the refactor that
+ *       replaced the ad-hoc {@code getLaunchIntentForPackage} with a call into {@link
+ *       NotificationPendingIntent#createIntent}. The helper must (a) synthesize the {@code {
+ *       id:'default', launchActivity:'default' }} bundle when the notification has no {@code
+ *       pressAction} (typical for triggers rehydrated from Room after an app kill), (b) synthesize
+ *       the same default when the user opted out via {@link
+ *       NotificationPendingIntent#PRESS_ACTION_OPT_OUT_ID} (the alarm-clock icon in the status bar
+ *       has no non-tappable mode, so we still need a valid show intent), and (c) pass a custom
+ *       pressAction through unchanged so {@code launchActivity} / {@code mainComponent} routing is
+ *       honoured end-to-end.
+ * </ol>
+ *
+ * <p>Test strategy: {@link MockedStatic} intercepts {@link AlarmUtils#getAlarmManager()} so the
+ * production code receives a Mockito-controlled {@link AlarmManager} instead of Robolectric's
+ * shadow. This lets the tests stub {@code canScheduleExactAlarms()} to skip the Android S+
+ * pre-check, stub {@code setAlarmClock} to either succeed or throw, and capture the {@link
+ * AlarmManager.AlarmClockInfo} that reached the platform. Everything else — {@link ContextHolder},
+ * {@link NotificationPendingIntent#createIntent}, the Intent/PendingIntent plumbing — runs against
+ * Robolectric's real application context.
+ */
+@RunWith(RobolectricTestRunner.class)
+// Robolectric's default SDK is too low for AlarmManager#canScheduleExactAlarms() (API 31+).
+// Pin to API 34 — matches ForegroundServiceTest and exercises the Android S+ pre-check branch
+// that the production code in scheduleTimestampTriggerNotification guards against.
+@Config(sdk = 34)
+public class NotifeeAlarmManagerSetAlarmClockTest {
+
+  /** A trigger timestamp comfortably in the future so {@code setNextTimestamp} is a no-op. */
+  private static final long FUTURE_OFFSET_MS = 60_000L;
+
+  private MockedStatic<AlarmUtils> alarmUtilsMock;
+  private AlarmManager mockAlarmManager;
+
+  @Before
+  public void setUp() {
+    // NotificationPendingIntent.createIntent, getAlarmManagerIntentForNotification, and the
+    // trigger-rescheduling path all call ContextHolder.getApplicationContext(). Robolectric's
+    // application context exposes a real PackageManager so the launch-intent fallback inside
+    // NotificationPendingIntent.createLaunchActivityIntent succeeds without mocking.
+    ContextHolder.setApplicationContext(RuntimeEnvironment.getApplication());
+
+    mockAlarmManager = mock(AlarmManager.class);
+    // Skip the Android S+ pre-check — we explicitly want the switch to reach the SET_ALARM_CLOCK
+    // branch. If canScheduleExactAlarms() returned Mockito's default (false), the pre-check would
+    // fall back to setAndAllowWhileIdle before the switch and the tests would never exercise the
+    // production path under scrutiny.
+    when(mockAlarmManager.canScheduleExactAlarms()).thenReturn(true);
+
+    alarmUtilsMock = mockStatic(AlarmUtils.class);
+    alarmUtilsMock.when(AlarmUtils::getAlarmManager).thenReturn(mockAlarmManager);
+  }
+
+  @After
+  public void tearDown() {
+    if (alarmUtilsMock != null) {
+      alarmUtilsMock.close();
+    }
+  }
+
+  // ─── Test 1: Happy path — setAlarmClock called with a non-null show intent ──
+
+  @Test
+  public void setAlarmClock_happyPath_usesAlarmClockInfoWithShowIntent() {
+    NotificationModel model = buildModel("happy-path");
+    TimestampTriggerModel trigger = buildSetAlarmClockTrigger();
+
+    NotifeeAlarmManager.scheduleTimestampTriggerNotification(model, trigger);
+
+    ArgumentCaptor<AlarmManager.AlarmClockInfo> infoCaptor =
+        ArgumentCaptor.forClass(AlarmManager.AlarmClockInfo.class);
+    ArgumentCaptor<PendingIntent> operationCaptor = ArgumentCaptor.forClass(PendingIntent.class);
+    verify(mockAlarmManager, times(1))
+        .setAlarmClock(infoCaptor.capture(), operationCaptor.capture());
+
+    AlarmManager.AlarmClockInfo info = infoCaptor.getValue();
+    assertNotNull("AlarmClockInfo must be non-null", info);
+    assertNotNull(
+        "AlarmClockInfo.showIntent must be non-null — AlarmManager requires a tap target for"
+            + " the status-bar alarm-clock icon",
+        info.getShowIntent());
+    assertNotNull(
+        "operation PendingIntent (alarm fire target) must be non-null", operationCaptor.getValue());
+
+    // The happy path must never touch the inexact fallback.
+    verify(mockAlarmManager, never())
+        .setAndAllowWhileIdle(anyInt(), anyLong(), any(PendingIntent.class));
+  }
+
+  // ─── Test 2: SecurityException → fallback to setAndAllowWhileIdle ──────────
+
+  @Test
+  public void setAlarmClock_securityException_fallsBackToInexact() {
+    // canScheduleExactAlarms() can race with permission revocation on Android 12+: the pre-check
+    // passes, but the subsequent setAlarmClock call still throws. The production code's
+    // try/catch inside scheduleTimestampTriggerNotification must route that throw to
+    // setAndAllowWhileIdle so the notification degrades gracefully instead of disappearing.
+    doThrow(new SecurityException("synthetic SCHEDULE_EXACT_ALARM denied at fire time"))
+        .when(mockAlarmManager)
+        .setAlarmClock(any(AlarmManager.AlarmClockInfo.class), any(PendingIntent.class));
+
+    NotificationModel model = buildModel("security-exception");
+    TimestampTriggerModel trigger = buildSetAlarmClockTrigger();
+
+    NotifeeAlarmManager.scheduleTimestampTriggerNotification(model, trigger);
+
+    // Primary attempt happened.
+    verify(mockAlarmManager, times(1))
+        .setAlarmClock(any(AlarmManager.AlarmClockInfo.class), any(PendingIntent.class));
+    // Fallback fired with RTC_WAKEUP — matches the other AlarmType branches' wake semantics.
+    verify(mockAlarmManager, times(1))
+        .setAndAllowWhileIdle(eq(AlarmManager.RTC_WAKEUP), anyLong(), any(PendingIntent.class));
+  }
+
+  // ─── Test 3: show-intent reuses the pressAction path (refactor guard) ─────
+
+  @Test
+  public void setAlarmClock_showIntentReusesPressActionPath() {
+    // Case 1: notification has no pressAction at all (e.g. rehydrated from Room after app kill).
+    // buildShowIntentPressActionBundle must synthesize the default so the status-bar icon opens
+    // the app via the same route as a normal tap.
+    Bundle absent = NotifeeAlarmManager.buildShowIntentPressActionBundle(buildModel("absent"));
+    assertNotNull("default pressAction must be synthesized when absent", absent);
+    assertEquals("default", absent.getString("id"));
+    assertEquals("default", absent.getString("launchActivity"));
+
+    // Case 2: notification was built with pressAction:null in JS, which surfaces in the native
+    // layer as PRESS_ACTION_OPT_OUT_ID. Unlike the content intent (where null means "non-tappable
+    // notification"), AlarmClockInfo demands a non-null show intent, so the helper must still
+    // synthesize the default instead of returning null and crashing the schedule call.
+    Bundle optOut =
+        NotifeeAlarmManager.buildShowIntentPressActionBundle(
+            buildModelWithPressAction(
+                "opt-out", NotificationPendingIntent.PRESS_ACTION_OPT_OUT_ID, null));
+    assertNotNull("default pressAction must be synthesized on opt-out sentinel", optOut);
+    assertEquals("default", optOut.getString("id"));
+    assertEquals("default", optOut.getString("launchActivity"));
+
+    // Case 3: a real custom pressAction must pass through untouched so custom launchActivity
+    // routing reaches NotificationPendingIntent.createLaunchActivityIntent.
+    Bundle custom =
+        NotifeeAlarmManager.buildShowIntentPressActionBundle(
+            buildModelWithPressAction("custom", "my-action", "com.example.CustomActivity"));
+    assertNotNull("custom pressAction must pass through", custom);
+    assertEquals("my-action", custom.getString("id"));
+    assertEquals("com.example.CustomActivity", custom.getString("launchActivity"));
+  }
+
+  // ─── Builders ──────────────────────────────────────────────────────────────
+
+  private static NotificationModel buildModel(String id) {
+    Bundle notificationBundle = new Bundle();
+    notificationBundle.putString("id", id);
+    notificationBundle.putString("title", "SetAlarmClockTest " + id);
+
+    Bundle androidBundle = new Bundle();
+    androidBundle.putString("channelId", "set-alarm-clock-test-channel");
+    notificationBundle.putBundle("android", androidBundle);
+
+    return NotificationModel.fromBundle(notificationBundle);
+  }
+
+  private static NotificationModel buildModelWithPressAction(
+      String id, String pressActionId, String launchActivity) {
+    Bundle notificationBundle = new Bundle();
+    notificationBundle.putString("id", id);
+    notificationBundle.putString("title", "SetAlarmClockTest " + id);
+
+    Bundle androidBundle = new Bundle();
+    androidBundle.putString("channelId", "set-alarm-clock-test-channel");
+
+    Bundle pressAction = new Bundle();
+    pressAction.putString("id", pressActionId);
+    if (launchActivity != null) {
+      pressAction.putString("launchActivity", launchActivity);
+    }
+    androidBundle.putBundle("pressAction", pressAction);
+
+    notificationBundle.putBundle("android", androidBundle);
+
+    return NotificationModel.fromBundle(notificationBundle);
+  }
+
+  private static TimestampTriggerModel buildSetAlarmClockTrigger() {
+    Bundle triggerBundle = new Bundle();
+    triggerBundle.putInt("type", 0); // TIMESTAMP
+    triggerBundle.putLong("timestamp", System.currentTimeMillis() + FUTURE_OFFSET_MS);
+    triggerBundle.putInt("repeatFrequency", -1); // non-repeating
+
+    Bundle alarmManagerBundle = new Bundle();
+    alarmManagerBundle.putInt("type", 4); // SET_ALARM_CLOCK (TimestampTriggerModel switch case 4)
+    triggerBundle.putBundle("alarmManager", alarmManagerBundle);
+
+    return TimestampTriggerModel.fromBundle(triggerBundle);
+  }
+}

package/android/src/test/java/app/notifee/core/database/WorkDataRepositoryFutureContractTest.java

@@ -0,0 +1,279 @@
+package app.notifee.core.database;
+
+/*
+ * Copyright (c) 2016-present Invertase Limited & Contributors
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this library except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ */
+
+import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertNotNull;
+import static org.junit.Assert.assertSame;
+import static org.junit.Assert.assertTrue;
+import static org.junit.Assert.fail;
+import static org.mockito.Mockito.doAnswer;
+import static org.mockito.Mockito.doThrow;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.verify;
+
+import com.google.common.util.concurrent.ListenableFuture;
+import com.google.common.util.concurrent.ListeningExecutorService;
+import com.google.common.util.concurrent.MoreExecutors;
+import java.util.Collections;
+import java.util.concurrent.CountDownLatch;
+import java.util.concurrent.ExecutionException;
+import java.util.concurrent.Executors;
+import java.util.concurrent.TimeUnit;
+import org.junit.After;
+import org.junit.Before;
+import org.junit.Test;
+
+/**
+ * Locks in the post-#549 contract that every {@link WorkDataRepository} mutation method returns a
+ * non-null {@link ListenableFuture} that only transitions to done after the underlying DAO call has
+ * actually returned — and that DAO exceptions propagate through {@code ExecutionException}.
+ *
+ * <p>Before the #549 fix, these methods were {@code void} and enqueued their work fire-and-forget
+ * on a cached thread pool. Any future refactor that drops the future return type or silently
+ * swallows DAO exceptions would be a regression and must fail these tests.
+ */
+public class WorkDataRepositoryFutureContractTest {
+
+  private WorkDataDao mockDao;
+  private ListeningExecutorService executor;
+  private WorkDataRepository repo;
+
+  @Before
+  public void setUp() {
+    mockDao = mock(WorkDataDao.class);
+    // Single-threaded so we can deterministically gate the DAO call with a latch
+    // and assert future.isDone() before the DAO has returned.
+    executor = MoreExecutors.listeningDecorator(Executors.newSingleThreadExecutor());
+    repo = new WorkDataRepository(mockDao, executor);
+  }
+
+  @After
+  public void tearDown() {
+    executor.shutdownNow();
+  }
+
+  // -------- insert --------
+
+  @Test
+  public void insert_returnsNonNullFuture() {
+    assertNotNull(repo.insert(newEntity("a")));
+  }
+
+  @Test
+  public void insert_futureNotDoneUntilDaoReturns() throws Exception {
+    CountDownLatch daoEntered = new CountDownLatch(1);
+    CountDownLatch daoGate = new CountDownLatch(1);
+    WorkDataEntity entity = newEntity("a");
+    doAnswer(
+            inv -> {
+              daoEntered.countDown();
+              daoGate.await();
+              return null;
+            })
+        .when(mockDao)
+        .insert(entity);
+
+    ListenableFuture<Void> f = repo.insert(entity);
+    assertTrue("DAO should be entered within 1s", daoEntered.await(1, TimeUnit.SECONDS));
+    assertFalse("insert future must not be done while DAO is blocked", f.isDone());
+
+    daoGate.countDown();
+    f.get(1, TimeUnit.SECONDS);
+    assertTrue(f.isDone());
+    verify(mockDao).insert(entity);
+  }
+
+  @Test
+  public void insert_propagatesDaoException() throws Exception {
+    RuntimeException boom = new RuntimeException("disk full");
+    WorkDataEntity entity = newEntity("a");
+    doThrow(boom).when(mockDao).insert(entity);
+
+    ListenableFuture<Void> f = repo.insert(entity);
+    try {
+      f.get(1, TimeUnit.SECONDS);
+      fail("Expected ExecutionException wrapping the DAO failure");
+    } catch (ExecutionException e) {
+      assertSame(boom, e.getCause());
+    }
+  }
+
+  // -------- deleteById --------
+
+  @Test
+  public void deleteById_returnsNonNullFuture() {
+    assertNotNull(repo.deleteById("a"));
+  }
+
+  @Test
+  public void deleteById_futureNotDoneUntilDaoReturns() throws Exception {
+    CountDownLatch daoEntered = new CountDownLatch(1);
+    CountDownLatch daoGate = new CountDownLatch(1);
+    doAnswer(
+            inv -> {
+              daoEntered.countDown();
+              daoGate.await();
+              return null;
+            })
+        .when(mockDao)
+        .deleteById("a");
+
+    ListenableFuture<Void> f = repo.deleteById("a");
+    assertTrue(daoEntered.await(1, TimeUnit.SECONDS));
+    assertFalse(f.isDone());
+
+    daoGate.countDown();
+    f.get(1, TimeUnit.SECONDS);
+    verify(mockDao).deleteById("a");
+  }
+
+  @Test
+  public void deleteById_propagatesDaoException() throws Exception {
+    RuntimeException boom = new RuntimeException("row missing");
+    doThrow(boom).when(mockDao).deleteById("a");
+
+    ListenableFuture<Void> f = repo.deleteById("a");
+    try {
+      f.get(1, TimeUnit.SECONDS);
+      fail("Expected ExecutionException wrapping the DAO failure");
+    } catch (ExecutionException e) {
+      assertSame(boom, e.getCause());
+    }
+  }
+
+  // -------- deleteByIds --------
+
+  @Test
+  public void deleteByIds_futureNotDoneUntilDaoReturns() throws Exception {
+    CountDownLatch daoEntered = new CountDownLatch(1);
+    CountDownLatch daoGate = new CountDownLatch(1);
+    doAnswer(
+            inv -> {
+              daoEntered.countDown();
+              daoGate.await();
+              return null;
+            })
+        .when(mockDao)
+        .deleteByIds(Collections.singletonList("a"));
+
+    ListenableFuture<Void> f = repo.deleteByIds(Collections.singletonList("a"));
+    assertTrue(daoEntered.await(1, TimeUnit.SECONDS));
+    assertFalse(f.isDone());
+
+    daoGate.countDown();
+    f.get(1, TimeUnit.SECONDS);
+    verify(mockDao).deleteByIds(Collections.singletonList("a"));
+  }
+
+  @Test
+  public void deleteByIds_propagatesDaoException() throws Exception {
+    RuntimeException boom = new RuntimeException("constraint violation");
+    doThrow(boom).when(mockDao).deleteByIds(Collections.singletonList("a"));
+
+    ListenableFuture<Void> f = repo.deleteByIds(Collections.singletonList("a"));
+    try {
+      f.get(1, TimeUnit.SECONDS);
+      fail("Expected ExecutionException");
+    } catch (ExecutionException e) {
+      assertSame(boom, e.getCause());
+    }
+  }
+
+  // -------- deleteAll --------
+
+  @Test
+  public void deleteAll_returnsNonNullFuture() {
+    assertNotNull(repo.deleteAll());
+  }
+
+  @Test
+  public void deleteAll_futureNotDoneUntilDaoReturns() throws Exception {
+    CountDownLatch daoEntered = new CountDownLatch(1);
+    CountDownLatch daoGate = new CountDownLatch(1);
+    doAnswer(
+            inv -> {
+              daoEntered.countDown();
+              daoGate.await();
+              return null;
+            })
+        .when(mockDao)
+        .deleteAll();
+
+    ListenableFuture<Void> f = repo.deleteAll();
+    assertTrue(daoEntered.await(1, TimeUnit.SECONDS));
+    assertFalse(f.isDone());
+
+    daoGate.countDown();
+    f.get(1, TimeUnit.SECONDS);
+    verify(mockDao).deleteAll();
+  }
+
+  @Test
+  public void deleteAll_propagatesDaoException() throws Exception {
+    RuntimeException boom = new RuntimeException("db locked");
+    doThrow(boom).when(mockDao).deleteAll();
+
+    ListenableFuture<Void> f = repo.deleteAll();
+    try {
+      f.get(1, TimeUnit.SECONDS);
+      fail("Expected ExecutionException");
+    } catch (ExecutionException e) {
+      assertSame(boom, e.getCause());
+    }
+  }
+
+  // -------- update --------
+
+  @Test
+  public void update_futureNotDoneUntilDaoReturns() throws Exception {
+    CountDownLatch daoEntered = new CountDownLatch(1);
+    CountDownLatch daoGate = new CountDownLatch(1);
+    WorkDataEntity entity = newEntity("a");
+    doAnswer(
+            inv -> {
+              daoEntered.countDown();
+              daoGate.await();
+              return null;
+            })
+        .when(mockDao)
+        .update(entity);
+
+    ListenableFuture<Void> f = repo.update(entity);
+    assertTrue(daoEntered.await(1, TimeUnit.SECONDS));
+    assertFalse(f.isDone());
+
+    daoGate.countDown();
+    f.get(1, TimeUnit.SECONDS);
+    verify(mockDao).update(entity);
+  }
+
+  @Test
+  public void update_propagatesDaoException() throws Exception {
+    RuntimeException boom = new RuntimeException("schema mismatch");
+    WorkDataEntity entity = newEntity("a");
+    doThrow(boom).when(mockDao).update(entity);
+
+    ListenableFuture<Void> f = repo.update(entity);
+    try {
+      f.get(1, TimeUnit.SECONDS);
+      fail("Expected ExecutionException");
+    } catch (ExecutionException e) {
+      assertSame(boom, e.getCause());
+    }
+  }
+
+  // -------- helpers --------
+
+  private static WorkDataEntity newEntity(String id) {
+    return new WorkDataEntity(id, new byte[0], new byte[0], false);
+  }
+}