react-native-notify-kit 9.1.21 → 9.2.0

package/README.md

@@ -42,7 +42,7 @@ This fork fills the gap: it preserves all of Notifee's advanced features, migrat
 - License: `Apache-2.0`
 - Full changelog: [CHANGELOG.md](CHANGELOG.md)
 
-The native core (NotifeeCore) is preserved intact and the public API is **100% compatible** with the original `@notifee/react-native` — migration is a safe, drop-in replacement.
+The native core (NotifeeCore) is compiled from source as part of the bridge module (since 9.2.0) and the public API is **100% compatible** with the original `@notifee/react-native` — migration is a safe, drop-in replacement.
 
 ## Installation
 
@@ -251,8 +251,9 @@ This fork is a complete migration to React Native's **New Architecture**:
 - **iOS bridge uses Objective-C++** with `NativeNotifeeModuleSpecJSI` TurboModule conformance
 - **Minimum React Native 0.73**, development target **0.84**
 - **Toolchain**: Yarn 4, Node 22+, Java 17, compileSdk/targetSdk 35
+- **Single Android module** — the original Notifee shipped a pre-compiled AAR bundled inside the npm tarball under a frozen Maven coordinate; this fork compiles the core from source as part of the React Native bridge module on every consumer build. Eliminates the `FAIL_ON_PROJECT_REPOS` issue on RN 0.74+ and the Gradle cache staleness bug that could serve outdated bytecode after `yarn upgrade`.
 - **Core notification logic (NotifeeCore) is unchanged** — the public API is fully compatible with the original Notifee
-- **17 upstream bugs fixed** — see [Bugs Fixed from Upstream Notifee](#bugs-fixed-from-upstream-notifee) below
+- **20 upstream bugs fixed** — see [Bugs Fixed from Upstream Notifee](#bugs-fixed-from-upstream-notifee) below
 - **Reliable trigger notifications** — AlarmManager is the default backend instead of WorkManager, with automatic fallback when exact alarm permission is not granted
 - **New API: `setNotificationConfig()`** — opt-out flag to prevent Notifee from intercepting iOS remote notification handlers (see [New APIs](#new-apis) below)
 
@@ -280,6 +281,9 @@ This fork fixes the following bugs that were never resolved in the original Noti
 | DST (daylight saving time) shifts repeating scheduled notifications by ±1 hour | Android | [#875](https://github.com/invertase/notifee/issues/875) | 9.1.14 |
 | `!=` reference equality on String comparison in `NotificationPendingIntent` (latent — would activate when `getLaunchActivity()` returns a non-null value for `id=default`) | Android | Pre-existing (latent) | 9.1.19 |
 | `pressAction.launchActivity` not defaulted at native layer when `pressAction.id === 'default'` | Android | N/A (defense-in-depth) | 9.1.19 |
+| Duplicate symbols linker error when using NSE (`$NotifeeExtension = true`) with static frameworks — `NotifeeExtensionHelper` compiled by both `RNNotifee` and `RNNotifeeCore` pods | iOS | Pre-existing | 9.1.22 |
+| `FAIL_ON_PROJECT_REPOS` rejection on RN 0.74+ — library injected a Maven repository into the consumer's `rootProject.allprojects` block, rejected by `dependencyResolutionManagement` mode | Android | N/A (architectural) | 9.2.0 |
+| Stale Gradle cache could serve outdated AAR bytecode after `yarn upgrade` — same Maven coordinate reused across releases violated Gradle's coordinate-immutability assumption | Android | N/A (architectural) | 9.2.0 |
 
 > **Note for apps requiring guaranteed exact alarms (alarm clocks, timers, calendars):**
 > Add `<uses-permission android:name="android.permission.USE_EXACT_ALARM" />` to your app's

package/RNNotifee.podspec

@@ -27,6 +27,7 @@ Pod::Spec.new do |s|
   elsif defined?($NotifeeExtension) && $NotifeeExtension == true
     # App uses Notification Service Extension
     Pod::UI.warn "RNNotifee: using Notification Service Extension."
+    s.exclude_files = 'ios/RNNotifee/NotifeeExtensionHelper.{h,m}'
     s.dependency 'RNNotifeeCore'
   else
     s.subspec "NotifeeCore" do |ss|

package/android/build.gradle

@@ -1,4 +1,4 @@
-import java.nio.file.Paths
+import org.gradle.internal.jvm.Jvm
 
 buildscript {
   // The Android Gradle plugin is only required when opening the android folder stand-alone.
@@ -23,24 +23,21 @@ plugins {
   id "org.jetbrains.kotlin.android"
 }
 
-// https://github.com/facebook/react-native/blob/a70354df12ef71aec08583cca4f1fed5fb77d874/ReactAndroid/build.gradle#L168-L201
-def findNodeModulePath(baseDir, packageName) {
-  def basePath = baseDir.toPath().normalize()
-  // Node's module resolution algorithm searches up to the root directory,
-  // after which the base path will be null
-  while (basePath) {
-    def candidatePath = Paths.get(basePath.toString(), "node_modules", packageName)
-    if (candidatePath.toFile().exists()) {
-      return candidatePath.toString()
-    }
-    basePath = basePath.getParent()
+ext {
+  jvmVersion = Jvm.current().javaVersion.majorVersion
+  if (jvmVersion != "8" && jvmVersion != "11" && jvmVersion != "17" && jvmVersion != "21") {
+    println "\n\n\n"
+    println "**************************************************************************************************************"
+    println "\n\n\n"
+    println "ERROR: Notifee builds with JVM LTS and current releases (currently major version 11, 17, or 21)."
+    println "  Incompatible major version detected: '" + jvmVersion + "'"
+    println "\n\n\n"
+    println "**************************************************************************************************************"
+    println "\n\n\n"
+    System.exit(1)
   }
-  return null
 }
 
-def notifeeDir = findNodeModulePath(projectDir, "react-native-notify-kit") ?: "$rootDir/../node_modules/react-native-notify-kit"
-println ":${project.name} react-native-notify-kit found at $notifeeDir"
-
 if (project.hasProperty('reactNativeProjects')) {
   reactNativeProjects.each { dependent ->
     project.evaluationDependsOn(dependent)
@@ -57,6 +54,15 @@ android {
     minSdk = 24
     targetSdk = 35
     multiDexEnabled true
+
+    testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
+
+    javaCompileOptions {
+      annotationProcessorOptions {
+        arguments = ["room.schemaLocation": "$projectDir/schemas".toString(),
+                     eventBusIndex: 'app.notifee.core.EventBusIndex']
+      }
+    }
   }
 
   lint {
@@ -76,7 +82,28 @@ android {
   sourceSets {
     main {
       kotlin.srcDirs += 'src/main/kotlin'
+      java.srcDirs += 'src/main/java'
     }
+    androidTest.assets.srcDirs += files("$projectDir/schemas".toString())
+  }
+
+  testOptions {
+    unitTests.returnDefaultValues = true
+  }
+
+  testOptions.unitTests.all {
+    testLogging {
+      events "failed", "skipped"
+      showStackTraces = true
+      exceptionFormat = "full"
+    }
+
+    maxParallelForks = (System.getenv("CI") == "true") ? 1 : Runtime.runtime.availableProcessors().intdiv(2) ?: 1
+    forkEvery = 40
+    maxHeapSize = "2048m"
+    minHeapSize = "1024m"
+    systemProperties['junit.jupiter.execution.parallel.enabled'] = true
+    systemProperties['junit.jupiter.execution.parallel.mode.default'] = "concurrent"
   }
 
   buildTypes {
@@ -92,34 +119,39 @@ repositories {
 }
 
 dependencies {
-  if (findProject(':notifee_core')) {
-    implementation findProject(':notifee_core')
-  } else {
-    implementation(group: 'app.notifee', name:'core', version: '+')
-  }
-
+  // --- Core dependencies (formerly in android/build.gradle) ---
+  api 'androidx.annotation:annotation:1.3.0' // https://developer.android.com/jetpack/androidx/releases/annotation
+  api 'androidx.concurrent:concurrent-futures:1.1.0' // https://developer.android.com/jetpack/androidx/releases/concurrent
+  api 'androidx.work:work-runtime:2.11.1' // https://developer.android.com/jetpack/androidx/releases/work
+  implementation 'com.facebook.fresco:fresco:2.6.0' // https://github.com/facebook/fresco/releases
   implementation("com.google.guava:guava:33.5.0-android") // https://github.com/google/guava
-  implementation 'androidx.concurrent:concurrent-futures:1.1.0' // https://developer.android.com/jetpack/androidx/releases/concurrent
-  implementation 'androidx.work:work-runtime:2.11.1' // https://developer.android.com/jetpack/androidx/releases/work
-  implementation 'org.greenrobot:eventbus:3.3.1' // https://github.com/greenrobot/EventBus/releases
-  implementation 'androidx.lifecycle:lifecycle-process:2.3.1'
+  compileOnly 'org.checkerframework:checker-qual:3.43.0' // required by Guava's nullness annotations
+  implementation 'androidx.core:core:1.6.0'
 
   // NotifeeCoreDatabase_Impl is generated against Room 2.8.4's RoomOpenDelegate API
   // (stable since Room 2.6.0). If bumping this version, verify the generated _Impl class
   // is still binary-compatible by running yarn smoke:android. A future Room 3.0 with
-  // breaking changes will require regenerating and republishing the core AAR.
-  api 'androidx.room:room-runtime:2.8.4' // https://developer.android.com/jetpack/androidx/releases/room
+  // breaking changes will require regenerating the core database sources.
+  def room_version = '2.8.4' // https://developer.android.com/jetpack/androidx/releases/room
+  api "androidx.room:room-runtime:$room_version"
   api 'androidx.sqlite:sqlite:2.6.2' // https://developer.android.com/jetpack/androidx/releases/sqlite
   api 'androidx.sqlite:sqlite-framework:2.6.2'
+  annotationProcessor "androidx.room:room-compiler:$room_version"
+
+  def eventbus_version = '3.3.1' // https://github.com/greenrobot/EventBus/releases
+  api "org.greenrobot:eventbus:$eventbus_version"
+  annotationProcessor "org.greenrobot:eventbus-annotation-processor:$eventbus_version"
 
+  // --- Bridge dependencies ---
+  implementation 'androidx.lifecycle:lifecycle-process:2.3.1'
   //noinspection GradleDynamicVersion
   implementation 'com.facebook.react:react-android:+'
-}
 
-rootProject.allprojects {
-  repositories {
-    maven {
-      url "$notifeeDir/android/libs"
-    }
-  }
+  // --- Test dependencies ---
+  testImplementation 'junit:junit:4.13.2' // https://github.com/junit-team/junit4/releases
+  testImplementation 'org.robolectric:robolectric:4.14.1' // https://github.com/robolectric/robolectric/releases
+  androidTestImplementation 'androidx.test.ext:junit:1.1.3' // https://developer.android.com/jetpack/androidx/releases/test
+  androidTestImplementation 'androidx.test.espresso:espresso-core:3.4.0' // see above
+  androidTestImplementation "androidx.room:room-testing:$room_version"
+  androidTestImplementation "androidx.test:monitor:1.4.0"
 }

package/android/proguard-rules.pro

@@ -1,3 +1,5 @@
+# --- Bridge classes ---
+
 -keep class io.invertase.notifee.NotifeeEventSubscriber
 -keep class io.invertase.notifee.NotifeeInitProvider
 -keepnames class io.invertase.notifee.NotifeePackage
@@ -12,8 +14,18 @@
 -keep class * extends com.facebook.react.ReactHost { *; }
 -keepnames class com.facebook.react.ReactActivity
 
+# --- Core classes ---
+
+# InitProvider is subclassed by the RN bridge module (NotifeeInitProvider).
+# R8 must not finalize its methods, otherwise the bridge cannot override onCreate().
+-keep class app.notifee.core.InitProvider { *; }
+-keeppackagenames app.notifee.core.**
+
+# --- Annotations ---
+
 # Preserve all annotations.
 -keepattributes *Annotation*
+-keepattributes Exceptions,InnerClasses,Signature,Deprecated,SourceFile,LineNumberTable,EnclosingMethod
 
 # Keep the classes/members we need for client functionality.
 -keep @interface androidx.annotation.Keep { *; }
@@ -35,6 +47,8 @@
   @app.notifee.core.KeepForSdk <methods>;
 }
 
+# --- Class/method preservation ---
+
 # Preserve all .class method names.
 -keepclassmembernames class * {
     java.lang.Class class$(java.lang.String);
@@ -72,4 +86,3 @@
 -keepclassmembers class * extends org.greenrobot.eventbus.util.ThrowableFailureEvent {
     <init>(java.lang.Throwable);
 }
-

package/android/schemas/app.notifee.core.database.NotifeeCoreDatabase/1.json

@@ -0,0 +1,44 @@
+{
+  "formatVersion": 1,
+  "database": {
+    "version": 1,
+    "identityHash": "f3fdf2a542ef241fa353c4b3be121211",
+    "entities": [
+      {
+        "tableName": "work_data",
+        "createSql": "CREATE TABLE IF NOT EXISTS `${TABLE_NAME}` (`id` TEXT NOT NULL, `notification` BLOB, `trigger` BLOB, PRIMARY KEY(`id`))",
+        "fields": [
+          {
+            "fieldPath": "id",
+            "columnName": "id",
+            "affinity": "TEXT",
+            "notNull": true
+          },
+          {
+            "fieldPath": "notification",
+            "columnName": "notification",
+            "affinity": "BLOB",
+            "notNull": false
+          },
+          {
+            "fieldPath": "trigger",
+            "columnName": "trigger",
+            "affinity": "BLOB",
+            "notNull": false
+          }
+        ],
+        "primaryKey": {
+          "columnNames": ["id"],
+          "autoGenerate": false
+        },
+        "indices": [],
+        "foreignKeys": []
+      }
+    ],
+    "views": [],
+    "setupQueries": [
+      "CREATE TABLE IF NOT EXISTS room_master_table (id INTEGER PRIMARY KEY,identity_hash TEXT)",
+      "INSERT OR REPLACE INTO room_master_table (id,identity_hash) VALUES(42, 'f3fdf2a542ef241fa353c4b3be121211')"
+    ]
+  }
+}

package/android/schemas/app.notifee.core.database.NotifeeCoreDatabase/2.json

@@ -0,0 +1,51 @@
+{
+  "formatVersion": 1,
+  "database": {
+    "version": 2,
+    "identityHash": "24b2477514809255df232947ce7928c4",
+    "entities": [
+      {
+        "tableName": "work_data",
+        "createSql": "CREATE TABLE IF NOT EXISTS `${TABLE_NAME}` (`id` TEXT NOT NULL, `notification` BLOB, `trigger` BLOB, `with_alarm_manager` INTEGER NOT NULL DEFAULT 0, PRIMARY KEY(`id`))",
+        "fields": [
+          {
+            "fieldPath": "id",
+            "columnName": "id",
+            "affinity": "TEXT",
+            "notNull": true
+          },
+          {
+            "fieldPath": "notification",
+            "columnName": "notification",
+            "affinity": "BLOB",
+            "notNull": false
+          },
+          {
+            "fieldPath": "trigger",
+            "columnName": "trigger",
+            "affinity": "BLOB",
+            "notNull": false
+          },
+          {
+            "fieldPath": "withAlarmManager",
+            "columnName": "with_alarm_manager",
+            "affinity": "INTEGER",
+            "notNull": true,
+            "defaultValue": "0"
+          }
+        ],
+        "primaryKey": {
+          "columnNames": ["id"],
+          "autoGenerate": false
+        },
+        "indices": [],
+        "foreignKeys": []
+      }
+    ],
+    "views": [],
+    "setupQueries": [
+      "CREATE TABLE IF NOT EXISTS room_master_table (id INTEGER PRIMARY KEY,identity_hash TEXT)",
+      "INSERT OR REPLACE INTO room_master_table (id,identity_hash) VALUES(42, '24b2477514809255df232947ce7928c4')"
+    ]
+  }
+}

package/android/src/androidTest/java/app/notifee/core/ExampleInstrumentedTest.java

@@ -0,0 +1,25 @@
+package app.notifee.core;
+
+import static org.junit.Assert.*;
+
+import android.content.Context;
+import androidx.test.ext.junit.runners.AndroidJUnit4;
+import androidx.test.platform.app.InstrumentationRegistry;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+
+/**
+ * Instrumented test, which will execute on an Android device.
+ *
+ * @see <a href="http://d.android.com/tools/testing">Testing documentation</a>
+ */
+@RunWith(AndroidJUnit4.class)
+public class ExampleInstrumentedTest {
+  @Test
+  public void useAppContext() {
+    // Context of the app under test.
+    Context appContext = InstrumentationRegistry.getInstrumentation().getTargetContext();
+
+    assertEquals("app.notifee.core.test", appContext.getPackageName());
+  }
+}

package/android/src/androidTest/java/app/notifee/core/database/NotifeeCoreDatabaseTest.java

@@ -0,0 +1,55 @@
+package app.notifee.core.database;
+
+import static app.notifee.core.database.NotifeeCoreDatabase.MIGRATION_1_2;
+
+import androidx.room.Room;
+import androidx.room.migration.Migration;
+import androidx.room.testing.MigrationTestHelper;
+import androidx.sqlite.db.SupportSQLiteDatabase;
+import androidx.sqlite.db.framework.FrameworkSQLiteOpenHelperFactory;
+import androidx.test.ext.junit.runners.AndroidJUnit4;
+import androidx.test.platform.app.InstrumentationRegistry;
+import java.io.IOException;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+
+@RunWith(AndroidJUnit4.class)
+public class NotifeeCoreDatabaseTest {
+  private static final String TEST_DB = "migration-test";
+
+  @Rule public MigrationTestHelper helper;
+
+  public NotifeeCoreDatabaseTest() {
+    helper =
+        new MigrationTestHelper(
+            InstrumentationRegistry.getInstrumentation(),
+            NotifeeCoreDatabase.class.getCanonicalName(),
+            new FrameworkSQLiteOpenHelperFactory());
+  }
+
+  @Test
+  public void migrateAll() throws IOException {
+    // Create earliest version of the database.
+
+    SupportSQLiteDatabase db = helper.createDatabase(TEST_DB, 1);
+    db.delete("work_data", null, null);
+    db.close();
+
+    // Open latest version of the database. Room will validate the schema
+    // once all migrations execute.
+    NotifeeCoreDatabase appDb =
+        Room.databaseBuilder(
+                InstrumentationRegistry.getInstrumentation().getTargetContext(),
+                NotifeeCoreDatabase.class,
+                TEST_DB)
+            .addMigrations(ALL_MIGRATIONS)
+            .build();
+    appDb.workDao().getAllWithAlarmManager(true);
+    appDb.getOpenHelper().getWritableDatabase();
+    appDb.close();
+  }
+
+  // Array of all migrations
+  private static final Migration[] ALL_MIGRATIONS = new Migration[] {MIGRATION_1_2};
+}

package/android/src/main/AndroidManifest.xml

@@ -1,10 +1,77 @@
-<?xml version="1.0" encoding="utf-8"?>
-<manifest xmlns:android="http://schemas.android.com/apk/res/android"
-  package="io.invertase.notifee">
+<manifest xmlns:android="http://schemas.android.com/apk/res/android">
+
+  <uses-permission android:name="android.permission.POST_NOTIFICATIONS"/>
+  <uses-permission android:name="android.permission.WAKE_LOCK" />
+  <uses-permission android:name="android.permission.ACCESS_NETWORK_STATE" />
+  <uses-permission android:name="android.permission.RECEIVE_BOOT_COMPLETED" />
+  <uses-permission android:name="android.permission.VIBRATE" />
+  <uses-permission android:name="android.permission.INTERNET" />
+  <uses-permission android:name="android.permission.FOREGROUND_SERVICE" />
+  <uses-permission android:name="android.permission.SCHEDULE_EXACT_ALARM" />
+  <uses-permission android:name="android.permission.BROADCAST_CLOSE_SYSTEM_DIALOGS" android:maxSdkVersion="30" />
+  <!-- For Xiaomi devices to enable heads-up notifications as default (https://github.com/invertase/notifee/issues/296) -->
+  <uses-permission android:name="android.permission.ACCESS_NOTIFICATION_POLICY" android:minSdkVersion="23" />
 
   <application>
+    <!-- Receiver Service -->
+    <service
+      android:name="app.notifee.core.ReceiverService"
+      android:exported="false" />
+
+    <activity
+      android:name="app.notifee.core.NotificationReceiverActivity"
+      android:noHistory="true"
+      android:excludeFromRecents="true"
+      android:taskAffinity=""
+      android:theme="@android:style/Theme.Translucent.NoTitleBar"
+      android:exported="true" />
+
+    <!-- Foreground Service -->
+    <service
+      android:name="app.notifee.core.ForegroundService"
+      android:exported="false" />
+
+    <receiver
+        android:name="app.notifee.core.RebootBroadcastReceiver"
+        android:exported="false">
+        <intent-filter>
+            <action android:name="android.intent.action.BOOT_COMPLETED" />
+            <action android:name="android.intent.action.QUICKBOOT_POWERON" />
+            <action android:name="com.htc.intent.action.QUICKBOOT_POWERON"/>
+        </intent-filter>
+    </receiver>
+
+    <receiver
+      android:name="app.notifee.core.AlarmPermissionBroadcastReceiver"
+      android:exported="true">
+      <intent-filter>
+        <action android:name="android.app.action.SCHEDULE_EXACT_ALARM_PERMISSION_STATE_CHANGED" />
+      </intent-filter>
+    </receiver>
+
+    <receiver
+      android:name="app.notifee.core.NotificationAlarmReceiver"
+      android:exported="false">
+      <intent-filter>
+        <action android:name="android.intent.action.BOOT_COMPLETED" />
+        <action android:name="android.intent.action.QUICKBOOT_POWERON" />
+        <action android:name="com.htc.intent.action.QUICKBOOT_POWERON"/>
+      </intent-filter>
+    </receiver>
+
+    <!-- Broadcast Receiver -->
+    <receiver
+      android:name="app.notifee.core.BlockStateBroadcastReceiver"
+      android:exported="false">
+      <intent-filter>
+        <action android:name="android.app.action.APP_BLOCK_STATE_CHANGED" />
+        <action android:name="android.app.action.NOTIFICATION_CHANNEL_BLOCK_STATE_CHANGED" />
+        <action android:name="android.app.action.NOTIFICATION_CHANNEL_GROUP_BLOCK_STATE_CHANGED" />
+      </intent-filter>
+    </receiver>
+
     <provider
-      android:name=".NotifeeInitProvider"
+      android:name="io.invertase.notifee.NotifeeInitProvider"
       android:authorities="${applicationId}.notifee-init-provider"
       android:exported="false"
       android:initOrder="-100" />

package/android/src/main/java/app/notifee/core/AlarmPermissionBroadcastReceiver.java

@@ -0,0 +1,25 @@
+package app.notifee.core;
+
+import static android.app.AlarmManager.ACTION_SCHEDULE_EXACT_ALARM_PERMISSION_STATE_CHANGED;
+
+import android.content.BroadcastReceiver;
+import android.content.Context;
+import android.content.Intent;
+import android.util.Log;
+
+public class AlarmPermissionBroadcastReceiver extends BroadcastReceiver {
+  @Override
+  public void onReceive(Context context, Intent intent) {
+
+    if (intent.getAction().equals(ACTION_SCHEDULE_EXACT_ALARM_PERMISSION_STATE_CHANGED)) {
+      PendingResult pendingResult = goAsync();
+      Log.i("AlarmPermissionReceiver", "Received alarm permission state changed event");
+
+      if (ContextHolder.getApplicationContext() == null) {
+        ContextHolder.setApplicationContext(context.getApplicationContext());
+      }
+
+      new NotifeeAlarmManager().rescheduleNotifications(pendingResult);
+    }
+  }
+}