react-native-nitro-player 1.2.2 → 1.4.0

package/android/build.gradle

@@ -140,11 +140,14 @@ dependencies {
   implementation project(":react-native-nitro-modules")
 
   implementation "androidx.media3:media3-exoplayer:$media3_version"
+  implementation "androidx.media3:media3-exoplayer-hls:$media3_version" //for .m3u8
+  implementation "androidx.media3:media3-exoplayer-dash:$media3_version"
+  implementation "androidx.media3:media3-exoplayer-smoothstreaming:$media3_version"
   implementation "androidx.media3:media3-session:$media3_version"
   implementation "androidx.media3:media3-common:$media3_version"
   implementation "androidx.media:media:1.7.0"
-  
-  // WorkManager for background downloads
-  implementation "androidx.work:work-runtime-ktx:2.9.0"
+
+  // WorkManager for background downloads.
+  implementation "androidx.work:work-runtime-ktx:2.10.5" // Latest version of 2.10
 }
 

package/android/src/main/java/com/margelo/nitro/nitroplayer/core/TrackPlayerCore.kt

@@ -125,6 +125,7 @@ class TrackPlayerCore private constructor(
 
     // ── Service binding ────────────────────────────────────────────────────
     private var serviceBound = false
+    private var rebindAttempts = 0
 
     private val serviceConnection =
         object : ServiceConnection {
@@ -132,7 +133,35 @@ class TrackPlayerCore private constructor(
                 name: ComponentName?,
                 service: IBinder?,
             ) {
-                val binder = service as NitroPlayerPlaybackService.LocalBinder
+                // Android can redeliver the MediaSessionService binder instead of
+                // our LocalBinder (e.g. after the service is restarted). Guard the
+                // cast and rebind explicitly with ACTION_LOCAL_BIND instead of crashing.
+                val binder = service as? NitroPlayerPlaybackService.LocalBinder
+                if (binder == null) {
+                    NitroPlayerLogger.log("TrackPlayerCore") {
+                        "onServiceConnected received unexpected binder: $service"
+                    }
+                    try {
+                        context.unbindService(this)
+                    } catch (_: Exception) {}
+                    serviceBound = false
+                    if (rebindAttempts < 3) {
+                        rebindAttempts++
+                        handler.post {
+                            val bindIntent =
+                                Intent(context, NitroPlayerPlaybackService::class.java).apply {
+                                    action = NitroPlayerPlaybackService.ACTION_LOCAL_BIND
+                                }
+                            context.bindService(
+                                bindIntent,
+                                this,
+                                Context.BIND_AUTO_CREATE,
+                            )
+                        }
+                    }
+                    return
+                }
+                rebindAttempts = 0
                 playerHandler = binder.handler
                 binder.service.trackPlayerCore = this@TrackPlayerCore
                 serviceBound = true

package/android/src/main/java/com/margelo/nitro/nitroplayer/download/DownloadWorker.kt

@@ -11,7 +11,9 @@ import androidx.work.ForegroundInfo
 import androidx.work.WorkerParameters
 import com.margelo.nitro.nitroplayer.*
 import kotlinx.coroutines.Dispatchers
+import kotlinx.coroutines.TimeoutCancellationException
 import kotlinx.coroutines.withContext
+import kotlinx.coroutines.withTimeout
 import java.io.BufferedInputStream
 import java.io.FileOutputStream
 import java.net.HttpURLConnection
@@ -35,6 +37,14 @@ class DownloadWorker(
         private const val NOTIFICATION_CHANNEL_ID = "nitro_player_downloads"
         private const val BASE_NOTIFICATION_ID = 2001
         private const val BUFFER_SIZE = 8192
+
+        /**
+         * Hard upper bound on a single download. Bounds runaway/trickling
+         * downloads so the dataSync foreground service is always released
+         * well within the Android 14+ FGS timeout window — otherwise the
+         * system kills the app with ForegroundServiceDidNotStopInTimeException.
+         */
+        private const val MAX_DOWNLOAD_DURATION_MS = 30L * 60L * 1000L
         private val CONTENT_DISPOSITION_REGEX = Regex("filename=\"?([^\";]+)\"?")
     }
 
@@ -72,8 +82,12 @@ class DownloadWorker(
                     // Download continues in background.
                 }
 
-                // Perform download
-                val localPath = downloadFile(downloadId, trackId, trackTitle, urlString, storageLocation)
+                // Perform download, bounded so the foreground service is
+                // always released within the Android 14+ FGS timeout window.
+                val localPath =
+                    withTimeout(MAX_DOWNLOAD_DURATION_MS) {
+                        downloadFile(downloadId, trackId, trackTitle, urlString, storageLocation)
+                    }
 
                 if (localPath != null) {
                     downloadManager.onComplete(downloadId, trackId, localPath)
@@ -91,6 +105,17 @@ class DownloadWorker(
                     showErrorNotification(trackTitle)
                     Result.retry()
                 }
+            } catch (e: TimeoutCancellationException) {
+                val error =
+                    DownloadError(
+                        code = "DOWNLOAD_TIMEOUT",
+                        message = "Download exceeded maximum allowed duration",
+                        reason = DownloadErrorReason.TIMEOUT,
+                        isRetryable = true,
+                    )
+                downloadManager.onError(downloadId, trackId, error)
+                showErrorNotification(trackTitle)
+                Result.retry()
             } catch (e: Exception) {
                 val errorReason =
                     when {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "react-native-nitro-player",
-  "version": "1.2.2",
+  "version": "1.4.0",
   "description": "A powerful audio player library for React Native with playlist management, playback controls, and support for Android Auto and CarPlay",
   "main": "lib/index",
   "module": "lib/index",
@@ -114,7 +114,8 @@
   },
   "release-it": {
     "npm": {
-      "publish": true
+      "publish": true,
+      "skipChecks": true
     },
     "git": {
       "commitMessage": "chore: release ${version}",