react-native-nitro-player 0.5.0 → 0.5.1

package/ios/core/TrackPlayerCore.swift

@@ -125,9 +125,10 @@ class TrackPlayerCore: NSObject {
 
     // MARK: - Gapless Playback Configuration
 
-    // Disable automatic waiting to minimize stalling - this allows smoother transitions
-    // between tracks as AVPlayer won't pause to buffer excessively
-    player?.automaticallyWaitsToMinimizeStalling = false
+    // Start with stall-waiting enabled so the first track buffers before playing.
+    // Once the first item is ready (readyToPlay), this is flipped to false for
+    // gapless inter-track transitions (see setupCurrentItemObservers).
+    player?.automaticallyWaitsToMinimizeStalling = true
 
     // Set playback rate to 1.0 immediately when ready (reduces gap between tracks)
     player?.actionAtItemEnd = .advance
@@ -138,7 +139,7 @@ class TrackPlayerCore: NSObject {
     }
 
     print(
-      "🎵 TrackPlayerCore: Gapless playback configured - automaticallyWaitsToMinimizeStalling=false")
+      "🎵 TrackPlayerCore: Gapless playback configured - automaticallyWaitsToMinimizeStalling=true (flipped to false on first readyToPlay)")
 
     setupPlayerObservers()
   }
@@ -569,6 +570,8 @@ class TrackPlayerCore: NSObject {
       if item.status == .readyToPlay {
         print("✅ TrackPlayerCore: Item ready, setting up boundaries")
         self?.setupBoundaryTimeObserver()
+        // First item is buffered and ready — disable stall waiting for gapless inter-track transitions
+        self?.player?.automaticallyWaitsToMinimizeStalling = false
         // Update now playing info now that duration is available
         self?.mediaSessionManager?.updateNowPlayingInfo()
       } else if item.status == .failed {
@@ -736,12 +739,11 @@ class TrackPlayerCore: NSObject {
       asset = preloadedAsset
       print("🚀 TrackPlayerCore: Using preloaded asset for \(track.title)")
     } else {
-      // Create asset with options optimized for gapless playback
-      asset = AVURLAsset(
-        url: url,
-        options: [
-          AVURLAssetPreferPreciseDurationAndTimingKey: true  // Ensures accurate duration for gapless transitions
-        ])
+      // No AVURLAssetPreferPreciseDurationAndTimingKey — gapless playback is achieved via
+      // AVQueuePlayer's internal audio buffer pre-roll, not timing metadata.
+      // Precise timing only helps with accurate VBR duration display, at the cost of
+      // deep file scanning that delays readyToPlay.
+      asset = AVURLAsset(url: url)
     }
 
     let item = AVPlayerItem(asset: asset)
@@ -807,11 +809,7 @@ class TrackPlayerCore: NSObject {
 
         guard let url = URL(string: track.url) else { continue }
 
-        let asset = AVURLAsset(
-          url: url,
-          options: [
-            AVURLAssetPreferPreciseDurationAndTimingKey: true
-          ])
+        let asset = AVURLAsset(url: url)
 
         // Preload essential keys for gapless playback
         asset.loadValuesAsynchronously(forKeys: Constants.preloadAssetKeys) { [weak self] in
@@ -1000,7 +998,7 @@ class TrackPlayerCore: NSObject {
     print("📋 TrackPlayerCore: UPDATE PLAYER QUEUE - Received \(tracks.count) tracks")
     print(String(repeating: "=", count: Constants.separatorLineLength))
 
-    // Print the full playlist being fed and check download status
+    #if DEBUG
     for (index, track) in tracks.enumerated() {
       let isDownloaded = DownloadManagerCore.shared.isTrackDownloaded(trackId: track.id)
       let downloadStatus = isDownloaded ? "📥 DOWNLOADED" : "🌐 REMOTE"
@@ -1013,6 +1011,7 @@ class TrackPlayerCore: NSObject {
       }
     }
     print(String(repeating: "=", count: Constants.separatorLineLength) + "\n")
+    #endif
 
     // Store tracks for index tracking
     currentTracks = tracks
@@ -1025,12 +1024,15 @@ class TrackPlayerCore: NSObject {
       boundaryTimeObserver = nil
     }
 
+    // Re-enable stall waiting for the new first track so it buffers before playing.
+    // Will be flipped back to false once the first item reaches readyToPlay.
+    player?.automaticallyWaitsToMinimizeStalling = true
+
     // Clear old preloaded assets when loading new queue
     preloadedAssets.removeAll()
 
     // Create gapless-optimized AVPlayerItems from tracks
     let items = tracks.enumerated().compactMap { (index, track) -> AVPlayerItem? in
-      // First few items get preload treatment for faster initial playback
       let isPreload = index < Constants.gaplessPreloadCount
       return createGaplessPlayerItem(for: track, isPreload: isPreload)
     }
@@ -1068,23 +1070,25 @@ class TrackPlayerCore: NSObject {
       }
     }
 
-    // Verify what's actually in the player now
+    #if DEBUG
+    let trackById = Dictionary(uniqueKeysWithValues: tracks.map { ($0.id, $0) })
     print(
       "\n🔍 TrackPlayerCore: VERIFICATION - Player now has \(existingPlayer.items().count) items:")
     for (index, item) in existingPlayer.items().enumerated() {
-      if let trackId = item.trackId, let track = tracks.first(where: { $0.id == trackId }) {
+      if let trackId = item.trackId, let track = trackById[trackId] {
         print("  [\(index + 1)] ✓ \(track.title) - \(track.artist) (ID: \(track.id))")
       } else {
         print("  [\(index + 1)] ⚠️ Unknown item (no trackId)")
       }
     }
-
-    if let currentItem = existingPlayer.currentItem, let trackId = currentItem.trackId {
-      if let track = tracks.first(where: { $0.id == trackId }) {
-        print("▶️  Current item: \(track.title)")
-      }
+    if let currentItem = existingPlayer.currentItem,
+      let trackId = currentItem.trackId,
+      let track = trackById[trackId]
+    {
+      print("▶️  Current item: \(track.title)")
     }
     print(String(repeating: "=", count: Constants.separatorLineLength) + "\n")
+    #endif
 
     // Note: Boundary time observers will be set up automatically when item becomes ready
     // This happens in setupCurrentItemObservers() -> status observer -> setupBoundaryTimeObserver()
@@ -1715,7 +1719,6 @@ class TrackPlayerCore: NSObject {
 
     // Create gapless-optimized player items
     let items = tracksToPlay.enumerated().compactMap { (offset, track) -> AVPlayerItem? in
-      // First few items get preload treatment for faster playback
       let isPreload = offset < Constants.gaplessPreloadCount
       return self.createGaplessPlayerItem(for: track, isPreload: isPreload)
     }
@@ -1731,6 +1734,10 @@ class TrackPlayerCore: NSObject {
       self.boundaryTimeObserver = nil
     }
 
+    // Re-enable stall waiting for the new first track so it buffers before playing.
+    // Will be flipped back to false once the first item reaches readyToPlay.
+    player.automaticallyWaitsToMinimizeStalling = true
+
     // Clear and rebuild queue
     player.removeAllItems()
     var lastItem: AVPlayerItem? = nil

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "react-native-nitro-player",
-  "version": "0.5.0",
+  "version": "0.5.1",
   "description": "A powerful audio player library for React Native with playlist management, playback controls, and support for Android Auto and CarPlay",
   "main": "lib/index",
   "module": "lib/index",