react-native-nitro-geolocation 1.4.0 → 1.4.1

package/android/src/main/java/com/margelo/nitro/nitrogeolocation/background/BackgroundDecisions.kt

@@ -50,3 +50,12 @@ internal fun resolveMaxStored(configured: Int?, default: Int): Int {
         else -> configured
     }
 }
+
+/**
+ * Headless JS is the fallback path when no in-process JS listener received the native event. If a
+ * live listener already handled the event, starting Headless JS duplicates delivery and React
+ * Native warns when the app did not register NitroBackgroundLocationTask.
+ */
+internal fun shouldDispatchHeadlessTask(deliveredToInProcessListener: Boolean): Boolean {
+    return !deliveredToInProcessListener
+}

package/android/src/main/java/com/margelo/nitro/nitrogeolocation/background/NitroBackgroundEventHub.kt

@@ -45,22 +45,27 @@ class NitroBackgroundEventHub {
         errorListeners.remove(token)
     }
 
-    fun emit(event: BackgroundEventEnvelope) {
+    fun emit(event: BackgroundEventEnvelope): Boolean {
+        var delivered = eventListeners.isNotEmpty()
         eventListeners.values.forEach { listener -> dispatch { listener(event) } }
 
         when (event.type) {
             BackgroundEventType.LOCATION -> {
                 event.location?.let { location ->
+                    delivered = delivered || locationListeners.isNotEmpty()
                     locationListeners.values.forEach { listener -> dispatch { listener(location) } }
                 }
             }
             BackgroundEventType.ERROR -> {
                 event.error?.let { error ->
+                    delivered = delivered || errorListeners.isNotEmpty()
                     errorListeners.values.forEach { listener -> dispatch { listener(error) } }
                 }
             }
             else -> Unit
         }
+
+        return delivered
     }
 
     // Listeners run inline on the caller's thread (often the broadcast receiver thread). Isolate

package/android/src/main/java/com/margelo/nitro/nitrogeolocation/background/NitroBackgroundLocationController.kt

@@ -604,7 +604,8 @@ class NitroBackgroundLocationController private constructor(
     }
 
     private fun dispatchEvent(event: BackgroundEventEnvelope) {
-        eventHub.emit(event)
+        val deliveredToInProcessListener = eventHub.emit(event)
+        if (!shouldDispatchHeadlessTask(deliveredToInProcessListener)) return
         // The in-process eventHub already delivered to any live JS listeners; the headless task is
         // the fallback for when JS is dead. Guard its start: startService from the background can be
         // rejected (ForegroundServiceStartNotAllowed / IllegalState), which must not crash the

package/android/src/test/java/com/margelo/nitro/nitrogeolocation/background/BackgroundDecisionsTest.kt

@@ -64,4 +64,14 @@ class BackgroundDecisionsTest {
         assertEquals(0, resolveMaxStored(0, 10_000))
         assertEquals(0, resolveMaxStored(-5, 10_000))
     }
+
+    @Test
+    fun headlessTaskIsSkippedWhenInProcessListenerReceivedEvent() {
+        assertFalse(shouldDispatchHeadlessTask(true))
+    }
+
+    @Test
+    fun headlessTaskRunsWhenNoInProcessListenerReceivedEvent() {
+        assertTrue(shouldDispatchHeadlessTask(false))
+    }
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "react-native-nitro-geolocation",
-  "version": "1.4.0",
+  "version": "1.4.1",
   "description": "Nitro-powered native geolocation for modern React Native apps",
   "main": "src/index",
   "source": "src/index",