react-native-nfc-manager 4.0.0-beta.2 → 4.0.0-beta.4

package/README.md

@@ -12,6 +12,11 @@ Made with ❤️ by [whitedogg13](https://github.com/whitedogg13) and [revteltec
 
 > Special thanks to [javix64](https://github.com/javix64) for restructuring the documentation!
 
+## Version Notes
+
+- `v3` only supports legacy architecture (latest release is `v3.16.2`).
+- `v4` supports new architecture (still in beta, latest release is `v4.0.0-beta.3`) .
+
 ## Table of Contents
 
 1. [Installation](#installation)

package/android/src/main/java/community/revteltech/nfc/NfcManager.java

@@ -94,12 +94,6 @@ class NfcManager extends NativeNfcManagerSpec implements ActivityEventListener,
         return "NfcManager";
     }
 
-    @ReactMethod
-    @Override
-    public void echo(String value, Callback callback) {
-        callback.invoke(null, value);
-    }
-
     @Override
     public Map<String, Object> getConstants() {
         final Map<String, Object> constants = new HashMap<>();
@@ -1309,9 +1303,9 @@ class NfcManager extends NativeNfcManagerSpec implements ActivityEventListener,
             try {
                 if (isReaderModeEnabled) {
                     if (enable) {
-                        Log.i(LOG_TAG, "enableReaderMode: " + readerModeFlags);
+                        Log.i(LOG_TAG, String.format("enableReaderMode, flags: %d, delay: %d ms", readerModeFlags, readerModeDelay));
                         Bundle readerModeExtras = new Bundle();
-                        readerModeExtras.putInt(NfcAdapter.EXTRA_READER_PRESENCE_CHECK_DELAY, readerModeDelay * 1000);
+                        readerModeExtras.putInt(NfcAdapter.EXTRA_READER_PRESENCE_CHECK_DELAY, readerModeDelay);
                         nfcAdapter.enableReaderMode(currentActivity, new NfcAdapter.ReaderCallback() {
                             @Override
                             public void onTagDiscovered(Tag tag) {

package/ios/NfcManager.mm

@@ -599,10 +599,6 @@ continueUserActivity:(NSUserActivity *)userActivity
 }
 #endif
 
-- (void)echo:(NSString *)value callback:(RCTResponseSenderBlock)callback {
-  callback(@[[NSNull null], value]);
-}
-    
 - (void)hasTagEventRegistration:(RCTResponseSenderBlock)callback {
     // bypass, Android's interface
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "react-native-nfc-manager",
-  "version": "4.0.0-beta.2",
+  "version": "4.0.0-beta.4",
   "description": "A NFC module for react native.",
   "main": "src/index.js",
   "repository": {

package/specs/NativeNfcManager.ts

@@ -2,7 +2,6 @@ import type {TurboModule} from 'react-native';
 import {TurboModuleRegistry} from 'react-native';
 
 export interface Spec extends TurboModule {
-  echo(value: string, callback: (err?: string, resp?: string) => void): void;
   isSupported(tech: string, callback: (err?: string, resp?: boolean) => void): void;
   isEnabled(callback: (err?: string, resp?: boolean) => void): void;
   start(callback: (err?: string) => void): void;

package/src/NfcManager.js

@@ -42,7 +42,7 @@ const DEFAULT_REGISTER_TAG_EVENT_OPTIONS = {
   invalidateAfterFirstRead: false,
   isReaderModeEnabled: false,
   readerModeFlags: 0,
-  readerModeDelay: 10,
+  readerModeDelay: 250,
 };
 
 function NotImpl() {

package/specs/NativeNfcManager.d.ts

@@ -1,6 +0,0 @@
-import type { TurboModule } from 'react-native';
-export interface Spec extends TurboModule {
-    echo(value: string, callback: (err?: string, resp?: string) => void): void;
-}
-declare const _default: Spec;
-export default _default;