react-native-navigation 7.23.1-snapshot.365 → 7.23.1-snapshot.393

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
@@ -26,6 +26,7 @@ steps:
26
26
  - "npm run test-unit-android -- --release"
27
27
  - "npm run test-e2e-android-multi -- --release --headless --verbose --ci"
28
28
  key: "android_build"
29
+ timeout_in_minutes: 90
29
30
 
30
31
  - label: ":ios: iOS - Unit"
31
32
  command:
@@ -33,6 +34,7 @@ steps:
33
34
  - "npm install"
34
35
  - "npm run test-unit-ios -- --release"
35
36
  key: "ios_unit"
37
+ timeout_in_minutes: 90
36
38
 
37
39
  - label: ":ios: iOS - E2E"
38
40
  command:
@@ -41,6 +43,7 @@ steps:
41
43
  - "npm run test-snapshot-ios -- --release"
42
44
  - "npm run test-e2e-ios -- --release --multi --ci"
43
45
  key: "ios_e2e"
46
+ timeout_in_minutes: 90
44
47
 
45
48
  - label: ":package: Publish"
46
49
  env:
@@ -53,3 +56,4 @@ steps:
53
56
  - "android_build"
54
57
  - "ios_unit"
55
58
  - "ios_e2e"
59
+ timeout_in_minutes: 90
@@ -28,7 +28,7 @@ class OverlayManager {
28
28
  }
29
29
 
30
30
  fun dismiss(overlaysContainer: ViewGroup, componentId: String, listener: CommandListener) {
31
- val overlay = overlayRegistry[componentId]
31
+ val overlay = overlayRegistry.remove(componentId)
32
32
  if (overlay == null) {
33
33
  listener.onError("Could not dismiss Overlay. Overlay with id $componentId was not found.")
34
34
  } else {
@@ -43,7 +43,13 @@ class OverlayManager {
43
43
  }
44
44
 
45
45
  fun destroy(overlaysContainer: ViewGroup) {
46
- overlayRegistry.values.forEach { overlay -> destroyOverlay(overlaysContainer, overlay) }
46
+ val removedOverlays = overlayRegistry.values.map { overlay ->
47
+ destroyOverlay(overlaysContainer, overlay)
48
+ overlay.id
49
+ }.toList()
50
+ removedOverlays.forEach {
51
+ overlayRegistry.remove(it)
52
+ }
47
53
  }
48
54
 
49
55
  fun size() = overlayRegistry.size
@@ -54,7 +60,6 @@ class OverlayManager {
54
60
 
55
61
  private fun destroyOverlay(overlaysContainer: ViewGroup, overlay: ViewController<*>) {
56
62
  overlay.destroy()
57
- overlayRegistry.remove(overlay.id)
58
63
  if (isEmpty) overlaysContainer.visibility = View.GONE
59
64
  }
60
65
 
@@ -32,6 +32,7 @@ public class OverlayManagerTest extends BaseTest {
32
32
 
33
33
  @Override
34
34
  public void beforeEach() {
35
+ super.beforeEach();
35
36
  Activity activity = newActivity();
36
37
  contentLayout = new FrameLayout(activity);
37
38
  contentLayout.layout(0, 0, 1000, 1000);
package/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "react-native-navigation",
3
- "version": "7.23.1-snapshot.365",
3
+ "version": "7.23.1-snapshot.393",
4
4
  "description": "React Native Navigation - truly native navigation for iOS and Android",
5
5
  "license": "MIT",
6
6
  "nativePackage": true,