react-native-navigation-mode 1.2.4 → 1.2.6

package/README.md

@@ -73,29 +73,17 @@ npm install react-native-navigation-mode
 npx expo install react-native-navigation-mode
 ```
 
-##### Expo Configuration
-
-Add the plugin to your `app.json` or `app.config.ts`:
-
-```json
-{
-  "expo": {
-    "plugins": [
-      "react-native-navigation-mode"
-    ]
-  }
-}
-```
+##### Development Builds
 
-For bare workflow or custom native code, you'll need to prebuild:
+Since this library contains native code, it requires a [development build](https://docs.expo.dev/develop/development-builds/introduction/). It cannot be used with Expo Go.
 
 ```sh
-npx expo prebuild
-```
+# Using EAS Build (recommended)
+eas build --profile development --platform android
 
-##### Development Builds
-
-Since this library contains native code, it requires a custom development build. You cannot use it with standard Expo Go.
+# Or locally
+npx expo run:android # Should auto-run prebuild if needed
+```
 
 #### Requirements
 
@@ -396,12 +384,6 @@ The library uses multiple detection methods for maximum accuracy:
 - This is normal on devices without navigation bars (some tablets)
 - On older Android versions, fallback detection may not work on all devices
 
-**Expo: "Package does not contain a valid config plugin"**
-
-- Ensure you've installed the latest version of the library
-- Try clearing your cache: `npx expo start --clear`
-- Make sure the plugin is added to your `app.json`
-
 ## 🤝 Contributing
 
 See the [contributing guide](CONTRIBUTING.md) to learn how to contribute to the repository and the development workflow.

package/android/src/main/java/com/navigationmode/NavigationModeModule.kt

@@ -13,9 +13,9 @@ import com.facebook.react.bridge.WritableMap
 import com.facebook.react.module.annotations.ReactModule
 
 @ReactModule(name = NavigationModeModule.NAME)
-class NavigationModeModule(reactContext: ReactApplicationContext) : 
+class NavigationModeModule(reactContext: ReactApplicationContext) :
     NativeNavigationModeSpec(reactContext) {
-    
+
     companion object {
         const val NAME = "NavigationMode"
     }
@@ -26,7 +26,7 @@ class NavigationModeModule(reactContext: ReactApplicationContext) :
         // Try to get Activity for WindowInsets
         val activity = if (context is Activity) context else reactApplicationContext.currentActivity
         val density = context.resources.displayMetrics.density // Get device density
-        
+
         if (activity != null && Build.VERSION.SDK_INT >= Build.VERSION_CODES.R) {
             val insets = activity.window.decorView.rootWindowInsets
             if (insets != null) {
@@ -34,7 +34,7 @@ class NavigationModeModule(reactContext: ReactApplicationContext) :
                 return (navBar.bottom / density).toInt() // Convert pixels to dp
             }
         }
-        
+
         // Fallback to resource-based approach for API < 30
         val resources = context.resources
         val resourceId = resources.getIdentifier("navigation_bar_height", "dimen", "android")
@@ -60,20 +60,21 @@ class NavigationModeModule(reactContext: ReactApplicationContext) :
         try {
             val result = Arguments.createMap()
             val context = reactApplicationContext
-            
+
             // Use reactApplicationContext for navigation bar height
             val navBarHeight = getNavigationBarHeight(context)
             result.putInt("navigationBarHeight", navBarHeight)
-            
+
             if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.Q) {
                 val navBarInteractionMode = getNavBarInteractionMode(context)
                 result.putInt("interactionMode", navBarInteractionMode)
                 result.putString("type", getNavigationTypeFromInteractionMode(navBarInteractionMode))
+                result.putBoolean("isGestureNavigation", navBarInteractionMode == 2)
+            } else {
+                val gestureNavEnabled = isGestureNavigationEnabledLegacy(context)
+                result.putBoolean("isGestureNavigation", gestureNavEnabled)
             }
-            
-            val gestureNavEnabled = isGestureNavigationEnabled(context)
-            result.putBoolean("isGestureNavigation", gestureNavEnabled)
-                        
+
             promise.resolve(result)
         } catch (e: Exception) {
             promise.reject("NAVIGATION_MODE_ERROR", "Failed to get navigation mode: ${e.message}", e)
@@ -83,12 +84,12 @@ class NavigationModeModule(reactContext: ReactApplicationContext) :
     override fun isGestureNavigation(promise: Promise) {
         try {
             val context = reactApplicationContext
-            
+
             if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.Q) {
                 val navBarInteractionMode = getNavBarInteractionMode(context)
                 promise.resolve(navBarInteractionMode == 2)
             } else {
-                val gestureEnabled = isGestureNavigationEnabled(context)
+                val gestureEnabled = isGestureNavigationEnabledLegacy(context)
                 promise.resolve(gestureEnabled)
             }
         } catch (e: Exception) {
@@ -119,17 +120,17 @@ class NavigationModeModule(reactContext: ReactApplicationContext) :
         }
     }
 
-    private fun isGestureNavigationEnabled(context: Context): Boolean {
-        return if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.Q) {
-            try {
-                val navBarMode = Settings.Secure.getString(
-                    context.contentResolver,
-                    "navigation_mode"
-                )
-                "2" == navBarMode
-            } catch (e: Exception) {
-                false
-            }
-        } else false
+  private fun isGestureNavigationEnabledLegacy(context: Context): Boolean {
+    // Legacy fallback using Settings.Secure (for pre-Android Q devices)
+    // or as a backup when config_navBarInteractionMode is not available
+    return try {
+      val navBarMode = Settings.Secure.getString(
+        context.contentResolver,
+        "navigation_mode"
+      )
+      "2" == navBarMode
+    } catch (e: Exception) {
+      false
     }
-}
+  }
+}

package/app.plugin.js

@@ -1,15 +1,13 @@
-const { createRunOncePlugin } = require('@expo/config-plugins');
-
 /**
  * Expo Config Plugin for react-native-navigation-mode
- * This plugin ensures the native module is properly linked in managed workflow
+ *
+ * Note: This plugin is optional. The library works without adding it to your
+ * plugins array because no native configuration changes are required.
  */
+
+/** @type {import('@expo/config-plugins').ConfigPlugin} */
 const withNavigationMode = (config) => {
-  // No additional configuration needed for this module
-  // The module will be auto-linked through the Expo modules system
   return config;
 };
 
-const pkg = require('./package.json');
-
-module.exports = createRunOncePlugin(withNavigationMode, pkg.name, pkg.version);
+module.exports = withNavigationMode;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "react-native-navigation-mode",
-  "version": "1.2.4",
+  "version": "1.2.6",
   "description": "Detect Android navigation mode (3-button, 2-button, or gesture)",
   "main": "./lib/module/index.js",
   "react-native": "./lib/module/index.js",
@@ -16,7 +16,6 @@
     "react-native.config.js",
     "expo-module.config.json",
     "app.plugin.js",
-    "plugin/build",
     "!ios/build",
     "!android/build",
     "!android/gradle",

package/lib/typescript/plugin/src/withNavigationMode.d.ts

@@ -1,4 +0,0 @@
-import { type ConfigPlugin } from '@expo/config-plugins';
-declare const withNavigationMode: ConfigPlugin;
-export default withNavigationMode;
-//# sourceMappingURL=withNavigationMode.d.ts.map

package/lib/typescript/plugin/src/withNavigationMode.d.ts.map

@@ -1 +0,0 @@
-{"version":3,"file":"withNavigationMode.d.ts","sourceRoot":"","sources":["../../../../plugin/src/withNavigationMode.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,KAAK,YAAY,EAAE,MAAM,sBAAsB,CAAC;AAEzD,QAAA,MAAM,kBAAkB,EAAE,YAEzB,CAAC;AAEF,eAAe,kBAAkB,CAAC"}