react-native-morph-card 0.1.4 → 0.1.5

package/android/src/main/java/com/melivalesca/morphcard/MorphCardSourceView.kt

@@ -228,7 +228,8 @@ class MorphCardSourceView(context: Context) : ReactViewGroup(context) {
    * Walk the view tree and hide any screen container that isn't already known.
    * This catches modal screens added to separate ScreenStacks (e.g. transparentModal).
    */
-  private fun hideNewScreenContainers(root: ViewGroup, knownScreens: Set<View>) {
+  private fun hideNewScreenContainers(root: ViewGroup, knownScreens: Set<View>): Int {
+    var count = 0
     fun walk(group: ViewGroup) {
       val name = group.javaClass.name
       if (name.contains("ScreenStack") || name.contains("ScreenContainer")) {
@@ -236,6 +237,7 @@ class MorphCardSourceView(context: Context) : ReactViewGroup(context) {
           val child = group.getChildAt(i)
           if (!knownScreens.contains(child) && child.visibility == View.VISIBLE) {
             child.visibility = View.INVISIBLE
+            count++
             Log.d(TAG, "preDraw: hid new screen ${child.javaClass.simpleName} in ${group.javaClass.simpleName}")
           }
         }
@@ -246,6 +248,7 @@ class MorphCardSourceView(context: Context) : ReactViewGroup(context) {
       }
     }
     walk(root)
+    return count
   }
 
   /**
@@ -353,8 +356,16 @@ class MorphCardSourceView(context: Context) : ReactViewGroup(context) {
     val knownScreens = collectExistingScreens(decorView)
     Log.d(TAG, "prepareExpand: tracking ${knownScreens.size} existing screens")
     val pdListener = ViewTreeObserver.OnPreDrawListener {
-      hideNewScreenContainers(decorView, knownScreens)
-      true
+      val hidCount = hideNewScreenContainers(decorView, knownScreens)
+      if (hidCount > 0) {
+        // Cancel this draw frame — the new screen was visible and we just hid it.
+        // Returning false prevents this frame from rendering, so the screen
+        // is never shown. The next frame will re-check and proceed.
+        Log.d(TAG, "preDraw: cancelled draw frame (hid $hidCount screens)")
+        false
+      } else {
+        true
+      }
     }
     decorView.viewTreeObserver.addOnPreDrawListener(pdListener)
     preDrawListener = pdListener
@@ -366,11 +377,10 @@ class MorphCardSourceView(context: Context) : ReactViewGroup(context) {
     // being visible. We use PixelCopy to capture the current screen with
     // hardware rendering preserved (clipToOutline, borderRadius, etc.).
     val fullScreenOverlay = FrameLayout(context)
-    fullScreenOverlay.layoutParams = FrameLayout.LayoutParams(
-      FrameLayout.LayoutParams.MATCH_PARENT,
-      FrameLayout.LayoutParams.MATCH_PARENT
-    )
+    fullScreenOverlay.layoutParams = FrameLayout.LayoutParams(decorView.width, decorView.height)
     fullScreenOverlay.isClickable = true
+    // Ensure the overlay renders above any views with elevation (e.g. ScreenStack children)
+    fullScreenOverlay.translationZ = 1000f
 
     // PixelCopy captures from the surface (hardware-rendered, preserves outlines).
     // We use a background HandlerThread for the callback to avoid deadlocking main.
@@ -382,9 +392,7 @@ class MorphCardSourceView(context: Context) : ReactViewGroup(context) {
       val copyHandler = Handler(copyThread.looper)
       val latch = java.util.concurrent.CountDownLatch(1)
       android.view.PixelCopy.request(window, blockerBitmap, { result ->
-        if (result != android.view.PixelCopy.SUCCESS) {
-          Log.d(TAG, "prepareExpand: PixelCopy failed with result=$result")
-        }
+        Log.d(TAG, "prepareExpand: PixelCopy result=$result (0=SUCCESS)")
         latch.countDown()
       }, copyHandler)
       // Wait for the copy (typically <5ms)

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "react-native-morph-card",
-  "version": "0.1.4",
+  "version": "0.1.5",
   "description": "Native card-to-modal morph transition for React Native. iOS App Store-style expand animation.",
   "main": "lib/commonjs/index.js",
   "module": "lib/module/index.js",