react-native-monorepo-config 0.1.5 → 0.1.7

package/index.js

@@ -34,33 +34,42 @@ export function withMetroConfig(baseConfig, { root, dirname }) {
 
   // Get the list of monorepo packages except current package
   // Yarn also supports workspaces as an object with a "packages" field
-  const packages = (pkg.workspaces.packages || pkg.workspaces)
-    .flatMap((pattern) =>
-      glob.sync(pattern, {
-        cwd: root,
-        onlyDirectories: true,
-        ignore: [`**/node_modules`, `**/.git`, `**/.yarn`],
+  const packages = Object.fromEntries(
+    (pkg.workspaces.packages || pkg.workspaces)
+      .flatMap((pattern) =>
+        glob.sync(pattern, {
+          cwd: root,
+          onlyDirectories: true,
+          ignore: [`**/node_modules`, `**/.git`, `**/.yarn`],
+        })
+      )
+      .map((p) => path.join(root, p))
+      .filter((dir) => {
+        // Exclude current package
+        if (path.relative(dir, dirname) === '') {
+          return false;
+        }
+
+        // Ignore folders that don't have a package.json
+        return fs.existsSync(path.join(dir, 'package.json'));
       })
-    )
-    .map((p) => path.join(root, p))
-    .filter((dir) => {
-      // Exclude current package
-      if (path.relative(dir, dirname) === '') {
-        return false;
-      }
-
-      // Ignore folders that don't have a package.json
-      return fs.existsSync(path.join(dir, 'package.json'));
-    });
+      .map((dir) => {
+        const pak = JSON.parse(
+          fs.readFileSync(path.join(dir, 'package.json'), 'utf8')
+        );
+
+        return [pak.name, dir];
+      })
+  );
 
   // If monorepo root contains a name, add it to the list of packages
   // Necessary if the root is a package itself
   if (pkg.name) {
-    packages.push(root);
+    packages[pkg.name] = root;
   }
 
   // Get the list of peer dependencies for all packages in the monorepo
-  const peers = packages
+  const peers = Object.values(packages)
     .flatMap((dir) => {
       const pak = JSON.parse(
         fs.readFileSync(path.join(dir, 'package.json'), 'utf8')
@@ -77,7 +86,7 @@ export function withMetroConfig(baseConfig, { root, dirname }) {
   // Otherwise duplicate versions of the same package will be loaded
   const blockList = new RegExp(
     '(' +
-      packages
+      Object.values(packages)
         .flatMap((dir) =>
           peers.map(
             (m) => `^${escape(path.join(dir, 'node_modules', m))}\\/.*$`
@@ -103,6 +112,13 @@ export function withMetroConfig(baseConfig, { root, dirname }) {
     return acc;
   }, {});
 
+  // If monorepo root is a package, add it to extraNodeModules so metro can find it
+  // Normally monorepo packages are symlinked to node_modules, but the root is not
+  // So we need to add it manually
+  if (pkg.name) {
+    extraNodeModules[pkg.name] = root;
+  }
+
   /** @type {import('metro-config').MetroConfig} */
   return {
     ...baseConfig,
@@ -119,17 +135,30 @@ export function withMetroConfig(baseConfig, { root, dirname }) {
 
       blockList,
       extraNodeModules,
-      resolveRequest: (context, realModuleName, platform) => {
+      resolveRequest: (originalContext, moduleName, platform) => {
+        let context = originalContext;
+
         // Prefer the source field for monorepo packages to consume source code
-        if (packages.includes(realModuleName)) {
-          context.mainFields = ['source', ...context.mainFields];
-          context.unstable_conditionNames = [
-            'source',
-            ...context.unstable_conditionNames,
-          ];
+        if (packages[moduleName]) {
+          context = {
+            ...context,
+            mainFields: ['source', ...context.mainFields],
+            unstable_conditionNames: [
+              'source',
+              ...context.unstable_conditionNames,
+            ],
+          };
         }
 
-        return context.resolveRequest(context, realModuleName, platform);
+        if (baseConfig.resolver.resolveRequest) {
+          return baseConfig.resolver.resolveRequest(
+            context,
+            moduleName,
+            platform
+          );
+        } else {
+          return context.resolveRequest(context, moduleName, platform);
+        }
       },
     },
   };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "react-native-monorepo-config",
-  "version": "0.1.5",
+  "version": "0.1.7",
   "description": "Configure Metro for a React Native app in a monorepo",
   "repository": "https://github.com/satya164/react-native-monorepo-config",
   "author": "Satyajit Sahoo <satyajit.happy@gmail.com> (https://github.com/satya164/)",