react-native-maps 0.31.1 → 1.0.0-beta.3

package/README.md

@@ -14,11 +14,7 @@ See [Setup Instructions for the Included Example Project](docs/examples-setup.md
 
 ## Compatibility
 
-Due to the rapid changes being made in the React Native ecosystem, we are not officially going to
-support this module on anything but the latest version of React Native. With that said, we will do
-our best to stay compatible with older versions as much that is practical, and the peer dependency
-of this requirement is set to `"react-native": "*"` explicitly for this reason. If you are using
-an older version of React Native with this module though, some features may be buggy.
+`react-native-maps` requires `react-native >= 0.64.3`.
 
 ## Component API
 

package/android/src/main/AndroidManifest.xml

@@ -1,6 +1,3 @@
-<?xml version="1.0" encoding="utf-8"?>
 <manifest xmlns:android="http://schemas.android.com/apk/res/android"
     package="com.airbnb.android.react.maps" >
-    <uses-permission android:name="android.permission.INTERNET" />
-    <uses-permission android:name="android.permission.ACCESS_COARSE_LOCATION" />
 </manifest>

package/android/src/main/java/com/airbnb/android/react/maps/AirMapLocalTile.java

@@ -20,11 +20,13 @@ public class AirMapLocalTile extends AirMapFeature {
         private static final int BUFFER_SIZE = 16 * 1024;
         private int tileSize;
         private String pathTemplate;
+        private boolean useAssets;
 
 
-        public AIRMapLocalTileProvider(int tileSizet, String pathTemplate) {
+        public AIRMapLocalTileProvider(int tileSizet, String pathTemplate, boolean useAssets) {
             this.tileSize = tileSizet;
             this.pathTemplate = pathTemplate;
+            this.useAssets = useAssets;
         }
 
         @Override
@@ -44,10 +46,10 @@ public class AirMapLocalTile extends AirMapFeature {
         private byte[] readTileImage(int x, int y, int zoom) {
             InputStream in = null;
             ByteArrayOutputStream buffer = null;
-            File file = new File(getTileFilename(x, y, zoom));
+            String tileFilename = getTileFilename(x, y, zoom);
 
             try {
-                in = new FileInputStream(file);
+                in = useAssets ? getContext().getAssets().open(tileFilename) : new FileInputStream(tileFilename);
                 buffer = new ByteArrayOutputStream();
 
                 int nRead;
@@ -87,6 +89,7 @@ public class AirMapLocalTile extends AirMapFeature {
     private String pathTemplate;
     private float tileSize;
     private float zIndex;
+    private boolean useAssets;
 
     public AirMapLocalTile(Context context) {
         super(context);
@@ -116,6 +119,10 @@ public class AirMapLocalTile extends AirMapFeature {
         }
     }
 
+    public void setUseAssets(boolean useAssets) {
+        this.useAssets = useAssets;
+    }
+
     public TileOverlayOptions getTileOverlayOptions() {
         if (tileOverlayOptions == null) {
             tileOverlayOptions = createTileOverlayOptions();
@@ -126,7 +133,7 @@ public class AirMapLocalTile extends AirMapFeature {
     private TileOverlayOptions createTileOverlayOptions() {
         TileOverlayOptions options = new TileOverlayOptions();
         options.zIndex(zIndex);
-        this.tileProvider = new AirMapLocalTile.AIRMapLocalTileProvider((int)this.tileSize, this.pathTemplate);
+        this.tileProvider = new AirMapLocalTile.AIRMapLocalTileProvider((int)this.tileSize, this.pathTemplate, this.useAssets);
         options.tileProvider(this.tileProvider);
         return options;
     }

package/android/src/main/java/com/airbnb/android/react/maps/AirMapLocalTileManager.java

@@ -53,4 +53,8 @@ public class AirMapLocalTileManager extends ViewGroupManager<AirMapLocalTile> {
         view.setZIndex(zIndex);
     }
 
-}
+    @ReactProp(name = "useAssets", defaultBoolean = false)
+    public void setUseAssets(AirMapLocalTile view, boolean useAssets) {
+        view.setUseAssets(useAssets);
+    }
+}

package/android/src/main/java/com/airbnb/android/react/maps/AirMapManager.java

@@ -314,17 +314,6 @@ public class AirMapManager extends ViewGroupManager<AirMapView> {
         view.animateToCamera(camera, duration);
         break;
 
-      case ANIMATE_TO_NAVIGATION:
-        region = args.getMap(0);
-        lng = region.getDouble("longitude");
-        lat = region.getDouble("latitude");
-        LatLng location = new LatLng(lat, lng);
-        bearing = (float)args.getDouble(1);
-        angle = (float)args.getDouble(2);
-        duration = args.getInt(3);
-        view.animateToNavigation(location, bearing, angle, duration);
-        break;
-
       case ANIMATE_TO_REGION:
         region = args.getMap(0);
         duration = args.getInt(1);
@@ -339,26 +328,6 @@ public class AirMapManager extends ViewGroupManager<AirMapView> {
         view.animateToRegion(bounds, duration);
         break;
 
-      case ANIMATE_TO_COORDINATE:
-        region = args.getMap(0);
-        duration = args.getInt(1);
-        lng = region.getDouble("longitude");
-        lat = region.getDouble("latitude");
-        view.animateToCoordinate(new LatLng(lat, lng), duration);
-        break;
-
-      case ANIMATE_TO_VIEWING_ANGLE:
-        angle = (float)args.getDouble(0);
-        duration = args.getInt(1);
-        view.animateToViewingAngle(angle, duration);
-        break;
-
-      case ANIMATE_TO_BEARING:
-        bearing = (float)args.getDouble(0);
-        duration = args.getInt(1);
-        view.animateToBearing(bearing, duration);
-        break;
-
       case FIT_TO_ELEMENTS:
         view.fitToElements(args.getMap(0), args.getBoolean(1));
         break;
@@ -421,13 +390,9 @@ public class AirMapManager extends ViewGroupManager<AirMapView> {
         "setCamera", SET_CAMERA,
         "animateCamera", ANIMATE_CAMERA,
         "animateToRegion", ANIMATE_TO_REGION,
-        "animateToCoordinate", ANIMATE_TO_COORDINATE,
-        "animateToViewingAngle", ANIMATE_TO_VIEWING_ANGLE,
-        "animateToBearing", ANIMATE_TO_BEARING,
         "fitToElements", FIT_TO_ELEMENTS,
         "fitToSuppliedMarkers", FIT_TO_SUPPLIED_MARKERS,
-        "fitToCoordinates", FIT_TO_COORDINATES,
-        "animateToNavigation", ANIMATE_TO_NAVIGATION
+        "fitToCoordinates", FIT_TO_COORDINATES
     );
 
     map.putAll(MapBuilder.of(
@@ -439,7 +404,7 @@ public class AirMapManager extends ViewGroupManager<AirMapView> {
   }
 
   public static <K, V> Map<K, V> CreateMap(
-  K k1, V v1, K k2, V v2, K k3, V v3, K k4, V v4, K k5, V v5, K k6, V v6, K k7, V v7, K k8, V v8, K k9, V v9, K k10, V v10) {
+  K k1, V v1, K k2, V v2, K k3, V v3, K k4, V v4, K k5, V v5, K k6, V v6) {
     Map map = new HashMap<K, V>();
     map.put(k1, v1);
     map.put(k2, v2);
@@ -447,10 +412,6 @@ public class AirMapManager extends ViewGroupManager<AirMapView> {
     map.put(k4, v4);
     map.put(k5, v5);
     map.put(k6, v6);
-    map.put(k7, v7);
-    map.put(k8, v8);
-    map.put(k9, v9);
-    map.put(k10, v10);
     return map;
   }
 

package/android/src/main/java/com/airbnb/android/react/maps/AirMapTileProvider.java

@@ -171,10 +171,10 @@ public class AirMapTileProvider implements TileProvider {
 		if (this.tileCachePath != null) {
 			image = readTileImage(x, y, zoom);
 			if (image != null) {
-				Log.d("urlTile: tile cache HIT for ", Integer.toString(zoom) + 
+				Log.d("urlTile", "tile cache HIT for " + Integer.toString(zoom) +
 					"/" + Integer.toString(x) + "/" + Integer.toString(y));
 			} else {
-				Log.d("urlTile: tile cache MISS for ", Integer.toString(zoom) + 
+				Log.d("urlTile", "tile cache MISS for " + Integer.toString(zoom) +
         	"/" + Integer.toString(x) + "/" + Integer.toString(y));
 			}
 			if (image != null && !this.offlineMode) {
@@ -212,10 +212,10 @@ public class AirMapTileProvider implements TileProvider {
 					if (this.tileCachePath != null) {
 						image = readTileImage(x, y, zoom);
 						if (image != null) {
-							Log.d("urlTile: tile cache fetch HIT for ", Integer.toString(zoom) + 
+							Log.d("urlTile","tile cache fetch HIT for " + Integer.toString(zoom) +
 								"/" + Integer.toString(x) + "/" + Integer.toString(y));
 						} else {
-								Log.d("urlTile: tile cache fetch MISS for ", Integer.toString(zoom) + 
+								Log.d("urlTile","tile cache fetch MISS for " + Integer.toString(zoom) +
 									"/" + Integer.toString(x) + "/" + Integer.toString(y));
 						}
 					}
@@ -229,7 +229,7 @@ public class AirMapTileProvider implements TileProvider {
 			Log.d("urlTile", "Normal fetch");
 			image = fetchTile(x, y, zoom);
 			if (image == null) {
-				Log.d("urlTile: tile fetch TIMEOUT / FAIL for ", Integer.toString(zoom) + 
+				Log.d("urlTile", "tile fetch TIMEOUT / FAIL for " + Integer.toString(zoom) +
 					"/" + Integer.toString(x) + "/" + Integer.toString(y));
 			}
 		}

package/android/src/main/java/com/airbnb/android/react/maps/AirMapView.java

@@ -291,7 +291,7 @@ public class AirMapView extends MapView implements GoogleMap.InfoWindowAdapter,
     map.setOnPolylineClickListener(new GoogleMap.OnPolylineClickListener() {
       @Override
       public void onPolylineClick(Polyline polyline) {
-        WritableMap event = makeClickEventData(polyline.getPoints().get(0));
+        WritableMap event = makeClickEventData(tapLocation);
         event.putString("action", "polyline-press");
         manager.pushEvent(context, polylineMap.get(polyline), "onPress", event);
       }
@@ -799,43 +799,11 @@ public class AirMapView extends MapView implements GoogleMap.InfoWindowAdapter,
     }
   }
 
-  public void animateToNavigation(LatLng location, float bearing, float angle, int duration) {
-    if (map == null) return;
-    CameraPosition cameraPosition = new CameraPosition.Builder(map.getCameraPosition())
-        .bearing(bearing)
-        .tilt(angle)
-        .target(location)
-        .build();
-    map.animateCamera(CameraUpdateFactory.newCameraPosition(cameraPosition), duration, null);
-  }
-
   public void animateToRegion(LatLngBounds bounds, int duration) {
     if (map == null) return;
     map.animateCamera(CameraUpdateFactory.newLatLngBounds(bounds, 0), duration, null);
   }
 
-  public void animateToViewingAngle(float angle, int duration) {
-    if (map == null) return;
-
-    CameraPosition cameraPosition = new CameraPosition.Builder(map.getCameraPosition())
-      .tilt(angle)
-      .build();
-    map.animateCamera(CameraUpdateFactory.newCameraPosition(cameraPosition), duration, null);
-  }
-
-  public void animateToBearing(float bearing, int duration) {
-    if (map == null) return;
-    CameraPosition cameraPosition = new CameraPosition.Builder(map.getCameraPosition())
-        .bearing(bearing)
-        .build();
-    map.animateCamera(CameraUpdateFactory.newCameraPosition(cameraPosition), duration, null);
-  }
-
-  public void animateToCoordinate(LatLng coordinate, int duration) {
-    if (map == null) return;
-    map.animateCamera(CameraUpdateFactory.newLatLng(coordinate), duration, null);
-  }
-
   public void fitToElements(ReadableMap edgePadding, boolean animated) {
     if (map == null) return;
 

package/ios/AirGoogleMaps/AIRGoogleMap.m

@@ -62,9 +62,10 @@ id regionAsJSON(MKCoordinateRegion region) {
   NSMutableArray<UIView *> *_reactSubviews;
   MKCoordinateRegion _initialRegion;
   MKCoordinateRegion _region;
-  BOOL _initialCameraSetOnLoad;
+  BOOL _initialRegionSet;
+  BOOL _initialCameraSet;
+  BOOL _didPrepareMap;
   BOOL _didCallOnMapReady;
-  BOOL _didMoveToWindow;
   BOOL _zoomTapEnabled;
 }
 
@@ -83,9 +84,10 @@ id regionAsJSON(MKCoordinateRegion region) {
     _cameraProp = nil;
     _initialRegion = MKCoordinateRegionMake(CLLocationCoordinate2DMake(0.0, 0.0), MKCoordinateSpanMake(0.0, 0.0));
     _region = MKCoordinateRegionMake(CLLocationCoordinate2DMake(0.0, 0.0), MKCoordinateSpanMake(0.0, 0.0));
-    _initialCameraSetOnLoad = false;
+    _initialRegionSet = false;
+    _initialCameraSet = false;
+    _didPrepareMap = false;
     _didCallOnMapReady = false;
-    _didMoveToWindow = false;
     _zoomTapEnabled = YES;
 
     // Listen to the myLocation property of GMSMapView.
@@ -245,36 +247,20 @@ id regionAsJSON(MKCoordinateRegion region) {
     ];
 }
 
-- (void)didMoveToWindow {
-  if (_didMoveToWindow) return;
-  _didMoveToWindow = true;
-
-  if (_initialCamera != nil) {
-    self.camera = _initialCamera;
-  }
-  else if (_initialRegion.span.latitudeDelta != 0.0 &&
-      _initialRegion.span.longitudeDelta != 0.0) {
-    self.camera = [AIRGoogleMap makeGMSCameraPositionFromMap:self andMKCoordinateRegion:_initialRegion];
-  } else if (_region.span.latitudeDelta != 0.0 &&
-      _region.span.longitudeDelta != 0.0) {
-    self.camera = [AIRGoogleMap makeGMSCameraPositionFromMap:self andMKCoordinateRegion:_region];
-  }
-
-  [super didMoveToWindow];
-}
-
 - (void)setInitialRegion:(MKCoordinateRegion)initialRegion {
-  if (_initialCameraSetOnLoad) return;
   _initialRegion = initialRegion;
-  _initialCameraSetOnLoad = _didMoveToWindow;
-  self.camera = [AIRGoogleMap makeGMSCameraPositionFromMap:self andMKCoordinateRegion:initialRegion];
+  if(!_initialRegionSet && _didPrepareMap){
+    self.camera = [AIRGoogleMap makeGMSCameraPositionFromMap:self andMKCoordinateRegion:initialRegion];
+    _initialRegionSet = true;
+  }
 }
 
 - (void)setInitialCamera:(GMSCameraPosition*)initialCamera {
-    if (_initialCameraSetOnLoad) return;
     _initialCamera = initialCamera;
-    _initialCameraSetOnLoad = _didMoveToWindow;
-    self.camera = initialCamera;
+    if(!_initialCameraSet && _didPrepareMap){
+      self.camera = initialCamera;
+      _initialCameraSet = true;
+    }
 }
 
 - (void)setRegion:(MKCoordinateRegion)region {
@@ -288,14 +274,34 @@ id regionAsJSON(MKCoordinateRegion region) {
     self.camera = camera;
 }
 
+- (void)setOnMapReady:(RCTBubblingEventBlock)onMapReady {
+    _onMapReady = onMapReady;
+    if(!_didCallOnMapReady && _didPrepareMap) {
+      self.onMapReady(@{});
+      _didCallOnMapReady = true;
+    }
+}
 
 - (void)didPrepareMap {
   UIView* mapView = [self valueForKey:@"mapView"]; //GMSVectorMapView
   [self overrideGestureRecognizersForView:mapView];
 
-  if (_didCallOnMapReady) return;
-  _didCallOnMapReady = true;
-  if (self.onMapReady) self.onMapReady(@{});
+  if(!_didPrepareMap && !_initialRegionSet && !_initialCameraSet){
+    if(_initialRegion.span.latitudeDelta != 0.0 && _initialRegion.span.longitudeDelta != 0.0){
+    self.camera = [AIRGoogleMap makeGMSCameraPositionFromMap:self andMKCoordinateRegion:_initialRegion];
+    _initialRegionSet = true;
+  } else if(_initialCamera != nil) {
+    self.camera = _initialCamera;
+    _initialCameraSet = true;
+  } else if(_region.span.latitudeDelta != 0.0 && _region.span.longitudeDelta != 0.0) {
+    self.camera = [AIRGoogleMap makeGMSCameraPositionFromMap:self andMKCoordinateRegion:_region];
+  }
+  }
+  if (!_didCallOnMapReady && self.onMapReady) {
+    self.onMapReady(@{});
+    _didCallOnMapReady = true;
+  }
+  _didPrepareMap = true;
 }
 
 - (void)mapViewDidFinishTileRendering {

package/ios/AirGoogleMaps/AIRGoogleMapManager.m

@@ -163,29 +163,6 @@ RCT_EXPORT_METHOD(animateCamera:(nonnull NSNumber *)reactTag
     }];
 }
 
-RCT_EXPORT_METHOD(animateToNavigation:(nonnull NSNumber *)reactTag
-                  withRegion:(MKCoordinateRegion)region
-                  withBearing:(CGFloat)bearing
-                  withAngle:(double)angle
-                  withDuration:(CGFloat)duration)
-{
-  [self.bridge.uiManager addUIBlock:^(__unused RCTUIManager *uiManager, NSDictionary<NSNumber *, UIView *> *viewRegistry) {
-    id view = viewRegistry[reactTag];
-    if (![view isKindOfClass:[AIRGoogleMap class]]) {
-      RCTLogError(@"Invalid view returned from registry, expecting AIRGoogleMap, got: %@", view);
-    } else {
-      [CATransaction begin];
-      [CATransaction setAnimationDuration:duration/1000];
-      AIRGoogleMap *mapView = (AIRGoogleMap *)view;
-      GMSCameraPosition *camera = [AIRGoogleMap makeGMSCameraPositionFromMap:mapView andMKCoordinateRegion:region];
-      [mapView animateToCameraPosition:camera];
-      [mapView animateToViewingAngle:angle];
-      [mapView animateToBearing:bearing];
-      [CATransaction commit];
-    }
-  }];
-}
-
 RCT_EXPORT_METHOD(animateToRegion:(nonnull NSNumber *)reactTag
                   withRegion:(MKCoordinateRegion)region
                   withDuration:(CGFloat)duration)
@@ -207,59 +184,6 @@ RCT_EXPORT_METHOD(animateToRegion:(nonnull NSNumber *)reactTag
   }];
 }
 
-RCT_EXPORT_METHOD(animateToCoordinate:(nonnull NSNumber *)reactTag
-                  withRegion:(CLLocationCoordinate2D)latlng
-                  withDuration:(CGFloat)duration)
-{
-  [self.bridge.uiManager addUIBlock:^(__unused RCTUIManager *uiManager, NSDictionary<NSNumber *, UIView *> *viewRegistry) {
-    id view = viewRegistry[reactTag];
-    if (![view isKindOfClass:[AIRGoogleMap class]]) {
-      RCTLogError(@"Invalid view returned from registry, expecting AIRGoogleMap, got: %@", view);
-    } else {
-      [CATransaction begin];
-      [CATransaction setAnimationDuration:duration/1000];
-      [(AIRGoogleMap *)view animateToLocation:latlng];
-      [CATransaction commit];
-    }
-  }];
-}
-
-RCT_EXPORT_METHOD(animateToViewingAngle:(nonnull NSNumber *)reactTag
-                  withAngle:(double)angle
-                  withDuration:(CGFloat)duration)
-{
-  [self.bridge.uiManager addUIBlock:^(__unused RCTUIManager *uiManager, NSDictionary<NSNumber *, UIView *> *viewRegistry) {
-    id view = viewRegistry[reactTag];
-    if (![view isKindOfClass:[AIRGoogleMap class]]) {
-      RCTLogError(@"Invalid view returned from registry, expecting AIRGoogleMap, got: %@", view);
-    } else {
-      [CATransaction begin];
-      [CATransaction setAnimationDuration:duration/1000];
-      AIRGoogleMap *mapView = (AIRGoogleMap *)view;
-      [mapView animateToViewingAngle:angle];
-      [CATransaction commit];
-    }
-  }];
-}
-
-RCT_EXPORT_METHOD(animateToBearing:(nonnull NSNumber *)reactTag
-                  withBearing:(CGFloat)bearing
-                  withDuration:(CGFloat)duration)
-{
-  [self.bridge.uiManager addUIBlock:^(__unused RCTUIManager *uiManager, NSDictionary<NSNumber *, UIView *> *viewRegistry) {
-    id view = viewRegistry[reactTag];
-    if (![view isKindOfClass:[AIRGoogleMap class]]) {
-      RCTLogError(@"Invalid view returned from registry, expecting AIRGoogleMap, got: %@", view);
-    } else {
-      [CATransaction begin];
-      [CATransaction setAnimationDuration:duration/1000];
-      AIRGoogleMap *mapView = (AIRGoogleMap *)view;
-      [mapView animateToBearing:bearing];
-      [CATransaction commit];
-    }
-  }];
-}
-
 RCT_EXPORT_METHOD(fitToElements:(nonnull NSNumber *)reactTag
                   edgePadding:(nonnull NSDictionary *)edgePadding
                   animated:(BOOL)animated)
@@ -418,25 +342,6 @@ RCT_EXPORT_METHOD(takeSnapshot:(nonnull NSNumber *)reactTag
         else if ([result isEqualToString:@"base64"]) {
             callback(@[[NSNull null], [data base64EncodedStringWithOptions:NSDataBase64EncodingEndLineWithCarriageReturn]]);
         }
-        else if ([result isEqualToString:@"legacy"]) {
-
-            // In the initial (iOS only) implementation of takeSnapshot,
-            // both the uri and the base64 encoded string were returned.
-            // Returning both is rarely useful and in fact causes a
-            // performance penalty when only the file URI is desired.
-            // In that case the base64 encoded string was always marshalled
-            // over the JS-bridge (which is quite slow).
-            // A new more flexible API was created to cover this.
-            // This code should be removed in a future release when the
-            // old API is fully deprecated.
-            [data writeToFile:filePath atomically:YES];
-            NSDictionary *snapshotData = @{
-                                           @"uri": filePath,
-                                           @"data": [data base64EncodedStringWithOptions:NSDataBase64EncodingEndLineWithCarriageReturn]
-                                           };
-            callback(@[[NSNull null], snapshotData]);
-        }
-
     }
     UIGraphicsEndImageContext();
   }];

package/ios/AirMaps/AIRMap.h

@@ -40,7 +40,6 @@ extern const NSInteger AIRMapMaxZoomLevel;
 @property (nonatomic, assign) CGFloat minDelta;
 @property (nonatomic, assign) CGFloat maxDelta;
 @property (nonatomic, assign) UIEdgeInsets legalLabelInsets;
-@property (nonatomic, strong) NSTimer *regionChangeObserveTimer;
 @property (nonatomic, assign) MKCoordinateRegion initialRegion;
 @property (nonatomic, assign) MKMapCamera *initialCamera;
 @property (nonatomic, assign) CGFloat minZoomLevel;

package/ios/AirMaps/AIRMap.m

@@ -48,7 +48,6 @@ const NSInteger AIRMapMaxZoomLevel = 20;
 @implementation AIRMap
 {
     UIView *_legalLabel;
-    CLLocationManager *_locationManager;
     BOOL _initialRegionSet;
     BOOL _initialCameraSet;
 
@@ -92,11 +91,6 @@ const NSInteger AIRMapMaxZoomLevel = 20;
     return self;
 }
 
-- (void)dealloc
-{
-    [_regionChangeObserveTimer invalidate];
-}
-
 -(void)addSubview:(UIView *)view {
     if([view isKindOfClass:[AIRMapMarker class]]) {
         [self addAnnotation:(id <MKAnnotation>)view];
@@ -350,12 +344,6 @@ const NSInteger AIRMapMaxZoomLevel = 20;
 - (void)setShowsUserLocation:(BOOL)showsUserLocation
 {
     if (self.showsUserLocation != showsUserLocation) {
-        if (showsUserLocation && !_locationManager) {
-            _locationManager = [CLLocationManager new];
-            if ([_locationManager respondsToSelector:@selector(requestWhenInUseAuthorization)]) {
-                [_locationManager requestWhenInUseAuthorization];
-            }
-        }
         super.showsUserLocation = showsUserLocation;
     }
 }