react-native-map-link 2.8.0 → 2.8.1

package/README.md

@@ -224,9 +224,9 @@ showLocation({
     dialogMessage: 'This is the amazing dialog Message', // optional (default: 'What app would you like to use?')
     cancelText: 'This is the cancel button text', // optional (default: 'Cancel')
     appsWhiteList: ['google-maps'], // optionally you can set which apps to show (default: will show all supported apps installed on device)
-    naverCallerName: 'com.example.myapp' // to link into Naver Map You should provide your appname which is the bundle ID in iOS and applicationId in android.
-    // appTitles: { 'google-maps': 'My custom Google Maps title' } // optionally you can override default app titles
-    // app: 'uber'  // optionally specify specific app to use
+    naverCallerName: 'com.example.myapp', // to link into Naver Map You should provide your appname which is the bundle ID in iOS and applicationId in android.
+    // appTitles: { 'google-maps': 'My custom Google Maps title' }, // optionally you can override default app titles
+    // app: 'uber',  // optionally specify specific app to use
     directionsMode: 'walk' // optional, accepted values are 'car', 'walk', 'public-transport' or 'bike'
 })
 ```
@@ -234,7 +234,7 @@ showLocation({
 Notes:
 
 - The `sourceLatitude/sourceLongitude` options only work if you specify both. Currently supports all apps except Waze.
-- Works on google-maps and apple-maps (on the latter, `bike` mode will not work). Without setting `directionsMode`, the app will decide based on his own settings.
+- `directionsMode` works on google-maps and apple-maps (on the latter, `bike` mode will not work). Without setting it, the app will decide based on his own settings.
 
 ## More information
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "react-native-map-link",
-  "version": "2.8.0",
+  "version": "2.8.1",
   "description": "Open the map app of the user's choice with a specific location",
   "main": "index.js",
   "repository": {

package/src/index.js

@@ -17,7 +17,7 @@ import {askAppChoice, checkOptions} from './utils';
  *     sourceLongitude: number | undefined | null,
  *     alwaysIncludeGoogle: boolean | undefined | null,
  *     googleForceLatLon: boolean | undefined | null,
- *     googlePlaceId: number | undefined | null,
+ *     googlePlaceId: number | string | undefined | null,
  *     title: string | undefined | null,
  *     app: string | undefined | null
  *     dialogTitle: string | undefined | null
@@ -129,21 +129,35 @@ export async function showLocation(options) {
     case 'google-maps':
       const googleDirectionMode = getDirectionsModeGoogleMaps();
       // Always using universal URL instead of URI scheme since the latter doesn't support all parameters (#155)
-      url = 'https://www.google.com/maps/dir/?api=1';
-      if (useSourceDestiny) {
+      if (useSourceDestiny || options.directionsMode) {
+        // Use "dir" as this will open up directions
+        url = 'https://www.google.com/maps/dir/?api=1';
         url += `&origin=${sourceLatLng}`;
-      }
-      if (!options.googleForceLatLon && title) {
-        url += `&destination=${encodedTitle}`;
-      } else {
-        url += `&destination=${latlng}`;
-      }
+        if (!options.googleForceLatLon && title) {
+          url += `&destination=${encodedTitle}`;
+        } else {
+          url += `&destination=${latlng}`;
+        }
 
-      url += options.googlePlaceId
-        ? `&destination_place_id=${options.googlePlaceId}`
-        : '';
+        url += options.googlePlaceId
+          ? `&destination_place_id=${options.googlePlaceId}`
+          : '';
 
-      url += googleDirectionMode ? `&travelmode=${googleDirectionMode}` : '';
+        url += googleDirectionMode ? `&travelmode=${googleDirectionMode}` : '';
+      } else {
+        // Use "search" as this will open up a single marker
+        url = 'https://www.google.com/maps/search/?api=1';
+
+        if (!options.googleForceLatLon && title) {
+          url += `&query=${encodedTitle}`;
+        } else {
+          url += `&query=${latlng}`;
+        }
+
+        url += options.googlePlaceId
+          ? `&query_place_id=${options.googlePlaceId}`
+          : '';
+      }
       break;
     case 'citymapper':
       url = `${prefixes.citymapper}directions?endcoord=${latlng}`;