react-native-kookit 0.3.3 → 0.3.5

package/android/src/main/java/expo/modules/kookit/JcifsShareEnumerator.kt

@@ -42,9 +42,8 @@ class JcifsShareEnumerator {
             } ?: emptyList()
             
         } catch (e: Exception) {
-            // If JCIFS enumeration fails, return empty list
-            // The caller can fall back to other methods
-            emptyList()
+            // If JCIFS enumeration fails, throw exception
+            throw Exception("Failed to enumerate shares using JCIFS: " + e.message)
         }
     }
     

package/android/src/main/java/expo/modules/kookit/SmbClient.kt

@@ -83,54 +83,33 @@ class SmbClient {
   fun listShares(): List<String> {
     val s = session ?: throw IOException("Not authenticated")
     
-    // First try JCIFS for more complete share enumeration
-    if (lastHost != null && lastUsername != null && lastPassword != null) {
-      try {
-        val shares = jcifsEnumerator.listShares(
-          lastHost!!,
-          lastUsername!!,
-          lastPassword!!,
-          lastDomain ?: ""
-        )
-        if (shares.isNotEmpty()) {
-          return shares
-        }
-      } catch (e: Exception) {
-        // JCIFS failed, fall back to SMBJ testing approach
-      }
+    // Check if we have the necessary credentials
+    if (lastHost == null || lastUsername == null || lastPassword == null) {
+      throw IOException("Missing host or credentials for share enumeration")
     }
     
-    return try {
-      // Fallback: SMBJ testing approach
-      val availableShares = mutableListOf<String>()
-      
-      // Common Windows shares
-      val windowsShares = listOf("C$", "D$", "E$", "ADMIN$", "IPC$")
-      // Common user-defined shares  
-      val commonShares = listOf("shared", "public", "data", "home", "Users", "files", "documents", "media")
-      
-      val allTestShares = windowsShares + commonShares
+    // Use JCIFS for share enumeration, no fallback to other methods
+    try {
+      val shares = jcifsEnumerator.listShares(
+        lastHost!!,
+        lastUsername!!,
+        lastPassword!!,
+        lastDomain ?: ""
+      )
       
-      for (shareName in allTestShares) {
-        try {
-          // Try to connect briefly to test if share exists
-          val testShare = s.connectShare(shareName)
-          testShare.close()
-          availableShares.add(shareName)
-        } catch (e: Exception) {
-          // Share doesn't exist, access denied, or other error - ignore
-        }
+      // If shares list is empty, throw an error
+      if (shares.isEmpty()) {
+        throw IOException("No shares found on server")
       }
       
-      // If no shares found, suggest some common ones
-      if (availableShares.isEmpty()) {
-        listOf("C$", "shared", "public")
+      return shares
+    } catch (e: Exception) {
+      // Directly propagate the error without fallback
+      if (e is IOException) {
+        throw e
       } else {
-        availableShares
+        throw IOException("Failed to enumerate shares: " + e.message, e)
       }
-    } catch (e: Exception) {
-      // Final fallback to common share names if all enumeration methods fail
-      listOf("C$", "shared", "public", "data")
     }
   }
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "react-native-kookit",
-  "version": "0.3.3",
+  "version": "0.3.5",
   "description": "React Native module for intercepting volume button presses on iOS and Android, with FTP client functionality",
   "main": "build/index.js",
   "types": "build/index.d.ts",