react-native-image-stitcher 0.15.2 → 0.16.1

package/src/camera/__tests__/PanoramaSettingsBridge.test.ts

@@ -1,190 +0,0 @@
-// SPDX-License-Identifier: Apache-2.0
-/**
- * Unit tests for the JS→native settings bridge.
- *
- * Scope: every adapter (panoramaSettingsToNativeConfig,
- * slitscanSettingsToNativeConfig, hybridSettingsToNativeConfig)
- * round-trip from a hierarchical typed input to the flat wire dict
- * the native side reads.  Asserts both:
- *
- *   1. Naming — JS key `registration.ncc1d.searchRadius` becomes
- *      native key `nccSearchRadius1d` (and similar mappings).  Each
- *      DEFAULT_* snapshot's expected wire dict is enumerated below;
- *      drift in either direction (lib drops a key, or adds a phantom
- *      one) is caught here.
- *
- *   2. Presence-as-enable — undefined optional sub-objects in the
- *      typed shape (`registration.ncc1d`, `registration.ncc2d`,
- *      `registration.ncc2d.emaSmoothing`, `registration.ncc2d.panAxisLock`,
- *      `frameSelection.flow`, `advanced`) translate to explicit
- *      `enable*: false` (or the absence of all the sub-object's
- *      payload keys) on the wire.  Many of these have been silent
- *      drift hazards historically — the old flat type required the
- *      consumer to set BOTH `enable1dNcc: true` AND `nccSearchRadius1d:
- *      <value>`; v0.4 makes them inseparable by collapsing into a
- *      single optional sub-object, and this file is what guarantees
- *      the wire side still gets both halves.
- *
- *   3. Engine-discriminated coverage — plane source variants
- *      ('Disabled' / 'ARKitDetected' / 'Virtual') gate which optional
- *      plane fields are emitted; the bridge filters those at the
- *      adapter boundary so the modal's per-source rendering doesn't
- *      get mislead by stale-but-present keys from a previous source
- *      selection.
- *
- * These tests are pure-TS; no React Native module import.  Jest config
- * (`jest.config.js`) routes test files in `__tests__/` through ts-jest
- * with the `node` testEnvironment.
- */
-
-import {
-  DEFAULT_FLOW_GATE_SETTINGS,
-  DEFAULT_PANORAMA_SETTINGS,
-  type PanoramaSettings,
-} from '../PanoramaSettings';
-import {
-  panoramaSettingsToNativeConfig,
-} from '../PanoramaSettingsBridge';
-
-
-// ════════════════════════════════════════════════════════════════════
-// PANORAMA — batch-keyframe engine
-// ════════════════════════════════════════════════════════════════════
-
-describe('panoramaSettingsToNativeConfig', () => {
-  it('round-trips DEFAULT_PANORAMA_SETTINGS to the expected flat dict', () => {
-    const cfg = panoramaSettingsToNativeConfig(DEFAULT_PANORAMA_SETTINGS);
-
-    // Cross-cutting
-    expect(cfg.captureSource).toBe('ar');
-
-    // BatchStitcherSettings
-    expect(cfg.stitchMode).toBe('auto');
-    expect(cfg.warperType).toBe('plane');
-    expect(cfg.blenderType).toBe('multiband');
-    expect(cfg.seamFinderType).toBe('graphcut');
-    expect(cfg.enableMaxInscribedRectCrop).toBe(false);
-
-    // FrameSelectionSettings
-    expect(cfg.frameSelectionMode).toBe('flow-based');
-    expect(cfg.keyframeMaxCount).toBe(6);
-    expect(cfg.keyframeOverlapThreshold).toBe(0.2);
-    expect(cfg.maxKeyframeIntervalMs).toBe(2000);
-
-    // FlowGateSettings (flow is defined in the default)
-    expect(cfg.flowNoveltyPercentile).toBe(0.85);
-    expect(cfg.flowEvalEveryNFrames).toBe(5);
-    expect(cfg.flowMaxTranslationCm).toBe(50);
-    expect(cfg.flowMaxCorners).toBe(150);
-    expect(cfg.flowQualityLevel).toBe(0.01);
-    expect(cfg.flowMinDistance).toBe(10);
-  });
-
-  it('falls back to DEFAULT_FLOW_GATE_SETTINGS when frameSelection.flow is undefined', () => {
-    // F10 Phase 2 review B1 — native compiled-in defaults disagree
-    // with the JS defaults for two flow knobs (maxTranslationCm and
-    // evalEveryNFrames).  The bridge must always emit every flow key
-    // so sparse-literal hosts get the JS defaults on the wire, not
-    // the native fallbacks.
-    const noFlow: PanoramaSettings = {
-      ...DEFAULT_PANORAMA_SETTINGS,
-      frameSelection: {
-        ...DEFAULT_PANORAMA_SETTINGS.frameSelection,
-        flow: undefined,
-      },
-    };
-    const cfg = panoramaSettingsToNativeConfig(noFlow);
-
-    expect(cfg.frameSelectionMode).toBe('flow-based');
-    expect(cfg.keyframeMaxCount).toBe(6);
-    expect(cfg.keyframeOverlapThreshold).toBe(0.2);
-
-    // Every flow.* native key present, matching DEFAULT_FLOW_GATE_SETTINGS.
-    expect(cfg.flowNoveltyPercentile).toBe(DEFAULT_FLOW_GATE_SETTINGS.noveltyPercentile);
-    expect(cfg.flowEvalEveryNFrames).toBe(DEFAULT_FLOW_GATE_SETTINGS.evalEveryNFrames);
-    expect(cfg.flowMaxTranslationCm).toBe(DEFAULT_FLOW_GATE_SETTINGS.maxTranslationCm);
-    expect(cfg.flowMaxCorners).toBe(DEFAULT_FLOW_GATE_SETTINGS.maxCorners);
-    expect(cfg.flowQualityLevel).toBe(DEFAULT_FLOW_GATE_SETTINGS.qualityLevel);
-    expect(cfg.flowMinDistance).toBe(DEFAULT_FLOW_GATE_SETTINGS.minDistance);
-  });
-
-  it('emits flow defaults to the wire when frameSelection.flow is undefined AND mode is flow-based', () => {
-    // F10 Phase 2 review N3 — the realistic user-facing case:
-    // host writes `mode: 'flow-based'` but omits the flow sub-tree.
-    // Pre-B1-fix, the gate would silently run with native fallbacks
-    // (flowMaxTranslationCm=0, flowEvalEveryNFrames=1) instead of
-    // the JS defaults (50 cm budget, 5× throttle).
-    const s: PanoramaSettings = {
-      ...DEFAULT_PANORAMA_SETTINGS,
-      frameSelection: {
-        mode: 'flow-based',
-        maxKeyframes: 6,
-        overlapThreshold: 0.20,
-        maxKeyframeIntervalMs: 2000,
-        // flow omitted — legal per the optional `?` in the type
-      },
-    };
-    const cfg = panoramaSettingsToNativeConfig(s);
-
-    expect(cfg.flowMaxTranslationCm).toBe(50);
-    expect(cfg.flowEvalEveryNFrames).toBe(5);
-    expect(cfg.flowNoveltyPercentile).toBe(0.85);
-    expect(cfg.flowMaxCorners).toBe(150);
-    expect(cfg.flowQualityLevel).toBe(0.01);
-    expect(cfg.flowMinDistance).toBe(10);
-  });
-
-  it('locks down the full wire-key set for DEFAULT_PANORAMA_SETTINGS', () => {
-    // F10 Phase 2 review N4 — mirror the hybrid test below.  Lock
-    // down which keys leave the bridge so a future field accidentally
-    // riding along (e.g. `debug` being treated as a wire knob) fails
-    // this test immediately.
-    const cfg = panoramaSettingsToNativeConfig(DEFAULT_PANORAMA_SETTINGS);
-    expect(Object.keys(cfg).sort()).toEqual([
-      'blenderType',
-      'captureSource',
-      'enableMaxInscribedRectCrop',
-      'flowEvalEveryNFrames',
-      'flowMaxCorners',
-      'flowMaxTranslationCm',
-      'flowMinDistance',
-      'flowNoveltyPercentile',
-      'flowQualityLevel',
-      'frameSelectionMode',
-      'keyframeMaxCount',
-      'keyframeOverlapThreshold',
-      'maxKeyframeIntervalMs',
-      'seamFinderType',
-      'stitchMode',
-      'warperType',
-    ]);
-  });
-
-  it('honours captureSource and stitcher overrides', () => {
-    const overridden: PanoramaSettings = {
-      ...DEFAULT_PANORAMA_SETTINGS,
-      captureSource: 'non-ar',
-      debug: true,
-      stitcher: {
-        stitchMode: 'scans',
-        warperType: 'spherical',
-        blenderType: 'feather',
-        seamFinderType: 'skip',
-        enableMaxInscribedRectCrop: true,
-      },
-    };
-    const cfg = panoramaSettingsToNativeConfig(overridden);
-
-    expect(cfg.captureSource).toBe('non-ar');
-    expect(cfg.stitchMode).toBe('scans');
-    expect(cfg.warperType).toBe('spherical');
-    expect(cfg.blenderType).toBe('feather');
-    expect(cfg.seamFinderType).toBe('skip');
-    expect(cfg.enableMaxInscribedRectCrop).toBe(true);
-    // Note: `debug` is intentionally NOT on the wire — it's a
-    // JS-side UI gate, not a native config knob.  The bridge MUST
-    // omit it; if a future change starts emitting it, the modal's
-    // operator-facing semantics will silently drift.
-    expect(cfg).not.toHaveProperty('debug');
-  });
-});

package/src/camera/__tests__/bandThumbRotation.test.ts

@@ -1,120 +0,0 @@
-// SPDX-License-Identifier: Apache-2.0
-/**
- * Unit tests for the band/tile orientation-decision functions in
- * `PanoramaBandOverlay` — the pure logic behind the v0.13.1 EXIF
- * double-rotation fix.
- *
- * Why test the pure functions, not a render: the lib's jest config is
- * pure-TS (`ts-jest` + node env, no `@testing-library/react-native`;
- * see jest.config.js header).  The orientation contract lives entirely
- * in `bandThumbRotation` / `tileRotation`, which the component now calls
- * directly — so exercising them here covers the real code path.
- *
- * The bug these guard against:
- *   Saved `keyframe-N.jpg` files are sensor-native LANDSCAPE pixels with
- *   EXIF Orientation = 6 ("rotate 90° CW").  RN's <Image> auto-rotates
- *   them upright.  v0.12 ALSO applied a JS rotate transform to the tiles
- *   → double-rotation → thumbnails 90° off in portrait-locked landscape.
- *   The fix: tiles get NO transform in the portrait-locked
- *   (vertical=false) path; the single cumulative thumb (no EXIF) still
- *   does.
- */
-
-// Mock react-native so importing the SUT module doesn't pull the native
-// StyleSheet/Image bridge (we only call the pure functions).  Matches
-// the mocking approach in useOrientationDrift.test.ts.
-jest.mock('react-native', () => ({
-  Image: 'Image',
-  ScrollView: 'ScrollView',
-  StyleSheet: { create: (s: Record<string, unknown>) => s, absoluteFill: {} },
-  Text: 'Text',
-  View: 'View',
-}));
-
-import {
-  _bandThumbRotationForTests as bandThumbRotation,
-  _tileRotationForTests as tileRotation,
-  type BandCaptureOrientation,
-} from '../PanoramaBandOverlay';
-
-const PORTRAIT: BandCaptureOrientation = 'portrait';
-const UPSIDE: BandCaptureOrientation = 'portrait-upside-down';
-const LEFT: BandCaptureOrientation = 'landscape-left';
-const RIGHT: BandCaptureOrientation = 'landscape-right';
-
-describe('bandThumbRotation — single cumulative thumb (no EXIF source)', () => {
-  describe('vertical=false (portrait-locked UI)', () => {
-    it('does not rotate in portrait', () => {
-      expect(bandThumbRotation(PORTRAIT, false)).toBeUndefined();
-    });
-
-    it('does not rotate in portrait-upside-down', () => {
-      expect(bandThumbRotation(UPSIDE, false)).toBeUndefined();
-    });
-
-    it('rotates 90° CW for landscape-left', () => {
-      expect(bandThumbRotation(LEFT, false)).toEqual([{ rotate: '90deg' }]);
-    });
-
-    it('rotates 90° CCW for landscape-right (opposite sign of left)', () => {
-      expect(bandThumbRotation(RIGHT, false)).toEqual([{ rotate: '-90deg' }]);
-    });
-  });
-
-  describe('vertical=true (non-locked, OS-rotated framebuffer)', () => {
-    it('does not rotate in portrait', () => {
-      expect(bandThumbRotation(PORTRAIT, true)).toBeUndefined();
-    });
-
-    it('uses the OPPOSITE sign from the portrait-locked case (left)', () => {
-      // vertical=false → 90deg, so vertical=true → -90deg.
-      expect(bandThumbRotation(LEFT, true)).toEqual([{ rotate: '-90deg' }]);
-      expect(bandThumbRotation(LEFT, true)).not.toEqual(
-        bandThumbRotation(LEFT, false),
-      );
-    });
-
-    it('uses the OPPOSITE sign from the portrait-locked case (right)', () => {
-      expect(bandThumbRotation(RIGHT, true)).toEqual([{ rotate: '90deg' }]);
-      expect(bandThumbRotation(RIGHT, true)).not.toEqual(
-        bandThumbRotation(RIGHT, false),
-      );
-    });
-  });
-});
-
-describe('tileRotation — per-keyframe tiles (EXIF-6 source, the fix)', () => {
-  describe('vertical=false (portrait-locked) — the regression case', () => {
-    it.each<[BandCaptureOrientation]>([
-      [PORTRAIT],
-      [UPSIDE],
-      [LEFT],
-      [RIGHT],
-    ])(
-      'applies NO transform for %s (EXIF already auto-rotates → no double-rotate)',
-      (orientation) => {
-        expect(tileRotation(orientation, false)).toBeUndefined();
-      },
-    );
-
-    it('specifically does NOT rotate landscape tiles (the v0.12 bug)', () => {
-      // Pre-fix this returned [{rotate:'90deg'}] / [{rotate:'-90deg'}]
-      // on top of the EXIF auto-rotate → tiles 90° off.  Must be undefined.
-      expect(tileRotation(LEFT, false)).toBeUndefined();
-      expect(tileRotation(RIGHT, false)).toBeUndefined();
-    });
-  });
-
-  describe('vertical=true (non-locked landscape) — transform still needed', () => {
-    it('matches bandThumbRotation in the vertical path', () => {
-      // In the OS-rotated case the box is landscape JS coords, 90° off
-      // the EXIF-upright tile, so the compensation IS required.
-      expect(tileRotation(LEFT, true)).toEqual(bandThumbRotation(LEFT, true));
-      expect(tileRotation(RIGHT, true)).toEqual(bandThumbRotation(RIGHT, true));
-    });
-
-    it('does not rotate in portrait even when vertical', () => {
-      expect(tileRotation(PORTRAIT, true)).toBeUndefined();
-    });
-  });
-});

package/src/camera/__tests__/buildPanoramaInitialSettings.test.ts

@@ -1,160 +0,0 @@
-// SPDX-License-Identifier: Apache-2.0
-/**
- * Unit tests for buildPanoramaInitialSettings — the prop→settings-tree
- * translation that runs once at <Camera>'s mount.
- *
- * Coverage:
- *
- *   - Defaults (no prop overrides) reproduce DEFAULT_PANORAMA_SETTINGS
- *     when `isLowMemDevice=false`.
- *   - `isLowMemDevice=true` swaps blender + seamFinder defaults to the
- *     feather+skip fallback; other fields unchanged.
- *   - Every prop override routes to its hierarchical path: stitchMode →
- *     stitcher.stitchMode, defaultFlowMaxTranslationCm →
- *     frameSelection.flow.maxTranslationCm, etc.
- *   - Partial overrides leave non-overridden fields at the default.
- *
- * Plus a "wire-format integration" check: the produced settings tree,
- * fed through `panoramaSettingsToNativeConfig`, lands at the expected
- * flat dict.  This is the seam where the prop translation, the
- * hierarchical tree, and the bridge all meet — verifying it here means
- * <Camera>'s `incremental.start({ config })` call is correctly wired
- * end-to-end on the JS side (on-device run remains the integration
- * check across the JS/native boundary itself).
- */
-
-import {
-  DEFAULT_PANORAMA_SETTINGS,
-  type PanoramaSettings,
-} from '../PanoramaSettings';
-import { panoramaSettingsToNativeConfig } from '../PanoramaSettingsBridge';
-import { buildPanoramaInitialSettings } from '../buildPanoramaInitialSettings';
-
-
-describe('buildPanoramaInitialSettings', () => {
-  it('returns DEFAULT_PANORAMA_SETTINGS verbatim when no overrides and not low-mem', () => {
-    const s = buildPanoramaInitialSettings({}, false);
-    expect(s).toEqual(DEFAULT_PANORAMA_SETTINGS);
-  });
-
-  it('swaps blender + seamFinder for the low-mem fallback', () => {
-    const s = buildPanoramaInitialSettings({}, true);
-    expect(s.stitcher.blenderType).toBe('feather');
-    expect(s.stitcher.seamFinderType).toBe('skip');
-    // Everything else stays at the static default.
-    expect(s.stitcher.stitchMode).toBe(DEFAULT_PANORAMA_SETTINGS.stitcher.stitchMode);
-    expect(s.stitcher.warperType).toBe(DEFAULT_PANORAMA_SETTINGS.stitcher.warperType);
-    expect(s.frameSelection).toEqual(DEFAULT_PANORAMA_SETTINGS.frameSelection);
-    expect(s.captureSource).toBe(DEFAULT_PANORAMA_SETTINGS.captureSource);
-  });
-
-  it('routes every prop override to its hierarchical path', () => {
-    const s = buildPanoramaInitialSettings(
-      {
-        defaultCaptureSource: 'non-ar',
-        defaultStitchMode: 'scans',
-        defaultBlender: 'feather',
-        defaultSeamFinder: 'skip',
-        defaultWarper: 'cylindrical',
-        defaultFlowNoveltyPercentile: 0.70,
-        defaultFlowEvalEveryNFrames: 3,
-        defaultFlowMaxTranslationCm: 12,
-        defaultKeyframeMaxCount: 8,
-        defaultKeyframeOverlapThreshold: 0.30,
-        maxInscribedRectCrop: true,
-      },
-      false,
-    );
-
-    expect(s.captureSource).toBe('non-ar');
-    expect(s.stitcher.stitchMode).toBe('scans');
-    expect(s.stitcher.blenderType).toBe('feather');
-    expect(s.stitcher.seamFinderType).toBe('skip');
-    expect(s.stitcher.warperType).toBe('cylindrical');
-    expect(s.frameSelection.flow?.noveltyPercentile).toBe(0.70);
-    expect(s.frameSelection.flow?.evalEveryNFrames).toBe(3);
-    expect(s.frameSelection.flow?.maxTranslationCm).toBe(12);
-    expect(s.frameSelection.maxKeyframes).toBe(8);
-    expect(s.frameSelection.overlapThreshold).toBe(0.30);
-    expect(s.stitcher.enableMaxInscribedRectCrop).toBe(true);
-  });
-
-  it('maps maxInscribedRectCrop → stitcher.enableMaxInscribedRectCrop', () => {
-    expect(
-      buildPanoramaInitialSettings({ maxInscribedRectCrop: true }, false)
-        .stitcher.enableMaxInscribedRectCrop,
-    ).toBe(true);
-    expect(
-      buildPanoramaInitialSettings({ maxInscribedRectCrop: false }, false)
-        .stitcher.enableMaxInscribedRectCrop,
-    ).toBe(false);
-    // Omitted ⇒ default (false — inscribed-rect crop is opt-in), and the
-    // low-mem fallback must not flip it.
-    expect(
-      buildPanoramaInitialSettings({}, false)
-        .stitcher.enableMaxInscribedRectCrop,
-    ).toBe(false);
-    expect(
-      buildPanoramaInitialSettings({}, true)
-        .stitcher.enableMaxInscribedRectCrop,
-    ).toBe(false);
-  });
-
-  it('maps defaultMaxKeyframeIntervalMs → frameSelection.maxKeyframeIntervalMs', () => {
-    expect(
-      buildPanoramaInitialSettings({ defaultMaxKeyframeIntervalMs: 3500 }, false)
-        .frameSelection.maxKeyframeIntervalMs,
-    ).toBe(3500);
-    // 0 explicitly disables the time-budget force-accept — it is NOT
-    // nullish, so `??` does not replace it with the default.
-    expect(
-      buildPanoramaInitialSettings({ defaultMaxKeyframeIntervalMs: 0 }, false)
-        .frameSelection.maxKeyframeIntervalMs,
-    ).toBe(0);
-    // Omitted ⇒ the 2000 ms default.
-    expect(
-      buildPanoramaInitialSettings({}, false)
-        .frameSelection.maxKeyframeIntervalMs,
-    ).toBe(2000);
-  });
-
-  it('leaves non-overridden fields at the default (partial override)', () => {
-    const s = buildPanoramaInitialSettings(
-      { defaultStitchMode: 'panorama' },
-      false,
-    );
-
-    // The override took effect …
-    expect(s.stitcher.stitchMode).toBe('panorama');
-
-    // … and every other field stays at the corresponding default.
-    expect(s.stitcher.warperType).toBe(DEFAULT_PANORAMA_SETTINGS.stitcher.warperType);
-    expect(s.stitcher.blenderType).toBe(DEFAULT_PANORAMA_SETTINGS.stitcher.blenderType);
-    expect(s.stitcher.seamFinderType).toBe(DEFAULT_PANORAMA_SETTINGS.stitcher.seamFinderType);
-    expect(s.frameSelection).toEqual(DEFAULT_PANORAMA_SETTINGS.frameSelection);
-    expect(s.captureSource).toBe(DEFAULT_PANORAMA_SETTINGS.captureSource);
-  });
-
-  it('produces wire-format-clean output when piped through the bridge', () => {
-    // The end-to-end JS-side path: props → buildPanoramaInitialSettings →
-    // panoramaSettingsToNativeConfig.  Verifying it here catches drift
-    // at any of the three layers (prop name, type-tree shape, bridge
-    // adapter) with a single assertion.
-    const overrides = {
-      defaultCaptureSource: 'non-ar' as const,
-      defaultStitchMode: 'scans' as const,
-      defaultFlowMaxTranslationCm: 25,
-    };
-    const settings: PanoramaSettings =
-      buildPanoramaInitialSettings(overrides, false);
-    const wire = panoramaSettingsToNativeConfig(settings);
-
-    expect(wire.captureSource).toBe('non-ar');
-    expect(wire.stitchMode).toBe('scans');
-    expect(wire.flowMaxTranslationCm).toBe(25);
-    // Defaulted fields still on the wire with their default value.
-    expect(wire.warperType).toBe('plane');
-    expect(wire.frameSelectionMode).toBe('flow-based');
-    expect(wire.flowNoveltyPercentile).toBe(0.85);
-  });
-});

package/src/camera/__tests__/cameraErrorMessages.test.ts

@@ -1,76 +0,0 @@
-// SPDX-License-Identifier: Apache-2.0
-/**
- * Unit tests for the recoverable-stitch-failure guidance map.
- *
- * Guarantees: (1) every recoverable code yields non-empty, plain-language
- * copy with no raw cv::Stitcher diagnostic leaking through; (2) the
- * cause-specific guidance actually names its corrective action; (3) every
- * non-recoverable code returns null so the host falls back to its generic
- * error UI.
- */
-import { userFacingStitchError } from '../cameraErrorMessages';
-import type { CameraErrorCode } from '../Camera';
-
-describe('userFacingStitchError', () => {
-  const RECOVERABLE: CameraErrorCode[] = [
-    'STITCH_NEED_MORE_IMGS',
-    'STITCH_HOMOGRAPHY_FAIL',
-    'STITCH_CAMERA_PARAMS_FAIL',
-    'STITCH_OOM',
-  ];
-
-  it.each(RECOVERABLE)(
-    'returns non-empty, jargon-free title+message for %s',
-    (code) => {
-      const r = userFacingStitchError(code);
-      expect(r).not.toBeNull();
-      expect(r!.title.length).toBeGreaterThan(0);
-      expect(r!.message.length).toBeGreaterThan(0);
-      // No raw stitcher diagnostics should ever reach the user.
-      expect(r!.message).not.toMatch(/warpRoi|cv::|OpenCV|ERR_|StsOutOfRange|estimator/i);
-      expect(r!.title).not.toMatch(/cv::|OpenCV|ERR_/i);
-      // The title is the corrective ASK (e.g. "Please pan more slowly"),
-      // not a generic failure headline.
-      expect(r!.title).not.toMatch(/couldn't|can't|error|failed|too large/i);
-    },
-  );
-
-  it('camera-params guidance names the 0.5x sensitivity and the 1x fix', () => {
-    const r = userFacingStitchError('STITCH_CAMERA_PARAMS_FAIL');
-    expect(r).not.toBeNull();
-    // The actual root cause (translation) + the actionable lens advice.
-    expect(r!.message).toMatch(/0\.5x|ultra-wide/i);
-    expect(r!.message).toMatch(/\b1x\b/i);
-    expect(r!.message).toMatch(/pivot|turning|one spot|moved|shifted/i);
-  });
-
-  it('need-more-images guidance is about overlap', () => {
-    expect(userFacingStitchError('STITCH_NEED_MORE_IMGS')!.message).toMatch(
-      /overlap/i,
-    );
-  });
-
-  it('oom guidance suggests a shorter sweep', () => {
-    expect(userFacingStitchError('STITCH_OOM')!.message).toMatch(
-      /shorter|narrower|memory/i,
-    );
-  });
-
-  const NON_RECOVERABLE: CameraErrorCode[] = [
-    'CAMERA_PERMISSION_DENIED',
-    'CAMERA_DEVICE_UNAVAILABLE',
-    'PHOTO_CAPTURE_FAILED',
-    'PANORAMA_START_FAILED',
-    'PANORAMA_FINALIZE_FAILED',
-    'OUTPUT_WRITE_FAILED',
-    'VISION_CAMERA_RUNTIME',
-    'UNKNOWN',
-  ];
-
-  it.each(NON_RECOVERABLE)(
-    'returns null for non-recoverable code %s',
-    (code) => {
-      expect(userFacingStitchError(code)).toBeNull();
-    },
-  );
-});

package/src/camera/__tests__/homeIndicatorEdge.test.ts

@@ -1,116 +0,0 @@
-// SPDX-License-Identifier: Apache-2.0
-/**
- * Unit tests for `homeIndicatorEdge` + `isSideEdge` — the pure functions
- * that produce the `vertical` flag driving PanoramaBandOverlay and
- * CaptureThumbnailStrip layout under non-locked hosts.
- *
- *   vertical = isSideEdge(homeIndicatorEdge(jsLandscape, deviceOrient))
- *
- * Contract (v0.12 orientation-aware Camera):
- *   - Portrait JS layout (jsLandscape=false) → 'bottom' edge → NOT a
- *     side edge → vertical=false (horizontal strip, the portrait-locked
- *     case that's the recommended config).
- *   - Landscape JS layout → 'right'/'left' edge → side edge →
- *     vertical=true (the strip/band stack along the home-indicator edge).
- *
- * Pure-TS test per jest.config.js (no component mount).  The functions
- * are imported via Camera.tsx's `_*ForTests` handles; react-native and
- * the heavy native deps are mocked so the import resolves in node env.
- */
-
-// The SUT lives in Camera.tsx, which transitively imports the entire
-// camera surface (vision-camera, worklets, sensors, native modules).
-// We only call two pure functions, so stub the whole dependency tree.
-jest.mock('react-native', () => ({
-  NativeModules: {},
-  Platform: { OS: 'ios', select: (o: Record<string, unknown>) => o.ios },
-  Pressable: 'Pressable',
-  StyleSheet: { create: (s: Record<string, unknown>) => s, absoluteFill: {} },
-  Text: 'Text',
-  View: 'View',
-  Image: 'Image',
-  ScrollView: 'ScrollView',
-  Animated: { View: 'Animated.View', Value: class {}, timing: () => ({ start: () => undefined }) },
-  Modal: 'Modal',
-  ActivityIndicator: 'ActivityIndicator',
-  useWindowDimensions: () => ({ width: 0, height: 0 }),
-  requireNativeComponent: () => 'NativeComponent',
-  UIManager: { getViewManagerConfig: () => ({}) },
-  findNodeHandle: () => 1,
-}));
-jest.mock('react-native-safe-area-context', () => ({
-  useSafeAreaInsets: () => ({ top: 0, bottom: 0, left: 0, right: 0 }),
-}));
-jest.mock('react-native-sensors', () => ({
-  accelerometer: { subscribe: jest.fn(() => ({ unsubscribe: jest.fn() })) },
-  setUpdateIntervalForType: jest.fn(),
-  SensorTypes: { accelerometer: 'accelerometer' },
-}));
-jest.mock('react-native-worklets-core', () => ({ Worklets: {} }));
-jest.mock('react-native-vision-camera', () => ({
-  Camera: 'Camera',
-  useCameraDevice: jest.fn(),
-  useCameraPermission: jest.fn(),
-}));
-
-import {
-  _homeIndicatorEdgeForTests as homeIndicatorEdge,
-  _isSideEdgeForTests as isSideEdge,
-} from '../Camera';
-import type { DeviceOrientation } from '../useDeviceOrientation';
-
-const PORTRAIT: DeviceOrientation = 'portrait';
-const UPSIDE: DeviceOrientation = 'portrait-upside-down';
-const LEFT: DeviceOrientation = 'landscape-left';
-const RIGHT: DeviceOrientation = 'landscape-right';
-
-// The composed signal the band/strip actually consume.
-const vertical = (jsLandscape: boolean, o: DeviceOrientation) =>
-  isSideEdge(homeIndicatorEdge(jsLandscape, o));
-
-describe('homeIndicatorEdge', () => {
-  it('returns bottom for any portrait JS layout (jsLandscape=false)', () => {
-    // Portrait JS layout always anchors bottom regardless of the sensor
-    // value — this is the portrait-locked case (the recommended config).
-    for (const o of [PORTRAIT, UPSIDE, LEFT, RIGHT]) {
-      expect(homeIndicatorEdge(false, o)).toBe('bottom');
-    }
-  });
-
-  it('anchors RIGHT for landscape-left device in landscape JS layout', () => {
-    expect(homeIndicatorEdge(true, LEFT)).toBe('right');
-  });
-
-  it('anchors LEFT for landscape-right device in landscape JS layout', () => {
-    expect(homeIndicatorEdge(true, RIGHT)).toBe('left');
-  });
-
-  it('falls through to right for non-landscape sensor + landscape JS (transient)', () => {
-    // jsLandscape=true with a portrait sensor reading only happens
-    // mid-rotation; defensive default is 'right'.
-    expect(homeIndicatorEdge(true, PORTRAIT)).toBe('right');
-    expect(homeIndicatorEdge(true, UPSIDE)).toBe('right');
-  });
-});
-
-describe('isSideEdge', () => {
-  it('is true only for left/right edges', () => {
-    expect(isSideEdge('left')).toBe(true);
-    expect(isSideEdge('right')).toBe(true);
-    expect(isSideEdge('bottom')).toBe(false);
-    expect(isSideEdge('top')).toBe(false);
-  });
-});
-
-describe('vertical flag (composed) — what the strip/band consume', () => {
-  it('is FALSE for portrait-locked layout (horizontal strip, recommended)', () => {
-    for (const o of [PORTRAIT, UPSIDE, LEFT, RIGHT]) {
-      expect(vertical(false, o)).toBe(false);
-    }
-  });
-
-  it('is TRUE for both landscape orientations under a non-locked host', () => {
-    expect(vertical(true, LEFT)).toBe(true);
-    expect(vertical(true, RIGHT)).toBe(true);
-  });
-});