react-native-hyperkyc-sdk 2.8.0 → 3.0.0-rc.1

package/android/build.gradle

@@ -56,7 +56,7 @@ repositories {
 dependencies {
     //noinspection GradleDynamicVersion
     implementation "com.facebook.react:react-native:+"  // From node_modules
-    implementation('co.hyperverge:hyperkyc:2.7.0@aar', {
+    implementation('co.hyperverge:hyperkyc:3.0.0-rc.1@aar', {
         transitive = true
          exclude group: 'co.hyperverge', module: 'hyperdocdetect'
          exclude group: 'co.hyperverge', module: 'hypersnap-pdf'

package/android/src/main/java/com/reactnativehyperkycsdk/HyperkycSdkModule.java

@@ -37,41 +37,10 @@ public class HyperkycSdkModule extends ReactContextBaseJavaModule {
     private final ReactApplicationContext reactContext;
     private final int HYPERKYC_REQUEST_CODE = 56455;
     private boolean isEventListenerAdded = false;
-    /* volatile because 
-            1. the pendingCallback is written on JS bridge thread (launch()), 
-            2. read/nulled on main thread (onActivityResult), 
-            3. nulled on teardown thread (invalidate()). 
-        Without volatile, the JMM provides no happens-before guarantee — the main thread may cache a stale null
-        and silently drop the KYC result. Works in practice without volatile (user spending more time in completing the workflow between write and read),
-        but timing is not a JMM guarantee. */
-    private volatile Callback pendingCallback = null;
-    /* Contract is stateless — createIntent and parseResult carry no per-launch state. */
-    private final HyperKyc.Contract contract = new HyperKyc.Contract();
-    /* Registered once at construction; never re-registered. Accumulation is impossible. */
-    private final ActivityEventListener kycActivityListener = new ActivityEventListener() {
-        @Override
-        public void onActivityResult(Activity activity, int requestCode,
-                                     int resultCode, Intent data) {
-            if (requestCode != HYPERKYC_REQUEST_CODE) return;
-            Callback cb = pendingCallback;
-            if (cb == null) return;
-            pendingCallback = null;
-            HyperKycResult result = contract.parseResult(resultCode, data);
-            if (result == null) {
-                cb.invoke(getDummyResultMap());
-            } else {
-                parseKYCResult(result, cb);
-            }
-        }
-
-        @Override
-        public void onNewIntent(Intent intent) {}
-    };
 
     public HyperkycSdkModule(ReactApplicationContext reactContext) {
         super(reactContext);
         this.reactContext = reactContext;
-        reactContext.addActivityEventListener(kycActivityListener);
     }
 
     @Override
@@ -106,15 +75,28 @@ public class HyperkycSdkModule extends ReactContextBaseJavaModule {
     @ReactMethod
     public void launch(ReadableMap kycConfig, Callback resultCallback) {
         ReactActivity currentActivity = (ReactActivity) getCurrentActivity();
-        if (currentActivity == null || kycConfig == null) {
-            resultCallback.invoke(getDummyResultMap());
-            return;
-        }
+        assert kycConfig != null;
         HyperKycConfig config = getHyperKycConfigFromMap(kycConfig);
+        HyperKyc.Contract contract = new HyperKyc.Contract();
+
+        reactContext.addActivityEventListener(new ActivityEventListener() {
+            @Override
+            public void onActivityResult(Activity activity, int requestCode, int resultCode, Intent data) {
+                if (requestCode == HYPERKYC_REQUEST_CODE) {
+                    HyperKycResult hyperKycResult = contract.parseResult(resultCode, data);
+                    parseKYCResult(hyperKycResult, resultCallback);
+                } else {
+                    resultCallback.invoke(getDummyResultMap());
+                }
+                reactContext.removeActivityEventListener(this);
+            }
+
+            @Override
+            public void onNewIntent(Intent intent) {
+            }
+        });
 
-        /* Clear any accumulated event listeners before adding a fresh one, so at most one event listener is active at any time. */
         if (isEventListenerAdded) {
-            HyperKyc.removeAllEventListeners();
             Function1<JSONObject, Unit> listener = jsonObject -> {
                 try {
                     WritableMap eventMap = HyperkycSdkUtils.convertJsonToMap(jsonObject);
@@ -127,19 +109,12 @@ public class HyperkycSdkModule extends ReactContextBaseJavaModule {
             HyperKyc.addEventListener(listener);
         }
 
-        /* Supersede any prior in-flight session — old callback silently discarded. */
-        pendingCallback = resultCallback;
-
-        Intent newIntent = contract.createIntent(currentActivity, config);
-        currentActivity.startActivityIfNeeded(newIntent, HYPERKYC_REQUEST_CODE);
-    }
-
-    /* invalidate() is the correct teardown hook for both old and new RN architecture;
-       onCatalystInstanceDestroy() is deprecated and removed in some RN versions. */
-    @Override
-    public void invalidate() {
-        pendingCallback = null;
-        reactContext.removeActivityEventListener(kycActivityListener);
+        if (currentActivity != null) {
+            Intent newIntent = contract.createIntent(currentActivity, config);
+            currentActivity.startActivityIfNeeded(newIntent, HYPERKYC_REQUEST_CODE);
+        } else {
+            resultCallback.invoke(getDummyResultMap());
+        }
     }
 
     private void sendEvent(String eventName, WritableMap eventProperties) {
@@ -206,7 +181,7 @@ public class HyperkycSdkModule extends ReactContextBaseJavaModule {
         Boolean useLocation = kycConfig.hasKey("useLocation") ? kycConfig.getBoolean("useLocation") : null;
         String uniqueId = kycConfig.hasKey("uniqueId") ? kycConfig.getString("uniqueId") : null;
         Map<String, String> metadata = new HashMap<>();
-        metadata.put("sdk-version", "2.7.0");
+        metadata.put("sdk-version", "3.0.0-rc.1");
         metadata.put("sdk-type", "React Native");
         if (accessToken == null) {
             assert appId != null;

package/ios/HyperkycSdk.swift

@@ -45,7 +45,7 @@ class Hyperkyc: RCTEventEmitter {
         let useLocation = _config["useLocation"] as? Bool
         let uniqueId = _config["uniqueId"] as? String
         let metadata: [String: String] = [
-            "sdk-version": "2.7.0",
+            "sdk-version": "3.0.0-rc.1",
             "sdk-type": "React Native"
         ]
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "react-native-hyperkyc-sdk",
-  "version": "2.8.0",
+  "version": "3.0.0-rc.1",
   "description": "React Native wrapper for HyperKYC SDK",
   "main": "lib/commonjs/index",
   "module": "lib/module/index",

package/react-native-hyperkyc-sdk.podspec

@@ -17,7 +17,7 @@ Pod::Spec.new do |s|
   s.static_framework = true
 
   s.dependency "React-Core"
-  s.dependency "HyperKYC", "1.3.0"
+  s.dependency "HyperKYC", "1.4.0"
   # Need these lines to support HyperKYC framework
   s.preserve_paths = 'HyperKYC.framework'
   s.xcconfig = { 'OTHER_LDFLAGS' => '-framework HyperKYC' }