react-native-fast-image 8.6.25 → 8.6.27

package/android/src/main/java/com/dylanvann/fastimage/FastImageViewManager.java

@@ -86,7 +86,7 @@ class FastImageViewManager extends SimpleViewManager<FastImageViewWithUrl> imple
     @ReactProp(name = "resizeMode")
     public void setResizeMode(FastImageViewWithUrl view, String resizeMode) {
         final FastImageViewWithUrl.ScaleType scaleType = FastImageViewConverter.getScaleType(resizeMode);
-        view.setScaleType(scaleType);
+        view.setResizeMode(scaleType);
     }
 
     @Override
@@ -94,15 +94,9 @@ class FastImageViewManager extends SimpleViewManager<FastImageViewWithUrl> imple
         // This will cancel existing requests.
         view.clearView(requestManager);
 
-        if (view.glideUrl != null) {
-            final String key = view.glideUrl.toString();
-            FastImageOkHttpProgressGlideModule.forget(key);
-            List<FastImageViewWithUrl> viewsForKey = VIEWS_FOR_URLS.get(key);
-            if (viewsForKey != null) {
-                viewsForKey.remove(view);
-                if (viewsForKey.size() == 0) VIEWS_FOR_URLS.remove(key);
-            }
-        }
+        // Same key as when the view was tracked (toStringUrl, not toString,
+        // which differ for urls that need escaping).
+        view.untrackUrl(VIEWS_FOR_URLS);
 
         super.onDropViewInstance(view);
     }

package/android/src/main/java/com/dylanvann/fastimage/FastImageViewWithUrl.java

@@ -48,6 +48,14 @@ class FastImageViewWithUrl extends AppCompatImageView {
         mDefaultSource = source;
     }
 
+    // Glide crops or fits the bitmap for the scale type when it loads, so a
+    // new resizeMode needs a reload to take effect (#762).
+    public void setResizeMode(ScaleType scaleType) {
+        if (scaleType == getScaleType()) return;
+        setScaleType(scaleType);
+        mNeedsReload = true;
+    }
+
     @SuppressLint("CheckResult")
     public void onAfterUpdate(
             @Nonnull FastImageViewManager manager,
@@ -55,15 +63,16 @@ class FastImageViewWithUrl extends AppCompatImageView {
             @Nonnull Map<String, List<FastImageViewWithUrl>> viewsForUrlsMap) {
         if (!mNeedsReload)
             return;
+        // Only reload for changes that affect the request (source,
+        // defaultSource, resizeMode), not for every prop update.
+        mNeedsReload = false;
 
         // Nothing to show.
         if (mSource == null && mDefaultSource == null) {
             // Cancel existing requests.
             clearView(requestManager);
 
-            if (glideUrl != null) {
-                FastImageOkHttpProgressGlideModule.forget(glideUrl.toStringUrl());
-            }
+            untrackUrl(viewsForUrlsMap);
 
             // Clear the image.
             setImageDrawable(null);
@@ -92,9 +101,7 @@ class FastImageViewWithUrl extends AppCompatImageView {
             // Cancel existing requests.
             clearView(requestManager);
 
-            if (glideUrl != null) {
-                FastImageOkHttpProgressGlideModule.forget(glideUrl.toStringUrl());
-            }
+            untrackUrl(viewsForUrlsMap);
             setImageDrawable(mDefaultSource);
             return;
         }
@@ -102,12 +109,17 @@ class FastImageViewWithUrl extends AppCompatImageView {
         // `imageSource` may be null and we still continue, if `defaultSource` is not null
         final GlideUrl glideUrl = imageSource == null ? null : imageSource.getGlideUrl();
 
+        String key = glideUrl == null ? null : glideUrl.toStringUrl();
+
+        // Loading a different url: stop tracking the old one.
+        if (this.glideUrl != null && !this.glideUrl.toStringUrl().equals(key)) {
+            untrackUrl(viewsForUrlsMap);
+        }
+
         // Cancel existing request.
         this.glideUrl = glideUrl;
         clearView(requestManager);
 
-        String key = glideUrl == null ? null : glideUrl.toStringUrl();
-
         if (glideUrl != null) {
             FastImageOkHttpProgressGlideModule.expect(key, manager);
             List<FastImageViewWithUrl> viewsForKey = viewsForUrlsMap.get(key);
@@ -152,6 +164,24 @@ class FastImageViewWithUrl extends AppCompatImageView {
         }
     }
 
+    // Removes this view from the list of views for its current url (used to send
+    // progress events), which otherwise kept it, and its Activity, alive after
+    // its source changed (#384). The url's progress listener is only forgotten
+    // when no other view uses it.
+    void untrackUrl(@Nonnull Map<String, List<FastImageViewWithUrl>> viewsForUrlsMap) {
+        if (glideUrl == null) return;
+        String key = glideUrl.toStringUrl();
+        List<FastImageViewWithUrl> viewsForKey = viewsForUrlsMap.get(key);
+        if (viewsForKey != null) {
+            viewsForKey.remove(this);
+            if (viewsForKey.isEmpty()) viewsForUrlsMap.remove(key);
+        }
+        if (viewsForKey == null || viewsForKey.isEmpty()) {
+            FastImageOkHttpProgressGlideModule.forget(key);
+        }
+        glideUrl = null;
+    }
+
     public void clearView(@Nullable RequestManager requestManager) {
         if (requestManager != null && getTag() != null && getTag() instanceof Request) {
             requestManager.clear(this);

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "react-native-fast-image",
-    "version": "8.6.25",
+    "version": "8.6.27",
     "description": "🚩 FastImage, performant React Native image component.",
     "keywords": [
         "cache",