react-native-fast-image 8.6.24 → 8.6.26

package/android/src/main/java/com/dylanvann/fastimage/FastImageViewManager.java

@@ -52,6 +52,11 @@ class FastImageViewManager extends SimpleViewManager<FastImageViewWithUrl> imple
     protected FastImageViewWithUrl createViewInstance(@NonNull ThemedReactContext reactContext) {
         if (isValidContextForGlide(reactContext)) {
             requestManager = Glide.with(reactContext);
+        } else if (getActivityFromContext(reactContext) == null) {
+            // Not in an Activity (e.g. a root view created with the application
+            // context): load with the application context, instead of leaving
+            // requestManager null and never loading (#520).
+            requestManager = Glide.with(reactContext.getApplicationContext());
         }
 
         return new FastImageViewWithUrl(reactContext);
@@ -81,7 +86,7 @@ class FastImageViewManager extends SimpleViewManager<FastImageViewWithUrl> imple
     @ReactProp(name = "resizeMode")
     public void setResizeMode(FastImageViewWithUrl view, String resizeMode) {
         final FastImageViewWithUrl.ScaleType scaleType = FastImageViewConverter.getScaleType(resizeMode);
-        view.setScaleType(scaleType);
+        view.setResizeMode(scaleType);
     }
 
     @Override

package/android/src/main/java/com/dylanvann/fastimage/FastImageViewWithUrl.java

@@ -48,6 +48,14 @@ class FastImageViewWithUrl extends AppCompatImageView {
         mDefaultSource = source;
     }
 
+    // Glide crops or fits the bitmap for the scale type when it loads, so a
+    // new resizeMode needs a reload to take effect (#762).
+    public void setResizeMode(ScaleType scaleType) {
+        if (scaleType == getScaleType()) return;
+        setScaleType(scaleType);
+        mNeedsReload = true;
+    }
+
     @SuppressLint("CheckResult")
     public void onAfterUpdate(
             @Nonnull FastImageViewManager manager,
@@ -55,6 +63,9 @@ class FastImageViewWithUrl extends AppCompatImageView {
             @Nonnull Map<String, List<FastImageViewWithUrl>> viewsForUrlsMap) {
         if (!mNeedsReload)
             return;
+        // Only reload for changes that affect the request (source,
+        // defaultSource, resizeMode), not for every prop update.
+        mNeedsReload = false;
 
         // Nothing to show.
         if (mSource == null && mDefaultSource == null) {

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "react-native-fast-image",
-    "version": "8.6.24",
+    "version": "8.6.26",
     "description": "🚩 FastImage, performant React Native image component.",
     "keywords": [
         "cache",